From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057122428766388224 X-Received: by 2002:adf:fac8:: with SMTP id a8mr8861550wrs.330.1644782973643; Sun, 13 Feb 2022 12:09:33 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:a3d0:: with SMTP id m16ls40422wrb.3.gmail; Sun, 13 Feb 2022 12:09:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJ0wEsOUIxR9NSqdrFrOxP1s5jOLSYn12iBDJy+mDYP+2uH41j8LeYFzZLUebL29bFbNOI X-Received: by 2002:adf:ab15:: with SMTP id q21mr8758411wrc.377.1644782972701; Sun, 13 Feb 2022 12:09:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644782972; cv=none; d=google.com; s=arc-20160816; b=Pd0qJ5bc08q9bOd9e2hOBSVPuCL94cZawj0Y592PIKDqGIrV97YyoeYzrj2/vaj92p kzMD+OxTts70m5QPaPf5kyWhkPRdh1ytEwBtxGW9N6SbBfVTCYaPXaQPqCTRc8Cbp199 tH9sgu03NuB7QXn47Ux1XwMz+W5AxvWM86Thm4Klv24AGfP5VB9U7McUzr4jzs5LllH7 DDA1v7WpBFBZskLXT+eNKnHq7GSF0MPzcGhNNNedbG9Qvh0ktR/jtG0GOHrbdvrywo2p LYkrPn5vq9UydZfv8kaVIYZLAX1WYpkRs4ckPg0PMzo//cJMz86oKRC6L1CWtLWt2Gv6 li+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=ex6xeUezT1rklLgiOF/u3X7HbG0xwsdH1o8TkcmGPbQ=; b=U/XqP2gzjAm0/eXtw66qZW8Y8rq52UXzmggLni1ROQ3JIngeC5iy7vGTPKA+ewLZxq Vd1azrcqY4pMpKLkgPGrvwCpusp3M6nNaXXJIZQd56qSQU7k67kV7zUkkGV57g6YAZ8E zlA851VK7Lk4tvWMsl5z8XsKE9Mp9+i1CN5VNqbFck47+Jb4uI6eKJySF/eQ9NBMtz8T TrUO9Fs3cuYIdim854b760Vjh8FtGP6CKfIOBTju/B3ZvCQJ6nlSbE51LczTmmoydyVr dQRCfWR7n5UtyjLvG9RnEX6sZY89cOoaO4HFQKFYZQxQ9mFfAP55dkHFf5NQKWwHvSgl saiw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id ay1si618455wmb.3.2022.02.13.12.09.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Feb 2022 12:09:32 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 21DK9Vlo013009 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 13 Feb 2022 21:09:31 +0100 From: Uladzimir Bely To: "isar-users@googlegroups.com" Cc: "Moessbauer, Felix" Subject: Re: [PATCH v7 06/13] sbuild: support of DEB_BUILD_PROFILES Date: Sun, 13 Feb 2022 23:09:28 +0300 Message-ID: <1912752.56niFO833r@home> In-Reply-To: References: <20220213074459.24200-1-ubely@ilbers.de> <20220213074459.24200-7-ubely@ilbers.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 7GHlUu1OC288 In the email from Sunday, 13 February 2022 19:04:48 +03 user Moessbauer, Felix wrote: > Hi, > > > -----Original Message----- > > From: isar-users@googlegroups.com On > > Behalf Of Uladzimir Bely > > Sent: Sunday, February 13, 2022 8:45 AM > > To: isar-users@googlegroups.com > > Subject: [PATCH v7 06/13] sbuild: support of DEB_BUILD_PROFILES > > > > In Isar packages may use their own profiles. For example, linux-custom.inc > > introduces 'nolibcdev' profile that should be passed to dpkg-buildpackage > > in both cross and native builds. > > > > By default, sbuild for cross-building uses passes "cross,nocheck" options > > to dpkg-buildpackage and ignores DEB_BUILD_PROFILES environment variable. > There is a typo (uses passes). > > > This change makes sbuild use custom profiles even in cross-build mode. > > > > Signed-off-by: Uladzimir Bely > > --- > > > > meta/classes/dpkg.bbclass | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass index > > 848ffad1..5511de64 100644 > > --- a/meta/classes/dpkg.bbclass > > +++ b/meta/classes/dpkg.bbclass > > @@ -40,10 +40,18 @@ dpkg_runbuild() { > > > > export DEB_BUILD_PROFILES="${@ isar_deb_build_profiles(d)}" > > export PARALLEL_MAKE="${PARALLEL_MAKE}" > > > > + profiles=$(grep "DEB_BUILD_PROFILES" ${SBUILD_CONFIG} | tail -n1 | > > cut -d "'" -f 4) > > + if [ ${ISAR_CROSS_COMPILE} -eq 1 ]; then > > + profiles="${profiles} cross nocheck" > > + fi > > + if [ ! -z "$profiles" ]; then > > + profiles=$(echo --profiles="$profiles" | sed -e 's/ \+/,/g') > > + fi > > + > > > > export SBUILD_CONFIG="${SBUILD_CONFIG}" > > > > sbuild -A -n -c ${SBUILD_CHROOT} > > --extra-repository="${ISAR_APT_REPO}" \ > > > > - --host=${PACKAGE_ARCH} --build=${SBUILD_HOST_ARCH} \ > > + --host=${PACKAGE_ARCH} --build=${SBUILD_HOST_ARCH} ${profiles} > > As we handle the DEB_BUILD_PROFILES exclusively in ISAR anyways, can't we > simplify this code by always adding --profiles="${@ > isar_deb_build_profiles(d)}" and get rid of the export? Otherwise we have > to maintain the "cross nocheck" logic for cross-compiling at two different > locations. > I need to check it. In isar_deb_build_profiles() we just add " cross" to profiles list in case of cross-build. Probably, sbuild also requires " nocheck" to be passed. Anyway, sbuild accepts comma-separated list, while environment variable is a space-separated one. So, some handling of this will be still required. > Felix > > > + \ > > > > --no-run-lintian --no-run-piuparts --no-run-autopkgtest \ > > --debbuildopts="--source-option=-I" \ > > --build-dir=${WORKDIR} ${WORKDIR}/${PPS} > > > > -- > > 2.20.1 > > > > -- > > You received this message because you are subscribed to the Google Groups > > "isar-users" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to isar-users+unsubscribe@googlegroups.com. > > To view this discussion on the web visit > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.g > > oogle.com%2Fd%2Fmsgid%2Fisar-users%2F20220213074459.24200-7- > > ubely%2540ilbers.de&data=04%7C01%7Cfelix.moessbauer%40siemens.co > > m%7C9a465e3edb52484113a108d9eec4bf92%7C38ae3bcd95794fd4addab42e1 > > 495d55a%7C1%7C0%7C637803351819682721%7CUnknown%7CTWFpbGZsb3d8 > > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > > 7C3000&sdata=Qq0ecQNOACm2ILez0sEG1A4qlyvrZ04kRT8dxkc4w2c%3D& > > amp;reserved=0. -- Uladzimir Bely