public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Florian Bezdeka' via isar-users" <isar-users@googlegroups.com>
To: Badrikesh Prusty <badrikesh.prusty@siemens.com>,
	isar-users@googlegroups.com
Cc: alexander.heinisch@siemens.com, felix.moessbauer@siemens.com
Subject: Re: [PATCH v2 1/2] image-postproc: ignore systemd preset failures
Date: Tue, 13 Jan 2026 15:55:09 +0100	[thread overview]
Message-ID: <195b950564b846dfac8fe4772f76bb38b8eeef6a.camel@siemens.com> (raw)
In-Reply-To: <20260113144832.3231870-1-badrikesh.prusty@siemens.com>

On Tue, 2026-01-13 at 09:48 -0500, 'Badrikesh Prusty' via isar-users
wrote:
> Add '|| true' to systemd preset invocation during image postprocessing
> to tolerate failures caused by already-masked units.

Hm. It's an assumption that this can only fail because of already-masked
units, no? Looking at the implementation below it looks more like that
we hide any error now.

> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/classes-recipe/rootfs.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index 8485b32f..ef3ddb84 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
>          --show systemd || echo "" )
>  
>      if (test "$SYSTEMD_INSTALLED" = "installed"); then
> -        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
> +        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only" || true
>      fi
>  }
>  
> -- 
> 2.47.3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260113144832.3231870-1-badrikesh.prusty%40siemens.com.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/195b950564b846dfac8fe4772f76bb38b8eeef6a.camel%40siemens.com.

  parent reply	other threads:[~2026-01-13 14:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 14:48 'Badrikesh Prusty' via isar-users
2026-01-13 14:48 ` [PATCH v2 2/2] image: make populate-systemd-preset opt-in 'Badrikesh Prusty' via isar-users
2026-01-14  9:46   ` 'Heinisch, Alexander' via isar-users
2026-01-13 14:55 ` 'Florian Bezdeka' via isar-users [this message]
2026-01-13 15:13   ` [PATCH v2 1/2] image-postproc: ignore systemd preset failures 'Badrikesh Prusty' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=195b950564b846dfac8fe4772f76bb38b8eeef6a.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=alexander.heinisch@siemens.com \
    --cc=badrikesh.prusty@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=florian.bezdeka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox