From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6727677240025284608 X-Received: by 2002:a50:b155:: with SMTP id l21mr37956926edd.186.1566409762796; Wed, 21 Aug 2019 10:49:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:b850:: with SMTP id k16ls1023493ede.12.gmail; Wed, 21 Aug 2019 10:49:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0Xst5BfVAvSw3fwzwMB46L5+nxrExnEKUOogDzaN4btxho9uITVYmaa2KF7i5M8yfMqk3 X-Received: by 2002:a50:f285:: with SMTP id f5mr37730487edm.109.1566409762210; Wed, 21 Aug 2019 10:49:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566409762; cv=none; d=google.com; s=arc-20160816; b=RhEZpVYG1fc1IsDR8ovD2mCag83NXzSWOXokaxT2LcWVAZPkixP3vkVtGeYnxDLLfI z5Gc50U9sZJAOUeYSw19/t6nfNoHBHlxDs7xcaoUj9VrNvKXdxCUOlN2WBrTJEUHY7w/ nbK+heFnr7YTDI6K+Sf73/xLekEGUtI9Kbir3QgmHjroTYpcaEPD98q2VFwiIAjEUmRN XtdiJsZDR/xYWN2D0k+Ptm4dBDS6BRMJa8vrLOVZxj8Tl5KXT4fwruS2xJaIQxgZijnd S8kYmiR2FuiGwg12mdtorKi7zCvK5TOtFQoVSX9YCT/+nyMYGF8QAwPZhHxjLaQ8DJlJ 7hYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=McxxJkDnuRVcRpH7WDbiWcpBt40n5NBxPvKWaVpwYtw=; b=WO/ssIY8Evoyc3gjjJ/m7iKBit0SYX72eyyJgGi2zgC6srQNxMTLc85Xz9yW0Tn2vj wjLqKzOMNxHV6OBr82/qXE4EOPSCrvcJOSo5KiB2L5hpIUexxHt8cNv00tMKcvSVZQxw lGf6plth3gDwMJGt570sabtGKZDx2ieT1rHwA5F7tB1zW2EkOEKl4ApnS+7owdC+fmmK mPVlNJrU/LIq+NeBHAomlRi/TrSDNFk6id+/kEUoLmrmPee///ymIW14y2lLoeycATCc VvDjW4QL2vFW5Sjo9tU9VXLnwkBVbH3KVZTs/HL4pk7VHTlUpKtqiy6Z3OZSJEulgxm6 IAsA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id d22si1071770edq.5.2019.08.21.10.49.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Aug 2019 10:49:22 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x7LHnLuP029383 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Aug 2019 19:49:21 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x7LHnKaH021351; Wed, 21 Aug 2019 19:49:20 +0200 Subject: Re: [PATCH] scripts: Avoid adding duplicate entries to PATH To: vijaikumar.kanagarajan@gmail.com, isar-users@googlegroups.com, henning.schild@siemens.com, claudius.heine.ext@siemens.com Cc: Vijai Kumar K References: <20190821174327.3369-1-Vijaikumar_Kangarajan@mentor.com> From: Jan Kiszka Message-ID: <199abc3d-5887-7011-c4be-b08b909c1a04@siemens.com> Date: Wed, 21 Aug 2019 19:49:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190821174327.3369-1-Vijaikumar_Kangarajan@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: fsGteP9KQJS4 On 21.08.19 19:43, vijaikumar.kanagarajan@gmail.com wrote: > From: Vijai Kumar K > > If the setup script is run multiple times in the same shell session, > PATH variable gets overpopulated with duplicate entries. Remove any > existing entries before adding. > > Signed-off-by: Vijai Kumar K > --- > scripts/isar-buildenv-internal | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv-internal > index 2186e40..8b941a2 100755 > --- a/scripts/isar-buildenv-internal > +++ b/scripts/isar-buildenv-internal > @@ -60,7 +60,14 @@ unset BDIR > > export BUILDDIR > > -PATH=$ISARROOT/bitbake/bin:$ISARROOT/scripts:$PATH > +for newpath in "$ISARROOT/bitbake/bin" "$ISARROOT/scripts"; do > + # Remove any existences of $newpath from $PATH > + PATH=$(echo $PATH | sed -re "s#(^|:)$newpath(:|$)#\2#g;s#^:##") > + > + # Add $newpath to $PATH > + PATH="$newpath:$PATH" > +done > + > export PATH > > BBPATH="${BUILDDIR}" > That's taken from OE - makes sense. OE does "unset newpath" afterwards. Is there more relevant stuff that we may lack? Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux