From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7187242631035879424 X-Received: by 2002:a05:6402:4017:b0:48e:c83d:a940 with SMTP id d23-20020a056402401700b0048ec83da940mr2889854eda.393.1673443442023; Wed, 11 Jan 2023 05:24:02 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:51c9:b0:479:6c1:ef04 with SMTP id r9-20020a05640251c900b0047906c1ef04ls569169edd.0.-pod-prod-gmail; Wed, 11 Jan 2023 05:24:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXupPCYNIZziDy/wwJDRM/I51/1/0qKrX+KDhea4pGhfRcL4DIoxhbyFsg55tpdiHMjgBsa8 X-Received: by 2002:aa7:c6c2:0:b0:46c:f113:b9bd with SMTP id b2-20020aa7c6c2000000b0046cf113b9bdmr61043994eds.6.1673443440685; Wed, 11 Jan 2023 05:24:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673443440; cv=pass; d=google.com; s=arc-20160816; b=Rd2Czfc1jzVKxuInzSJqx0XCZJPnbltitUNdl1fCZ20LLVi/C4GZrQFGqi5eKorvgS bLH3MoiX6xjrc6/OAENpE8N7LbmOKOtDgoxsgTG4rAflG/+YhbLz+rcPhCvWIbfx9Iek nC5ZC//pz1jgnUHaYnxHSj2FQG5iQW1VGasFB2JsorrUegIU7G5gWBN7yRkoYOaihzLF WbkZfvEKn7At+U4vkPLXZJS3NZLfKd+FCSfjRFbGz40xN1dqvc77hzawoeU8uaj7EkR9 aTKnI6+EOrBJwBSEq8fLSVdDGLe3NX67r0f3bMfrOBmRRU425sL9r0B6Zodc7iJevkVJ tMjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=TULWakXrl8gjZlUptZiBSGYIxLJXDsCbEMTO2TJKZ14=; b=WjdzVtFcRxCxqUBIFpg7gZu3q1sdJI82xzhmf5/xGZ2o6sdo5LG+KO7FXwaB0DRzPC eQQRjO0kqMej5Z8cqcftsd1fd9b0w8QKFMs4V0394UGIhKGBsd1oZONglXEZEE1TnvSL qV82gtuIikEyYFh9zG3lFO81Vqc4TRVbCt1UAakhUdmxba3bx0ZDqrsbQg/fbqrXONQD /xD9H3fkgdnqn6gFH6yMHieeinPn/UhLhxVAB6soePMk3puBkLBxgBKnawxUAup8GO1P N6/myc4x8q5YL5NLjSKRSCBqlGjFCmg+dWhrnvzyv5QOC2HjXX95kV2kEcpiAZc0Vr1F Cqtg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=u2cNypk+; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.8.54 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2054.outbound.protection.outlook.com. [40.107.8.54]) by gmr-mx.google.com with ESMTPS id k20-20020a05640212d400b0047014e8771fsi597948edx.3.2023.01.11.05.24.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2023 05:24:00 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.8.54 as permitted sender) client-ip=40.107.8.54; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=u2cNypk+; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.8.54 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PnqC1I+BCLenK0be83jELzt+tbeRTUIRAD8FFp4jx+kOg6YNNZnjGH1hODkQSX6qhC1IJuIW6IkJp9U7J4R3XLr6vEucfFwvETdMsftLU5PPhbK9D19TqNuR5sLCLGw4YW7ZG7NoyvoVYJ/IAmktdWFPKB6VVlCMJRCMGBnH2Juky86dSYftDihvHF31Nv+2vTvpzu2qn1JmIV1Yp5KpK8K3ZSlIJYPCPsOTZHeLWdrN2n5j765pNtmAuzUD57fXUeEKHTk1VoUC4iRaqP4nwUA8DumYBvvdQAhoqMlEy4H8mRGwFw76xvW+4ZI0RM7k6x7WQxAUZFh7YFxbAJFAOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TULWakXrl8gjZlUptZiBSGYIxLJXDsCbEMTO2TJKZ14=; b=R5inz1Ytsl9kxZ2UFmvdqepWCML5s6v5I6RTCfD5Um4XBnR/k1z8DWPAsIgojIltlVFwE65R9S0wuzo5SgNx+ZkkpINTQEzJvLcYi3OLrcRwjhqhwzmszPP/ADZ4gxFNKmNhPAnOm5uJwWgK+CeTmlXQKlMh9UWKnby184Io8uZ81He38JIPji2ZUyJRJ4hr60aeeWud/rCOKTmR5txLarM3nTbF/8ajr3t3+y5bqYE+InCsfk3qazuqwPhvnzIMeaalql47yrF8reyj6sEtKJ9VrblCVvWvVEaUNItilfH7WCHXT26p7GwgMT2iCGwmMw2EEgr76DRcwSzX5r3Ipw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TULWakXrl8gjZlUptZiBSGYIxLJXDsCbEMTO2TJKZ14=; b=u2cNypk+oFZnx/zEtjOEhjBfOogR0J+RJ/9wGMkj4AxKls/BG4jX4idlRkxEPN9n2oE2yGw8/InYTQgicSUnVgtaWXRF5bdl96Hd4fBgPcQx1YueykusRUqEq8ht5d5er7iiunlTKYxO2b8ODU+LQYOI77ONnliyqjVPpstvAOauUTaBk7PvIRqJBVWIxtF8m0iBDyhLjgVmBi9qsebZeRPijmv2hLcRWvGCOKUDkK//XhIgKODBwlRKNzZyj0ciYUxdS9U/uTCHIwb0DJFx6WhTb7B1cj4old7c2Yzg07UGJsUKnU5nEcCr/okLwJtJKroZhUsFyHuuFx+10fvE0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DU0PR10MB6704.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:400::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:23:59 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 13:23:59 +0000 Message-ID: <1a33ebd0-5b4a-87d6-01a9-4b0c41cb3e8e@siemens.com> Date: Wed, 11 Jan 2023 14:23:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 03/11] rootfs postprocess: clean python cache Content-Language: en-US To: "Moessbauer, Felix (T CED INW-CN)" , "Schild, Henning (T CED SES-DE)" Cc: "Bovensiepen, Daniel (bovi) (T CED INW-CN)" , "isar-users@googlegroups.com" , "venkata.pyla@toshiba-tsip.com" References: <20230111041140.3460393-1-felix.moessbauer@siemens.com> <20230111041140.3460393-4-felix.moessbauer@siemens.com> <20230111090626.7f2bc56c@md1za8fc.ad001.siemens.net> <9e2bda0ce8c1c4cebdb57f9a40cc4db91d0a7d83.camel@siemens.com> <20230111134756.77c9564a@md1za8fc.ad001.siemens.net> <360bbce523ed35f7687788f8a6cb946bdfa447c3.camel@siemens.com> From: Jan Kiszka In-Reply-To: <360bbce523ed35f7687788f8a6cb946bdfa447c3.camel@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::20) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DU0PR10MB6704:EE_ X-MS-Office365-Filtering-Correlation-Id: 21e0eac3-28dd-41f8-04e7-08daf3d718ea X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zhIjhLE8VP1Hx2OVWQ+U2vaZ+5y9UnwNE1ZzAhmrpqlA+8MgWUHWW7CAnc+heuaojw4+COBXG8vsTnVHFndUwnb0PrYz8Tb5+KhJ1glOQ4qzUD2fJfCVcssp0oR+Otcp1dEQbE4+Upa7jVSmIiYvLM8ADQPXQgbrtj14Z67sn2yMusYN+LW7vkEQVVENf6sv64+he+QsHM1voNDuT70FV6TtwB/LKrCJCQmI/kOqD212VLlA7A+i6ecYmFRhsKV4kPr+5SQoN99Qc6YcCJPEYcoibIRO+aFHVeMhSJz2oIDHEVx4/RAd/ZUjbkeMmkRkY1L9reCIgahEL0/n87gDwLHy6lojmpyHBSryjkpNe/HVkT/BPrnUYJfLNYIQlhXp2PPFIPk1e9lb+tb1egKj6ltvL4Ut2aSZcZtY0EskWWxSsd+hG04106QhtBo7oKbLfdmEoiedDmJdklo5EGtVOUWi6vy3bFX3/yxLm61XdBZsnDRrbdPI9l0lEeQzfSJEgYfC3jCdCbtRaPY6lBUQUvWu6CqjR/ntIteHBqRNXHnd8ilhLdgfOAHZUUI1jYKDUoRpphJyVuy2w/p7Kjgkem+OngI5pEV7JcUsa2WvT6//wWb3H6kmojxH7OX6B04iY+IvP9eEyychV0mCCLjM3MHj1hSfB/FIg2z++DodvaciEN8IieaJPtN5Mc2gBjy6fvFiPjqYoesU1wMQiNpsdFBEhffrBYywQOSR0MqbN04= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(366004)(376002)(396003)(451199015)(8676002)(66946007)(31686004)(41300700001)(2906002)(44832011)(8936002)(5660300002)(36756003)(66476007)(316002)(6512007)(66556008)(110136005)(54906003)(6636002)(478600001)(6666004)(6486002)(53546011)(6506007)(4326008)(26005)(186003)(2616005)(31696002)(83380400001)(86362001)(82960400001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emswZUhwNU5TNHh1RjRVanFGdDVBd0ZkL0xFcWY2clNvVWFwQVhtZzhlWHhL?= =?utf-8?B?bWVtV1NtYzVVME9lMjBxdi93QUxOcUxZUERoVEdaRG1iUURwVDdTWTdoZXpr?= =?utf-8?B?U0xoZmI5ck9hU0lmWlk3YmpocjhGcmFQTERyL0dOQXZuWXRCSmRCRk1qQWhH?= =?utf-8?B?RE1xVWdHM0tSSGV1c1lOK01QWUZkVENWcGRnOE1mSTZCRDQxTXRNQ2FnUVA4?= =?utf-8?B?MG5SYVdqNGNabjgzQzlYRmRCQnBqZnBGWnhRSHdRQUhvaXBaSERaQXJxNE1H?= =?utf-8?B?dmEyNWVjb0prZERUejB6WUZmY1paaXh0RE1kRnpQcmpNbzFKWTVXOW9yUlhl?= =?utf-8?B?K3krQkUxbm8rSFMrNnNWYThxVFhsT3M0a1BmRVpPN3U5dFRBTERKdlNzYVRX?= =?utf-8?B?Y2tSYTJHNzBKTjhSYXBmWVlzSTE3dXhqY0RKUWQ1ZmFsTTBZbUJ6SHd4S1pX?= =?utf-8?B?eForc3M3aC9VcXV2VHhsbmczZHNWeVZ1a0tZU2NyUHRGbHBxa29tT2Q3c0FZ?= =?utf-8?B?dW1VMGlZMkpER2daSmZkQlppUmw4REZkemxtK04yd0pDWWFza0k3WEF5SW15?= =?utf-8?B?d0hkMzJJQVJNaHoxZDAyb2VaR3lzSTJISlZxNGRSdmM1Zk1CNjJNaVQvc2RO?= =?utf-8?B?VWlibkhHSnZzd0dQek80eWhJYlpCaGRWdEs0K28yTTZJUkp5eDQrbTVrTDRD?= =?utf-8?B?TStnMGQrNzkxSkMrQ1czNTVGdGFnOUFaa2ZZUlBFRXgvYVVRSDJYSnJlUllK?= =?utf-8?B?K3Vha3g4ckM1WkhrRmNuZTF5cGxqbG9tN2ZZT0tIOC81dWpFeWVpQlZLMG9k?= =?utf-8?B?T1VFNit1ZXA4T3BhOWVKMFY0VzU0NmQ3by9FbUR2QlB2SHMyd3RBSW1ieDJ4?= =?utf-8?B?WEIxY1E1TXNzcVZYMXNZK3hKaWJKZ28vbEZNcEpJdFYwQmdKNzF2ZjJTM1Bw?= =?utf-8?B?VWNYa2N3bkprVVRGTU1sL3ZqVEtaRFViYjRKOU1hejdpdmp3aGlGaVdka0JM?= =?utf-8?B?citPSlBaNS9hSGdGQy9sL0hvNmkvam05WFRRbGpuanppUTJvT0syd3BWMXJC?= =?utf-8?B?WGZsb3d2ZHlkeHZ5NFhvSDd2dkpBTW9iZDJWQTd4TUdqUUtyNUc2NHBaRHNs?= =?utf-8?B?NUhwNU9HVjkvK0VIL3I1ZzFmVHJ5SjY2OVhlT0tML3VON2RTYUpUYXM2K1ZU?= =?utf-8?B?R3lsWDB5eFl0Y3E5QzhSTlBkcWVYUUlZSDR4Ulh2akNiVEtqYkZwVjlFWm9T?= =?utf-8?B?bElqR2hHTmUwY09ibUNCSGpSZlF6S3YvNnZqbHVqMUQxRElNL0NzRndzRDAr?= =?utf-8?B?aXk4TWVlZ0ZUT1Z4K0ZMQ3ZnNU1sY2NuZ29zZ3NPMC9kKzlueE5YL1hSRzl2?= =?utf-8?B?cTZvTmF0QlpUV05pT3NXSGNudDNiVVNZZThySFEvK015Uld1SkREOGhrL1Nx?= =?utf-8?B?NWFzMm5OSXpaNlROY0t2dnR1Y3lDYTViOW9IbmxxcmF4SkdmS0pkYkdHTW9q?= =?utf-8?B?YXBHS0EyWXNmQ3dENUk1SHF5cFBKMm5QcXNTb0FlSER5R0tlR2ZrMjVuSzdB?= =?utf-8?B?MVNDYmVrd3k4N2tXUDN6Zkp4MmlHK0ZPQ3BKMys2THN5L2dRLysrUkN4eUh2?= =?utf-8?B?elVUV2F2cStxSGJRVGx0Zm1HZ0JNazBKNHRDYUFtaTViWDRpNjlwcENiQ2VB?= =?utf-8?B?eVhxVGlRV3ZHYk5taXcvUmkyQzdCTnU3bUdXZE9oeUhVaXhNSlVTZGQ4WEls?= =?utf-8?B?UWFLQlh3ZkFuK2dlYy9LMkV0bFlzWUZUZ2Q0RWkzRFAvVGVXK1ZTRDVQOTB2?= =?utf-8?B?Q1YvdnFJVmlxNFgxQTY1OWh6M3JnWkUyb3V5b0s3cThsd21NSFAxRC9RSjYy?= =?utf-8?B?b3FndThQcVI3RFJUcjg2Y203bUswaUUrUThXUmc0MjNVSGFmUHBCYmJwNDJL?= =?utf-8?B?akN4UnY3S082bktxcWhHOHRpM2RSbnVFV2pQK0dnSEhEU01teThveEFUMGkr?= =?utf-8?B?eWlmNDRodDl0RGYzWnpVTllnUmZEbjFPRzhsckdPUHJ1NUJkYXE2VFFCQ3JI?= =?utf-8?B?T1Q3cGdDdThaT01wdVVpdHVpcFNxVm9od0RoNkJrVzBHQTZGUC9tOEM4U21K?= =?utf-8?B?QXdWUWdGdVFlVlo1eGJEc2huSVNJMExRRWpQNGNRVUJKcml3b3pCdkhXb0hO?= =?utf-8?B?Z1E9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21e0eac3-28dd-41f8-04e7-08daf3d718ea X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:23:58.9104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aB8U801KRNGQTX3VitYDCE/OagHirf+DBCTlHupUnys6egaJO0PFn4G8naKSqLgokNMKsNxFgy5wMraJK4aCEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6704 X-TUID: bA57OpSysfGF On 11.01.23 14:18, Moessbauer, Felix (T CED INW-CN) wrote: > On Wed, 2023-01-11 at 13:47 +0100, Henning Schild wrote: >> Am Wed, 11 Jan 2023 09:23:01 +0100 >> schrieb "Moessbauer, Felix (T CED INW-CN)" >> : >> >>> On Wed, 2023-01-11 at 09:06 +0100, Henning Schild wrote: >>>> Am Wed, 11 Jan 2023 04:11:32 +0000 >>>> schrieb Felix Moessbauer : >>>> >>>>> When calling python scripts, python automatically creates cache >>>>> files >>>>> to speedup future invocations of the same sources. This often >>>>> happens >>>>> in postinst scripts, that directly run in the image chroot. The >>>>> created debian packages do not ship these files, as the >>>>> debheper >>>>> scripts remove them before installing. >>>>> >>>>> For the rootfs part, we manually have to do it to also not >>>>> include these in the final image. This patch implements this >>>>> logic >>>>> in >>>>> a custom cleanup postprocess step. As there might be situations >>>>> where >>>>> shipping of a subset of the caches is desireable (e.g. readonly >>>>> rootfs >>>>> images), we add support to control this logic using >>>>> ROOTFS_FEATURES. >>>>> >>>>> Signed-off-by: Felix Moessbauer >>>>> --- >>>>> meta/classes/image.bbclass | 2 +- >>>>> meta/classes/rootfs.bbclass | 6 ++++++ >>>>> 2 files changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/meta/classes/image.bbclass >>>>> b/meta/classes/image.bbclass >>>>> index 519a2e5..b86a428 100644 >>>>> --- a/meta/classes/image.bbclass >>>>> +++ b/meta/classes/image.bbclass >>>>> @@ -80,7 +80,7 @@ image_do_mounts() { >>>>> } >>>>> >>>>> ROOTFSDIR = "${IMAGE_ROOTFS}" >>>>> -ROOTFS_FEATURES += "clean-package-cache generate-manifest >>>>> export-dpkg-status clean-log-files clean-debconf-cache" >>>>> +ROOTFS_FEATURES += "clean-package-cache clean-pycache >>>>> generate-manifest export-dpkg-status clean-log-files >>>>> clean-debconf-cache" ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} >>>>> ${IMAGE_INSTALL}" ROOTFS_MANIFEST_DEPLOY_DIR ?= >>>>> "${DEPLOY_DIR_IMAGE}" >>>>> ROOTFS_DPKGSTATUS_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" diff -- >>>>> git >>>>> a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass >>>>> index >>>>> 786682d..325e7ae 100644 --- a/meta/classes/rootfs.bbclass +++ >>>>> b/meta/classes/rootfs.bbclass @@ -252,6 +252,12 @@ >>>>> rootfs_postprocess_clean_debconf_cache() { sudo rm -rf >>>>> "${ROOTFSDIR}/var/cache/debconf/"* } >>>>> >>>>> +ROOTFS_POSTPROCESS_COMMAND += >>>>> "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-pycache', >>>>> 'rootfs_postprocess_clean_pycache', '', d)}" >>>>> +rootfs_postprocess_clean_pycache() { >>>>> + sudo find ${ROOTFSDIR}/usr -type f -name '*.pyc' >>>>> -delete -print >>>>> + sudo find ${ROOTFSDIR}/usr -type d -name '__pycache__' >>>>> -delete -print +} >>>> >>>> Are we sure that this can never be valid content of any package? >>>> I >>>> suggest we double check with dpkg. >>> >>> I already checked this. Shipping the __pycache__ folder is a >>> linitan >>> error [1], shipping any .pyc files is a linitan warning [2]. >>> >>> Adding bbwarn here does not make sense either, as we cannot >>> distinguish between pycache entries from a broken package and ones >>> created by postinst scripts. Anyways, pyc files are just cache >>> files >>> and these should not be part of any package or image. >> >> Can we not ask dpkg -S for every file before we delete it? Removing >> files owned by package would likely be wrong. No matter what you >> might > > This does not scale. We are talking about potentially thousands of pyc > files (e.g. for tensorflow or pytorch). > >> think of the quality of such a package and how many debian rules you >> cite. We have these kinds of packages, coming from funny vendors and >> maybe also from weird recipes. > > I know. Anyways, the python code will very likely break in case only > the .pyc files are on the system, as these files depend on many > conditions which are different in the buildchroot and on the target. > In case any of the conditions is not met, it will be re-generated from > the .py file. Let us please not try to create overly complex solutions > for use-cases that are broken / invalid in the first place. > > In short: I'm strictly against not removing these files. I even thought > about always running this cleanup command unconditionally. > > I would also appreciate if we do not delay the whole reproducibility > story just because there might be some exotic and invalid use-cases > that break. Yes, focus should be on clean Debian packages first. If broken downstream stumbles too often, we can still take measures. Jan -- Siemens AG, Technology Competence Center Embedded Linux