From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7345378448314990592 X-Forwarded-Encrypted: i=3; AJvYcCUHPR3OxIWrI0fYJ8UPxTzU/yijwP1c63ebk5NpIx3Lbdb+IFG9n+qq/KR77ozYdwOj3J3lue4z3xOo9ynuamaA7bP9qF9kvDV6sDk= X-Received: by 2002:a05:622a:190d:b0:42f:5131:54a9 with SMTP id w13-20020a05622a190d00b0042f513154a9mr2581765qtc.63.1710234228556; Tue, 12 Mar 2024 02:03:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac8:5912:0:b0:42e:efca:555d with SMTP id 18-20020ac85912000000b0042eefca555dls294978qty.1.-pod-prod-04-us; Tue, 12 Mar 2024 02:03:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXK/dNckkrMLV5w3aphTatbCK2+81z1xb/l8Ux/s+moC/+KZF9f46yfiiLIE6zo/mF9VBQ9kpTIgbjpoakEfvp+aSDqi5KL6Xi3wdI= X-Google-Smtp-Source: AGHT+IHS53VOijQQ+faReHlrx5sE2yNEvOmgWR1qSvbBoBW+aa7RctITTXosUWMzoTcsem16YX7s X-Received: by 2002:a05:6122:388d:b0:4c0:2abe:d585 with SMTP id eo13-20020a056122388d00b004c02abed585mr5650955vkb.6.1710234227538; Tue, 12 Mar 2024 02:03:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710234227; cv=pass; d=google.com; s=arc-20160816; b=sJu5iBGtJt+7JOFEPOf0clPKfkFz2JHvQAeuoE9cbnCGk1RPlZsb17EzF+Go0F6OxV MkZqBVbnfqBa4L3dCmpyRa5dSjZguf2DaU+taFh6VVAApSExXmeN46SMIrEAyF9K6GuC xn8CAEsnWRJd8aWidkaN0BPkh6543DtBsVxPCai+47ySMRlV8qn3+jCrwL75tKhMQBg/ axsEeep28aNzSgrqBNx3n4lYsh1tJwHQwri8kpl/aDYz9W0J10LK569Pcd5HjGd+AHCG AJo5PpQM5yOz+ZnASWq9kOPgk8xcpHonUK7YrNqn60Ij4R7BedqkfZhRCt5NCtwaVBVX Wg2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=LfF/5Zui3cwHJqMjY58XfArYL2QTjsyHxiYL4r7S2dk=; fh=uGKozc259thEjNNZnCO/y/6BixyM/1r2+o7koGbmSIM=; b=Mj8vKVfe6DGdtP2kPcNfaZBeGKRddaMMzcCPcRl7XRg+vGsc9MnSBcMvagEACOBVQ4 GlU1Qs65Xm1UZNUkQQD90UayusZx2puc8rBfWRnCkMldX4/AjrKnKsH93yl9NTE4cn5W OTtQJVFqNDNvwer6s71pV/MHwOjskkPW1qtI/3G2EaOcwoftT79oj1pOfkBhIytDJpSj Qo/iScKngwtyDtX/SALiRXn7lBImXtyKT6JZg6pJh6OBabKEtFB4Lk/DXQYcxxSoIP4M EzlOfHucKV4xsgzqqrheHjP/D0l/SsGcvnc2SN9hMvgLyKRGsyjV6UfwSslfomudKOGT DWSg==; dara=google.com ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="JLam87B/"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2612::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20601.outbound.protection.outlook.com. [2a01:111:f403:2612::601]) by gmr-mx.google.com with ESMTPS id i187-20020a1feac4000000b004d3342d94easi1051516vkh.1.2024.03.12.02.03.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2024 02:03:47 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2612::601 as permitted sender) client-ip=2a01:111:f403:2612::601; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="JLam87B/"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2612::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NR6H2x9siIWjRKLMFHxnz0xnnkhtu66Zc7+mpdO51gvthP+zsJ83nDjopeYTzhMzv88yax+LC9gTipIO2YgvoGjoPspc6/RRPu3jzTFrdZJLDpGA10TuRX7hwDCKxbDAjEJKnkTYSTyPI6Tk0h6WAtqiLday2iD+uhVP9+D2qkp7wicHRtID9lvHc2NIIuPpdejas6330mWyNWWIWyAp36Uzj7tbn0tENRrwGgEk1GnjxED9ClzyChIFW13RDUcqVvPAQcKmwgUMz08AtZycdZq0sdhjfRg6E1W4xG4+sd1njggEljEM0+1f7sKdtqWX4HZzy0L2dHFPmy23FJBBMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LfF/5Zui3cwHJqMjY58XfArYL2QTjsyHxiYL4r7S2dk=; b=CsLfklbIE/3LV2+ZA/Ji9q237Wz+TVuLp51dUA4ympA4aRnEqs8tvQE5FdSExNzp461Sb4PdWdSgkSuOdcBm+izZrJ/jtj5gMsBZ2C/x6PNp+2WlqOlvEOwPhbBXcEjnu/fnyfxbFQyCW37JoCYZ+nJp55TNffQjMrfsdKD+Iawljg+w07gCbyq/xzvTQ7MSdYImjI0J9SqbQBCmjSJhGhE+v3WkpfHvyBTJKYGf98optEd/jvUNfbLU3zLnX91DFiieEk/Ej1YKo/iS91BnJqBIWKuiUZie1MC6HHXCG9S17N5wOuLMzzpz6pGZsZHEL2iOCC6rU7Ng4iU9XqFpVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LfF/5Zui3cwHJqMjY58XfArYL2QTjsyHxiYL4r7S2dk=; b=JLam87B/iX4uJnMFkZowsxxlAUBFTBrpfJDkxjDN22dlWcnuMFWcIeGrHcUMrW5Q1Cx+OL6XVy+GhnMLS7Vvh7/O1xHRe8fQxU9ujp/jmbukHm+uTkgO5+apU+rpJRSPYWU2ZhnAA0OtP2gWonbEXH/2CoegFtQOPwqrZfdl4vMcsdYerjf9WmrvoeSP8sZtv/TNRytHNZuHm96k3zBOlTo4VP85BpMlqJpeZZ7uocqozHOQzUlUJWyMqRkluVHnNsGRoLS8x5qpmifYJnQzxnvqyAA6xAtcaUcywlzTVA8NdlbsFRl1XC3OhgEbmCKFJLMVSLhFl3FRoOd1lUD0gA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AS4PR10MB6302.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:58d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Tue, 12 Mar 2024 09:03:45 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe%3]) with mapi id 15.20.7362.035; Tue, 12 Mar 2024 09:03:45 +0000 Message-ID: <1a638438-e283-4aff-9f52-dbbb67ef1170@siemens.com> Date: Tue, 12 Mar 2024 10:03:43 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] image: limit search for *.core to regular files Content-Language: en-US To: "Moessbauer, Felix (T CED OES-DE)" , "isar-users@googlegroups.com" , "Hombourger, Cedric (DI CTO FDS CES LX)" References: <20240312073935.331457-1-cedric.hombourger@siemens.com> <6d0596bc-dd71-4521-af1a-4cb77a7c63d1@siemens.com> <562bfbade6a1b418fde9861a27ebe991b08cfd96.camel@siemens.com> From: Jan Kiszka In-Reply-To: <562bfbade6a1b418fde9861a27ebe991b08cfd96.camel@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0102.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::16) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AS4PR10MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 271103d6-ca73-411f-139c-08dc42735277 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5ylikm8Jo9utBv0wZJ7HY0TUZdc2i9fDpKirIzrdXYA5k/FxOY8e9AtCRHWS5g94FXa4CvwE8nyGOen5237bw0UQSbuDR/vTafRE33GZG298Eb9p+8tknq8EVEO1N8rHXce6zO/0ZNwYYsfhlscwNuHYBekBNLLjVoAbtMu0gsiqJYUaY5hwz4+lwHrYHSpV5rrPJBnItG6bLaEU+bI49EBbWzCES5/zCc5sZW8rkx67+2qzTizINU7JiPjPgLSFm9sikVvWY4e45YrDkaElfpb8XbbFUMU5jvmykgoYIMgPU8odSAJHVnhT3ba9OdKXunXp0xza1AFJNz4K4LLqzeMO/SDjD+E+Q84rP9c9AowYyFejvJgUw/XyGvXTVhRsN0BcTj626Ufzx4tPE2pSjtWnqTeCxwpbYQPeqdHRwLkA70pWSOky07BOTOTg2TxQ1xEBEOD58cGxRIIdsYM0fgqqMlTqB9oVqbV9VIJfU9S9fcrDuN9SW6gvSLPioPzRpQlZu6Q+KonH1BIoAjkdVYhNyTcC+1fJMXQ+Nn9uwdQ44PYtaNGyHLdPQz3jbhh2eepPFcC6+WDsp32bOJz6K89vAz3DxQZQoURWbLO8E4Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2xNSU1NRVNhZ2hxeFpTSmdpaFNsVlNwalJkcWs2M056cU9tTjZwdkZITDdR?= =?utf-8?B?aVR5Qm5DWTIvN0RkSkZ6U1FselY4Vkg3WUgxL05wRU1KRitTUlBXbTNpRkR4?= =?utf-8?B?WW5OcjhUaUJIRlVHWFhBQ2l2WTd2ZFRVTlh4UitPMjQzUmlOZEtBSDFxbk5z?= =?utf-8?B?TmZjbS9uNjRqY010K3BwME9BM1NacndTU044cmF5dGxSM2NSVFJ3OHNkT2o4?= =?utf-8?B?MGIrMjJ2TEFQTFV2WXF0L0xTY0F3K0NvVzBsalcrZEc5dnBpdHBXUDRPSUxT?= =?utf-8?B?bG5sb0ZyckVKSWMweU5jR3dHdWgrTExtOTE1Sm5yT1RJTUZmdTZBbFExVUx2?= =?utf-8?B?NnhDZm9YMjh6T2FaU2pSRlF2YVhIQXoxU2wxZ2FwN2NZc2pUVURQc3dDaTda?= =?utf-8?B?UEVNVHhBbUxOWk5XVE5tcU5vK1dMa3hQRGNtd3NzMnozOFc0U1c5VC9Hd0Na?= =?utf-8?B?TkpxQ212MjJwckJ4K3BJZW9oOGxvYU1aYmtXUm5QMzlBSXdUOHhzNzZEVm1v?= =?utf-8?B?VmRZRk9rbytSa1piT2tMTml1MCtUUzUzd3RyR1JaeVJyM3FUSWZyMGZHRUZk?= =?utf-8?B?ZVd0KzRqZy9OVlp6cHgya3J0UENaTUVkMFFaNUZIWS9OcWtjS0gweUVsc1pQ?= =?utf-8?B?Tk1heTZhQ0gzeVcwcFZFTG5hd1M1Y1lkV0xob3dub3A5ZkxaVzgxdlNoaVBq?= =?utf-8?B?cFhxSzI1VWdqTHAzcUdYQXM3YStETXNaZ1ZORmVteXQxVjUvR2F3UHBaOEM0?= =?utf-8?B?aDdLcUVpVHRDNUxudFErQzVUcW9TWVhWUTMzTDVaVllURGVyY2JGQW1RUHpy?= =?utf-8?B?cnhhUGY4dFhPbzFaNFYyU0k1NkYzY3d2TTlGU3ZEVncvcVZEYmRwelFHekdO?= =?utf-8?B?M0FCaWJzMndncy83MDJDbUlBaG13Ym1IU2FNaFNQa3JxNkp3VC91S3lBcG9y?= =?utf-8?B?dmlSRVBLcHFkb3Y4blI5NUl0Q2ZDTldKS05MUEdSeG5qWlFtOVNRSldWeEQw?= =?utf-8?B?YWU3aGVMdHllRG9idi9hMjYyNzNMaGZmdE1JcmplZEVEWjJsaEpST0Y1RlQ2?= =?utf-8?B?bUk3a3ZTODBWKy9FUFRjYVRCU1VjTUdLYkk2azc1Q1hqcFJvc1Fkbnlhb2gr?= =?utf-8?B?R2hZYjFiUVlhTWhxbWgzQmVqUzY0QkIxNVk1WXQvUE43ZWVhZEdOcFRNc1lk?= =?utf-8?B?ZnlwZ3RybzZJNFZiREpXWG9FWkNlNU9qOEI1ZUhRZzlBa1N4Y1RIa0tzODZr?= =?utf-8?B?RUZ0bzhoa1BXWmVHRzR4cDRqL3QrYmxPVXo4aWliZHdzMjdWNG90bXVGR1BM?= =?utf-8?B?d3U5N2c2blJ4Umh5MWFFZ1F1czdmYlIxdER2WTY3VHRSRStVakhzdUM5LzhI?= =?utf-8?B?c2RTaGcrSWc0SklEelhJb1dUU0hOaXdIZkZSRjB2Wm90WjVCUmRldTIzZnp3?= =?utf-8?B?NWhkZVlYcG5lRlVQcC9qWkg0SXo4TzBuRE0yeUMxTTlOOVRKYXB5T0Z6QVJD?= =?utf-8?B?VDN1c29ndDFhZ3ltZnpsL1JKT01lYzZtc3ZvYmRZUzJVdTVXeUlhZ0dhZDNM?= =?utf-8?B?MEpveUg3SW43MjM4aXRwUHZrSThnRWhic3gvNS9mZzhXZTdtb3FZa3MyZk9J?= =?utf-8?B?ZmZLTnZNb2FvL0RUYU05dWhoM3RodGt3eHBoK0V5Q2VuRGloSkRyMW5BbVh6?= =?utf-8?B?ODY3QnZUTXVVbzdqV2pMclFKSmlQbVU4TE02b2NSZElFcGlnWVM4bUtHeHlD?= =?utf-8?B?NUoxRnhUT3gwR2RPUCt3KzdzVEY5cElnTEJIN2VkaUtreENKbjh6aWlwcHhq?= =?utf-8?B?d1R2ZzlYZm93NFdoK0I0T0hJQVl3Ui9peUF0WlQ2ZFZPejFVVnVtck1VNXV4?= =?utf-8?B?VjZWTlorSGNKK2pTTFNKQlZJSm81SU5EcGY2ZHVTZUZPNzlCcFZ5ZkNEeURK?= =?utf-8?B?bVVFZUlFZkpNdCsvbmZwRjZCKzNlalVQYkpBYVJEM1k0QVcyZy93WE5obmhY?= =?utf-8?B?eDFSZDJFZGhNM3JnbW02VkVzTU9DdXlMNGpvcm1Yc25kcHlrRlBkR0ZVSW9v?= =?utf-8?B?bTFiWjBoM3JXbURNQkN1ZC9JMjZJODZNM3l6RnFhc3BnZUh2K09QZ09NTXpP?= =?utf-8?B?emxxSkpUdE9qL05aWU11QlIzcjVvSzVhQkhGcFZaTVJIRjFOMTNjZTJtUzd4?= =?utf-8?B?d1E9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 271103d6-ca73-411f-139c-08dc42735277 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 09:03:45.3599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VV27bU/0EAS5Rvrxh5ao37XHFD3NdC1rSTfI3u+7KfZmO2oZd+hwbdXM5Q1X4e8nRaiMuQbKhb1v8+qZLc9h3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB6302 X-TUID: EOksL7qB4iIG On 12.03.24 09:31, Moessbauer, Felix (T CED OES-DE) wrote: > On Tue, 2024-03-12 at 09:11 +0100, 'Jan Kiszka' via isar-users wrote: >> On 12.03.24 08:39, 'Cedric Hombourger' via isar-users wrote: >>> Code to search and delete core dumps in the build tree assumes that >>> the build host has a kernel.core_pattern setting which would result >>> in core dumps having a .core file suffix: this is not guaranteed. >>> One >>> may also argue that the build should have failed if a process >>> executed >>> under qemu-user got to crash (and we should check why qemu has >>> crashed > > Well... It's not that easy. This is the third time for me that this > coredump discussion pops up somewhere. > > Many builders (like CMake) use feature probing (e.g. to check for AVX2) > which execute test examples that either succeed or crash with a > coredump [1]. While most of our builders run inside the schroot, there > might still be cases outside schroot where this is the expected > behavior. > >>> and fix it). My vote would be to kill that code but for now, make >>> it >>> less wrong by restricting the search to regular files suffixed with >>> .core (this would at least stop isar from moving directories such >>> as >>> "org.eclipse.equinox.p2.core" out of the image). >>> >>> Signed-off-by: Cedric Hombourger >>> --- >>>  meta/classes/image.bbclass | 2 +- >>>  1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/classes/image.bbclass >>> b/meta/classes/image.bbclass >>> index 73f1d52c..793c21a2 100644 >>> --- a/meta/classes/image.bbclass >>> +++ b/meta/classes/image.bbclass >>> @@ -457,7 +457,7 @@ EOSUDO >>>   >>>      # Sometimes qemu-user-static generates coredumps in chroot, >>> move them >>>      # to work temporary directory and inform user about it. >>> -    for f in $(sudo find ${ROOTFSDIR} -name *.core); do >>> +    for f in $(sudo find ${ROOTFSDIR} -type f -name *.core); do >>>          sudo mv "${f}" "${WORKDIR}/temp/" >>>          bbwarn "found core dump in rootfs, check it in >>> ${WORKDIR}/temp/${f##*/}" >>>      done >> >> Yeah, too much heuristics in play now. We could add a list of valid >> "core" files on top, but maybe we should rather demand core file >> generation being disabled during the build and enforcing that. > > We had exactly that discussion on the KAS ML as well, were I tried to > introduce a warning on default coredump configurations (which are BTW > really tricky to debug on CI systems). However that was not accepted as > the builders itself shall be responsible for a suitable coredump > configuration [2]. The truths is probably somewhere in between. > > Just disabling the coredump generation is not easily possible, as there > is no "coredump" namespace in the kernel. By that, you would fiddle > around with the global system config and potentially interfere with > systemd (systemd-coredump). > > The probably best thing we could do is to look for common coredump > patterns and check with file if these are actual coredumps. > Can't we read out in isar what the effective settings are and use them at least? In addition to possibly adding some exceptions on a per-image basis. Jan > [1] https://github.com/DynamoRIO/dynamorio/issues/6126 > [2] https://groups.google.com/g/kas-devel/c/-sEyujhICfw/m/1UtVfsDRAAAJ > > Best regards, > Felix > >> >> Jan >> >> -- >> Siemens AG, Technology >> Linux Expert Center >> > -- Siemens AG, Technology Linux Expert Center