From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com, Kasturi Shekar <kasturi.shekar@siemens.com>
Subject: Re: [PATCH 4/4] installer: install seprated installer modules in recipe
Date: Thu, 14 May 2026 09:20:01 +0300 [thread overview]
Message-ID: <1aaf8140-e8c4-48c7-8a23-0c2bbc6c0433@ilbers.de> (raw)
In-Reply-To: <20260427063957.603123-5-kasturi.shekar@siemens.com>
27.04.2026 09:39, 'Kasturi shekar' via isar-users wrote:
> From: "kasturi.shekar" <kasturi.shekar@siemens.com>
>
> Update deploy-image recipe to ship the newly split installer modules.
> Add the following files to SRC_URI and do_install:
> - sys_api.sh
> - installer_ui.sh
>
> This finalizes packaging for the refactored installer layout.
>
> Signed-off-by: kasturi.shekar <kasturi.shekar@siemens.com>
Just to keep things clean, can you use "Name Surname" format for From and
Signed-off-by sections?
> ---
> .../recipes-installer/deploy-image/deploy-image_0.1.bb | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb b/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb
> index 03b082a9..ef161ebd 100644
> --- a/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb
> +++ b/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb
> @@ -1,5 +1,5 @@
> # This software is a part of Isar.
> -# Copyright (C) Siemens AG, 2024
> +# Copyright (C) Siemens AG, 2026
This should probably be look like "Copyright (C) Siemens AG, 2024-2026",
because you've just changed some lines, not the whole file.
The same for patch 3.
> #
> # SPDX-License-Identifier: MIT
>
> @@ -9,6 +9,8 @@ MAINTAINER = "isar-users <isar-users@googlegroups.com>"
> inherit dpkg-raw
>
> SRC_URI = "file://usr/bin/deploy-image-wic.sh \
> + file://usr/bin/sys_api.sh \
> + file://usr/bin/installer_ui.sh \
> file://usr/lib/deploy-image-wic/handle-config.sh \
> "
>
> @@ -20,5 +22,7 @@ do_install[cleandirs] = "${D}/usr/bin/ \
> "
> do_install() {
> install -m 0755 ${WORKDIR}/usr/bin/deploy-image-wic.sh ${D}/usr/bin/deploy-image-wic.sh
> + install -m 0755 ${WORKDIR}/usr/bin/sys_api.sh ${D}/usr/bin/sys_api.sh
> + install -m 0755 ${WORKDIR}/usr/bin/installer_ui.sh ${D}/usr/bin/installer_ui.sh
> install -m 0755 ${WORKDIR}/usr/lib/deploy-image-wic/handle-config.sh ${D}/usr/lib/deploy-image-wic/handle-config.sh
> }
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/1aaf8140-e8c4-48c7-8a23-0c2bbc6c0433%40ilbers.de.
prev parent reply other threads:[~2026-05-14 6:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 6:39 [PATCH 0/4] installer: separate installer into backend, UI, and flow modules 'Kasturi shekar' via isar-users
2026-04-27 6:39 ` [PATCH 1/4] installer: extract backend helpers to sys_api.sh 'Kasturi shekar' via isar-users
2026-04-27 6:39 ` [PATCH 2/4] installer: extract attended UI to installer_ui.sh 'Kasturi shekar' via isar-users
2026-04-27 6:39 ` [PATCH 3/4] installer: add installer flow module and entrypoint 'Kasturi shekar' via isar-users
2026-05-14 9:19 ` [PATCH v2 0/4] installer: separate installer into backend, UI, and flow modules 'Kasturi shekar' via isar-users
2026-05-14 9:19 ` [PATCH v2 1/4] installer: extract backend helpers to sys_api.sh 'Kasturi shekar' via isar-users
2026-05-14 9:19 ` [PATCH v2 2/4] installer: extract attended UI to installer_ui.sh 'Kasturi shekar' via isar-users
2026-05-14 9:19 ` [PATCH v2 3/4] installer: add installer flow module and entrypoint 'Kasturi shekar' via isar-users
2026-05-14 9:19 ` [PATCH v2 4/4] installer: install seprated installer modules in recipe 'Kasturi shekar' via isar-users
2026-04-27 6:39 ` [PATCH " 'Kasturi shekar' via isar-users
2026-05-14 6:20 ` Anton Mikanovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aaf8140-e8c4-48c7-8a23-0c2bbc6c0433@ilbers.de \
--to=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=kasturi.shekar@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox