From: Jan Kiszka <jan.kiszka@siemens.com>
To: Claudius Heine <claudius.heine.ext@siemens.com>,
isar-users <isar-users@googlegroups.com>,
Claudius Heine <ch@denx.de>
Subject: Re: [PATCH] rootfs: Add missing dependency for rootfs_postprocess
Date: Tue, 20 Aug 2019 16:58:12 +0200 [thread overview]
Message-ID: <1b049084-e088-ca37-2e5b-394adb436736@siemens.com> (raw)
In-Reply-To: <fcd669ff-4e3e-f696-a62f-b4508e402a85@siemens.com>
On 20.08.19 16:55, Claudius Heine wrote:
> Hi Jan,
>
> On 20/08/2019 16.48, [ext] Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This task needs the unpacked files from SRC_URI, specifically
>> DISTRO_CONFIG_SCRIPT.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> meta/classes/rootfs.bbclass | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
>> index c7e0435..7d22452 100644
>> --- a/meta/classes/rootfs.bbclass
>> +++ b/meta/classes/rootfs.bbclass
>> @@ -227,7 +227,7 @@ python do_rootfs_postprocess() {
>> for cmd in cmds:
>> bb.build.exec_func(cmd, d)
>> }
>> -addtask rootfs_postprocess before do_rootfs
>> +addtask rootfs_postprocess before do_rootfs after do_unpack
>
> No, I think the dependency between do_unpack and do_fetch is missing.
That would be another bug, a rather generic one.
The good news is that this change resolved my "debian-configscript.sh: No such
file or directory".
>
> rootfs_postprocess depends on rootfs_install which depends on do_unpack already:
>
> classes/rootfs.bbclass
> 159:addtask rootfs_install before do_rootfs_postprocess after do_unpack
Let me visualize the dep-graph to find out where your assumption was wrong. I
don't see that ATM either.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2019-08-20 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 14:48 Jan Kiszka
2019-08-20 14:55 ` Claudius Heine
2019-08-20 14:57 ` Claudius Heine
2019-08-20 14:58 ` Jan Kiszka [this message]
2019-08-20 15:34 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b049084-e088-ca37-2e5b-394adb436736@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=ch@denx.de \
--cc=claudius.heine.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox