From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6623002413686063104 X-Received: by 2002:a7b:c018:: with SMTP id c24-v6mr419393wmb.7.1542203941981; Wed, 14 Nov 2018 05:59:01 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:f0d0:: with SMTP id x16-v6ls4162363wro.22.gmail; Wed, 14 Nov 2018 05:59:01 -0800 (PST) X-Google-Smtp-Source: AJdET5fMQ/bJh6ITWUGXQ1jLuszeWp7RfVkjnDIvD4xK+lmE0KY8xtQVvhxdjQlGLR7A9vhXk75b X-Received: by 2002:adf:f389:: with SMTP id m9-v6mr399228wro.11.1542203941500; Wed, 14 Nov 2018 05:59:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542203941; cv=none; d=google.com; s=arc-20160816; b=gbHw+jUz9+/C5w8wyNI3dbM97VKZ03eDQAOCEUgHpIuOJ0Tk8zsHrc42OfDOeVgWl8 CtcPanHKi/lBG/hooMfhIl0Gq+CnOMiz/V/nTF+Rk0c7KF/xPMvmyY5tL3Kxo90HHh5K LT897W75ssCPEeXiYWrBL2Vqegfa9Wl/vH26hO9w+byP26aNA9d07ZyNd1DMI/Z6uPpO AWhDJmWbExrIWM/q6NvixzfdTat5csBZaFeqyTTLp/Pty9maAauqvs2GXCZ4KTaLptuo oQp3qM+g4I+l0TzboUc8vHOJ3QciKNGLr4E45r0tXFfYG5IsdQBddbxlRIY/QBx7StR0 7jsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=BH+szuSZ3D84ZApMYqG/8F8eOgc+g020YnAyZXk6Ux0=; b=nCZ1iiuvIrpz1sMc0hlplPHcR7IqgItxyEmiR+7V3uJ+2EkNc/OQtkx7U22KUV7WbL s4sEHTc8ByaO8oMACnV6XeIgeY0G7fAJKoMkN751PFlLvtyU7TvdZModRSJkpH7/4I/g z/ysbyvX9hpr79RNwTXIJGJ06RA6cSHkv7QMq6yeNeDwCc3OQhitUNO2bnbmu6X8oYbz nqjNKVJs5htlTgvejLgouYTY8PxaBoLOPGx6Mwb2UUQj7Yz3SZa4TeNT2uj7xkmoMYKD hXi4PrHc/2jTRkMolKLZznS+KnCD5kUK6+ixEUyJ5nZQfkjDQd064xjh+TaZ6/8K/Jqe gCAQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id u13-v6si774321wrn.3.2018.11.14.05.59.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 05:59:01 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wAEDx1ql010064 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 Nov 2018 14:59:01 +0100 Received: from [167.87.37.94] ([167.87.37.94]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wAEDww5G000764; Wed, 14 Nov 2018 14:58:59 +0100 Subject: Re: [PATCH 2/3] Revert "Change ownership of WORKDIR prior to unpacking" From: Jan Kiszka To: Henning Schild , isar-users References: <20181112155149.24215-1-henning.schild@siemens.com> <20181112155149.24215-3-henning.schild@siemens.com> <6852a6f3-79a6-7320-abae-5a168fcada59@siemens.com> <06ac3f88-0104-6bd0-711c-f75fec4e4a6f@siemens.com> Message-ID: <1b49699a-e4a5-83fb-f631-de56c7ee266a@siemens.com> Date: Wed, 14 Nov 2018 14:58:57 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <06ac3f88-0104-6bd0-711c-f75fec4e4a6f@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: +dPgN8llA8Li On 14.11.18 14:23, Jan Kiszka wrote: > On 14.11.18 14:10, Jan Kiszka wrote: >> On 12.11.18 16:51, Henning Schild wrote: >>> We do not build as root anymore and the non-root uid/gid are now in sync >>> between inside and outside the chroot. >>> >>> This reverts commit 624b7c484bf59940ac2a4114018f7d56892dc05e. >>> --- >>>    meta/classes/base.bbclass | 5 ----- >>>    1 file changed, 5 deletions(-) >>> >>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >>> index fce1084..d4082de 100644 >>> --- a/meta/classes/base.bbclass >>> +++ b/meta/classes/base.bbclass >>> @@ -120,17 +120,12 @@ do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" >>>    # Unpack package and put it into working directory >>>    python do_unpack() { >>> -    import subprocess >>> - >>>        src_uri = (d.getVar('SRC_URI', True) or "").split() >>>        if len(src_uri) == 0: >>>            return >>>        rootdir = d.getVar('WORKDIR', True) >>> -    uid = str(os.getuid()) >>> -    subprocess.call('sudo chown -R ' + uid + ' ' + rootdir, shell=True) >>> - >>>        try: >>>            fetcher = bb.fetch2.Fetch(src_uri, d) >>>            fetcher.unpack(rootdir) >>> >> >> This possibly causes this regression: >> >> ERROR: expand-on-first-boot-1.0-r0 do_install: Function failed: do_install >> (log file is located at >> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263) >> >> ERROR: Logfile of failure stored in: >> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263 >> >> Log data follows: >> | DEBUG: Executing shell function do_install >> | install: cannot remove >> '/work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/image//lib/systemd/system/expand-on-first-boot.service': >> Permission denied >> | WARNING: exit code 1 from a shell command. >> | ERROR: Function failed: do_install (log file is located at >> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263) >> >> > > OK, that wasn't a "clean" re-build (rather a rebuild after the Isar update). > Retesting with the same Isar version for build 1 and 2. > It persists, at least for dpkg-raw, and that is likely because of the chroot we do for that package. How does normal dpkg get away without chroot now and still produce the right ownership when installing a package? Can we adopt that? Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux