public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH 1/4] dpkg-base: Relocate dpkg_runbuild and adjust comments
Date: Sat,  1 Sep 2018 16:47:47 +0200	[thread overview]
Message-ID: <1b5e15c8e81573a268ee1dbfed346ad8ca56ff65.1535813270.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1535813270.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1535813270.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

This puts this placeholder in the context of its task definition and
also improves the comments related to dpkg_runbuild as well as
dpkg_prepare. No functional changes.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/dpkg-base.bbclass | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 5826357..84c56af 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -50,13 +50,10 @@ PPS ?= "${@get_package_srcdir(d)}"
 BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
 do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 
-# default to "emtpy" implementation for dpkg_prepare() and dpkg_runbuild()
+# Empty do_prepare() implementation, to be overwritten if needed
 dpkg_prepare() {
     true
 }
-dpkg_runbuild() {
-    die "This should never be called, overwrite it in your derived class"
-}
 
 MOUNT_LOCKFILE = "${BUILDCHROOT_DIR}/mount.lock"
 
@@ -89,6 +86,11 @@ do_prepare() {
 addtask prepare after do_patch before do_build
 do_prepare[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 
+# Placeholder for actual dpkg_runbuild() implementation
+dpkg_runbuild() {
+    die "This should never be called, overwrite it in your derived class"
+}
+
 do_build() {
     dpkg_do_mounts
     dpkg_runbuild
-- 
2.16.4


  reply	other threads:[~2018-09-01 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-01 14:47 [PATCH 0/4] dpkg class refactorings, API changelog Jan Kiszka
2018-09-01 14:47 ` Jan Kiszka [this message]
2018-09-01 14:47 ` [PATCH 2/4] dkpg-base: Clarify dependency logic between package recipes Jan Kiszka
2018-09-01 14:47 ` [PATCH 3/4] dpkg: Split dependency installation from build preparations Jan Kiszka
2018-09-01 14:47 ` [PATCH 4/4] Add changelog for the recipe API Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b5e15c8e81573a268ee1dbfed346ad8ca56ff65.1535813270.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox