From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6596267784429109248 X-Received: by 2002:adf:b713:: with SMTP id l19-v6mr1622986wre.8.1535813273257; Sat, 01 Sep 2018 07:47:53 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:9d15:: with SMTP id k21-v6ls3700659wre.6.gmail; Sat, 01 Sep 2018 07:47:52 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaXv3Ven81ck3BK3e9mW9B+6Q66A/yxyul7Ykc9Yqgj22SBIpvBcDYGhHqGrGA/ym1LYoM6 X-Received: by 2002:adf:f787:: with SMTP id q7-v6mr1679103wrp.5.1535813272780; Sat, 01 Sep 2018 07:47:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535813272; cv=none; d=google.com; s=arc-20160816; b=dHWhkWWxfp0Bwn3cZQ0aiBjKYNtH/etfWro12flajuYrAtQ+67HzSLPnF8CIiffiM+ BfomDhXBeBP/v72CV7oe89Y47klToo3QpC2d3gWiDVLv65Lqnq4Xj9VGiDRnJp5wSu+V XYMgn/FI3PAyvIuOI0eokzD3TsjhpspUE2dFZh8zyKzmpSitcw5jS+L+d9byJY25DL19 DZo593SF26Le1j+DMFqOCEFBjFo/pe+yr7cxnUEn2CuaJtnIyj4s2/rkw3dK8r5RX7Ko 1J0Zysb+UtCkOeB/OzMkq8tySSy7PBz4qeyusDUhVpepPYUaUzz/isNU8HSERlBJFQNq 0KHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:references:in-reply-to:message-id:date :subject:to:from:arc-authentication-results; bh=9mqM6XPgnFSMBExG9H68FfrbQ2IKVa5P+4B5dcKSXfg=; b=rar4LWjlOyq5NU+XyjXTApymKgZp+RpS0OqxZEk5gNJT5QuChqALZ+2GTmkliHnZzF sw02tuhCehYkYGjo8xRBi7LskInp5Td01jR/d6+fqAYKviMqAj2e5Kgizo+lruMsf4vV ihYfA/5U0FESWr4RtaK5lzXxS4HuBnkfclagsqLF/0zRNnD/kXawXJeP8EgrtoPJP+xW ZlDEjJs3K1c6Auzn+4sSgvFt2FIhnDxhFFWk+5+/OmyOFYy5tNouNa4aUyqrwbRSuA1O rgEaOKamoIAPcavwTnxkRV+oFfM1ysPlsSDXXpU8SkD3/ucxlj9cY4zjx76fQrKNPxPO k8cA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id j6-v6si259886wmh.2.2018.09.01.07.47.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Sep 2018 07:47:52 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w81Elq6B010783 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 1 Sep 2018 16:47:52 +0200 Received: from md1f2u6c.ad001.siemens.net ([139.22.35.9]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w81EloWd011101 for ; Sat, 1 Sep 2018 16:47:51 +0200 From: Jan Kiszka To: isar-users Subject: [PATCH 1/4] dpkg-base: Relocate dpkg_runbuild and adjust comments Date: Sat, 1 Sep 2018 16:47:47 +0200 Message-Id: <1b5e15c8e81573a268ee1dbfed346ad8ca56ff65.1535813270.git.jan.kiszka@siemens.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: References: In-Reply-To: References: X-TUID: x8mBoPoM3/qi From: Jan Kiszka This puts this placeholder in the context of its task definition and also improves the comments related to dpkg_runbuild as well as dpkg_prepare. No functional changes. Signed-off-by: Jan Kiszka --- meta/classes/dpkg-base.bbclass | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index 5826357..84c56af 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -50,13 +50,10 @@ PPS ?= "${@get_package_srcdir(d)}" BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" -# default to "emtpy" implementation for dpkg_prepare() and dpkg_runbuild() +# Empty do_prepare() implementation, to be overwritten if needed dpkg_prepare() { true } -dpkg_runbuild() { - die "This should never be called, overwrite it in your derived class" -} MOUNT_LOCKFILE = "${BUILDCHROOT_DIR}/mount.lock" @@ -89,6 +86,11 @@ do_prepare() { addtask prepare after do_patch before do_build do_prepare[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" +# Placeholder for actual dpkg_runbuild() implementation +dpkg_runbuild() { + die "This should never be called, overwrite it in your derived class" +} + do_build() { dpkg_do_mounts dpkg_runbuild -- 2.16.4