Re: [PATCH 7/7] linux-custom: rewrite to no longer depend on the kernel's builddeb

[Gylstorff Quirin <quirin.gylstorff@siemens.com>]

On 11/7/19 2:20 PM, Cedric Hombourger wrote:
> 
> On 11/7/19 12:44 PM, Gylstorff Quirin wrote:
>>
>>
>> On 11/5/19 2:57 PM, Cedric Hombourger wrote:
>>> -KV=$( make -s kernelrelease )
>>> -if [ "${KV}" != "${PV}" ]; then
>>> -    echo "ERROR: Recipe PV is \"${PV}\" but should be \"${KV}\"" 1>&2
>>> -    echo "ERROR: Probably due to CONFIG_LOCALVERSION" 1>&2
>>> -    exit 1
>>> -fi
>>> -
>>
>> Can we now use CONFIG_LOCALVERSION in a kernel configuration?
> 
> looks like I need to handle that.
> 
> do we want to maintain the current behavior and make sure that PV and 
> $(make -s kernelrelease) match or do we want to accept something like 
> (pseudo-code):
> 
> KR=$(make -s kernelrelease)
> if [ "${PV}" != "${KR}" -a "${PV}${CONFIG_LOCALVERSION}" != "${KR}" ]; then
>      echo "ERROR: Recipe PV (${PV}) does not seem to match the 
> kernelrelease (${KR})!" 1>&2
>      echo "ERROR: Make sure the kernel version in your PV setting and/or 
> CONFIG_LOCALVERSION are aligned" 1>&2
>      exit 1
> fi
> 

 From my understanding should it be allowed that the package version and
  the version differ.

What happens if we let the user set KR + CONFIG_LOCALVERSION as Version 
like Debian?

Example current 4.19 Kernel image:
	Package: linux-image-4.19.0-6-amd64
	Version: 4.19.67-2+deb10u1
	Built-Using: linux (= 4.19.67-2+deb10u1)
	Priority: optional
	Section: kernel


The original code was added to avoid confusion.

build-kernel.sh: Handle kernel configs with CONFIG_LOCALVERSION

Setting this option in your kernel config will result in filenames that
build-kernel.sh does not expect. To not introduce confusion between
recipe versions and debian package versions simply require the recipe to
have a PV matching "make kernelrelease".

Signed-off-by: Henning Schild <henning.schild@siemens.com>

Quirin