From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6755821036247187456 X-Received: by 2002:a1c:650b:: with SMTP id z11mr3510867wmb.149.1573141446185; Thu, 07 Nov 2019 07:44:06 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:9d8b:: with SMTP id p11ls2436060wre.7.gmail; Thu, 07 Nov 2019 07:44:05 -0800 (PST) X-Google-Smtp-Source: APXvYqw1wkecsbHmbZjPej0M3UIQ1KpL4Jdb4whcQAuGasoSEoAtNlgTUacucwEcMzdPA3LLymmm X-Received: by 2002:adf:f1c7:: with SMTP id z7mr3756641wro.355.1573141445721; Thu, 07 Nov 2019 07:44:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573141445; cv=none; d=google.com; s=arc-20160816; b=Y7WPzdV2rrjvHGLTv9l0eNnq99i8rAuZv4JYmap+xNRUkkbuUQIn7Psn/kgQjpgzOl fx8TYcdpIAJ7iJTSIjsJDpG/l/8yM78TWbLH/VMQsObJY2/mkQPNFTnEZ7OnlnlLlNDm MlKq/epg76XxeWy8QMKt5X8DVPxCFOmkIKmPigA4DDfoeU5knSILfJHGvZHAKITSH9+X z7N6ASQ5Rh0QPckt5sA5e/NlS2s0r6sCPWw5AHy8Y6AzLMkp9GARIRVGqdJtSCGeCxFg K258tEW0EjoGeACMMmdn7l9jg03bsrYKs9cippR0w+U7xi0uDOzr5hhQtEADhDHsbJ5D QhLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=ALzWeqd28Ryd7uzbyt87KZfP2u8eT71bIEJD2sF3oLQ=; b=L57CaJpbyQSoflqnKlH/s0CA9EZt1Vxh//rfB0sDIAhr+PtwDZSxfSb/fxssQoxTh8 Hk3PRLN6/NGBmX8y5Ds7Oh5OL4CxUsNWr4Z8eHVKmGU19UUProvMgrzhlEJY9aaKgzBU +ushREwejITR/wPNqy0ZtUoC/A7l8Tl2jOwFtfTXjACUtZy4xt5DjcjVYL1M++izDHfT lBv3RSYUxHP4+HN4MkUHJ6BdkiZOyJ5R6eBdX2giKo+9ywlOkboRbNvS6eSDlgEnubP4 omFfB/znqIG3iyz0KMiStmQCKs1OHGfILSSXif3Cz+cs849L9ms+0PTic/xcWNp5w9ZV UEYw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id y140si176747wmd.0.2019.11.07.07.44.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Nov 2019 07:44:05 -0800 (PST) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id xA7Fi56B029259 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Nov 2019 16:44:05 +0100 Received: from [139.25.69.120] ([139.25.69.120]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xA7Fi59t004020; Thu, 7 Nov 2019 16:44:05 +0100 Subject: Re: [PATCH 7/7] linux-custom: rewrite to no longer depend on the kernel's builddeb To: Cedric Hombourger , isar-users@googlegroups.com References: <1572962145-318-1-git-send-email-Cedric_Hombourger@mentor.com> <1572962258-367-1-git-send-email-Cedric_Hombourger@mentor.com> <1572962258-367-3-git-send-email-Cedric_Hombourger@mentor.com> From: Gylstorff Quirin Message-ID: <1b865e26-a199-0b10-d639-638df777d922@siemens.com> Date: Thu, 7 Nov 2019 16:43:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: Clj1ahonBKHJ On 11/7/19 2:20 PM, Cedric Hombourger wrote: > > On 11/7/19 12:44 PM, Gylstorff Quirin wrote: >> >> >> On 11/5/19 2:57 PM, Cedric Hombourger wrote: >>> -KV=$( make -s kernelrelease ) >>> -if [ "${KV}" != "${PV}" ]; then >>> -    echo "ERROR: Recipe PV is \"${PV}\" but should be \"${KV}\"" 1>&2 >>> -    echo "ERROR: Probably due to CONFIG_LOCALVERSION" 1>&2 >>> -    exit 1 >>> -fi >>> - >> >> Can we now use CONFIG_LOCALVERSION in a kernel configuration? > > looks like I need to handle that. > > do we want to maintain the current behavior and make sure that PV and > $(make -s kernelrelease) match or do we want to accept something like > (pseudo-code): > > KR=$(make -s kernelrelease) > if [ "${PV}" != "${KR}" -a "${PV}${CONFIG_LOCALVERSION}" != "${KR}" ]; then >     echo "ERROR: Recipe PV (${PV}) does not seem to match the > kernelrelease (${KR})!" 1>&2 >     echo "ERROR: Make sure the kernel version in your PV setting and/or > CONFIG_LOCALVERSION are aligned" 1>&2 >     exit 1 > fi > From my understanding should it be allowed that the package version and the version differ. What happens if we let the user set KR + CONFIG_LOCALVERSION as Version like Debian? Example current 4.19 Kernel image: Package: linux-image-4.19.0-6-amd64 Version: 4.19.67-2+deb10u1 Built-Using: linux (= 4.19.67-2+deb10u1) Priority: optional Section: kernel The original code was added to avoid confusion. build-kernel.sh: Handle kernel configs with CONFIG_LOCALVERSION Setting this option in your kernel config will result in filenames that build-kernel.sh does not expect. To not introduce confusion between recipe versions and debian package versions simply require the recipe to have a PV matching "make kernelrelease". Signed-off-by: Henning Schild Quirin