Re: [PATCH 2/7] dpkg-base: introduce an "apt-get source" fetch/unpack step

[Jan Kiszka <jan.kiszka@siemens.com>]

On 28.01.19 18:12, Hombourger, Cedric wrote:
> Hi Jan,
> 
> Henning did a good of rework to the changeset used in our local project tree, he deserves most of the credits :)
> 

OK. Then let's move a credit like "based on original patch(es) by ..." into the 
commit log but remove the bogus SOB.

Jan

> Cedric
> 
> -----Original Message-----
> From: Jan Kiszka [mailto:jan.kiszka@siemens.com]
> Sent: Monday, January 28, 2019 6:07 PM
> To: [ext] Henning Schild <henning.schild@siemens.com>; isar-users <isar-users@googlegroups.com>
> Cc: Hombourger, Cedric <Cedric_Hombourger@mentor.com>
> Subject: Re: [PATCH 2/7] dpkg-base: introduce an "apt-get source" fetch/unpack step
> 
> On 17.01.19 17:04, [ext] Henning Schild wrote:
>> From: Henning Schild <henning.schild@siemens.com>
>>
>> This creates a new task to fetch/unpack debian sources from debian
>> source mirrors. This is done using "apt-get source" and the new
>> variable APT_SRC to control the arguments.
>>
>> An example where a original debian package gets rebuild will follow in
>> a later commit.
>>
>> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> 
> How does Cedric SOB come in here, before your own? Is it his patch that should actually be credited by a proper "From:"?
> 
>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>> ---
>>    meta/classes/dpkg-base.bbclass | 19 +++++++++++++++++++
>>    1 file changed, 19 insertions(+)
>>
>> diff --git a/meta/classes/dpkg-base.bbclass
>> b/meta/classes/dpkg-base.bbclass index f1b127c..2f324f9 100644
>> --- a/meta/classes/dpkg-base.bbclass
>> +++ b/meta/classes/dpkg-base.bbclass
>> @@ -20,6 +20,25 @@ do_adjust_git[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>>    inherit patch
>>    addtask patch after do_adjust_git before do_build
>>    
>> +SRC_APT ?= ""
>> +
>> +do_apt_fetch[depends] = "buildchroot-target:do_build"
>> +
>> +do_apt_fetch() {
>> +	if [ -z "${@d.getVar("SRC_APT", True).strip()}" ]; then
>> +		exit
>> +	fi
>> +	dpkg_do_mounts
>> +	E="${@ bb.utils.export_proxies(d)}"
>> +	sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
>> +		sh -c 'cd ${PP} && apt-get -y source ${SRC_APT}'
>> +	dpkg_undo_mounts
>> +}
>> +
>> +addtask apt_fetch after do_unpack before do_patch
>> +do_apt_fetch[lockfiles] += "${REPO_ISAR_DIR}/isar.lock"
>> +do_apt_fetch[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>> +
>>    def get_package_srcdir(d):
>>        s = d.getVar("S", True)
>>        workdir = d.getVar("WORKDIR", True)
>>
> 
> Jan
> 
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux