From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647496723618856960 X-Received: by 2002:a1c:6584:: with SMTP id z126mr53342wmb.18.1548695622601; Mon, 28 Jan 2019 09:13:42 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:a9d1:: with SMTP id s200ls2012778wme.2.canary-gmail; Mon, 28 Jan 2019 09:13:42 -0800 (PST) X-Google-Smtp-Source: AHgI3IYkpqWrwyCQOJ2rHJottJmtYj3c1RAjbtIs5QhizzkdXp5BNpSK/FwN34GKSqH8YGKVceQZ X-Received: by 2002:a1c:23ca:: with SMTP id j193mr53436wmj.1.1548695621827; Mon, 28 Jan 2019 09:13:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548695621; cv=none; d=google.com; s=arc-20160816; b=xNUGKlOZPZPUX9kCtt5Z6gBJ5jXsmwj9Wz+eT10KUvXQEz/okAQrcpwQTnwh+UJA4f 4WszijFki6dmqszVcYfYgmiq23v7Z0J1fikFW6wAnalf4f3sP037YBxGSpFiDC5ENO6Z L4MFtF6O6Z16Krwd0sN6sWvvPUJ+H73k9dgA8/aweWbBA3XZyAmFLIyEFeV0lVLvzOT0 gZ0aUK8XMaqYC+UIp2EgIt2gB59c1xLuPLmb4t8sVbC8XpdVej6azephH6vKG2Tcr2tK cMHyqVYemwBVEWqGVzqsHMuT13unMXEpSqnL1O6WHrMgVCY1UY63zEQ+tOFWaOn9Rxe0 tpEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=Duqyvt9ZsPHY6+wao90iO63CwZNjJ52RYT6BFrYRjg8=; b=VWKP6nX0b03P8cJ3ShdNJhaxUmWX3bb6WJ5mUSzxZ1eB4yU++yUqiO+gyqXh0+ix4N tW9zUwBaJFKh7gfx0DGyy6Hpig1BRlmA41YFpo2qaGiyCBlCokwSgMNiRzrMShLjQq6z W1T9V/X6vp0/OIcG/1HnDZ9Zluf/TjC1qihulXV0nTX7RM70WC5n1wUWH602QqYgxL0L imFmjwBtnxjN3Vcch4tEJOXlWBvM59taedGG5j3Sw+M9iEuXgyslev04Fm4v3AkCiYFj iWha0iRrn+VeOrC6A8bSXUzL/SIxIKSIjWtD1jzPjHij6nvZGoa2pc0pDSdD58X/VRDQ LBtQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id s124si819wmf.0.2019.01.28.09.13.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 09:13:41 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x0SHDfJp029291 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Jan 2019 18:13:41 +0100 Received: from [139.22.44.10] ([139.22.44.10]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0SHDeiM010719; Mon, 28 Jan 2019 18:13:41 +0100 Subject: Re: [PATCH 2/7] dpkg-base: introduce an "apt-get source" fetch/unpack step To: "Hombourger, Cedric" , "[ext] Henning Schild" Cc: isar-users References: <20190117160427.26556-1-henning.schild@siemens.com> <20190117160427.26556-3-henning.schild@siemens.com> <378d7c32-23d8-a619-c0f9-eb4b746cc417@siemens.com> <7a0c801896344cbabf871b9fbeded3fd@svr-ies-mbx-02.mgc.mentorg.com> From: Jan Kiszka Message-ID: <1c16145f-52cc-2f9d-87ff-bd02eb681829@siemens.com> Date: Mon, 28 Jan 2019 18:13:40 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <7a0c801896344cbabf871b9fbeded3fd@svr-ies-mbx-02.mgc.mentorg.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: EhP4l+SZr3aD On 28.01.19 18:12, Hombourger, Cedric wrote: > Hi Jan, > > Henning did a good of rework to the changeset used in our local project tree, he deserves most of the credits :) > OK. Then let's move a credit like "based on original patch(es) by ..." into the commit log but remove the bogus SOB. Jan > Cedric > > -----Original Message----- > From: Jan Kiszka [mailto:jan.kiszka@siemens.com] > Sent: Monday, January 28, 2019 6:07 PM > To: [ext] Henning Schild ; isar-users > Cc: Hombourger, Cedric > Subject: Re: [PATCH 2/7] dpkg-base: introduce an "apt-get source" fetch/unpack step > > On 17.01.19 17:04, [ext] Henning Schild wrote: >> From: Henning Schild >> >> This creates a new task to fetch/unpack debian sources from debian >> source mirrors. This is done using "apt-get source" and the new >> variable APT_SRC to control the arguments. >> >> An example where a original debian package gets rebuild will follow in >> a later commit. >> >> Signed-off-by: Cedric Hombourger > > How does Cedric SOB come in here, before your own? Is it his patch that should actually be credited by a proper "From:"? > >> Signed-off-by: Henning Schild >> --- >> meta/classes/dpkg-base.bbclass | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/meta/classes/dpkg-base.bbclass >> b/meta/classes/dpkg-base.bbclass index f1b127c..2f324f9 100644 >> --- a/meta/classes/dpkg-base.bbclass >> +++ b/meta/classes/dpkg-base.bbclass >> @@ -20,6 +20,25 @@ do_adjust_git[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" >> inherit patch >> addtask patch after do_adjust_git before do_build >> >> +SRC_APT ?= "" >> + >> +do_apt_fetch[depends] = "buildchroot-target:do_build" >> + >> +do_apt_fetch() { >> + if [ -z "${@d.getVar("SRC_APT", True).strip()}" ]; then >> + exit >> + fi >> + dpkg_do_mounts >> + E="${@ bb.utils.export_proxies(d)}" >> + sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \ >> + sh -c 'cd ${PP} && apt-get -y source ${SRC_APT}' >> + dpkg_undo_mounts >> +} >> + >> +addtask apt_fetch after do_unpack before do_patch >> +do_apt_fetch[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" >> +do_apt_fetch[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" >> + >> def get_package_srcdir(d): >> s = d.getVar("S", True) >> workdir = d.getVar("WORKDIR", True) >> > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux