From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] claudius.heine.ext@siemens.com"
<claudius.heine.ext@siemens.com>,
isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: Re: [PATCH v2 1/2] meta-isar: allow all distro variables to be overwritten by local.conf
Date: Fri, 21 Jul 2017 10:39:02 +0200 [thread overview]
Message-ID: <1c5c85ef-176a-fd9d-16c8-2e0d6e121dfb@siemens.com> (raw)
In-Reply-To: <20170720081542.32733-2-claudius.heine.ext@siemens.com>
On 2017-07-20 10:15, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> Also removed '??=' because that not really necessary since the distro
> configuration is loaded after the local.conf anyway.
I suppose you based this on my "Allow overwriting of DISTRO_APT_SOURCE
via local.conf" patch, which I didn't send yet. Better base it on
master, then I can skip the submission.
Jan
>
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> meta-isar/conf/distro/debian-jessie.conf | 8 ++++----
> meta-isar/conf/distro/debian-stretch.conf | 8 ++++----
> meta-isar/conf/distro/raspbian-stable.conf | 8 ++++----
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/meta-isar/conf/distro/debian-jessie.conf b/meta-isar/conf/distro/debian-jessie.conf
> index 3aa8ee4..6a639e1 100644
> --- a/meta-isar/conf/distro/debian-jessie.conf
> +++ b/meta-isar/conf/distro/debian-jessie.conf
> @@ -3,7 +3,7 @@
> # This software is a part of ISAR.
> # Copyright (C) 2015-2016 ilbers GmbH
>
> -DISTRO_SUITE = "jessie"
> -DISTRO_COMPONENTS = "main contrib non-free"
> -DISTRO_APT_SOURCE ??= "http://httpredir.debian.org/debian"
> -DISTRO_CONFIG_SCRIPT = "debian-configscript.sh"
> +DISTRO_SUITE ?= "jessie"
> +DISTRO_COMPONENTS ?= "main contrib non-free"
> +DISTRO_APT_SOURCE ?= "http://deb.debian.org/debian"
> +DISTRO_CONFIG_SCRIPT ?= "debian-configscript.sh"
> diff --git a/meta-isar/conf/distro/debian-stretch.conf b/meta-isar/conf/distro/debian-stretch.conf
> index 00fea8a..aa1c89a 100644
> --- a/meta-isar/conf/distro/debian-stretch.conf
> +++ b/meta-isar/conf/distro/debian-stretch.conf
> @@ -3,7 +3,7 @@
> # This software is a part of ISAR.
> # Copyright (C) 2015-2016 ilbers GmbH
>
> -DISTRO_SUITE = "stretch"
> -DISTRO_COMPONENTS = "main contrib non-free"
> -DISTRO_APT_SOURCE ??= "http://ftp.debian.org/debian/"
> -DISTRO_CONFIG_SCRIPT = "debian-configscript.sh"
> +DISTRO_SUITE ?= "stretch"
> +DISTRO_COMPONENTS ?= "main contrib non-free"
> +DISTRO_APT_SOURCE ?= "http://deb.debian.org/debian"
> +DISTRO_CONFIG_SCRIPT ?= "debian-configscript.sh"
> diff --git a/meta-isar/conf/distro/raspbian-stable.conf b/meta-isar/conf/distro/raspbian-stable.conf
> index da8b37d..70066d5 100644
> --- a/meta-isar/conf/distro/raspbian-stable.conf
> +++ b/meta-isar/conf/distro/raspbian-stable.conf
> @@ -3,7 +3,7 @@
> # This software is a part of ISAR.
> # Copyright (C) 2015-2016 ilbers GmbH
>
> -DISTRO_SUITE = "stable"
> -DISTRO_COMPONENTS = "main contrib non-free firmware"
> -DISTRO_APT_SOURCE ??= "http://archive.raspbian.org/raspbian"
> -DISTRO_CONFIG_SCRIPT = "raspbian-configscript.sh"
> +DISTRO_SUITE ?= "jessie"
> +DISTRO_COMPONENTS ?= "main contrib non-free firmware"
> +DISTRO_APT_SOURCE ?= "http://archive.raspbian.org/raspbian"
> +DISTRO_CONFIG_SCRIPT ?= "raspbian-configscript.sh"
>
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-07-21 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 8:15 [PATCH v2 0/2] Allow for overwriting settings in local.conf claudius.heine.ext
2017-07-20 8:15 ` [PATCH v2 1/2] meta-isar: allow all distro variables to be overwritten by local.conf claudius.heine.ext
2017-07-21 8:39 ` Jan Kiszka [this message]
2017-07-21 9:07 ` Claudius Heine
2017-07-20 8:15 ` [PATCH v2 2/2] meta-isar/machine: replaced '=' with '+=' or '?=' to allow overwrite claudius.heine.ext
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c5c85ef-176a-fd9d-16c8-2e0d6e121dfb@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=ch@denx.de \
--cc=claudius.heine.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox