* [PATCH 0/1] Add support for Suite Component format sources
@ 2020-07-01 11:24 Felix Mößbauer
2020-07-01 11:24 ` [PATCH 1/1] Add support for apt sources which use an absolute Suite Component Felix Mößbauer
2020-07-01 11:27 ` [PATCH 0/1] Add support for Suite Component format sources Jan Kiszka
0 siblings, 2 replies; 9+ messages in thread
From: Felix Mößbauer @ 2020-07-01 11:24 UTC (permalink / raw)
To: isar-users; +Cc: Felix Mößbauer
This patch adds support to add apt sources in the format of
deb http://url / which is also known as absolute Suite Component format.
The current isar version fails on parsing this format.
A potential use case is to add packages from opensuse.
Felix Mößbauer (1):
Add support for apt sources which use an absolute Suite Component
meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] Add support for apt sources which use an absolute Suite Component
2020-07-01 11:24 [PATCH 0/1] Add support for Suite Component format sources Felix Mößbauer
@ 2020-07-01 11:24 ` Felix Mößbauer
2020-07-01 11:27 ` [PATCH 0/1] Add support for Suite Component format sources Jan Kiszka
1 sibling, 0 replies; 9+ messages in thread
From: Felix Mößbauer @ 2020-07-01 11:24 UTC (permalink / raw)
To: isar-users; +Cc: Felix Mößbauer
Signed-off-by: Felix Mößbauer <felix.moessbauer@siemens.com>
---
meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index da0d436..f530d7d 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -86,7 +86,10 @@ def parse_aptsources_list_line(source_list_line):
source, s = re.split("\s+", s, maxsplit=1)
- suite, s = re.split("\s+", s, maxsplit=1)
+ if s.startswith("/"):
+ suite = ""
+ else:
+ suite, s = re.split("\s+", s, maxsplit=1)
components = " ".join(s.split())
--
2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/1] Add support for Suite Component format sources
2020-07-01 11:24 [PATCH 0/1] Add support for Suite Component format sources Felix Mößbauer
2020-07-01 11:24 ` [PATCH 1/1] Add support for apt sources which use an absolute Suite Component Felix Mößbauer
@ 2020-07-01 11:27 ` Jan Kiszka
2020-07-01 12:19 ` [PATCH v2 " Felix Moessbauer
2020-07-01 12:19 ` [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component Felix Moessbauer
1 sibling, 2 replies; 9+ messages in thread
From: Jan Kiszka @ 2020-07-01 11:27 UTC (permalink / raw)
To: [ext] Felix M????bauer, isar-users
Hi Felix,
first posting already made it.
Note that your name in the sender field is mangled, at least for me.
It's encoding fine in the patch (and below), though.
On 01.07.20 13:24, [ext] Felix M????bauer wrote:
> This patch adds support to add apt sources in the format of
> deb http://url / which is also known as absolute Suite Component format.
> The current isar version fails on parsing this format.
>
> A potential use case is to add packages from opensuse.
>
This belongs into the commit, not the coverletter.
Jan
> Felix Mößbauer (1):
> Add support for apt sources which use an absolute Suite Component
>
> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 0/1] Add support for Suite Component format sources
2020-07-01 11:27 ` [PATCH 0/1] Add support for Suite Component format sources Jan Kiszka
@ 2020-07-01 12:19 ` Felix Moessbauer
2020-07-01 12:19 ` [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component Felix Moessbauer
1 sibling, 0 replies; 9+ messages in thread
From: Felix Moessbauer @ 2020-07-01 12:19 UTC (permalink / raw)
To: isar-users; +Cc: Felix Moessbauer
Hi Jan,
thanks for your comments, these are addressed in v2.
changes since v1:
- move cover letter statements into commit message
Felix Mößbauer (1):
Add support for apt sources which use an absolute Suite Component
meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component
2020-07-01 11:27 ` [PATCH 0/1] Add support for Suite Component format sources Jan Kiszka
2020-07-01 12:19 ` [PATCH v2 " Felix Moessbauer
@ 2020-07-01 12:19 ` Felix Moessbauer
2020-07-27 9:22 ` Moessbauer, Felix
` (2 more replies)
1 sibling, 3 replies; 9+ messages in thread
From: Felix Moessbauer @ 2020-07-01 12:19 UTC (permalink / raw)
To: isar-users; +Cc: Felix Mößbauer
From: Felix Mößbauer <felix.moessbauer@siemens.com>
This patch adds support to add apt sources in the format of
deb http://url / which is also known as absolute Suite Component format.
The current isar version fails on parsing this format.
A potential use case is to add packages from opensuse.
Signed-off-by: Felix Mößbauer <felix.moessbauer@siemens.com>
---
meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index da0d436..f530d7d 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -86,7 +86,10 @@ def parse_aptsources_list_line(source_list_line):
source, s = re.split("\s+", s, maxsplit=1)
- suite, s = re.split("\s+", s, maxsplit=1)
+ if s.startswith("/"):
+ suite = ""
+ else:
+ suite, s = re.split("\s+", s, maxsplit=1)
components = " ".join(s.split())
--
2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component
2020-07-01 12:19 ` [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component Felix Moessbauer
@ 2020-07-27 9:22 ` Moessbauer, Felix
2020-07-27 9:42 ` Jan Kiszka
2020-10-13 10:24 ` Jan Kiszka
2020-11-18 19:17 ` Baurzhan Ismagulov
2 siblings, 1 reply; 9+ messages in thread
From: Moessbauer, Felix @ 2020-07-27 9:22 UTC (permalink / raw)
To: jan.kiszka, isar-users
Hi,
What's the status of this patch?
Are there any open points / reviews before it can be merged?
Best regards,
Felix
> -----Original Message-----
> From: Felix Moessbauer <felix.moessbauer@siemens.com>
> Sent: Wednesday, July 1, 2020 2:20 PM
> To: isar-users@googlegroups.com
> Cc: Moessbauer, Felix (CT RDA IOT SES-DE) <felix.moessbauer@siemens.com>
> Subject: [PATCH v2 1/1] Add support for apt sources which use an absolute Suite
> Component
>
> From: Felix Mößbauer <felix.moessbauer@siemens.com>
>
> This patch adds support to add apt sources in the format of deb http://url /
> which is also known as absolute Suite Component format.
> The current isar version fails on parsing this format.
>
> A potential use case is to add packages from opensuse.
>
> Signed-off-by: Felix Mößbauer <felix.moessbauer@siemens.com>
> ---
> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-
> core/isar-bootstrap/isar-bootstrap.inc
> index da0d436..f530d7d 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -86,7 +86,10 @@ def parse_aptsources_list_line(source_list_line):
>
> source, s = re.split("\s+", s, maxsplit=1)
>
> - suite, s = re.split("\s+", s, maxsplit=1)
> + if s.startswith("/"):
> + suite = ""
> + else:
> + suite, s = re.split("\s+", s, maxsplit=1)
>
> components = " ".join(s.split())
>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component
2020-07-27 9:22 ` Moessbauer, Felix
@ 2020-07-27 9:42 ` Jan Kiszka
0 siblings, 0 replies; 9+ messages in thread
From: Jan Kiszka @ 2020-07-27 9:42 UTC (permalink / raw)
To: Moessbauer, Felix (CT RDA IOT SES-DE), isar-users
On 27.07.20 11:22, Moessbauer, Felix (CT RDA IOT SES-DE) wrote:
> Hi,
>
> What's the status of this patch?
> Are there any open points / reviews before it can be merged?
>
It's fine from my POV. I suppose our maintainer is on vacation.
Jan
> Best regards,
> Felix
>
>> -----Original Message-----
>> From: Felix Moessbauer <felix.moessbauer@siemens.com>
>> Sent: Wednesday, July 1, 2020 2:20 PM
>> To: isar-users@googlegroups.com
>> Cc: Moessbauer, Felix (CT RDA IOT SES-DE) <felix.moessbauer@siemens.com>
>> Subject: [PATCH v2 1/1] Add support for apt sources which use an absolute Suite
>> Component
>>
>> From: Felix Mößbauer <felix.moessbauer@siemens.com>
>>
>> This patch adds support to add apt sources in the format of deb http://url /
>> which is also known as absolute Suite Component format.
>> The current isar version fails on parsing this format.
>>
>> A potential use case is to add packages from opensuse.
>>
>> Signed-off-by: Felix Mößbauer <felix.moessbauer@siemens.com>
>> ---
>> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-
>> core/isar-bootstrap/isar-bootstrap.inc
>> index da0d436..f530d7d 100644
>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
>> @@ -86,7 +86,10 @@ def parse_aptsources_list_line(source_list_line):
>>
>> source, s = re.split("\s+", s, maxsplit=1)
>>
>> - suite, s = re.split("\s+", s, maxsplit=1)
>> + if s.startswith("/"):
>> + suite = ""
>> + else:
>> + suite, s = re.split("\s+", s, maxsplit=1)
>>
>> components = " ".join(s.split())
>>
>> --
>> 2.20.1
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component
2020-07-01 12:19 ` [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component Felix Moessbauer
2020-07-27 9:22 ` Moessbauer, Felix
@ 2020-10-13 10:24 ` Jan Kiszka
2020-11-18 19:17 ` Baurzhan Ismagulov
2 siblings, 0 replies; 9+ messages in thread
From: Jan Kiszka @ 2020-10-13 10:24 UTC (permalink / raw)
To: Baurzhan Ismagulov; +Cc: [ext] Felix Moessbauer, isar-users
On 01.07.20 14:19, [ext] Felix Moessbauer wrote:
> From: Felix Mößbauer <felix.moessbauer@siemens.com>
>
> This patch adds support to add apt sources in the format of
> deb http://url / which is also known as absolute Suite Component format.
> The current isar version fails on parsing this format.
>
> A potential use case is to add packages from opensuse.
>
> Signed-off-by: Felix Mößbauer <felix.moessbauer@siemens.com>
> ---
> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index da0d436..f530d7d 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -86,7 +86,10 @@ def parse_aptsources_list_line(source_list_line):
>
> source, s = re.split("\s+", s, maxsplit=1)
>
> - suite, s = re.split("\s+", s, maxsplit=1)
> + if s.startswith("/"):
> + suite = ""
> + else:
> + suite, s = re.split("\s+", s, maxsplit=1)
>
> components = " ".join(s.split())
>
>
Another overdue patch.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component
2020-07-01 12:19 ` [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component Felix Moessbauer
2020-07-27 9:22 ` Moessbauer, Felix
2020-10-13 10:24 ` Jan Kiszka
@ 2020-11-18 19:17 ` Baurzhan Ismagulov
2 siblings, 0 replies; 9+ messages in thread
From: Baurzhan Ismagulov @ 2020-11-18 19:17 UTC (permalink / raw)
To: isar-users
On Wed, Jul 01, 2020 at 02:19:54PM +0200, Felix Moessbauer wrote:
> This patch adds support to add apt sources in the format of
> deb http://url / which is also known as absolute Suite Component format.
> The current isar version fails on parsing this format.
>
> A potential use case is to add packages from opensuse.
Applied to next, thanks.
With kind regards,
Baurzhan.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-11-18 19:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 11:24 [PATCH 0/1] Add support for Suite Component format sources Felix Mößbauer
2020-07-01 11:24 ` [PATCH 1/1] Add support for apt sources which use an absolute Suite Component Felix Mößbauer
2020-07-01 11:27 ` [PATCH 0/1] Add support for Suite Component format sources Jan Kiszka
2020-07-01 12:19 ` [PATCH v2 " Felix Moessbauer
2020-07-01 12:19 ` [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component Felix Moessbauer
2020-07-27 9:22 ` Moessbauer, Felix
2020-07-27 9:42 ` Jan Kiszka
2020-10-13 10:24 ` Jan Kiszka
2020-11-18 19:17 ` Baurzhan Ismagulov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox