public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: isar-users@googlegroups.com
Cc: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>,
	Christian Storm <christian.storm@siemens.com>,
	Claudius Heine <ch@denx.de>,
	Henning Schild <henning.schild@siemens.com>
Subject: [PATCH 2/6] meta: Move 'do_fetch' and 'do_unpack' to base-class
Date: Wed, 30 Aug 2017 21:03:53 +0200	[thread overview]
Message-ID: <1d3a315a8ac98ba02800168b6f8bc50d95a96bb4.1504119538.git.henning.schild@siemens.com> (raw)
In-Reply-To: <cover.1504119538.git.henning.schild@siemens.com>
In-Reply-To: <cover.1504119538.git.henning.schild@siemens.com>

Issues:
unpack and fetch can only be used if you inherit dpkg, they should be
available to others i.e. classes and images

Change:
Pull the code out of the dpdk-class and stick it into the base-class. It is the
same code, no changes to it.

Impact:
This patch does not change the behaviour of Isar. It addresses the
issue, preparing for future patches.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/base.bbclass | 36 ++++++++++++++++++++++++++++++++++++
 meta/classes/dpkg.bbclass | 35 -----------------------------------
 2 files changed, 36 insertions(+), 35 deletions(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 2179ba9..3cace37 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -58,6 +58,42 @@ python do_listtasks() {
 			sys.__stdout__.write("%s\n" % e)
 }
 
+do_fetch[dirs] = "${DL_DIR}"
+
+# Fetch package from the source link
+python do_fetch() {
+    src_uri = (d.getVar('SRC_URI', True) or "").split()
+    if len(src_uri) == 0:
+        return
+
+    try:
+        fetcher = bb.fetch2.Fetch(src_uri, d)
+        fetcher.download()
+    except bb.fetch2.BBFetchException as e:
+        raise bb.build.FuncFailed(e)
+}
+
+addtask fetch before do_build
+
+do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
+
+# Unpack package and put it into working directory
+python do_unpack() {
+    src_uri = (d.getVar('SRC_URI', True) or "").split()
+    if len(src_uri) == 0:
+        return
+
+    rootdir = d.getVar('WORKDIR', True)
+
+    try:
+        fetcher = bb.fetch2.Fetch(src_uri, d)
+        fetcher.unpack(rootdir)
+    except bb.fetch2.BBFetchException as e:
+        raise bb.build.FuncFailed(e)
+}
+
+addtask unpack after do_fetch before do_build
+
 addtask build
 do_build[dirs] = "${TOPDIR}"
 python base_do_build () {
diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 81e21ce..0b8c7c4 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -10,46 +10,11 @@ do_unpack[deptask] = "do_build"
 PP = "/home/builder/${PN}"
 BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
 
-do_fetch[dirs] = "${DL_DIR}"
-
-# Fetch package from the source link
-python do_fetch() {
-    src_uri = (d.getVar('SRC_URI', True) or "").split()
-    if len(src_uri) == 0:
-        return
-
-    try:
-        fetcher = bb.fetch2.Fetch(src_uri, d)
-        fetcher.download()
-    except bb.fetch2.BBFetchException as e:
-        raise bb.build.FuncFailed(e)
-}
-
-addtask fetch before do_build
-
 do_unpack[dirs] = "${BUILDROOT}"
-do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 S ?= "${BUILDROOT}"
 
 WORKDIR_task-unpack = "${BUILDROOT}"
 
-# Unpack package and put it into working directory
-python do_unpack() {
-    src_uri = (d.getVar('SRC_URI', True) or "").split()
-    if len(src_uri) == 0:
-        return
-
-    rootdir = d.getVar('WORKDIR', True)
-
-    try:
-        fetcher = bb.fetch2.Fetch(src_uri, d)
-        fetcher.unpack(rootdir)
-    except bb.fetch2.BBFetchException as e:
-        raise bb.build.FuncFailed(e)
-}
-
-addtask unpack after do_fetch before do_build
-
 do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 
 # Build package from sources using build script
-- 
2.13.5


  parent reply	other threads:[~2017-08-30 19:03 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 19:03 [PATCH 0/6] v3 of getting the custom debian package in Henning Schild
2017-08-30 19:03 ` [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out Henning Schild
2017-09-04 15:11   ` Alexander Smirnov
2017-09-04 16:47     ` Jan Kiszka
2017-09-05  7:05     ` Claudius Heine
2017-09-05  7:25       ` Alexander Smirnov
2017-09-05  7:37         ` Alexander Smirnov
2017-09-05  7:56           ` Claudius Heine
2017-09-08  8:30           ` Henning Schild
2017-09-08  8:44             ` Claudius Heine
2017-09-08  9:03               ` Henning Schild
2017-08-30 19:03 ` Henning Schild [this message]
2017-09-04 15:14   ` [PATCH 2/6] meta: Move 'do_fetch' and 'do_unpack' to base-class Alexander Smirnov
2017-09-04 16:03     ` Jan Kiszka
2017-09-04 16:10       ` Alexander Smirnov
2017-09-04 16:11         ` Jan Kiszka
2017-09-04 16:39           ` Alexander Smirnov
2017-09-04 16:45             ` Jan Kiszka
2017-08-30 19:03 ` [PATCH 3/6] meta/dpkg: rename to dpkg-debian and add comment Henning Schild
2017-08-31  8:23   ` Claudius Heine
2017-09-04 15:17   ` Alexander Smirnov
2017-09-04 16:05     ` Jan Kiszka
2017-08-30 19:03 ` [PATCH 4/6] meta/dpkg-debian: Make 'do_install' more generic, prepare for pulling out Henning Schild
2017-08-30 19:09   ` Henning Schild
2017-09-08  8:35     ` Henning Schild
2017-08-30 19:03 ` [PATCH 5/6] meta/dpkg: add dpkg-custom class Henning Schild
2017-08-31  8:38   ` Claudius Heine
2017-08-31  8:42     ` Jan Kiszka
2017-08-31  9:10       ` Claudius Heine
2017-08-31  9:32       ` Henning Schild
2017-08-31 12:14         ` Claudius Heine
2017-08-31 13:39           ` Henning Schild
2017-09-11  8:39       ` Alexander Smirnov
2017-08-31  8:53     ` Claudius Heine
2017-08-31 10:21       ` Henning Schild
2017-09-04 15:36   ` Alexander Smirnov
2017-09-04 16:08     ` Jan Kiszka
2017-09-04 16:30       ` Alexander Smirnov
2017-09-04 16:53         ` Jan Kiszka
2017-09-08  8:20         ` Henning Schild
2017-09-08  8:15     ` Henning Schild
2017-09-08  8:31       ` Alexander Smirnov
2017-09-08  8:42         ` Henning Schild
2017-09-08  8:50           ` Alexander Smirnov
2017-09-11  8:13     ` Claudius Heine
2017-09-11  8:19       ` Henning Schild
2017-09-11  9:12         ` Claudius Heine
2017-09-11  8:42       ` Claudius Heine
2017-08-30 19:03 ` [PATCH 6/6] recipes-app/example-custom: add example on how to use dpkg-custom Henning Schild
2017-09-04 15:40   ` Alexander Smirnov
2017-09-06  7:36     ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d3a315a8ac98ba02800168b6f8bc50d95a96bb4.1504119538.git.henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=alex.bluesman.smirnov@gmail.com \
    --cc=ch@denx.de \
    --cc=christian.storm@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox