[PATCH] linux-custom: use slightly faster make target

[PATCH] linux-custom: use slightly faster make target

[Henning Schild]

From: Henning Schild <henning.schild@siemens.com>

Skip building the source deb package, which is not used anyways.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/recipes-kernel/linux/files/build-kernel.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh b/meta/recipes-kernel/linux/files/build-kernel.sh
index dbd6162..ddc9d0c 100644
--- a/meta/recipes-kernel/linux/files/build-kernel.sh
+++ b/meta/recipes-kernel/linux/files/build-kernel.sh
@@ -46,7 +46,7 @@ if [ "${KV}" != "${PV}" ]; then
 fi
 
 rm -f .version
-KBUILD_DEBARCH=$target_arch make -j $(($(nproc) * 2)) deb-pkg
+KBUILD_DEBARCH=$target_arch make -j $(($(nproc) * 2)) bindeb-pkg
 
 rm -rf ${REPACK_DIR}
 mkdir -p ${REPACK_DIR}
-- 
2.19.2

Re: [PATCH] linux-custom: use slightly faster make target

[Jan Kiszka]

On 16.01.19 16:20, Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> Skip building the source deb package, which is not used anyways.

Aren't we building source packages with dpkg[-raw] as well? We may not exploit 
this feature systematically yet to create source repos, but we will for sure in 
the not so far future. So I see no reason to apply this patch now and then 
revert it later on again.

Jan

> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   meta/recipes-kernel/linux/files/build-kernel.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh b/meta/recipes-kernel/linux/files/build-kernel.sh
> index dbd6162..ddc9d0c 100644
> --- a/meta/recipes-kernel/linux/files/build-kernel.sh
> +++ b/meta/recipes-kernel/linux/files/build-kernel.sh
> @@ -46,7 +46,7 @@ if [ "${KV}" != "${PV}" ]; then
>   fi
>   
>   rm -f .version
> -KBUILD_DEBARCH=$target_arch make -j $(($(nproc) * 2)) deb-pkg
> +KBUILD_DEBARCH=$target_arch make -j $(($(nproc) * 2)) bindeb-pkg
>   
>   rm -rf ${REPACK_DIR}
>   mkdir -p ${REPACK_DIR}
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] linux-custom: use slightly faster make target

[Henning Schild]

Am Wed, 16 Jan 2019 20:14:42 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> On 16.01.19 16:20, Henning Schild wrote:
> > From: Henning Schild <henning.schild@siemens.com>
> > 
> > Skip building the source deb package, which is not used anyways.  
> 
> Aren't we building source packages with dpkg[-raw] as well? We may
> not exploit this feature systematically yet to create source repos,
> but we will for sure in the not so far future. So I see no reason to
> apply this patch now and then revert it later on again.

Not building the source packages would save a lot of time. But the
patch is indeed inconsistent since it should also disable building
source packages for the dpkg-buildpackage case.
If we ever gain support for source package repos, building source
packages should depend on that feature and be optional. So i would
actually send a v2 this disables source package builds for the other
flow as well.

Henning

> Jan
> 
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >   meta/recipes-kernel/linux/files/build-kernel.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh
> > b/meta/recipes-kernel/linux/files/build-kernel.sh index
> > dbd6162..ddc9d0c 100644 ---
> > a/meta/recipes-kernel/linux/files/build-kernel.sh +++
> > b/meta/recipes-kernel/linux/files/build-kernel.sh @@ -46,7 +46,7 @@
> > if [ "${KV}" != "${PV}" ]; then fi
> >   
> >   rm -f .version
> > -KBUILD_DEBARCH=$target_arch make -j $(($(nproc) * 2)) deb-pkg
> > +KBUILD_DEBARCH=$target_arch make -j $(($(nproc) * 2)) bindeb-pkg
> >   
> >   rm -rf ${REPACK_DIR}
> >   mkdir -p ${REPACK_DIR}
> >   
>