From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com, Wadim Klincov <wadim@klincov.com>,
Henning Schild <henning.schild@siemens.com>
Subject: Re: [PATCH] Add missing WicError import
Date: Wed, 16 Mar 2022 12:03:36 +0300 [thread overview]
Message-ID: <1df6f1fc-f36b-f008-84b2-55777b934cc2@ilbers.de> (raw)
In-Reply-To: <20220316092405.2044eb0f@md1za8fc.ad001.siemens.net>
16.03.2022 11:24, Henning Schild wrote:
> This is already done in all the plugins we have in tree. The file you
> are touching here is "what we need to fork", and we do not need that.
> Or does the import in the existing plugins also not work?
>
> In case you need that in your custom plugin, just include the import
> into your own plugin. Maybe you do not even need that "base" lib for
> your custom plugin. Since it is ... what we need to fork. Not what we
> might need for our own plugins.
>
> regards,
> Henning
I agree we should add this import of WicError in isarpluginbase.py
because it
is really used inside it.
Any script using isar_get_filenames() can not care about its internal
implementation and can not even use WicError. So the requirement of
importing
something not even used looks wrong in that case.
next prev parent reply other threads:[~2022-03-16 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 10:55 Wadim Klincov
2022-03-16 8:24 ` Henning Schild
2022-03-16 9:03 ` Anton Mikanovich [this message]
2022-03-16 10:12 ` Henning Schild
2022-03-16 9:12 ` Wadim Klincov
2022-03-16 11:13 ` Henning Schild
2022-03-17 9:00 ` Wadim Klincov
2022-03-21 15:02 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1df6f1fc-f36b-f008-84b2-55777b934cc2@ilbers.de \
--to=amikan@ilbers.de \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=wadim@klincov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox