From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7074908419729129472 X-Received: by 2002:adf:ce03:0:b0:1f0:62b9:3c7a with SMTP id p3-20020adfce03000000b001f062b93c7amr23163035wrn.102.1647421422695; Wed, 16 Mar 2022 02:03:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:47c6:0:b0:1ef:f983:3883 with SMTP id o6-20020a5d47c6000000b001eff9833883ls343315wrc.2.gmail; Wed, 16 Mar 2022 02:03:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWYb/XUtDNOHAX0TBdTy5XvXrQOYokEzX4sdi86HEC2GKa6zifYFF1aVu6dUA7grHfgpwV X-Received: by 2002:a5d:4887:0:b0:203:dde4:c770 with SMTP id g7-20020a5d4887000000b00203dde4c770mr2036754wrq.20.1647421421830; Wed, 16 Mar 2022 02:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647421421; cv=none; d=google.com; s=arc-20160816; b=yReQd6z6IcHUBtPelyK7OcxsYxiM2JToBJeLLjTTLq1DVpSypjNhyTKClS1CGy8ass NB7JkP1hioDSnuSZgf7tW+CxRI7JDoLEfVJzY1kbAoLmMwptlgTcrzD1xxdLclreOzUG bf4SYAI1K7JpYDcsPE5KBCkKr/LHBjeXti/TRn8JruXat4L/Tx+PJeYLyiWzemTaYpA8 9HcsDr7+ghBm7AywKkBWTEV2tTFC6zJLhj18ygMMV4/P7mv1FN2zF49cunskBqBtvNrt nTDOJr5/cMYJNExpupSVMKDdRNH9LK6L3ncv+XiRlRRW3tvErPfAtKwU40nXWASIncva UErw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id; bh=W2BLgN2+osDXKTWnhanzVicQ+y9Vh3WW6mMVkmqrFsk=; b=yBSGDkmGMN449TtVvsvIP4bIp3v7D4lTTLh/G+mztASL/d2pppmG1WYtSrrLW3NcGh 5BsBD7RCCOKeJypkrWVsODFBQo6Z1gJxSrudLFJVmbTI1Bh0FSy0vI6Qz+Gk3HwHuAEW 7cI/BrgW/790KP/N/6qaBAz0e8nbv+NlrsxivSe7hMeCkCCzhSa0ZruxuViejpp9Uiyk 6CDzxx6mzxMic/jUl4vqVM8GQ1rN2aO02n1IAPOyY7palFvnbmFbw/aLyi0Eg2Rhxvwj ktYDkBRn+WoPdN9N/DZB+n43DvgabCVjQQMwdnDP+fgVjTHP5qu/HuHOEue0VZ0yJVCM tz0A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id w15-20020a1cf60f000000b003497ca2a0f8si265158wmc.1.2022.03.16.02.03.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Mar 2022 02:03:41 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 22G93b6g022239 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Mar 2022 10:03:40 +0100 Message-ID: <1df6f1fc-f36b-f008-84b2-55777b934cc2@ilbers.de> Date: Wed, 16 Mar 2022 12:03:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Add missing WicError import Content-Language: en-US To: isar-users@googlegroups.com, Wadim Klincov , Henning Schild References: <20220314105543.100423-1-wadim@klincov.com> <20220316092405.2044eb0f@md1za8fc.ad001.siemens.net> From: Anton Mikanovich In-Reply-To: <20220316092405.2044eb0f@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: wfFkGTz6C7N1 16.03.2022 11:24, Henning Schild wrote: > This is already done in all the plugins we have in tree. The file you > are touching here is "what we need to fork", and we do not need that. > Or does the import in the existing plugins also not work? > > In case you need that in your custom plugin, just include the import > into your own plugin. Maybe you do not even need that "base" lib for > your custom plugin. Since it is ... what we need to fork. Not what we > might need for our own plugins. > > regards, > Henning I agree we should add this import of WicError in isarpluginbase.py because it is really used inside it. Any script using isar_get_filenames() can not care about its internal implementation and can not even use WicError. So the requirement of importing something not even used looks wrong in that case.