public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"Kiszka, Jan" <jan.kiszka@siemens.com>
Cc: "Heinisch, Alexander" <alexander.heinisch@siemens.com>
Subject: Re: [PATCH] kas: Allow to define custom snapshot date
Date: Mon, 7 Oct 2024 07:26:44 +0000	[thread overview]
Message-ID: <1e13ffea7a0132e5bb60592329f056d333b0d034.camel@siemens.com> (raw)
In-Reply-To: <010cb6be-1909-4113-86b8-22f9f2365c28@siemens.com>

On Fri, 2024-10-04 at 12:20 +0200, 'Jan Kiszka' via isar-users wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Currently very useful for building constantly broken riscv via sid.
> The
> default value is actually a known-to-work one, taken from isar-cip-
> core.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  kas/opt/Kconfig | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/kas/opt/Kconfig b/kas/opt/Kconfig
> index 65482e3a..de7700f5 100644
> --- a/kas/opt/Kconfig
> +++ b/kas/opt/Kconfig
> @@ -44,7 +44,25 @@ config USE_APT_SNAPSHOT
>         bool "Use the distros snapshot mirror"
>         depends on !MIRROR_DEBIAN && (DEBIAN_BUSTER ||
> DEBIAN_BULLSEYE || DEBIAN_BOOKWORM || DEBIAN_TRIXIE || DEBIAN_SID ||
> UBUNTU_FOCAL || UBUNTU_JAMMY)
>         help
> -               Use a snapshot mirror for the selected distribution.
> The date is defined by ISAR_APT_SNAPSHOT_TIMESTAMP.
> +               Use a snapshot mirror for the selected distribution.
> +
> +choice
> +       prompt "Snapshot date"
> +       depends on USE_APT_SNAPSHOT
> +       default APT_SNAPSHOT_GIT_DATE
> +
> +config APT_SNAPSHOT_GIT_DATE
> +       bool "Latest git commit"
> +
> +config APT_SNAPSHOT_CUSTOM_DATE
> +       bool "Custom date"

The term "date" might be misleading here, as the value is a unix
timestamp. IIRC Alexander wanted to send a similar patch to specify the
apt snaptshot date in the upstream format (e.g. 20240702T082400Z),
making it easier to read.

Either we rename that here to "Custom timestamp", or we wait for the
patch of Alexander and adapt accordingly.

Felix

> +
> +endchoice
> +
> +config ISAR_APT_SNAPSHOT_TIMESTAMP
> +       string "Custom snapshot date"
> +       depends on APT_SNAPSHOT_CUSTOM_DATE
> +       default "1707606000"
>  
>  config KAS_INCLUDE_APT_SNAPSHOT
>         string
> -- 
> 2.43.0
> 

-- 
Siemens AG, Technology
Linux Expert Center


-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/1e13ffea7a0132e5bb60592329f056d333b0d034.camel%40siemens.com.

  reply	other threads:[~2024-10-07  7:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 10:20 'Jan Kiszka' via isar-users
2024-10-07  7:26 ` 'MOESSBAUER, Felix' via isar-users [this message]
2024-10-07  9:57   ` 'Jan Kiszka' via isar-users
2024-10-07 10:57     ` 'Heinisch, Alexander' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e13ffea7a0132e5bb60592329f056d333b0d034.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=alexander.heinisch@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox