* [PATCH] meta/classes/dpkg-base: update the comment for devshell task
@ 2024-02-28 11:23 srinuvasan.a
2024-02-29 13:18 ` Uladzimir Bely
0 siblings, 1 reply; 2+ messages in thread
From: srinuvasan.a @ 2024-02-28 11:23 UTC (permalink / raw)
To: isar-users; +Cc: ubely, Srinuvasan A
From: Srinuvasan A <srinuvasan.a@siemens.com>
We observed some typo in the devshell task comments and moreover there
is no do_install_builddeps task after we migrated into SBUILD, hence
remove the comment.
Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
meta/classes/dpkg-base.bbclass | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index a8263046..a5ae8e07 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -349,7 +349,6 @@ python do_devshell_nodeps() {
bb.build.exec_func('do_devshell', d)
}
-# devshell may be placed after do_instell_builddeps in downstream classes.
# devshell_nodeps will always stay right after do_prepare_build.
addtask devshell_nodeps after do_local_isarapt do_prepare_build
do_devshell_nodeps[dirs] = "${DEVSHELL_STARTDIR}"
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] meta/classes/dpkg-base: update the comment for devshell task
2024-02-28 11:23 [PATCH] meta/classes/dpkg-base: update the comment for devshell task srinuvasan.a
@ 2024-02-29 13:18 ` Uladzimir Bely
0 siblings, 0 replies; 2+ messages in thread
From: Uladzimir Bely @ 2024-02-29 13:18 UTC (permalink / raw)
To: srinuvasan.a, isar-users
On Wed, 2024-02-28 at 16:53 +0530, srinuvasan.a@siemens.com wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> We observed some typo in the devshell task comments and moreover
> there
> is no do_install_builddeps task after we migrated into SBUILD, hence
> remove the comment.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
> meta/classes/dpkg-base.bbclass | 1 -
> 1 file changed, 1 deletion(-)
>
Applied to next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-29 13:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-28 11:23 [PATCH] meta/classes/dpkg-base: update the comment for devshell task srinuvasan.a
2024-02-29 13:18 ` Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox