From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6592507174472122368 X-Received: by 2002:a2e:7819:: with SMTP id t25-v6mr682122ljc.35.1535704917868; Fri, 31 Aug 2018 01:41:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9e03:: with SMTP id e3-v6ls1083385ljk.4.gmail; Fri, 31 Aug 2018 01:41:57 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbm5wu9zfg5NyhHf29aNlx/JlBU6BTa1Wcv8EzvF/26BE2hVPeeDQqIly4rBoJJZ/7HWIjK X-Received: by 2002:a2e:5d1c:: with SMTP id r28-v6mr702246ljb.0.1535704917275; Fri, 31 Aug 2018 01:41:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535704917; cv=none; d=google.com; s=arc-20160816; b=hE1OANC7WJnHNulghpRkQSLJmsDlGrxm3gyCN0ORyZ8eBUhUJVDElMipTWjhteHPr1 wdhHJJqFgAlPbGd0dlJFoxF6u3m8Fn9dBBbs58pp25fjCDHoRjaLQUQmTsd+od0h2qUw RSzSQUzFNAg0/Rw3zbUIbkhvh7gz1gk9iDwKYPm7AxI4+1c5DhPPgWP/JqZdpxS9G6XG er+dpW6qbcv6m/SStcph5VeycwS9ZDeTKnTXK8XS6+ynNtYOmqCD7wssQTMaYOgN7stC E2FU1wCCZMg6q8tWA/qILBfOND6QMfGlBMgGjye0DDzhxA2kaaaMVUtWEy+3u8JW++IX LDBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=pVHne7oH652i74znXGa9DF4pPeRPIE/1Q7EnH28PPg4=; b=ORzgremeejlJdKh0VNaI2s7kcx7pMcEa+T27YytmbN7vyTEBBpnkaUSQ9mAbNsDrbt ISHxqBKP1U7uA8AoPl+bpN8DBKbwsbNb0tdeIw/0nHjE9m6/0mcmND4lLAtgAQdp8IfT qkuxrPuIEYOVHtFGgQg2luPE8l5N5wpvknQJUPwVcYtl57lQUBhsiRH+63njRP52WjzD OFaurn+xxRFE42XFV6cHr0stDcdq8jEhLcsfKti7DqAulhf7BnX847vFqFxAhvU7eoJH GIaX9wX2caz1tGC5xzUCcIW2QSBYaAuR3QXXLjFKRtyVTlVU3RTon1fH7CIrB9AerhF9 zLlg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id i67-v6si86981lfb.3.2018.08.31.01.41.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Aug 2018 01:41:57 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w7V8ftjL022566 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Aug 2018 10:41:55 +0200 Received: from [139.22.120.205] ([139.22.120.205]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w7V8ft2p014739; Fri, 31 Aug 2018 10:41:55 +0200 Subject: Re: [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare To: chombourger@gmail.com, isar-users , Maksim Osipov References: <20180822154145.07d4a2ca@md1pvb1c.ad001.siemens.net> <1535264488-128-1-git-send-email-Cedric_Hombourger@mentor.com> <3681e5f1-6401-4453-980b-585049d14329@googlegroups.com> From: Jan Kiszka Message-ID: <1e560261-edee-203b-db74-4ed5d1a35541@siemens.com> Date: Fri, 31 Aug 2018 10:41:55 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <3681e5f1-6401-4453-980b-585049d14329@googlegroups.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: 0EXkwyW3O9J0 On 2018-08-31 10:33, chombourger@gmail.com wrote: > > > On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: > > Re-reading the patch with my new knowledge: > > On 2018-08-26 08:21, Cedric Hombourger wrote: > > diff --git a/meta/recipes-kernel/linux-module/module.inc > b/meta/recipes-kernel/linux-module/module.inc > > index 3075f44..3a3cab1 100644 > > --- a/meta/recipes-kernel/linux-module/module.inc > > +++ b/meta/recipes-kernel/linux-module/module.inc > > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" > > > >   inherit dpkg > > > > -dpkg_runbuild_prepend() { > > +do_prepare_prepend() { > > Shouldn't that be dpgk_prepare_append()? > > > Wouldn't it be too late? > I am afraid that debian/control wouldn't be complete and prevent > installation of build dependencies > Right, we need that for the installation... I was wondering, though, if it wouldn't be cleaner to hook additions to the inner handler. Anyway, all this is not mature yet: - debianization does not require locking, only the dependency installation does - I'm quite sure something is broken now with dpkg-raw, because there is no lock involved, but we can pull packages that way as well - we should cleanly name the steps, as you suggested, so that users know what to overwrite / append /prepend Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux