From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7221105623410147328 X-Received: by 2002:a50:d490:0:b0:504:9390:180f with SMTP id s16-20020a50d490000000b005049390180fmr665804edi.2.1681369357146; Thu, 13 Apr 2023 00:02:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:907:2d26:b0:94e:56b2:4aa2 with SMTP id gs38-20020a1709072d2600b0094e56b24aa2ls3563452ejc.9.-pod-prod-gmail; Thu, 13 Apr 2023 00:02:35 -0700 (PDT) X-Google-Smtp-Source: AKy350ZLZlDBNVLKxnIa2uC8Yv+xjzliR+jetGiWjNcBR3YrN/w2pn8vXcEfOVvl8DM37YF+ffis X-Received: by 2002:a17:907:7885:b0:93e:8791:7d8e with SMTP id ku5-20020a170907788500b0093e87917d8emr1461942ejc.2.1681369355589; Thu, 13 Apr 2023 00:02:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1681369355; cv=pass; d=google.com; s=arc-20160816; b=1LN5yT2iOWb/hYgcRy48Zd/Hi8zSfKWORMVS5lTGPFyuxoOwtTsNWTX+FLKdSoa70K EcoHsuHpeVEHLDGCdoWdSxZ56S2GTfXwEh99ZtJm3UFOxQA7OR3F2o3UJwhmn3WCHHX7 +jyZ/qd03mFqtyVap/h86Lor7IG/hOhStiXnUkeu5SFthZO/p/qeN2pPO3+oY7n8k4tM PgJR4iw/aIiirhF3jtIIg86+cld3ldYNDljHepzqmMR7IeUsrs9F1Ho97tXdE1osVPGU hWtIPrNq6O4Ry5wkZthOM9l3Scu+JPsyPJeTNmD/vhlu35YP2y2ECrlEVvfti+zXIHVl ABFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=sjnkASilfADdW9kWssEf01XNutwbYH1T8SpVjRqGDbU=; b=oNCmh7g2PGstb8RbT0IIMJIM9ol47s7t4sRwe35CoNiNIx2f8IkG0zB1SR1gBrLU7w QmfkEeIweV9ZFClytWcg75PMSXoW/0LciGUzoUTAw6X3EZ82ucZFT278Jv7DiOEMDK7o 6ad7ybU1hkJ1c6JuEXPQ+vYuC9xVWaQTJQKNEApB2jiQBmTwDih3f8VR7/Njqngcb6hD sweD177t7Ijc7ZPYf5cRsAv2Zr6kyjNbtC/QaGPuDHHlx9fqCz7tkI/EHsa10JL3UsS+ mSxFDkFJ009iWZ68CmnzymxP3wViQhoeuTDtcqoahrWx5ZYICY4OB1fceanKBR7Gj4vP Utyg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=shRCSNSv; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::620 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0620.outbound.protection.outlook.com. [2a01:111:f400:fe0e::620]) by gmr-mx.google.com with ESMTPS id ti11-20020a170907c20b00b0094e847b3512si43136ejc.0.2023.04.13.00.02.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Apr 2023 00:02:35 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::620 as permitted sender) client-ip=2a01:111:f400:fe0e::620; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=shRCSNSv; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::620 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MvWWuEIJDyxDk1GQr2FlWx7raKnZBbojPPS2ZJDd5fopuUe2ZGWx0VZxohTGYf59Lx4quAzfJU92hk7JkN3cZxDW7GSDricKc8FxZ1iQiaJMpqPE/8bhV5Y4Lyr+bdVhP61XZNv4SOxshYr9izx1hBvas+B8T9qu/Ls6hsZ5fYspQZetX9R6tx8TcbPKa/reolpaSYBUtlagT+kT5UbKcjZxZXigj5mV1ZwUe/xCN0wlaGf04ShXrhz9CmulsYgRETsvg8YGwaIRszscsRk9zBtWqOZcmjD+Y+xbEsQhnf5Vz2/1/t9fULi3rhG0sEnnIr6Dc2O798YVhbtPnpDzfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sjnkASilfADdW9kWssEf01XNutwbYH1T8SpVjRqGDbU=; b=juyfU5NXdJnqL8AWowVsJkOq1aBgNK47f2mQAvufVKyQE6f/tMPyWe3c8LqDa0miNhRAJicGcKtMHXF1ThQqiqrujhEQx46B06MzkR3xWpGbizyYqJSIYzmo3fR0OmFk6EmvqYwbpALJ0YSCjwT3FQmtNynO9SGw3ogajdrKkZ4fV4+4mE904TnFrpQtdIu5GnrkdLaxg6k3gPUxQgXdEczuHaw7OuqynKUmhYrECwPecPN90+dMCZLIFEIHaV7/RhXaXmN4NB48W/IwOuxOX43Q4mHcbwGQLjr6MC3DQo2e3yosIBU0zK9KqHGM6277XOy2EFCjvH+CycskyykWaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sjnkASilfADdW9kWssEf01XNutwbYH1T8SpVjRqGDbU=; b=shRCSNSvK8qxkmjExe+6IYc+510ej00N9JXOUAilv3Nei3OF/dcMv9UO4EIBNIf3tXNdbVmFIZLdmuZRNC5nl2K3sIQhLP/oSrD4YOWeHJ1dnvNgLqUqSM/j2gdym/yg3z+pP2G/PXMXsmAzmGlptuoDN1sSJ8PXsUmxf2WJmaX/omH4OPtulhCQRA6IQfHtGYZSAzM+AsqlS/q9nlsPVBuKMybvN8C8HrKvTIUk++HP9gZfAhsT84dKnYbwqfAlJpc+djF5zb66llpTsWDz0yy65B094ZA7qaHEG0Ok36ZYgHcFZ03XQb2Wx7iLXiqfjML0HkK5nSO3tjVSOb/OMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AM7PR10MB3670.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:136::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Thu, 13 Apr 2023 07:02:34 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::f5ab:5f59:3b47:fc2e]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::f5ab:5f59:3b47:fc2e%5]) with mapi id 15.20.6319.004; Thu, 13 Apr 2023 07:02:34 +0000 Message-ID: <1e8a8cb1-68e6-be14-0d42-13a8a5ff1dea@siemens.com> Date: Thu, 13 Apr 2023 09:02:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] meta/conf/bitbake.conf: enable SRCPV support for AUTOREV Content-Language: en-US To: Srinuvasan Arjunan , isar-users@googlegroups.com References: <20230412101721.682675-1-srinuvasan_a@mentor.com> From: Jan Kiszka In-Reply-To: <20230412101721.682675-1-srinuvasan_a@mentor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d5::6) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AM7PR10MB3670:EE_ X-MS-Office365-Filtering-Correlation-Id: 42b3d3a0-81b7-434a-a5e0-08db3bed0ea8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kueWVtR4XCl5yCICXf7OzPrKPf1cqgGnY95nWDowOEX+7DOBQWL6iACrL4y37IRkbHOycEVGdWQv9GpyKL9EXkjfp97lGz0+9H4xGmxHzPMuBPCOGSA6g1Q1Q/wiIcb6bywUDxidBTSu2bN+s66uI1SH//sBCFwR+4pWAhhXLe71+cMjIn/vUSmBBjOh6qZX8Dn4zfkO+YEGiRe6MgBKSEK6vcjH21gu+AI1Ec/IhBHCFAgb9KHjIAF6eT2kf2sqW6MwHLuRMdwljcIrzdRWoKq45QyLhJHQjvX3W/IeAQmwsL3FwU1szP7M+lKvx+6OCsREMZzbSchAfaRLSNNZLfOaSXZu2wv1LdMcji3zaQsZQa3vBq21lTz0VH83w179QAV8IZk7OHIk3opp4xAN6UKgYoLhVoNVgKXcNRLnNTIjVklu4UwcLSZhws71TbP/9bOcSRwwYUEOtdvbar5kuvBQV0wjjyUF4k1/EXgjOWpzXF1F9YSDyBFLDK3oc4ES9iKM9FK1wGFTeuev4PUdsiEH4FB9p4Xt1oAd33hbobIayOm02ZWBUgCfK9qQnMyjDSWAxMniN0/qnXkLHbtFPCMfw93ge+WJdhfJIQHd6+Wkm1NXPQzWb+SGZ0ghTpRb8Ir7hWs5/Xsz4N38U8Z2lw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(396003)(136003)(366004)(376002)(451199021)(186003)(31686004)(86362001)(2906002)(41300700001)(38100700002)(83380400001)(6486002)(6666004)(53546011)(6506007)(31696002)(26005)(6512007)(2616005)(478600001)(316002)(66556008)(66476007)(8676002)(8936002)(66946007)(36756003)(44832011)(5660300002)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlJjQ1hscVI5TGIzNk53VklOOExLbFI2M1RLY09IQUd5dW45d3FMbEtraDky?= =?utf-8?B?akRaZThvdXIxeE9FRHpiTHFtN2VXOU16cEZ1VCtJdHZteFpTZkhleTUvd0JD?= =?utf-8?B?MUYxZVB2ZktTK0llYzhEejlOMjhBWTFFWkNoZ3ZZQU1jd1p4cFJXRFhiQkFa?= =?utf-8?B?QWc3ODdsTHhKQVVnMEJHTDVjZ0JRalNneVNwS096MzI1SndMeFlyU3M2TURs?= =?utf-8?B?WFUzS3FLWWZzZWYxYXVyelpaK3NjcExPdlo4RlVoSG01VWUyVTl2S0hwWEpS?= =?utf-8?B?dVZkdk9Jd2Z1ZXZMb01kUm14cjR4ZGorbWZzR2JyWE9uM0VYMGFnVkZjZEdz?= =?utf-8?B?MVNzTE9UcFVkQlJUakptUllkL0JWZmZjVUtzT2tKM3BkeUlSYjJRNHo1NEl5?= =?utf-8?B?SzdhSWFGb2lOMDdqdWZoRlJYVVhZYk5ld3k4Y3ByWG8xNm1KWk11R1NGK2hj?= =?utf-8?B?c2xQazBBNVhvSVlMc1BKZ3RKODdkdEIxK0toVVJndCtyM3RVSm9Jc01aUUgr?= =?utf-8?B?cm1CZHJRTmk4Z1JMKzZ4c3FwTkt6eGRnSDlBODBwWjVDekR6V3A2ZEVhdjUw?= =?utf-8?B?MkRGL3QwT0NLaUxOTGFsMUsxRXgrOGJqS2s2Z0VEZmtCUE1PN0pMOXJtTVZp?= =?utf-8?B?WXJTbUhQSHZOMnRaRDZraENsaW0zZm5Ua1pYTWo0c3hTSkVTMFRXeFRCYm8w?= =?utf-8?B?QjJ2NVJOS1FGK2VHN3poSEsxTFRpTks1VVd3TEt2VFdlZTBLSzI0U01USWlr?= =?utf-8?B?Z1BRcUJVMGdEMXljbUlFV3Y1NWRsWDJ5cDhLczAxV01JSWRsNUVPU2dDTWRs?= =?utf-8?B?a0xGb1lXNC9IOE1FOGM4RU1NSlZTSVNySzBLS1l2RnpHekJGRUJvNEpvMnJl?= =?utf-8?B?SXRlUjY0SExPSEpGS2NNREpwZW55QXZyS2dKY1MzZ0JiZGpkTGN2TEc0WVZ3?= =?utf-8?B?am96blZpeGdFV1NnNUk4SzFKbm0yZWlyMngyU2xIYllNejdvWDcyaHowL0ZW?= =?utf-8?B?bFp2RzNPSUN6dW9SRzM0bEhuQTBWTVpXK2JPZ1VnSDV0UjlVcnNpYVFWSGd0?= =?utf-8?B?dEh2NEZYNHZtbm45ckVwR0QyTjlaSklyR3p6TmdyblBsN2pKYW9sd205aUVm?= =?utf-8?B?M0IwV0hGbCtCb011QlBWNlBvZ0s1eWJuOTRhRjZCTWVQMHNGRWxFWE0rU3hD?= =?utf-8?B?d2RXVVM0bS9TeWpheUJuRWZ0L1l5RnVHUlAwUUs1dFVUZzFCVFVEZ2F6OEFo?= =?utf-8?B?aEcxZ2RiNExMR2dxZzYxRlNzdG5XdzUvOGRLd3JCWkQrT2VtZWpjYTdxM0tr?= =?utf-8?B?TXY2bFJoVzRvUUZybXRrb29LRVl4TThRUFJPMmYzZlVYSkNneUMraWZoc0d6?= =?utf-8?B?OGtkMzJCZUtBLy8wM1FpeEJ1S2c3am51bm1xZndqY3laV1E2eldxMDFieDFQ?= =?utf-8?B?cVpQcGIwMlpFVmJMZE92eERJRklGcHJOdzdHR04xM1g4YVRieUxHZmMyeXpE?= =?utf-8?B?c21nMU1XMGJaU2hYTHlQZDNqaUc4elIvT3NkODFuSGgzY0lVOFdpM2NXNy83?= =?utf-8?B?VUFOcE04TGlvdS9JbTl0dndaRERxMHJmVm9hcWVIcFZobzZ5R0pZVjNoYVBr?= =?utf-8?B?MjhDR3JuYTJMbHpCekM4RHRmeVdPNUxmTmtHWGpZc2N6bm5NcnVYTU5VVXlN?= =?utf-8?B?UHBiWmR2N05ibUV3UmJpbWdrTnpRRE1BdzJmUWxETGJKM0RoaXozNXBvSkZn?= =?utf-8?B?cE9MOUU1NjZNcThodisyRVB5NzNrOW4ya0pSSFFUby92UGJMV1h4alduRHR6?= =?utf-8?B?Y0pvNFVzN3pOeDZuY3hwNTdiT1FVUzhBMVI4cDJkanprVlpXZUNGNDFqS1hL?= =?utf-8?B?cklZU2tzMGllL25aOEk0Ti8zMmx3YnhHU2FoM3VDK3hOZFI1aXlad1F6eG5E?= =?utf-8?B?eGo1eDdPN0NCUytERmQyQklJRVl1VGc2NllISjBIRmF4NHVFZEN4N0hXUEVD?= =?utf-8?B?aHBwNEFxTVREejNlN0RNa1RMQXVHVWJuQjg1QVJlOXczc2pSSkdlVXJXa25v?= =?utf-8?B?eDQ3cVBTN3ppTDJ0NmQ4cFpwQnpOK3R0MG03OFNOM3dOUjE2L01oL21VVlVE?= =?utf-8?Q?Rrf6enPfZDGHm7aE5JahWGqIk?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42b3d3a0-81b7-434a-a5e0-08db3bed0ea8 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 07:02:34.3508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TkmA9x/6wkodD2kuItxk2DEc1zg/o8i0qhrOjLhU8zacARY3D9DVpsg7NzSRDnuvd5CHkWfFdcN9gxjixRUWjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3670 X-TUID: 3ulsgLDDfnTh On 12.04.23 12:17, Srinuvasan Arjunan wrote: > From: Srinuvasan A > > One of our downstream project recipe uses `SRCREV = "${AUTOREV}"` to get > the latest changes always, but this not works after bitbake 2 migration, > it throws the below error. > > do_fetch: Fetcher failure: Recipe uses a floating tag/branch without a fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use SRCPV in PV for OE). > > Till now we don't have support for SRCPV in ISAR, hence add this support > as like OE. > > Signed-off-by: Srinuvasan A > --- > meta/classes/base.bbclass | 2 ++ > meta/conf/bitbake.conf | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > index 53550ae..cc2b195 100644 > --- a/meta/classes/base.bbclass > +++ b/meta/classes/base.bbclass > @@ -120,6 +120,8 @@ root_cleandirs() { > python() { > import re > > + d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}") > + This is likely not correct. OE upstream checks if there is any SCM in the SRC_URI entries and only then adds this. I've played with unconditionally adding SRCPV (though via bitbake.conf), and I got errors. Jan > for e in d.keys(): > flags = d.getVarFlags(e) > if flags and flags.get('task'): > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index f421050..124bf49 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -36,6 +36,10 @@ PR = "${@bb.parse.vars_from_file(d.getVar('FILE', False),d)[2] or 'r0'}" > PROVIDES = "" > S = "${WORKDIR}/${P}" > AUTOREV = "${@bb.fetch2.get_autorev(d)}" > +AUTOREV[vardepvalue] = "${SRCPV}" > +# Set Dynamically in base.bbclass > +# SRCPV = "${@bb.fetch2.get_srcrev(d)}" > +SRCPV[vardepvalue] = "${SRCPV}" > SRC_URI = "" > STAMPS_DIR ?= "${TMPDIR}/stamps" > STAMP = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}/${PV}-${PR}" -- Siemens AG, Technology Competence Center Embedded Linux