Re: [PATCH] fix: remove unsigned example module before including the signed one

[Jan Kiszka <jan.kiszka@siemens.com>]

On 25.05.23 11:56, 'MOESSBAUER, Felix' via isar-users wrote:
> On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote:
>> We need remove unsigned exmple module firstly, because signed and
>> unsigned
>> exmaple module will install example-module.ko to the same path, which
>> will
>> lead to dpkg error.
> 
> Please add the signed-off line to the commit message (git commit
> --signoff). For details, see https://wiki.linuxfoundation.org/dco
> 

And fix the "exm[a]ple" typos at this chance. ;)

Thanks,
Jan

> Felix
> 
>> ---
>>  meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> index 19a105e..ca76685 100644
>> --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye"
>>  
>>  # include public keys
>>  IMAGE_INSTALL += "sb-mok-public"
>> -# include signed example module
>> +# remove unsigned example module and include signed example module
>> +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" 
>>  IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}"
>>  
>>  # add MOK utilities to insert MOK into EFI
> 

-- 
Siemens AG, Technology
Competence Center Embedded Linux