Re: [PATCH 1/2] u-boot: Switch to use DEB_BUILD_PROFILES

[Jan Kiszka <jan.kiszka@siemens.com>]

On 18.02.22 13:00, vijai kumar wrote:
> On Fri, Feb 18, 2022 at 5:23 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>
>> On 16.02.22 19:01, Vijai Kumar K wrote:
>>> Use DEB_BUILD_PROFILES to select packages to build.
>>>
>>> This patch drops the U_BOOT_TOOLS_PACKAGE and U_BOOT_CONFIG_PACKAGE
>>> variables and uses DEB_BUILD_PROFILES to enable particular packages
>>> like u-boot-tools, u-boot-dev and u-boot-config.
>>>
>>> Also, provide backward compatibility with U_BOOT_*_PACKAGES
>>> variable and prompt a deprecation warning to user.
>>>
>>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
>>> ---
>>>  RECIPE-API-CHANGELOG.md                       | 14 ++++-
>>>  .../u-boot/files/debian/control.tmpl          | 13 +++++
>>>  meta/recipes-bsp/u-boot/files/debian/rules    |  9 +++-
>>>  meta/recipes-bsp/u-boot/u-boot-custom.inc     | 51 ++++++++++---------
>>>  4 files changed, 60 insertions(+), 27 deletions(-)
>>>
>>> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
>>> index cad15a8..c135bd0 100644
>>> --- a/RECIPE-API-CHANGELOG.md
>>> +++ b/RECIPE-API-CHANGELOG.md
>>> @@ -342,4 +342,16 @@ The bitbake variable defines the respective environment variable which is availa
>>>  When cross compiling, `cross` is added to the `DEB_BUILD_PROFILES` environment variable.
>>>  Please note, that manually exported versions of the variables are overwritten.
>>>
>>> -For a list of well-known Debian build profiles and common practices, we refer to Debian's BuildProfileSpec.
>>> \ No newline at end of file
>>> +For a list of well-known Debian build profiles and common practices, we refer to Debian's BuildProfileSpec.
>>> +
>>> +### Deprecate U_BOOT_TOOLS_PACKAGE and U_BOOT_CONFIG_PACKAGE
>>> +
>>> +Use DEB_BUILD_PROFILES instead of U_BOOT_TOOLS_PACKAGE and U_BOOT_CONFIG_PACKAGE
>>> +
>>> +U_BOOT_TOOLS_PACKAGE = "1" is achieved by DEB_BUILD_PROFILES += "tools"
>>> +U_BOOT_CONFIG_PACKAGE = "1" is achieved by DEB_BUILD_PROFILES += "config"
>>
>> This is actually not an equivalent interface: So far, we also had layers
>> setting U_BOOT_*_PACKAGE at distro or even layer-level. Now you need to
>> patch that into the respective U-Boot recipes because the variable is
>> shared with other recipes. We need to check if that actually addresse
>> all use cases.
> 
> Ah. Yes indeed.
> 
>>
>> Did you have a look at the usual suspects already, specifically
>> isar-cip-core? I'm even seeing the SWUpdate package doing things
>> differently there depending on the availability of U_BOOT_CONFIG_PACKAGE.
> 
> Let me have a look again into this and get back.
> 

What happened to this?

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux