From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7249602373157388288 X-Received: by 2002:a05:6512:10c9:b0:4f8:6bca:50d7 with SMTP id k9-20020a05651210c900b004f86bca50d7mr7387390lfg.13.1688381980872; Mon, 03 Jul 2023 03:59:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:5008:0:b0:4f9:5662:5ef9 with SMTP id e8-20020a195008000000b004f956625ef9ls710204lfb.0.-pod-prod-02-eu; Mon, 03 Jul 2023 03:59:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlE5uRJ/wqNBw+oNM0Y/7hqie4hEWh52koxwSN+ovi1MjXa7gXHgPID6OHNDOYgUKnzexbCJ X-Received: by 2002:a05:6512:2510:b0:4fb:74da:989a with SMTP id be16-20020a056512251000b004fb74da989amr6923670lfb.3.1688381978651; Mon, 03 Jul 2023 03:59:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1688381978; cv=pass; d=google.com; s=arc-20160816; b=Htg9vIlDHo9X0i2vjOZffVgA56tbmcQ+P/u5C/sg0eNysvfi+GJgXJYXP6iEJt16v2 IbGnnQjFNAixe4sWkK2pQb/ems03KsaHob8X+478kPdUC2uYCUlnUy8QbjRMiZqJ/Wuu +kUf+YFYH2BzwmG9x4bM+Utt/SYg4gkh98hRJOhPDs2oz9pL+nqNwdq41PMDLBUkY194 G7Mq7kRXOpTbuMd0GeGs81Tb3cw+2yirutDmUZx1/goNLCMJgLp2jMnMoIKJWVUted96 JQf0iNecPIxM+K4d9rv36zfSRTnyHiai0X2ilfji4tJQhM06fW2S1slQRhBTwvS658xQ YpDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=HPxpUBNrDH+ENrM6ONs662sA85tSPTS5m5aOsIbruxA=; fh=eewSXB7G1O5VETdv1TqYeqW6/GzVpZAcTeN5jHTG+Y8=; b=NE8InNbTIkVuylB1QZaRm+nYZsRHcjQIYeYnQ0RKAK8yQvyo1r92Eae/rXTysCDRc9 mYMyVRfhGOZVIEpv9V1b2bAvonQiJriic2ydG1npLD+99+NjYX9pBOqjffZFhnpnY0/r ETs2sxc50nxz6fLge3zr0jdwPodu6Og1qHc65xgXzl3RDnwJ6HQKymxW1/rSlG5wIgps TkUM9RHlYJq95h+B9udd/RqLfalTXSTqLfGZf0+0xrhI/aGZ/IaeKLytpnVntGgjLpiw WxVDgd+LIoFkxRM25GPigt0Mlx+iTz7gjckDUWITJbmJCZO/0R9I6losNNOz2kG+IDiM P23g== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="ocI8Gjj/"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::60b as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060b.outbound.protection.outlook.com. [2a01:111:f400:fe0e::60b]) by gmr-mx.google.com with ESMTPS id ay4-20020a05600c1e0400b003fb415dd573si1103085wmb.2.2023.07.03.03.59.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jul 2023 03:59:38 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::60b as permitted sender) client-ip=2a01:111:f400:fe0e::60b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="ocI8Gjj/"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::60b as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qy6/S4IST99gkI60hL+NCJJnBViEzoSHnBO5mraOOLfK8xor/OVBhsYf0FiZuCwOorhigSTYExmVPkdhCrd+nnOcxKFr5/s6s/xWsTV5GLwbfARedZc86lhXXlm9429uBQ6Pd646zqUw1IojJkLJEOVESj9bgc+VoI8Gu6hvJKyqgx5xrUFmN50m8ql3Xh5dP/davRHRSfn2eUAI7mtCsvUUzRR31AwcnKCGs/brNdOkrCkoW+AnIWUwWLnGyZpxq3X8et/oth9+ZjE3Wohjrh4qyvtXDfeeSby8n8/rEhEEWj8WTj+CXIFC2SQslch4H0eVAbIoljerx9rAWI9JXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HPxpUBNrDH+ENrM6ONs662sA85tSPTS5m5aOsIbruxA=; b=D9F21dc1XjbCEH6akPevFfNTuxxuKEclpM4BGmNJCDnBcGZBRAlmd6XUHsBXCZ+7LCfp7SwSKChyXdgFr0T+YxxTyw6RVGSIgRVa3ljB3yz5BlrCfpsGDS+ztEcS67k+dycbm/3279wIh6EPYdZCMwK5RMh9fP88XerO70uHFZirek2P2VGzhu7NxAb1teYLeQTJy1I6QNp7fjKcCIOMKmaND/lOzDfuX5RkhJXe/3S2Qh1sopDXx53335pnw9/WnQixymqKF7F9J0/CqhnFRS91x0ChbpmbWWD/scRA+iRlWPwCHepXqvqCf5nxOnrrifVMeZdj41mpxFMKAQ8/cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HPxpUBNrDH+ENrM6ONs662sA85tSPTS5m5aOsIbruxA=; b=ocI8Gjj/FPXiwbp00c2/NLUl+eMDG0l7nT2KkXSI2jTHqojsqp6GVQjVVePumAuK5/0lf0++a+0WPbRDVtnS+/0e5snCBKIqAQpcHvagVfdYQcWJzjR8BkqAtKzjWKDRUDEhsy/slkOWyniPnXGeeo8LZ92xNvQcm5v0FjiUTzgSsaS/rvwk9f8BPT9Yzao1Vr5OhCIjomaoiZVgFZ30DBgW9xHFgGsKwaKphnJzm1hnXPD3R3pNqqe+uJzCVCpRyW6KguMqKX+sup6RcuZReZAtl4T8AmCUAl3MeQdivd5hHxY6DFwTN0ved2Cel+C1jhSxZ0DljhMutcaNrnLpQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by PAWPR10MB7700.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:34f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 10:59:37 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::53c2:174a:8b13:ce94]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::53c2:174a:8b13:ce94%3]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 10:59:37 +0000 Message-ID: <1f9502ac-f331-66b6-f402-3afcd968ceb5@siemens.com> Date: Mon, 3 Jul 2023 12:59:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] classes/sdk.bbclass: remove additional "/" in new_target finding Content-Language: en-US To: Srinuvasan Arjunan , isar-users References: <20230628051920.2364466-1-srinuvasan_a@mentor.com> <095c5ab0-3c19-4247-970b-ea645540d5dfn@googlegroups.com> From: Jan Kiszka In-Reply-To: <095c5ab0-3c19-4247-970b-ea645540d5dfn@googlegroups.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CH2PR14CA0060.namprd14.prod.outlook.com (2603:10b6:610:56::40) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|PAWPR10MB7700:EE_ X-MS-Office365-Filtering-Correlation-Id: dd2b505d-dbdf-4633-c1ac-08db7bb497a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mi2LAxvQSYl8Vzw9tcH8KWY9JKkOZVT+QVNd6fFRiISDvSrWbNbw0kiUlrdBcdIPG4iItDRHhLHjjNmLoPkZRcpTMTRlss2LQp9ftpnxdwyvm/P+/rMNJI3erDE6g7EuEyzlZnkPlGUTRF+Uoxnyks85xuSaRDhUdMbok56thXQiW2yEcztWn3YXjdxBo0sLTNhXpmzb3NtYw/b/iaflLx9ijqFs63QHNO+Bwc7v/YMOpO8qX65Km1WAjhutjJxL0ujNehw/vZ3AExWMBBupxLbb6rK4c6U1J1rBbpi5IQAOdZTcOfPiqidgqJh4mds09KP0QaJ9S+wOb6JHe+uY7Qidwz8YpuGxhyD+DiDSSjdkmW6t4QOIvFU0yYEDvfmQYTs6u9gbHJJYU6YijfYUTisATw/1lVMm4zLbDP2yUeLtdUuIh3YjGRPC1xyfwGXhEWdOQmdsV5vH/6zRl3rxNgBfUUhmJAKZnPWL37AXwVRx3JPrtfD61AfNL1HNJPpMXtSn4LA7+F+KcIp3I9ds/rBRwnK2shcuM/PUvjiEGtOHsJTvXQ6b+cX/LFXAA2TPc6w6c565Wi+ewk4jT8s3o+rUnmOP75SKHKh7awkBvlUkFCjWhuTqyIWb4XfJNTjPUtI4HF48wJxoluY1ncb0yw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(136003)(366004)(376002)(451199021)(316002)(41300700001)(6486002)(6512007)(31686004)(83380400001)(53546011)(2616005)(26005)(6506007)(186003)(478600001)(6666004)(110136005)(82960400001)(38100700002)(44832011)(66476007)(66946007)(66556008)(5660300002)(31696002)(86362001)(8676002)(8936002)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1hlbS9FdEs4azEwYkpyVjAxcFNaUDlMcnRpeHhHbVNRUms0cEF5NW41ai9F?= =?utf-8?B?V1hUKzY2RkVYQS92c0pMYVQ5azc4VUdTV3gwSFdBczRuVERaRlFLOEp2cEhI?= =?utf-8?B?TFAyM214eXduUFU2bHRWTmhPZGllU2ZrdlMvREpwZVVrYmJmeWUyN1dMbnFz?= =?utf-8?B?aVowZnR5K2o0S2h0eFB6Ty9zb0R0M0lVbyt2Um4yNlAyKytldFdqQ1BwMDBK?= =?utf-8?B?a1RjNkplVmU1MG0zRkxmR0FEeTFGQkxJTnBEazhzMUtsd1VYZG9NOWEyTlUv?= =?utf-8?B?eVcxdnJvSGRPQ2JRbys5dWFTVUx1L2V0NG0wcG5HdEd1TFpHdTRtUmUzd2xZ?= =?utf-8?B?MGwxTzFiQkdoN3FYaVMxcnVzTG0rZFBGU3hUb2VrWE1OZ09DRVJPTUhwdWpZ?= =?utf-8?B?eHorZXVvNXYxT284c1hEMVoxN3ptV3U2ZVMxTXJucWNWNFAzcFhnRnlWc2du?= =?utf-8?B?Umc1SEU2ejJnelQwSHBDaDk2UW5jNEVLT0tnNEZ0VllGaVpjQ2FxUmZCMnEv?= =?utf-8?B?b1NnRFlHK25Ud1FiekE0SzNTVFluOUpmY1VMQzNXanZlcms0SW5sc3hySXdr?= =?utf-8?B?WmJvaDltdkhWQjE2ZlBiWGxub2dRK1J4eGpKcXF3WHpheGVqVlpFTzZza2Jp?= =?utf-8?B?ZjVNdkR2ci9XTktZdm9mMGtPYlNjMGZ1RkVHaW5PN01LemJFRTBHUWVnT1dZ?= =?utf-8?B?SThKTkhWcGowSTFLMmlsRkUrWDd2dlZVZWNkZ2tQekRQNkRPekpRWHA0VElI?= =?utf-8?B?UlppZ2Z2cHQ2ZGpCWmhpR3dOclRHOHVvMmI0OS9qWHVXaTJPb05qTWNDTFBa?= =?utf-8?B?QVZSMmMvS2w1S0ZvRGdZUEl2WnloVVZFa2VJbnFPczBxR0JrR1J2Q0YvMHo0?= =?utf-8?B?S1ZkYzZsVlNyNGdxaHBlRURaUkJiVUgzZ0lJT1NXRlgyQXl1OEJlbnJ6RTdV?= =?utf-8?B?U2dKWlVEa1phancxRDJKNUlCTFlWMk8rN0JyNUYrRDZUR21yTjRNVkVNWEFZ?= =?utf-8?B?Z3BnenBQdEd5ZFBpbnl3dlkyeXA3cVA3N2FMUWFIYW5kRGRQTEZMajhMR0hB?= =?utf-8?B?c3hLR1l0NTZlamZCUDdKejJmTzhZLzRvZ1VqT2NWcDRGRklkRWFoa2gvS0o4?= =?utf-8?B?cXZnVTlZc3doaEpwYzdKb2ZBRXorWlp6T0xxUFF4R00wbzg4L0dIL21HRCtB?= =?utf-8?B?VGwrbWNUK1NndVpXTkYvcEhLL2huTUI0MnY2NzFvbkhqTVdUbUNkeGRQVFB3?= =?utf-8?B?R0cxbzZIWGcyUlFSOVRWbkxCMzNBdERDNzIxenRCS3hWMk5Pb0RRMEppdmcv?= =?utf-8?B?NWwwa09COTRTeW9iTHZNVGVieldua2EzempKWHpZdGxUaERzbHlyWCs5K1ly?= =?utf-8?B?MnJuK1FlOHU3TkdBNzhFRTBMZFRIN3dRU2VSUzN1K2Q3cVBNN29DRWNuN2c5?= =?utf-8?B?VWYzc0JvSG04RUdteVd1VkZFcXcrRW96dG5VUXIzc0cyRVNqbE9OSW94L3o5?= =?utf-8?B?L29VN25JdHZhSER2OHgzY2RBU3hUL0FXR1hDTm5EeU5aQXlvSGVoQzNaSUNz?= =?utf-8?B?UHVvaUhmN1l1MzVHR25scFE4MEw5SkZhUzdrajFDUDVUYU9MUUF1LzhlWXI2?= =?utf-8?B?dGsxMDBOQ3U2bTdCb0cvNFFqc1BPL09mNkNFOU85V0U3QUpVRlV5eUg2bG5U?= =?utf-8?B?K3NkL3B3OXlFOTdvdU9odU9od1lHeW8vTHREaWh2bE95ODFxK0Fma2hTTlRZ?= =?utf-8?B?clhZNVVlK0ZTNkhKVlFnMnRKMzRZRnB2TFY0WENiRWd1cUh1QWhCd292VWk1?= =?utf-8?B?cE9VSWZEVTNkeTUrNWV2OWhrWU1GUXlMdG5PanZ4ZGpJUFZlK0RENDBxdDNp?= =?utf-8?B?Z0ptcy8yUC9tSVBvb0c2b0N3MWZiTGh3RytvOThJc1JxV3IwTFM2aUVPbjc3?= =?utf-8?B?d0t4S0dwRHMyeUhFT2RHMjJ6djBLSnMzUFVRTzI4eTdQNjlMSzlWTEVwRmFt?= =?utf-8?B?cUpSMFU0NlkyRHlRVWk4dHVKMFZobVlTNStDT0lKWjFXSy8vcFRCUVowSG9p?= =?utf-8?B?Y3E3WGhOK2tnTFpjcVpuZVdlL1hZeFBGclRCbk5YVzhRbjJrVW54cmRSdGhk?= =?utf-8?B?dHc5QXBmeVdId3BidGVzeTBCNm16U093N2s1ek5uck95R09Na0Roc2ErUTJ0?= =?utf-8?B?YWc9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd2b505d-dbdf-4633-c1ac-08db7bb497a5 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 10:59:37.3453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kH4OA60SjY6o9g2TvaLjemFCB1Omam/MoU3Vg9A5zKu0yl9Jylv4uhPE29/Tl/peit9MiGN5znRGrxaL6BX0iA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR10MB7700 X-TUID: FagaDXojOrr8 On 03.07.23 09:07, Srinuvasan Arjunan wrote: > > > On Wednesday, June 28, 2023 at 12:42:52 PM UTC+5:30 Jan Kiszka wrote: > > On 28.06.23 07:19, Srinuvasan Arjunan wrote: > > From: Srinuvasan A > > > > We observed that one additional / present in finding the new_target, > > here target already start with /, hence no need to append the > additional > > /. > > > > In functionality wise there is no change. > > > > Signed-off-by: Srinuvasan A > > --- > > meta/classes/sdk.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass > > index c6dc689..f14b447 100644 > > --- a/meta/classes/sdk.bbclass > > +++ b/meta/classes/sdk.bbclass > > @@ -100,7 +100,7 @@ sdkchroot_finalize() { > > > > if [ "${target#/}" != "${target}" ]; then > > basedir=$(dirname $link) > > - new_target=$(realpath --no-symlinks -m --relative-to=$basedir > ${ROOTFSDIR}/${target}) > > + new_target=$(realpath --no-symlinks -m --relative-to=$basedir > ${ROOTFSDIR}${target}) > > > > Can you guarantee that ROOTFSDIR comes with a trailing / in ALL case? > I'm skeptical about that. > > >   Actually ROOTFSDIR not contains / in all the cases, rather target > always start with /, hence the additional / is not needed. OK, we are under if [ "${target#/}" != "${target}" ]; then thus only enter this branch if target has a leading /. Maybe worth to leave a comment behind in the code nevertheless. Jan -- Siemens AG, Technology Competence Center Embedded Linux