From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6924962081797046272 X-Received: by 2002:adf:8547:: with SMTP id 65mr22614891wrh.269.1614692264999; Tue, 02 Mar 2021 05:37:44 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:6a89:: with SMTP id s9ls15657119wru.2.gmail; Tue, 02 Mar 2021 05:37:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhZ5de/y8MAzGmnzwPREQDQ70cFnYq1jGsEKW1Mu2gTbmOKGLUeTyIlMiPH3nShZaAJ/Of X-Received: by 2002:adf:cd8c:: with SMTP id q12mr21676753wrj.185.1614692264135; Tue, 02 Mar 2021 05:37:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614692264; cv=none; d=google.com; s=arc-20160816; b=HbeJcrO4xffzKwHsBpGEnoR+bf6HHpZI7HVxZRswLCxjm+JQeo8D+hOKF7/TFuXMLD msz+weD2hV4Sdnfi3QPINyueAAPtplZzM+fzuTb8nkIcUuGTfPTFkjIgczesk40/mGbU uGHzjmhW9td6WQKTpVWVB/jweUY9VVsTbpg38pGdJF3RpWgfqVBaDDTUOsn9MNz8JYDu 3pZBLej335YPwm7cCjeQVwv/OJJGnek+aqeYjkr6Y2Cj1AM6h77E4jpmoWyS4wODQZVv TFI8PTjF3M4NDk74cWRgCR7jLbiLw8AtjrEW4itWlEiWRxhGi0tovsWqluFsx9jdoMNJ 55/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=oz304u42hCfxW9ttdJV30gyQ6QldForBwrGPsNcDwcU=; b=FzxCzQl4EtxRBVr5U9rWKFFmIDorXNY0iyxR1u0AwV37jPtGT7a+Q4tJzbHSRVgqry m9hV1IJR5Rdzn/kvXLe3zJhi1kVHNB91mmgs9g7T9jCjcw/1c/pPjhIep1IDHQnACCoV QN9RTj84jL50VLTvUqSWgPYEDFwKqaWpMfRlG3fj0B1jnL989Uf5wk7MO03tT4s3im5d b9h/xBIj6x80oiL6vYpHsBwrAw/nuvVOgu3j4dxQ/fuEjrHJDnmEq3ftKoKC6JvtI2Gg gOz2dNbWLl8v7/Alt5Jz7pr49esBOKvMtADaXE4JHkHRSEvqQXXliKeAcBLJHk45ZYuX NO8g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id v16si186146wmh.1.2021.03.02.05.37.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Mar 2021 05:37:44 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-205-79-121-178.mgts.dynamic.pppoe.byfly.by [178.121.79.205] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 122Dbgtb001278 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 Mar 2021 14:37:43 +0100 Subject: Re: [PATCH] meta/conf/distro: Fix filling of DISTRO_APT_SOURCES with default sources To: "florian.bezdeka@siemens.com" , "isar-users@googlegroups.com" , "jan.kiszka@siemens.com" Cc: "Vijaikumar_Kanagarajan@mentor.com" References: <20210203090927.97067-1-florian.bezdeka@siemens.com> <0cfe236a6b40bef79206b78b3451f96fd031e3bc.camel@siemens.com> From: Anton Mikanovich Message-ID: <1ffdb0ac-162e-6162-79e7-b9d2eed34aab@ilbers.de> Date: Tue, 2 Mar 2021 16:37:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0cfe236a6b40bef79206b78b3451f96fd031e3bc.camel@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: TudOK0rIKLzZ 04.02.2021 11:57, florian.bezdeka@siemens.com wrote: > On Wed, 2021-02-03 at 10:43 +0100, Jan Kiszka wrote: > > This isn't correct. DISTRO_APT_SOURCES points to the target distro, > HOST_DISTRO_APT_SOURCES to the host distro. > >> On 03.02.21 10:09, Bezdeka, Florian (T RDA IOT SES-DE) wrote: >>> From: Florian Bezdeka >>> >>> The following (quite minimal) distribution inheritance did not work: >>> >>> own-distro.conf: >>> require conf/distro/debian-buster.conf >>> >>> Build result (error): >>> E: option suite may not be empty >>> >>> The reason for the build failure was that own-distro did not have any APT >>> sources configured. This was broken with f3b4f74a869a. ${DISTRO} is set >>> to "own-distro" in this case and the apt source file (${DISTRO}.list) >>> might not exist. >>> >>> Fixes: f3b4f74a869a ("meta/conf/distro: Cleanup DISTRO_APT_SOURCES") >>> Signed-off-by: Florian Bezdeka >>> --- >>>  meta/conf/distro/debian-common.conf | 2 +- >>>  1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf >>> index cb7f8ed..aa32b24 100644 >>> --- a/meta/conf/distro/debian-common.conf >>> +++ b/meta/conf/distro/debian-common.conf >>> @@ -6,7 +6,7 @@ >>>  BASE_DISTRO = "debian" >>> >>>  HOST_DISTRO_APT_SOURCES ?= "conf/distro/${HOST_DISTRO}.list" >>> -DISTRO_APT_SOURCES ?= "conf/distro/${DISTRO}.list" >>> +DISTRO_APT_SOURCES ?= "conf/distro/${HOST_DISTRO}.list" >>> > I see... That's truly not correct. > >> If we want to ease defining deviating distros under own names that can >> easily include debian-xxx.conf, we need to revert that cleanup commit, >> hard-coding the association between distro conf an chosen list files again. >> > +1 for a revert from my side. Added Vijai to CC (author of the cleanup > commit). Maybe we get some more comments. > >> Jan >> >>>  WIC_IMAGER_INSTALL = "parted \ >>>                        gdisk \ >>> -- >>> 2.29.2 >>> >> I've just proposed revert+fix here: https://groups.google.com/g/isar-users/c/Mf1QQuAQ9V4/m/VVXDYt29BgAJ Please, review. -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov