Re: [PATCH 13/16] meta: classes: move install_package to isar-base

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 1 Aug 2017 16:00:03 +0200
schrieb Claudius Heine <claudius.heine.ext@siemens.com>:

> On 08/01/2017 12:17 PM, [ext] Henning Schild wrote:
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >   meta/classes/dpkg.bbclass      |  9 ---------
> >   meta/classes/isar-base.bbclass | 10 ++++++++++
> >   2 files changed, 10 insertions(+), 9 deletions(-)
> > 
> > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > index 2a1b85c..37b2c8d 100644
> > --- a/meta/classes/dpkg.bbclass
> > +++ b/meta/classes/dpkg.bbclass
> > @@ -20,12 +20,3 @@ do_compile() {
> >   
> >   addtask compile after do_unpack before do_install_package
> >   do_compile[stamp-extra-info] = "${DISTRO}"
> > -
> > -# Install package to dedicated deploy directory
> > -do_install_package() {
> > -    install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/
> > -}
> > -
> > -addtask install_package after do_compile before do_build
> > -do_install_package[dirs] = "${DEPLOY_DIR_DEB}"
> > -do_install_package[stamp-extra-info] = "${MACHINE}"
> > diff --git a/meta/classes/isar-base.bbclass
> > b/meta/classes/isar-base.bbclass index 3df6572..68e2aed 100644
> > --- a/meta/classes/isar-base.bbclass
> > +++ b/meta/classes/isar-base.bbclass
> > @@ -32,3 +32,13 @@ python do_unpack() {
> >   addtask unpack after do_fetch before do_build
> >   do_unpack[dirs] = "${WORKDIR}"
> >   do_unpack[stamp-extra-info] = "${DISTRO}"
> > +
> > +
> > +# Install package to dedicated deploy directory
> > +do_install_package() {
> > +    install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/  
> 
> Since I like to use the fetcher tasks for a image recipe, I inherit
> from this class, but the image recipe does not have any 'deb' files,
> so building failes here.
> 
> So it might be more modular if this task moves into an own class.

Sure, makes sense. I just started looking into the image side of isar.
Will be addressed in a V2.

Henning

> > +}
> > +
> > +addtask install_package before do_build
> > +do_install_package[dirs] = "${DEPLOY_DIR_DEB}"
> > +do_install_package[stamp-extra-info] = "${MACHINE}"
> >