From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247988281769984 X-Received: by 10.46.0.215 with SMTP id e84mr2373199lji.36.1501599572270; Tue, 01 Aug 2017 07:59:32 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.141.10 with SMTP id p10ls270668lfd.31.gmail; Tue, 01 Aug 2017 07:59:31 -0700 (PDT) X-Received: by 10.25.233.88 with SMTP id g85mr1842999lfh.38.1501599571892; Tue, 01 Aug 2017 07:59:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501599571; cv=none; d=google.com; s=arc-20160816; b=Q48EEn32wK9kBpU6iEWUUAx8ba5RWIVWDl5qtgPAI+mNkm/RYFb8AW9THREZfXm/VQ GpyeZFygBYmVURTLBzRX4KXGUuM+IuCLWSAadBBMArzIokgya9VavXGOpF18OiqfB9lz cAFCZtuRiaKddIBqkxYtvenYNCNqlPl5PPyQuplla2w75tt8G8rxdUCOqxMJ2Wy0Yqza X0+TEwYhltF/vCyfwHXs1qGu2WylDEGkazlIr5hGdblM7VIKIch57+Lk9rWYSzUWoewI 9bU6QetrHP4sKbg9SPODE5SQbZlEDPb/BxZRtq5HAKqpTiS8tY28PI/eInw0zfaA8Qyq 9Gpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=QLTunC2AO5ZK8dr8yuJ9uDSE1wAIl1uthVS/KVUNQX0=; b=OLuo15p2PYEqLmfspfPTGpA8lPnr2JzajJOGbuyohq54/BoGOTOUTl0AwmFkSSOdNT bkigCUnh1ZtPHzUpCQbx1gMkcWBaacKz5oar91QTHVnmPi1YGZkVsusCq3ElwdFGhprF nYdsn/fSF0khO66dt+G0MualN/Ga6eNwr1E7cxBkqny0fxqxCE2zKXs2p55Faiqsai+b A/W0KaHQFEbH6W33pDmlMlXtOrvi/gqx34eZp/Hz08/u6RHrWtNckeNUjivyS2KAFxQu b/wm1YPAcUmfGcJl4vU7Ptwmxsfsl0Hgpaq1BKD2rcq7F0A6NZuYvLAsSgCLjA608TaN c98w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id f3si441826wme.4.2017.08.01.07.59.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 07:59:31 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v71ExVcQ006937 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 1 Aug 2017 16:59:31 +0200 Received: from md1em3qc ([139.25.68.40]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id v71ExVq5001189; Tue, 1 Aug 2017 16:59:31 +0200 Date: Tue, 1 Aug 2017 17:01:25 +0200 From: Henning Schild To: Claudius Heine Cc: Subject: Re: [PATCH 13/16] meta: classes: move install_package to isar-base Message-ID: <20170801170125.40c5ffbf@md1em3qc> In-Reply-To: <8a72ec15-8fed-e4e3-5dd6-dcdd7252da49@siemens.com> References: <73503162ba0eaa3425468aa1f820c08f0272f261.1501582237.git.henning.schild@siemens.com> <8a72ec15-8fed-e4e3-5dd6-dcdd7252da49@siemens.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Me/xeRCHCjqj Am Tue, 1 Aug 2017 16:00:03 +0200 schrieb Claudius Heine : > On 08/01/2017 12:17 PM, [ext] Henning Schild wrote: > > Signed-off-by: Henning Schild > > --- > > meta/classes/dpkg.bbclass | 9 --------- > > meta/classes/isar-base.bbclass | 10 ++++++++++ > > 2 files changed, 10 insertions(+), 9 deletions(-) > > > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > > index 2a1b85c..37b2c8d 100644 > > --- a/meta/classes/dpkg.bbclass > > +++ b/meta/classes/dpkg.bbclass > > @@ -20,12 +20,3 @@ do_compile() { > > > > addtask compile after do_unpack before do_install_package > > do_compile[stamp-extra-info] = "${DISTRO}" > > - > > -# Install package to dedicated deploy directory > > -do_install_package() { > > - install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ > > -} > > - > > -addtask install_package after do_compile before do_build > > -do_install_package[dirs] = "${DEPLOY_DIR_DEB}" > > -do_install_package[stamp-extra-info] = "${MACHINE}" > > diff --git a/meta/classes/isar-base.bbclass > > b/meta/classes/isar-base.bbclass index 3df6572..68e2aed 100644 > > --- a/meta/classes/isar-base.bbclass > > +++ b/meta/classes/isar-base.bbclass > > @@ -32,3 +32,13 @@ python do_unpack() { > > addtask unpack after do_fetch before do_build > > do_unpack[dirs] = "${WORKDIR}" > > do_unpack[stamp-extra-info] = "${DISTRO}" > > + > > + > > +# Install package to dedicated deploy directory > > +do_install_package() { > > + install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ > > Since I like to use the fetcher tasks for a image recipe, I inherit > from this class, but the image recipe does not have any 'deb' files, > so building failes here. > > So it might be more modular if this task moves into an own class. Sure, makes sense. I just started looking into the image side of isar. Will be addressed in a V2. Henning > > +} > > + > > +addtask install_package before do_build > > +do_install_package[dirs] = "${DEPLOY_DIR_DEB}" > > +do_install_package[stamp-extra-info] = "${MACHINE}" > >