From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247988281769984 X-Received: by 10.25.56.91 with SMTP id d27mr2397747lfj.7.1501669445318; Wed, 02 Aug 2017 03:24:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.22.19 with SMTP id m19ls432254lfi.23.gmail; Wed, 02 Aug 2017 03:24:04 -0700 (PDT) X-Received: by 10.25.198.78 with SMTP id w75mr2396120lff.41.1501669444973; Wed, 02 Aug 2017 03:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501669444; cv=none; d=google.com; s=arc-20160816; b=UnTU0+6QQERE4NacHYx1ttFCbxaWJZmolWSyp/I8OfEDGS8iyiUKSw7TsPU8UTTp2u +oB/oGTukzyr8wPF3mfVhae5LW7yea6nXJnHbVMakxMSWj6Nn0ZJopZJh1XoPc/teC5Q urOr1VCA/Kax4G0VMm8pZr1+ecX7mP3LS6aUnzRdbuJ78PMacxLyp78OAEcnZRA94RZh vRCwUKtL5CSzLbTpk6ePBWWf5uVImZUr6YngDBXEpo6xuuN10uIBAjYQ3D6211xGpN6G ABAP3cLmKT4ZcXRmfGybfNSxHnLqP7wzptDYE7rPEC+7mfHjmYSrSmFwSHMM26s3iGA0 mcWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=ZkCS7L0JyqbyPNy4ArZYj1968/B11pF6P48pm3UfAPA=; b=qdZ5jSqgjzAbQ2a82QSGYlLbKZBzkAx3lIpXnvcw8IJLgpHKvXJ87WstScDzga6+QE 9LgyI+kXVs6896/Ndnoa1YaIAaf6TLrEHKqCU8csLfeHKAJZdviKRvFdjUIkk89FZLjm N2e2zD2GM2chbtZf6Zm6Fq93Vz41xUU/potzid3RWihod4TvjlK6Qlpnv3Up+gxBysJS 04W9NHoh5j3dEfBf3T4HFwk8ZOZjy9444w1vf6TrJAf8tqdBH31HCr5+4/uqVj8Xskjj btyioF6PBLLfteN1LQNgye6NRZDEOYl1J1yrBczhpahz0pB4AX4Bt01QIZk4EzarMtwk b+NQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id 132si843386wmn.6.2017.08.02.03.24.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Aug 2017 03:24:04 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v72AO4xe017896 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Aug 2017 12:24:04 +0200 Received: from md1em3qc ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v72AO3fO030005; Wed, 2 Aug 2017 12:24:03 +0200 Date: Wed, 2 Aug 2017 12:25:58 +0200 From: Henning Schild To: Alexander Smirnov Cc: Claudius Heine , , "Dr . Johann Pfefferl" Subject: Re: [PATCH 15/16] meta: add dpkg-bin class Message-ID: <20170802122558.67955c4f@md1em3qc> In-Reply-To: References: <45a900737baed2ceb30b5eef22eb5a53f64ae020.1501582237.git.henning.schild@siemens.com> <85893014-c2cf-9bde-abf4-ddecf5c2682b@siemens.com> <1411c20e-fff4-cef4-9e15-460eebc14dab@siemens.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: d418ybbk4nPJ Am Wed, 2 Aug 2017 13:11:47 +0300 schrieb Alexander Smirnov : > Hi colleagues, > > from the patch description it's not clear what this patch stays for, > seems that I'm out of you communcation loop. Could you please > annotate the patches with more detailed description, at least with > the following information: > - Change proposal > - Why this change is needed. It's not about arguments to push your > change, it's more about your ideas and motivation. That's the most > imporant information which is missed. > - Change impact to Isar, who will be affected Some of that information is in the cover letter and some other things have been discussed in threads on the list. The example patch behind it might make it clear. But you are right that information should go into the patches. Thanks for the review, i will repost the series with comments addressed. Henning > 2017-08-01 18:10 GMT+03:00 Claudius Heine > : > > > > > > > On 08/01/2017 04:25 PM, [ext] Claudius Heine wrote: > > > >> > >> > >> On 08/01/2017 12:17 PM, [ext] Henning Schild wrote: > >> > >>> Signed-off-by: Henning Schild > >>> --- > >>> meta/classes/dpkg-bin.bbclass | 47 > >>> ++++++++++++++++++++++++++++++ +++++++++++++ > >>> 1 file changed, 47 insertions(+) > >>> create mode 100644 meta/classes/dpkg-bin.bbclass > >>> > >>> diff --git a/meta/classes/dpkg-bin.bbclass > >>> b/meta/classes/dpkg-bin.bbclass > >>> new file mode 100644 > >>> index 0000000..1e96bd1 > >>> --- /dev/null > >>> +++ b/meta/classes/dpkg-bin.bbclass > >>> @@ -0,0 +1,47 @@ > >>> +inherit isar-base > >>> + > >>> +DEBIAN_DEPENDS ?= "" > >>> +DEBIAN_MAINTAINER ?= "FIXME Unknown maintainer" > >>> + > >>> +D = "${WORKDIR}/image/" > >>> + > >>> +# Populate folder that will be picked up as package > >>> +do_install() { > >>> + bbnote "Put your files for this package in ${D}" > >>> +} > >>> + > >>> +addtask install after do_unpack before do_deb_package_prepare > >>> +# so we can put hooks in there already > >>> +do_install[dirs] = "${D}/DEBIAN" > >>> + > >>> +do_deb_package_prepare() { > >>> + cat<<-__EOF__ > ${D}/DEBIAN/control > >>> + Package: ${PN} > >>> + Architecture: `dpkg --print-architecture` > >>> + Section: misc > >>> + Priority: optional > >>> + Maintainer: ${DEBIAN_MAINTAINER} > >>> + Depends: `echo ${DEBIAN_DEPENDS} | tr '[:blank:]' ','` > >>> + Version: ${PV}+isar > >>> + Description: ${DESCRIPTION} > >>> + __EOF__ > >>> + CONFFILES=${D}/DEBIAN/conffiles > >>> + find ${D} -path '*/etc/*' | sed -e 's|^${D}||' > $CONFFILES > >>> > >> > >> I package a container root file system and now the files in the etc > >> directory of this rfs is mentioned in the conffiles file. > >> > > > > It also adds directories into the conffiles file. dpkg does not > > like this. > > > > > >> Maybe add an option to disable this here? > >> > >> + test -s $CONFFILES || rm $CONFFILES > >>> + for t in pre post > >>> + do > >>> + for a in inst rm > >>> + do > >>> + chmod -f +x ${D}/DEBIAN/${t}${a} || true > >>> + done > >>> + done > >>> +} > >>> + > >>> +addtask deb_package_prepare after do_install before > >>> do_install_package + > >>> +do_deb_package() { > >>> + sudo chown -R root:root ${D}/DEBIAN/ > >>> + sudo dpkg-deb --build ${D} ${WORKDIR} > >>> +} > >>> + > >>> +addtask deb_package after do_deb_package_prepare before > >>> do_install_package > >>> > >>> > >> > > -- > > You received this message because you are subscribed to the Google > > Groups "isar-users" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to isar-users+unsubscribe@googlegroups.com. > > To post to this group, send email to isar-users@googlegroups.com. > > To view this discussion on the web visit > > https://groups.google.com/d/ms > > gid/isar-users/1411c20e-fff4-cef4-9e15-460eebc14dab%40siemens.com. > > > > For more options, visit https://groups.google.com/d/optout. > >