Re: [PATCH 14/16] meta: classes: rename dpkg to dpkg-src

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 2 Aug 2017 13:02:10 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> 2017-08-01 13:17 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  meta-isar/recipes-app/hello/hello.bb            | 2 +-
> >  meta/classes/{dpkg.bbclass => dpkg-src.bbclass} | 0
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename meta/classes/{dpkg.bbclass => dpkg-src.bbclass} (100%)
> >  
> 
> What was your idea to do so? Why not 'dpkg-buildpackage.bbclass'?

The idea is to have source and binary packages at the end. How they are
constructed should not be in the name of the class. That way you could
switch the tooling in the future.

Maybe we will never switch the tools but the names should be used to
abstract from implementation.

Henning
 
> >
> > diff --git a/meta-isar/recipes-app/hello/hello.bb
> > b/meta-isar/recipes-app/hello/hello.bb
> > index 56424fb..5c5d714 100644
> > --- a/meta-isar/recipes-app/hello/hello.bb
> > +++ b/meta-isar/recipes-app/hello/hello.bb
> > @@ -15,4 +15,4 @@ SRCREV =
> > "ad7065ecc4840cc436bfcdac427386dbba4ea719"
> >
> >  SRC_DIR = "git"
> >
> > -inherit dpkg
> > +inherit dpkg-src
> > diff --git a/meta/classes/dpkg.bbclass
> > b/meta/classes/dpkg-src.bbclass similarity index 100%
> > rename from meta/classes/dpkg.bbclass
> > rename to meta/classes/dpkg-src.bbclass
> > --
> > 2.13.0
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "isar-users" group.
> > To unsubscribe from this group and stop receiving emails from it,
> > send an email to isar-users+unsubscribe@googlegroups.com.
> > To post to this group, send email to isar-users@googlegroups.com.
> > To view this discussion on the web visit
> > https://groups.google.com/d/
> > msgid/isar-users/f3b8fd43828bf124f4125fb0ba4853cb8a795571.1501582237.git.
> > henning.schild%40siemens.com. For more options, visit
> > https://groups.google.com/d/optout.