From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247988281769984 X-Received: by 10.46.78.10 with SMTP id c10mr336361ljb.43.1502179226780; Tue, 08 Aug 2017 01:00:26 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.153.202 with SMTP id b193ls1710354wme.22.canary-gmail; Tue, 08 Aug 2017 01:00:26 -0700 (PDT) X-Received: by 10.28.5.70 with SMTP id 67mr459601wmf.24.1502179226436; Tue, 08 Aug 2017 01:00:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502179226; cv=none; d=google.com; s=arc-20160816; b=W7fUm1w9oi/9zsmsgEtpftPvZRCeDuXnomt230hxbX0shZJnJVc7llKSPq2ekK8tp5 7mcd0zKElc03ObPXYxaZpufFaB/GovTusP1NcN+1gxD7qM6oa70DzrvZdLyAZ0WO4iHu iu2FI8YKrwz2qJQMCYz4XKVaxgfArGdZtk6/YXqCawwxJNEVDPSdv/ApOHga/4PKypkV WgMJ7Bo3zr5Ixh/lJMsFu/psr73ZKLb9YjBJCjstZWbcK6Cnz9g0KBWdEtuJE75ZazIY E18hjqzZF4XjajbTg3rQTeStjlazXzlraQPaQpJ+7orIrwyV8fKJj91U6A1mLQcR/ggn 6gFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=tqxjRLD6ZebnQir3LPZ125qFU+1Ndm7gTsVQfxOiqx4=; b=zSiDCmDO9EZrV+HoFqEdxXhlQVWT9aodsNweXEozgtJGs67UkTaMNO0JcauNVK/ID5 glIK6zPl6zn4sF/LhSPTYp6yngoGidUWxBKUeHx4uywu36aO3EGkPnQyS9/CkAkjfV38 9B2WLYJ8OMhGmcqC4vB0XLpTvFbZG6QCnaWXIVZPOLSbNrjohajtrr0joybYDZAFoUEh NxJKsdFPeZG8zXg6ip1PUlMpWOoFvesMpj+HWPspJ6AXV2xHtcKBkKWPFM2hXmnbfig9 LUBT+U7YgqLEJ2crmY9SRhavR7QZxcQVnY+6gyFCHya0uLT+T36vDgc7cVQ+7t7Un2ml GakQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id b82si286857wmd.5.2017.08.08.01.00.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 01:00:26 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v7880PlU026444 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Aug 2017 10:00:25 +0200 Received: from md1em3qc ([139.25.68.40]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id v7880PIA021662; Tue, 8 Aug 2017 10:00:25 +0200 Date: Tue, 8 Aug 2017 10:02:22 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 0-10 of 16 v2 3/8] remove redundant variable THISDIR Message-ID: <20170808100222.62f6eb9b@md1em3qc> In-Reply-To: References: <2ea1d8c5cd65ae2ad0e2a17876eb3607c5296b1a.1501760818.git.henning.schild@siemens.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: kJfOgWaclyLw Am Mon, 7 Aug 2017 22:30:48 +0300 schrieb Alexander Smirnov : > 2017-08-03 14:55 GMT+03:00 Henning Schild > : > > > Signed-off-by: Henning Schild > > --- > > meta-isar/recipes-core/images/isar-image-base.bb | 8 ++++---- > > meta/classes/isar-base.bbclass | 2 -- > > meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +++++----- > > 3 files changed, 9 insertions(+), 11 deletions(-) > > > > diff --git a/meta-isar/recipes-core/images/isar-image-base.bb > > b/meta-isar/recipes-core/images/isar-image-base.bb > > index 337c329..0810de0 100644 > > --- a/meta-isar/recipes-core/images/isar-image-base.bb > > +++ b/meta-isar/recipes-core/images/isar-image-base.bb > > @@ -27,10 +27,10 @@ do_rootfs() { > > install -d -m 755 ${WORKDIR}/hooks_multistrap > > > > # Copy config file > > - install -m 644 ${THISDIR}/files/multistrap.conf.in > > ${WORKDIR}/multistrap.conf > > - install -m 755 ${THISDIR}/files/${DISTRO_CONFIG_SCRIPT} > > ${WORKDIR}/configscript.sh > > - install -m 755 ${THISDIR}/files/setup.sh ${WORKDIR} > > - install -m 755 ${THISDIR}/files/download_dev-random > > ${WORKDIR}/hooks_multistrap/ > > + install -m 644 ${FILESDIR}/multistrap.conf.in > > ${WORKDIR}/multistrap.conf > > + install -m 755 ${FILESDIR}/${DISTRO_CONFIG_SCRIPT} > > ${WORKDIR}/configscript.sh > > + install -m 755 ${FILESDIR}/setup.sh ${WORKDIR} > > + install -m 755 ${FILESDIR}/download_dev-random > > ${WORKDIR}/hooks_multistrap/ > > > > # Adjust multistrap config > > sed -i 's|##IMAGE_PREINSTALL##|${IMAGE_PREINSTALL}|' > > ${WORKDIR}/multistrap.conf > > diff --git a/meta/classes/isar-base.bbclass > > b/meta/classes/isar-base. bbclass > > index efd4223..d860937 100644 > > --- a/meta/classes/isar-base.bbclass > > +++ b/meta/classes/isar-base.bbclass > > @@ -19,6 +19,4 @@ > > # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE > > USE OR # OTHER DEALINGS IN THE SOFTWARE. > > > > -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" > > - > > do_build[nostamp] = "0" > > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb > > b/meta/recipes-devtools/buildchroot/buildchroot.bb > > index ba1bc66..f471f5e 100644 > > --- a/meta/recipes-devtools/buildchroot/buildchroot.bb > > +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb > > @@ -29,10 +29,10 @@ do_build() { > > install -d -m 755 ${WORKDIR}/hooks_multistrap > > > > # Copy config files > > - install -m 644 ${THISDIR}/files/multistrap.conf.in > > ${WORKDIR}/multistrap.conf > > - install -m 755 ${THISDIR}/files/configscript.sh ${WORKDIR} > > - install -m 755 ${THISDIR}/files/setup.sh ${WORKDIR} > > - install -m 755 ${THISDIR}/files/download_dev-random > > ${WORKDIR}/hooks_multistrap/ > > + install -m 644 ${FILESDIR}/multistrap.conf.in > > ${WORKDIR}/multistrap.conf > > + install -m 755 ${FILESDIR}/configscript.sh ${WORKDIR} > > + install -m 755 ${FILESDIR}/setup.sh ${WORKDIR} > > + install -m 755 ${FILESDIR}/download_dev-random > > ${WORKDIR}/hooks_multistrap/ > > > > # Adjust multistrap config > > sed -i > > 's|##BUILDCHROOT_PREINSTALL##|${BUILDCHROOT_PREINSTALL}|' > > ${WORKDIR}/multistrap.conf @@ -51,7 +51,7 @@ do_build() { > > sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f > > "${WORKDIR}/multistrap.conf" || true > > > > # Install package builder script > > - sudo install -m 755 ${THISDIR}/files/build.sh > > ${BUILDCHROOT_DIR} > > + sudo install -m 755 ${FILESDIR}/build.sh ${BUILDCHROOT_DIR} > > > > # Configure root filesystem > > sudo chroot ${BUILDCHROOT_DIR} /configscript.sh > > -- > > 2.13.0 > > > > > As I already mentioned, there is a build problem, need further > investigation about python version. I do not remember that remark and do not see how it influences the validity of this patch. Does the patch introduce the build-problem? Henning