Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 7 Aug 2017 22:36:18 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> I'm not sure that this function is unused. It's usually used for debug
> purposes to route traces to console.

It is unused in Isar and not part of the default base class of bitbake.

> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> chapter: 2.3.8.2

OE implements it in meta/classes/logging.bbclass

> I think it makes sense to keep it to debug complicated classes and
> recipes in future.

Ok.

Henning

> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  meta/classes/isar-base.bbclass | 12 ------------
> >  1 file changed, 12 deletions(-)
> >
> > diff --git a/meta/classes/isar-base.bbclass
> > b/meta/classes/isar-base. bbclass
> > index 67d38a1..efd4223 100644
> > --- a/meta/classes/isar-base.bbclass
> > +++ b/meta/classes/isar-base.bbclass
> > @@ -21,16 +21,4 @@
> >
> >  THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> >
> > -bbdebug() {
> > -       test $# -ge 2 || {
> > -               echo "Usage: bbdebug level \"message\""
> > -               exit 1
> > -       }
> > -
> > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > -               shift
> > -               echo "DEBUG:" $*
> > -       }
> > -}
> > -
> >  do_build[nostamp] = "0"
> > --
> > 2.13.0
> >
> >