public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function
Date: Tue, 8 Aug 2017 14:08:09 +0200	[thread overview]
Message-ID: <20170808140809.1636322c@md1em3qc> (raw)
In-Reply-To: <CAJmB2rDgfRZR5o9aSSPPZD0vKVkyKt62BtQ-NL77M+U-K_SPCQ@mail.gmail.com>

Am Tue, 8 Aug 2017 12:33:58 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> 2017-08-08 11:05 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Am Mon, 7 Aug 2017 22:36:18 +0300
> > schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >  
> > > I'm not sure that this function is unused. It's usually used for
> > > debug purposes to route traces to console.  
> >
> > It is unused in Isar and not part of the default base class of
> > bitbake. 
> > > http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> > > chapter: 2.3.8.2  
> >
> > OE implements it in meta/classes/logging.bbclass
> >
> >  
> That's a good hint! So probably we can move this function to similar
> class instead of removing it.

I would still remove it since it is not used. When people need it they
can introduce it again. For logging we have bbnote bbwarn and bbfatal
from base.bbclass already.

Our bitbake does not seem to know "debug_level" so it is outdated and
unused.

Henning

> 
> > > I think it makes sense to keep it to debug complicated classes and
> > > recipes in future.  
> >
> > Ok.
> >
> > Henning
> >  
> > > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > > <henning.schild@siemens.com>:
> > >  
> > > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > > ---
> > > >  meta/classes/isar-base.bbclass | 12 ------------
> > > >  1 file changed, 12 deletions(-)
> > > >
> > > > diff --git a/meta/classes/isar-base.bbclass
> > > > b/meta/classes/isar-base. bbclass
> > > > index 67d38a1..efd4223 100644
> > > > --- a/meta/classes/isar-base.bbclass
> > > > +++ b/meta/classes/isar-base.bbclass
> > > > @@ -21,16 +21,4 @@
> > > >
> > > >  THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > >
> > > > -bbdebug() {
> > > > -       test $# -ge 2 || {
> > > > -               echo "Usage: bbdebug level \"message\""
> > > > -               exit 1
> > > > -       }
> > > > -
> > > > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > > -               shift
> > > > -               echo "DEBUG:" $*
> > > > -       }
> > > > -}
> > > > -
> > > >  do_build[nostamp] = "0"
> > > > --
> > > > 2.13.0
> > > >
> > > >  
> >
> >  


  reply	other threads:[~2017-08-08 12:06 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 11:55 [PATCH 0-10 of 16 v2 0/8] splitting the previous q Henning Schild
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake Henning Schild
2017-08-07 16:27   ` Alexander Smirnov
2017-08-08  8:52     ` Henning Schild
2017-08-08  9:39       ` Alexander Smirnov
2017-08-09 13:15         ` Henning Schild
2017-08-08 11:40       ` Jan Kiszka
2017-08-07 19:18   ` Alexander Smirnov
2017-08-08  8:43     ` Henning Schild
2017-08-08 14:02       ` Alexander Smirnov
2017-08-08 14:15         ` Henning Schild
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function Henning Schild
2017-08-07 19:36   ` Alexander Smirnov
2017-08-08  8:05     ` Henning Schild
2017-08-08  9:33       ` Alexander Smirnov
2017-08-08 12:08         ` Henning Schild [this message]
2017-08-08 12:29           ` Alexander Smirnov
2017-08-08 13:12             ` Henning Schild
2017-08-08 13:24               ` Alexander Smirnov
2017-08-08 14:21                 ` Henning Schild
2017-08-21 23:05                   ` Baurzhan Ismagulov
2017-08-08 13:47               ` Alexander Smirnov
2017-08-08 14:17                 ` Henning Schild
2017-08-21 22:26   ` Baurzhan Ismagulov
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 3/8] remove redundant variable THISDIR Henning Schild
2017-08-07 19:30   ` Alexander Smirnov
2017-08-08  8:02     ` Henning Schild
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes Henning Schild
2017-08-07 19:37   ` Alexander Smirnov
2017-08-21 13:25   ` Baurzhan Ismagulov
2017-08-21 18:29     ` Henning Schild
2017-08-22 11:31       ` Baurzhan Ismagulov
2017-08-22 12:45         ` Henning Schild
2017-08-22 15:31           ` Baurzhan Ismagulov
2017-08-22 18:55             ` Henning Schild
2017-08-23 11:31               ` Baurzhan Ismagulov
2017-08-23 11:46                 ` Henning Schild
2017-08-27 23:46                   ` Baurzhan Ismagulov
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 5/8] meta: conf: clean up local bitbake config Henning Schild
2017-08-07 19:37   ` Alexander Smirnov
2017-08-21 19:55   ` Baurzhan Ismagulov
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base Henning Schild
2017-08-07 19:40   ` Alexander Smirnov
2017-08-08  8:00     ` Henning Schild
2017-08-08  9:30       ` Alexander Smirnov
2017-08-08 12:01         ` Henning Schild
2017-08-21 20:27           ` Baurzhan Ismagulov
2017-08-22  8:19             ` Henning Schild
2017-08-22 10:18               ` Baurzhan Ismagulov
2017-08-22 10:44                 ` Henning Schild
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 7/8] meta: dpdk use [dirs] directive instead of mkdir Henning Schild
2017-08-07 19:41   ` Alexander Smirnov
2017-08-21 20:33   ` Baurzhan Ismagulov
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 8/8] meta: dpkg: reorder and rename do_install to install in addtask Henning Schild
2017-08-07 19:41   ` Alexander Smirnov
2017-08-21 20:42   ` Baurzhan Ismagulov
2017-08-07 19:44 ` [PATCH 0-10 of 16 v2 0/8] splitting the previous q Alexander Smirnov
2017-08-08  8:45   ` Henning Schild
2017-08-08  9:43     ` Alexander Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170808140809.1636322c@md1em3qc \
    --to=henning.schild@siemens.com \
    --cc=alex.bluesman.smirnov@gmail.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox