From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.25.201.71 with SMTP id z68mr599627lff.17.1502193974141; Tue, 08 Aug 2017 05:06:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.169.216 with SMTP id s207ls1792702wme.19.canary-gmail; Tue, 08 Aug 2017 05:06:13 -0700 (PDT) X-Received: by 10.28.187.215 with SMTP id l206mr464042wmf.7.1502193973823; Tue, 08 Aug 2017 05:06:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502193973; cv=none; d=google.com; s=arc-20160816; b=PhPYdJFn+Mr72R47X/vai8JUtATDxDRoODegesvuQU1uBnOxhi8jQ8I/+nZ7FYD7vs mwUhhS18qebgf7a/rPlcc/0/n2W+vIYNSFehtMHljMxGWcwvqHuC66PZheEgSUavi/K/ DdfI/ZHyxd6b9YMWm6TM7tulEE6ygj7MwTHjqukbfkRV69swXGoZaaDCbl2JPDWU2ZgM +vUtalj0EO3611M/NASN16/4uu3cUvh7qpKJFF3wD7GyA6bS6BAR1zS6IGbXGIwDEhxa kEmp1UOLLOO8+UCV43FLDioCndI/L2sGFJNHb9n1b5A5HgF4X9DkaAf0fUcDFjJX4XNH yNuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=a+Zhk5iowTAbngJhxBGpOxdQyZdIZMAHU9H0xykoYYI=; b=D4TWmb4qiF5+bj/ra9HOE8SCKUpXlf6OhkZxDMBmRyAydFNlYCgLQPcZ8Tp5tX5qn9 lQtY38mojfnQ3NwZqj0SjO8gujvjSxGfW1+OmSZiD3A1sKx6/sgTq0WDFBS20u79XLBS OmuRrd4oNhKbc62I5TtslQdTT3a9tevAmiYvQpmPazre50tMNmp8wBhhioaZO01ROANm Bw83/b85XdYUEApIlfirndCzQZgIc8Zn+k/koTbhkezhXH7NrM96YbeE+uuLm19K3OpW l6dNs2AF67/oHDv5lhEDfkkw3FQr+OsRpMX/5Yk+dFDtNosGjqC8MnmTBLemxjnphGYi t49w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id v142si422508wmv.8.2017.08.08.05.06.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 05:06:13 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v78C6Cul032084 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Aug 2017 14:06:12 +0200 Received: from md1em3qc ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v78C6Ccc019071; Tue, 8 Aug 2017 14:06:12 +0200 Date: Tue, 8 Aug 2017 14:08:09 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function Message-ID: <20170808140809.1636322c@md1em3qc> In-Reply-To: References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: tYQILfND1GB+ Am Tue, 8 Aug 2017 12:33:58 +0300 schrieb Alexander Smirnov : > 2017-08-08 11:05 GMT+03:00 Henning Schild > : > > > Am Mon, 7 Aug 2017 22:36:18 +0300 > > schrieb Alexander Smirnov : > > > > > I'm not sure that this function is unused. It's usually used for > > > debug purposes to route traces to console. > > > > It is unused in Isar and not part of the default base class of > > bitbake. > > > http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html > > > chapter: 2.3.8.2 > > > > OE implements it in meta/classes/logging.bbclass > > > > > That's a good hint! So probably we can move this function to similar > class instead of removing it. I would still remove it since it is not used. When people need it they can introduce it again. For logging we have bbnote bbwarn and bbfatal from base.bbclass already. Our bitbake does not seem to know "debug_level" so it is outdated and unused. Henning > > > > I think it makes sense to keep it to debug complicated classes and > > > recipes in future. > > > > Ok. > > > > Henning > > > > > 2017-08-03 14:55 GMT+03:00 Henning Schild > > > : > > > > > > > Signed-off-by: Henning Schild > > > > --- > > > > meta/classes/isar-base.bbclass | 12 ------------ > > > > 1 file changed, 12 deletions(-) > > > > > > > > diff --git a/meta/classes/isar-base.bbclass > > > > b/meta/classes/isar-base. bbclass > > > > index 67d38a1..efd4223 100644 > > > > --- a/meta/classes/isar-base.bbclass > > > > +++ b/meta/classes/isar-base.bbclass > > > > @@ -21,16 +21,4 @@ > > > > > > > > THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" > > > > > > > > -bbdebug() { > > > > - test $# -ge 2 || { > > > > - echo "Usage: bbdebug level \"message\"" > > > > - exit 1 > > > > - } > > > > - > > > > - test ${@bb.msg.debug_level['default']} -ge $1 && { > > > > - shift > > > > - echo "DEBUG:" $* > > > > - } > > > > -} > > > > - > > > > do_build[nostamp] = "0" > > > > -- > > > > 2.13.0 > > > > > > > > > > > >