From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.28.99.135 with SMTP id x129mr591671wmb.9.1502197851502; Tue, 08 Aug 2017 06:10:51 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.31.199 with SMTP id f190ls1830626wmf.25.canary-gmail; Tue, 08 Aug 2017 06:10:51 -0700 (PDT) X-Received: by 10.223.181.146 with SMTP id c18mr353991wre.18.1502197851271; Tue, 08 Aug 2017 06:10:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502197851; cv=none; d=google.com; s=arc-20160816; b=ZTNgwNF0i0u6vHnP9qISuKA1no7dddfiJabp6VrQcGbpbyggHNCflp1ubMZWTylKVv Eh/Joy8q2pnd9hQ7iAaAdPbI4P8H4FRhs2VBDsP1PJgHJfDHYhqCNvcLzw+MpNlc5co+ M0gMy/V9ZZ83eZuYFMvuch1kG/xvO0m8ubWOAcabqXSYZu1WeRz799Me0G76vs9PEPKt 8xyxwvtfvPM6B8z5tY1OfzeVbZWi3UdC4oFdTingG76/UDWf1pcPEKL4CjHd99dYr8Lf MTLA32GpwH8GnY2LCbNPcFICE0xTJZ36Yol9PoR6sKdp9G29/pkd/bos1Bsh7IjnG9o8 2zHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=HZMw79O9J47x5w3RGNplcWWjC7WWeb2uGL0AOZaNVbc=; b=kf8fRgYYFS2RMTkK3cRakg3hcADGhypyXSEOBrDcUoHzfrpC9aOPwfCbMPzkTbLl+U J/Q3Y6ji5la4Yx+JNKUTXand+By6bFJzfrCsVXbWRiATnTNT/5dKuZq6rGUY4DLURG4b Pf+SurklLCLM/A70rMq4v/osAQNJIlOmiWUwz7IDsCXElRWcraM6cLqlce+bgl9rSTRx cdaTkeuRvDfGxU7K5wr3Ad6/7viGvZcJGSnw52XW2udGA3/Jkj9sMf6i7rEc7h7791XM nrr8qGcH4pTgAuCgyzhPxlHzVor5qxYOqhnRZVVeiKZ7KnOXtFsbWNAdNoAhHXSMO0Ri sRCg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id 72si440489wmo.9.2017.08.08.06.10.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 06:10:51 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v78DAoc4007694 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Aug 2017 15:10:50 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v78DAoxA018965; Tue, 8 Aug 2017 15:10:50 +0200 Date: Tue, 8 Aug 2017 15:12:47 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function Message-ID: <20170808151247.40b2f573@md1em3qc> In-Reply-To: <55765622-5df2-3353-2326-7f3d66a0e57e@ilbers.de> References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> <20170808140809.1636322c@md1em3qc> <55765622-5df2-3353-2326-7f3d66a0e57e@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: O12iR0299CcA Am Tue, 8 Aug 2017 15:29:35 +0300 schrieb Alexander Smirnov : > Hi, > > On 08/08/2017 03:08 PM, Henning Schild wrote: > > Am Tue, 8 Aug 2017 12:33:58 +0300 > > schrieb Alexander Smirnov : > > > >> 2017-08-08 11:05 GMT+03:00 Henning Schild > >> : > >> > >>> Am Mon, 7 Aug 2017 22:36:18 +0300 > >>> schrieb Alexander Smirnov : > >>> > >>>> I'm not sure that this function is unused. It's usually used for > >>>> debug purposes to route traces to console. > >>> > >>> It is unused in Isar and not part of the default base class of > >>> bitbake. > >>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html > >>>> chapter: 2.3.8.2 > >>> > >>> OE implements it in meta/classes/logging.bbclass > >>> > >>> > >> That's a good hint! So probably we can move this function to > >> similar class instead of removing it. > > > > I would still remove it since it is not used. When people need it > > they can introduce it again. For logging we have bbnote bbwarn and > > bbfatal from base.bbclass already. > > > > Our bitbake does not seem to know "debug_level" so it is outdated > > and unused. > > I'll send patch which introduces logging class and move all the > 'bbXXX' helpers to it (also fix bbdebug). Please do not touch base.bbclass! Or come up with one that is really different from the bitbake default one for a good reason. > I really don't like the idea to drop debug capabilities only because > they are not used at the moment. If this interface is going to be > dropped, then we need to introduce new interface before. Like Isar was used by anyone or this was anything like a tiny broken print function.... without users or a release who cares about interfaces? But keep it like the bugs in ext4! Can we please start dicsussing the real patches? Henning > Alex > > > > >> > >>>> I think it makes sense to keep it to debug complicated classes > >>>> and recipes in future. > >>> > >>> Ok. > >>> > >>> Henning > >>> > >>>> 2017-08-03 14:55 GMT+03:00 Henning Schild > >>>> : > >>>> > >>>>> Signed-off-by: Henning Schild > >>>>> --- > >>>>> meta/classes/isar-base.bbclass | 12 ------------ > >>>>> 1 file changed, 12 deletions(-) > >>>>> > >>>>> diff --git a/meta/classes/isar-base.bbclass > >>>>> b/meta/classes/isar-base. bbclass > >>>>> index 67d38a1..efd4223 100644 > >>>>> --- a/meta/classes/isar-base.bbclass > >>>>> +++ b/meta/classes/isar-base.bbclass > >>>>> @@ -21,16 +21,4 @@ > >>>>> > >>>>> THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" > >>>>> > >>>>> -bbdebug() { > >>>>> - test $# -ge 2 || { > >>>>> - echo "Usage: bbdebug level \"message\"" > >>>>> - exit 1 > >>>>> - } > >>>>> - > >>>>> - test ${@bb.msg.debug_level['default']} -ge $1 && { > >>>>> - shift > >>>>> - echo "DEBUG:" $* > >>>>> - } > >>>>> -} > >>>>> - > >>>>> do_build[nostamp] = "0" > >>>>> -- > >>>>> 2.13.0 > >>>>> > >>>>> > >>> > >>> > > >