Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 8 Aug 2017 16:47:26 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> On 08/08/2017 04:12 PM, Henning Schild wrote:
> > Am Tue, 8 Aug 2017 15:29:35 +0300
> > schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> >   
> >> Hi,
> >>
> >> On 08/08/2017 03:08 PM, Henning Schild wrote:  
> >>> Am Tue, 8 Aug 2017 12:33:58 +0300
> >>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >>>      
> >>>> 2017-08-08 11:05 GMT+03:00 Henning Schild
> >>>> <henning.schild@siemens.com>:
> >>>>     
> >>>>> Am Mon, 7 Aug 2017 22:36:18 +0300
> >>>>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >>>>>        
> >>>>>> I'm not sure that this function is unused. It's usually used
> >>>>>> for debug purposes to route traces to console.  
> >>>>>
> >>>>> It is unused in Isar and not part of the default base class of
> >>>>> bitbake.  
> >>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> >>>>>> chapter: 2.3.8.2  
> >>>>>
> >>>>> OE implements it in meta/classes/logging.bbclass
> >>>>>
> >>>>>        
> >>>> That's a good hint! So probably we can move this function to
> >>>> similar class instead of removing it.  
> >>>
> >>> I would still remove it since it is not used. When people need it
> >>> they can introduce it again. For logging we have bbnote bbwarn and
> >>> bbfatal from base.bbclass already.  
> 
> Ahh, I suppose I got it now, I thought that bbdebug was a part of 
> default base.class, that why I insisted on keeping it. But now I see 
> that default class doesn't contain this blob. Ok, agreed.

Ok, nice!

Henning

> Alex
> 
> >>>
> >>> Our bitbake does not seem to know "debug_level" so it is outdated
> >>> and unused.  
> >>
> >> I'll send patch which introduces logging class and move all the
> >> 'bbXXX' helpers to it (also fix bbdebug).  
> > 
> > Please do not touch base.bbclass! Or come up with one that is really
> > different from the bitbake default one for a good reason.
> >   
> >> I really don't like the idea to drop debug capabilities only
> >> because they are not used at the moment. If this interface is
> >> going to be dropped, then we need to introduce new interface
> >> before.  
> > 
> > Like Isar was used by anyone or this was anything like a tiny
> > broken print function.... without users or a release who cares about
> > interfaces? But keep it like the bugs in ext4!
> > 
> > Can we please start dicsussing the real patches?
> > 
> > Henning
> >   
> >> Alex
> >>  
> >>>      
> >>>>     
> >>>>>> I think it makes sense to keep it to debug complicated classes
> >>>>>> and recipes in future.  
> >>>>>
> >>>>> Ok.
> >>>>>
> >>>>> Henning
> >>>>>        
> >>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild
> >>>>>> <henning.schild@siemens.com>:
> >>>>>>        
> >>>>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> >>>>>>> ---
> >>>>>>>    meta/classes/isar-base.bbclass | 12 ------------
> >>>>>>>    1 file changed, 12 deletions(-)
> >>>>>>>
> >>>>>>> diff --git a/meta/classes/isar-base.bbclass
> >>>>>>> b/meta/classes/isar-base. bbclass
> >>>>>>> index 67d38a1..efd4223 100644
> >>>>>>> --- a/meta/classes/isar-base.bbclass
> >>>>>>> +++ b/meta/classes/isar-base.bbclass
> >>>>>>> @@ -21,16 +21,4 @@
> >>>>>>>
> >>>>>>>    THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> >>>>>>>
> >>>>>>> -bbdebug() {
> >>>>>>> -       test $# -ge 2 || {
> >>>>>>> -               echo "Usage: bbdebug level \"message\""
> >>>>>>> -               exit 1
> >>>>>>> -       }
> >>>>>>> -
> >>>>>>> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> >>>>>>> -               shift
> >>>>>>> -               echo "DEBUG:" $*
> >>>>>>> -       }
> >>>>>>> -}
> >>>>>>> -
> >>>>>>>    do_build[nostamp] = "0"
> >>>>>>> --
> >>>>>>> 2.13.0
> >>>>>>>
> >>>>>>>        
> >>>>>
> >>>>>        
> >>>      
> >>  
> >   
>