From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.223.172.172 with SMTP id o41mr420186wrc.19.1502201754999; Tue, 08 Aug 2017 07:15:54 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.63.151 with SMTP id m145ls1870254wma.0.gmail; Tue, 08 Aug 2017 07:15:54 -0700 (PDT) X-Received: by 10.28.45.5 with SMTP id t5mr626644wmt.12.1502201754664; Tue, 08 Aug 2017 07:15:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502201754; cv=none; d=google.com; s=arc-20160816; b=Ha3VcIgATTB07dqZe/S0Q/2JYnQCMm57jnGDrrtb2GYc7vpbFeDbYIDnD7RIKJmgWL fdvJZZZsYLa05AYxRb68hbCtZOFJ5X3S+RkfrbvoCf3PAUn8ny8XKBgTUndrndq4cvZ7 9Sx5D+XhACXtNtND1uNBcOkw052AO3YGp5FDjWLbV8VEuvZthiHzaev+Ed+s0Y/yxMeI m+CvZPdTB79JRnTUdrgtiFoL7m8i0u0Zhv+TXQ+b/d2nfYDKGJWt53dWA/WwX+jQ8EP8 Wi0/oRZbbUG4+jf5pCYDnDilLoxgzt/3S0wOyaVuyED/+7sU90wlK15cTJ7Q8iuIv+pP 1giw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=Zh5hWLaVOCiCETYXPmr/T3ceBvXpjclUQ67L0hP3ymY=; b=woaryzqD3DDp9oZcJ0N520oxp1jpG3JvQOwZbzmUJ7UIrcgkMgKyza5ESS2OEOrUEQ DEO4iv8j5dDa7fs9c007U1O5hUVe7+AmGFrUdYEP0wLFr0ozQijuDG0iEa7aLKUPsSnW MXTwVr0cSOSJat+kU4ZcHQNPCvNJtfsZr1Cy1Hs9tQlgulUnQMBJ2FHXwYEFGdk7NpKp XSHQpPFxDok41tW9lEgs9UPyjNpdoep/us8ZUC/VP2g3DP1hR4Wrl8evxwEaasTw/4PO sxpFkTSTDV8NHlTXYbYoXJDRLgTyPi/VpRrkC5xpC5WXoZzVonwQqZ3+qkIdG2pEoDw6 D44A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id 2si540991wms.6.2017.08.08.07.15.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 07:15:54 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v78EFs3U006965 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Aug 2017 16:15:54 +0200 Received: from md1em3qc ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v78EFsLD007650; Tue, 8 Aug 2017 16:15:54 +0200 Date: Tue, 8 Aug 2017 16:17:51 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function Message-ID: <20170808161751.10b54667@md1em3qc> In-Reply-To: <9a926579-707a-aca9-43e3-9b550a4e88a2@ilbers.de> References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> <20170808140809.1636322c@md1em3qc> <55765622-5df2-3353-2326-7f3d66a0e57e@ilbers.de> <20170808151247.40b2f573@md1em3qc> <9a926579-707a-aca9-43e3-9b550a4e88a2@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: cHWdL3YoxzSN Am Tue, 8 Aug 2017 16:47:26 +0300 schrieb Alexander Smirnov : > On 08/08/2017 04:12 PM, Henning Schild wrote: > > Am Tue, 8 Aug 2017 15:29:35 +0300 > > schrieb Alexander Smirnov : > > > >> Hi, > >> > >> On 08/08/2017 03:08 PM, Henning Schild wrote: > >>> Am Tue, 8 Aug 2017 12:33:58 +0300 > >>> schrieb Alexander Smirnov : > >>> > >>>> 2017-08-08 11:05 GMT+03:00 Henning Schild > >>>> : > >>>> > >>>>> Am Mon, 7 Aug 2017 22:36:18 +0300 > >>>>> schrieb Alexander Smirnov : > >>>>> > >>>>>> I'm not sure that this function is unused. It's usually used > >>>>>> for debug purposes to route traces to console. > >>>>> > >>>>> It is unused in Isar and not part of the default base class of > >>>>> bitbake. > >>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html > >>>>>> chapter: 2.3.8.2 > >>>>> > >>>>> OE implements it in meta/classes/logging.bbclass > >>>>> > >>>>> > >>>> That's a good hint! So probably we can move this function to > >>>> similar class instead of removing it. > >>> > >>> I would still remove it since it is not used. When people need it > >>> they can introduce it again. For logging we have bbnote bbwarn and > >>> bbfatal from base.bbclass already. > > Ahh, I suppose I got it now, I thought that bbdebug was a part of > default base.class, that why I insisted on keeping it. But now I see > that default class doesn't contain this blob. Ok, agreed. Ok, nice! Henning > Alex > > >>> > >>> Our bitbake does not seem to know "debug_level" so it is outdated > >>> and unused. > >> > >> I'll send patch which introduces logging class and move all the > >> 'bbXXX' helpers to it (also fix bbdebug). > > > > Please do not touch base.bbclass! Or come up with one that is really > > different from the bitbake default one for a good reason. > > > >> I really don't like the idea to drop debug capabilities only > >> because they are not used at the moment. If this interface is > >> going to be dropped, then we need to introduce new interface > >> before. > > > > Like Isar was used by anyone or this was anything like a tiny > > broken print function.... without users or a release who cares about > > interfaces? But keep it like the bugs in ext4! > > > > Can we please start dicsussing the real patches? > > > > Henning > > > >> Alex > >> > >>> > >>>> > >>>>>> I think it makes sense to keep it to debug complicated classes > >>>>>> and recipes in future. > >>>>> > >>>>> Ok. > >>>>> > >>>>> Henning > >>>>> > >>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild > >>>>>> : > >>>>>> > >>>>>>> Signed-off-by: Henning Schild > >>>>>>> --- > >>>>>>> meta/classes/isar-base.bbclass | 12 ------------ > >>>>>>> 1 file changed, 12 deletions(-) > >>>>>>> > >>>>>>> diff --git a/meta/classes/isar-base.bbclass > >>>>>>> b/meta/classes/isar-base. bbclass > >>>>>>> index 67d38a1..efd4223 100644 > >>>>>>> --- a/meta/classes/isar-base.bbclass > >>>>>>> +++ b/meta/classes/isar-base.bbclass > >>>>>>> @@ -21,16 +21,4 @@ > >>>>>>> > >>>>>>> THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" > >>>>>>> > >>>>>>> -bbdebug() { > >>>>>>> - test $# -ge 2 || { > >>>>>>> - echo "Usage: bbdebug level \"message\"" > >>>>>>> - exit 1 > >>>>>>> - } > >>>>>>> - > >>>>>>> - test ${@bb.msg.debug_level['default']} -ge $1 && { > >>>>>>> - shift > >>>>>>> - echo "DEBUG:" $* > >>>>>>> - } > >>>>>>> -} > >>>>>>> - > >>>>>>> do_build[nostamp] = "0" > >>>>>>> -- > >>>>>>> 2.13.0 > >>>>>>> > >>>>>>> > >>>>> > >>>>> > >>> > >> > > >