From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.46.19.26 with SMTP id 26mr527813ljt.25.1502201981922; Tue, 08 Aug 2017 07:19:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.20.86 with SMTP id 22ls753952lju.22.gmail; Tue, 08 Aug 2017 07:19:41 -0700 (PDT) X-Received: by 10.25.84.138 with SMTP id b10mr252033lfl.42.1502201981508; Tue, 08 Aug 2017 07:19:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502201981; cv=none; d=google.com; s=arc-20160816; b=jW5+aEq/wf1DGaPran96qUKWkZ8zlqCiX8hYt9XJSLO/WzsOjeRDYi+uk2fZBe4P6N blu+HuKu68QPL0r3/x25ueaEo9WPyeb9zvCfS9dszDvLJQdfIH3qDmmxhs9eSzeOauDW dcscw0oXU+ek3eVOV3N7UW+ZuZ6+x5p+FEgb3QHg1BcGCkLb2VYRMyC81N5FC900kpDG oBEjauUSS+LHpMghAlQrRh8LD1yfECtodkqgZjm2SZ9fxH6nlDqXkJ2ynra2j6FxBKPf 6GpbTbobvowYRirV56tFcUhXgRUEWKeeu1rDl6LNUVdduFDwzZFUKvYbxY1nr7EXiLby uMPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=AZGtu9nB/DRFADuyS91SvZPGDSO6yMnyiEXr3NtSZfI=; b=VZSti5/wUA2tM+W2AoHo5ziFwf0gbtMmnU1rZF5N6AK4BpVioUb06prVWQuJj+xL/D BBPLQJNoJrlc8IoJH5fd673kKqiIF45N1+TWcP1v44ZDaZPv05+bUQ8xzfbKe/AEkFK9 Jetc5/E832SbcHYUMTJmNOD72Dl35kjItGfzXfT/q+vlhl3D5MM+bH71RNY5JTW+JQfu PjZhoViWpgMCHBOFTY6FKOiOg1aLM8sUxYqn1bakmgvqqznMbu93impdd5qIUlB5Nn4y l5tFVr1P+OvmRvc2HvkUA7OZtBlX1MkmXS5yGylV7NZklHNBpa2PZEdVV97UtZ+lyvkw 9c+w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id 132si524617wmn.6.2017.08.08.07.19.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 07:19:41 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v78EJemX019448 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Aug 2017 16:19:41 +0200 Received: from md1em3qc ([139.25.68.40]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id v78EJeTp018008; Tue, 8 Aug 2017 16:19:40 +0200 Date: Tue, 8 Aug 2017 16:21:37 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function Message-ID: <20170808162137.1ea80448@md1em3qc> In-Reply-To: <187ded0d-5751-3267-e321-4258f77e8557@ilbers.de> References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> <20170808140809.1636322c@md1em3qc> <55765622-5df2-3353-2326-7f3d66a0e57e@ilbers.de> <20170808151247.40b2f573@md1em3qc> <187ded0d-5751-3267-e321-4258f77e8557@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: t4zDonVhjJjx Am Tue, 8 Aug 2017 16:24:44 +0300 schrieb Alexander Smirnov : > On 08/08/2017 04:12 PM, Henning Schild wrote: > > Am Tue, 8 Aug 2017 15:29:35 +0300 > > schrieb Alexander Smirnov : > > > >> Hi, > >> > >> On 08/08/2017 03:08 PM, Henning Schild wrote: > >>> Am Tue, 8 Aug 2017 12:33:58 +0300 > >>> schrieb Alexander Smirnov : > >>> > >>>> 2017-08-08 11:05 GMT+03:00 Henning Schild > >>>> : > >>>> > >>>>> Am Mon, 7 Aug 2017 22:36:18 +0300 > >>>>> schrieb Alexander Smirnov : > >>>>> > >>>>>> I'm not sure that this function is unused. It's usually used > >>>>>> for debug purposes to route traces to console. > >>>>> > >>>>> It is unused in Isar and not part of the default base class of > >>>>> bitbake. > >>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html > >>>>>> chapter: 2.3.8.2 > >>>>> > >>>>> OE implements it in meta/classes/logging.bbclass > >>>>> > >>>>> > >>>> That's a good hint! So probably we can move this function to > >>>> similar class instead of removing it. > >>> > >>> I would still remove it since it is not used. When people need it > >>> they can introduce it again. For logging we have bbnote bbwarn and > >>> bbfatal from base.bbclass already. > >>> > >>> Our bitbake does not seem to know "debug_level" so it is outdated > >>> and unused. > >> > >> I'll send patch which introduces logging class and move all the > >> 'bbXXX' helpers to it (also fix bbdebug). > > > > Please do not touch base.bbclass! Or come up with one that is really > > different from the bitbake default one for a good reason. > > > > Why base.bbclass should stay untouched? If default bitbake contains > garbage, should we still keep it and workaround as much as possible? To be able to update bitbake without using copied parts of the old bitbake. If we use code from the default base.bbclass this should be done with inheritance and not copying. Getting a copy is exactly how we got broken listtasks in the first place. Henning > >> I really don't like the idea to drop debug capabilities only > >> because they are not used at the moment. If this interface is > >> going to be dropped, then we need to introduce new interface > >> before. > > > > Like Isar was used by anyone or this was anything like a tiny > > broken print function.... without users or a release who cares about > > interfaces? But keep it like the bugs in ext4! > > In my previous comment I mentioned, that bbdebug should be fixed. > > > > > Can we please start dicsussing the real patches? > > This discussion relates to real patch. > > >>>>>> I think it makes sense to keep it to debug complicated classes > >>>>>> and recipes in future. > >>>>> > >>>>> Ok. > >>>>> > >>>>> Henning > >>>>> > >>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild > >>>>>> : > >>>>>> > >>>>>>> Signed-off-by: Henning Schild > >>>>>>> --- > >>>>>>> meta/classes/isar-base.bbclass | 12 ------------ > >>>>>>> 1 file changed, 12 deletions(-) > >>>>>>> > >>>>>>> diff --git a/meta/classes/isar-base.bbclass > >>>>>>> b/meta/classes/isar-base. bbclass > >>>>>>> index 67d38a1..efd4223 100644 > >>>>>>> --- a/meta/classes/isar-base.bbclass > >>>>>>> +++ b/meta/classes/isar-base.bbclass > >>>>>>> @@ -21,16 +21,4 @@ > >>>>>>> > >>>>>>> THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" > >>>>>>> > >>>>>>> -bbdebug() { > >>>>>>> - test $# -ge 2 || { > >>>>>>> - echo "Usage: bbdebug level \"message\"" > >>>>>>> - exit 1 > >>>>>>> - } > >>>>>>> - > >>>>>>> - test ${@bb.msg.debug_level['default']} -ge $1 && { > >>>>>>> - shift > >>>>>>> - echo "DEBUG:" $* > >>>>>>> - } > >>>>>>> -} > >>>>>>> - > >>>>>>> do_build[nostamp] = "0" > >>>>>>> -- > >>>>>>> 2.13.0 > >>>>>>> > >>>>>>> > >>>>> > >>>>> > >>> > >> > > >