From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6450128683656019968 X-Received: by 10.46.83.27 with SMTP id h27mr473551ljb.35.1502203654593; Tue, 08 Aug 2017 07:47:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.80.12 with SMTP id e12ls724281ljb.32.gmail; Tue, 08 Aug 2017 07:47:34 -0700 (PDT) X-Received: by 10.46.74.1 with SMTP id x1mr473230lja.24.1502203654221; Tue, 08 Aug 2017 07:47:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502203654; cv=none; d=google.com; s=arc-20160816; b=Ou5tSXB+qULBo8FQ38gPmjxOaU4R2fm2IlvjNyM6QBnaZ1ZZuU8T5wjsCvkQOZ3Axx 5fk2MTheUjjWvq/XMRXtAzzgIIwYfsRNd9tA3uGeQyOKIurcqkHCWIvYI8k14FqAU6Y6 Bqr6z4Jkqjz8H6DW18UbjNYbtSCECM19qIOvpzEFxoFZoFmTKKj7bk4hEmq+VyifKYRp qE+kVLd6vljFmZI552ybqDkwILFNFv8i3bJ/k3GTT6mHrur4as1MvEKfaUGGFAmL7fNZ 314D3xUok6lh3W20cYgcy9Vn50C0rELnePgI/ZgIYKcMVxn1ZHc5vXLiAQI/DkoeGnqr 9jMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=vIZHeUVapGsLYDOpu9vDSaIAD/1a2oXEhpvzZHxmmXo=; b=HbrfNJp1SwENH4um62kms7oOQbjdNY9QRT6T+tcKeVQAvWFl3R2ffKup5hbe3jMMw+ jxsU/uNBBgV0SBQ+kdKGLuXqmGakGVYXH/WKAW/O/dFLhFfxo9ryY1FGW0bg8q1h+EAL CnOepPIRvSazKB+JEbd5Qr5pJ6luxIN9y6O8Kad4K0zZ9pbnpYiQmhEoAcoxLhPNq8Vb ELA00kAdsn2Dnf4iYlqB+RSKkKaF7r6KrmIKbqpmqIMxNH+YIOp1vY491lA4mioCyV6p zMgoMvDQ+SDm4FpIe1PiGSM7BA8OGTKlWq9+DcwRLf6aINPKSmqiPlZ/Gq9NxSy41/SK +4/g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id x7si460347wmf.8.2017.08.08.07.47.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 07:47:34 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v78ElX4u030627 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Aug 2017 16:47:33 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v78ElX8Q008720; Tue, 8 Aug 2017 16:47:33 +0200 Date: Tue, 8 Aug 2017 16:49:30 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 11-16 of 16 v2 1/6] meta: dpkg rename install to package_write_deb Message-ID: <20170808164930.22ef5a22@md1em3qc> In-Reply-To: References: X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: JSiQss0vfLTL Am Tue, 8 Aug 2017 16:06:11 +0300 schrieb Alexander Smirnov : > 2017-08-03 22:15 GMT+03:00 Henning Schild > : > > > This way we stay with OE names. The name "install" will be used to > > populate ${D} in a later patch, also in line with OE. > > > > Signed-off-by: Henning Schild > > --- > > meta/classes/dpkg.bbclass | 9 ++++----- > > meta/classes/image.bbclass | 2 +- > > 2 files changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > > index ca0c5ab..97238b5 100644 > > --- a/meta/classes/dpkg.bbclass > > +++ b/meta/classes/dpkg.bbclass > > @@ -23,12 +23,11 @@ do_build() { > > sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} > > } > > > > - > > # Install package to dedicated deploy directory > > -do_install() { > > +do_package_write_deb() { > > > > Why it's 'package_write_deb'? If we speak about 'like-OE' style, in > OE this function does (NOTE: I provide links to GitHub because they > have line numbering): > > 1. package_write_deb: > https://github.com/MentorEmbedded/poky/blob/master/meta/classes/package_deb.bbclass#L342 > > 2. It calls package_deb: > https://github.com/MentorEmbedded/poky/blob/master/meta/classes/package_deb.bbclass#L51 > > So this function performs creating of deb package from built binaries. > > > In general it's quite difficult to map Isar package building process > to OE (some tasks like 'patch' are missed due to no meaning in this > context): > > 1. Isar: fetch -> unpack -> (!) build (using dpkg) > > 2. OE: fetch -> unpack -> (!) configure -> compile -> install -> > package_write_deb > > So all the tasks after (!) in OE are done in single task in Isar. > That's one of the Isar main difference from OE, that package building > is performed by native Debian tools and this process can't be > break-down and one-to-one mapped to OE tasks. > > Regarding the function in patch, this is defenitely install and not > package write, but we can specify what kind of install, for example: > install_to_deploy, or populate_apt or etc... http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html#ref-tasks-package_write_deb Yes they also build the package in that step. But after that step a .deb is in DEPLOY_DEB_DIR. Henning > Alex > > > > install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/ > > } > > > > -addtask install after do_build > > -do_install[dirs] = "${DEPLOY_DIR_DEB}" > > -do_install[stamp-extra-info] = "${MACHINE}" > > +addtask package_write_deb after do_build > > +do_package_write_deb[dirs] = "${DEPLOY_DIR_DEB}" > > +do_package_write_deb[stamp-extra-info] = "${MACHINE}" > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > > index 3e4877c..f60ec11 100644 > > --- a/meta/classes/image.bbclass > > +++ b/meta/classes/image.bbclass > > @@ -27,4 +27,4 @@ do_populate() { > > } > > > > addtask populate before do_build > > -do_populate[deptask] = "do_install" > > +do_populate[deptask] = "do_package_write_deb" > > -- > > 2.13.0 > > > >