Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 21 Aug 2017 15:25:39 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Thu, Aug 03, 2017 at 01:55:53PM +0200, Henning Schild wrote:
> > force isar to always use a bitbake.conf from its bitbake
> > the diff went into a file that needs to be looked at later  
> 
> Applied with comment amendments, thanks.

Ok.

> Alex has updated the commit comment to reflect also the motivation
> for the change. In the commit comment, please use complete sentences
> (first cap, period at the end).

Yes i have seen that.

> We had considered the split configuration in the beginning and have
> seen that 1. Yocto forks it, and 2. bitbake doesn't seem to support
> reading both by itself. These were the reasons why we also forked the
> file.
> 
> (1) might be caused by the fact that there are no major bitbake users
> except Yocto, so both are possibly not clearly separated. The
> separation has value for Isar, since it clearly shows what is
> different, that is why I've applied the patch.
> 
> (2) is worse, as IMHO, bitbake should do that itself and it doesn't
> (https://github.com/ilbers/isar/issues/27). Concatenating configs is
> magic that Yocto users do not expect, and this has to be documented.
> Could you provide a patch for the manual?

No. You do not apply a patch directly to master if that creates an
issue, you could have asked me for a v3 instead. Please revert or
provide the patch to the manual yourself.

Henning

> With kind regards,
> Baurzhan.
>