Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Baurzhan Ismagulov <ibr@radix50.net>]

On Tue, Aug 08, 2017 at 04:21:37PM +0200, Henning Schild wrote:
> To be able to update bitbake without using copied parts of the old
> bitbake. If we use code from the default base.bbclass this should be
> done with inheritance and not copying.

In general, I agree with the approach.

In practice, bitbake interfaces are not stable. This means that one generally
can't update bitbake version without thorough testing. We have to work with
upstream regarding this.


> > > Like Isar was used by anyone or this was anything like a tiny
> > > broken print function.... without users or a release who cares about
> > > interfaces?

We started 2004 from a single shell script. There is actually working code
using a newer bitbake version, where this verbatim bbdebug() works. That code
is proprietary; we decided not to publish it as is and instead merge features
from it into a new code base, Isar. This verbatim base.class comes from that
original code base. Not all features have been migrated yet; e.g., building
from .dsc files is pending -- FWIW, due to changed bitbake API. And yes, there
are users of Isar, as well as releases 0.1 and 0.2.

I've applied the patch because bbdebug() was broken in Isar as it was. That
said, I also don't like removing code without introducing a replacement.
Providing debugging infrastructure to users, however small, is important for
lowering the entry barrier. When we update bitbake, we should also take the
logging functionality.


> But keep it like the bugs in ext4!  
> > > 
> > > Can we please start dicsussing the real patches?  

Let's remain factual, respect others' work and use appropriate language / tone.


With kind regards,
Baurzhan.