From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.28.63.199 with SMTP id m190mr1912104wma.0.1503356714967; Mon, 21 Aug 2017 16:05:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.211.210 with SMTP id k201ls273522wmg.25.gmail; Mon, 21 Aug 2017 16:05:14 -0700 (PDT) X-Received: by 10.28.214.84 with SMTP id n81mr1897568wmg.29.1503356714566; Mon, 21 Aug 2017 16:05:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503356714; cv=none; d=google.com; s=arc-20160816; b=Hho0W2m8H5GugYHTSDFBTtu/VpqGaQos/9Spasnvf2JHLHLOXJfAYiES11hucx3CXy DIUJ9oSD2jzVxNoXwbt/ilxpKL99gORWeG6HJr9fUtBs9SoToOr0Ebvlrr4NedWGsoX6 vSl9xgxkQ6diWhl0tOyXACXJiloUt5L+bebmPM6Qu1CO9Qw5X58DJkSVwoXIBUWtOncj HN3aKugOkZGGlPnOeLG6RWaezTaQDD442lwJfnhpzAlWVtlCW8Y2t+KE27yGZmIMtMjt pNOjQ442TGB0DXk6xxZL2XOD3mzpPmxx9VerOJX7mJkQ/g9IXOiSHKqjrXjN2xwg6CFD EwmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date :arc-authentication-results; bh=2MjBl1e8Ydh8AVoqsRPYJsU83FEF9LpoCSe1RPA47EA=; b=lF32tTtOM7f806uaCQ3eqz5zqOBSWnaZoiRQJJ0K0oq5l+qSuuYIB3uw1TA5hYE2U8 kolgfHnPEJl4hyIQKYkaZM7o7KMvBPcS8AhzxDVBUhGrSA1WirOyNpozSjan00GD8MwS sQeZ8bdNBl4pqTfGElY5CI+CBmnM3cb7tU6K9EdPaXOnyvTQ5QjavXsKFkeV7kmlowG+ Ng/ooxJIo2xzB/XxIr4vQr+3+pnxYtH7pNsmxFfbErF/Eo6dM+47zSyS5stFD+iHcygA xghWG0/uHeYdDKFf5wbMOiimKdvvqPowEYS+oahajp+2sLF0vtkhsiK1Xgp4gVmUb9N+ Er1A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id 187si2958901wmj.0.2017.08.21.16.05.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Aug 2017 16:05:14 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.radix50.net (dslb-088-067-177-003.088.067.pools.vodafone-ip.de [88.67.177.3]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v7LN5CVO010566 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 22 Aug 2017 01:05:13 +0200 Received: from yssyq.radix50.net (localhost [127.0.0.1]) by yssyq.radix50.net (8.14.4/8.14.4/Debian-8) with ESMTP id v7LN56ZS013519 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 22 Aug 2017 01:05:06 +0200 Received: (from ibr@localhost) by yssyq.radix50.net (8.14.4/8.14.4/Submit) id v7LN56Rs013518 for isar-users@googlegroups.com; Tue, 22 Aug 2017 01:05:06 +0200 Date: Tue, 22 Aug 2017 01:05:06 +0200 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function Message-ID: <20170821230506.GJ3711@yssyq.radix50.net> Mail-Followup-To: isar-users@googlegroups.com References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> <20170808140809.1636322c@md1em3qc> <55765622-5df2-3353-2326-7f3d66a0e57e@ilbers.de> <20170808151247.40b2f573@md1em3qc> <187ded0d-5751-3267-e321-4258f77e8557@ilbers.de> <20170808162137.1ea80448@md1em3qc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170808162137.1ea80448@md1em3qc> User-Agent: Mutt/1.5.23 (2014-03-12) X-TUID: OT7UrSzZLz2Q On Tue, Aug 08, 2017 at 04:21:37PM +0200, Henning Schild wrote: > To be able to update bitbake without using copied parts of the old > bitbake. If we use code from the default base.bbclass this should be > done with inheritance and not copying. In general, I agree with the approach. In practice, bitbake interfaces are not stable. This means that one generally can't update bitbake version without thorough testing. We have to work with upstream regarding this. > > > Like Isar was used by anyone or this was anything like a tiny > > > broken print function.... without users or a release who cares about > > > interfaces? We started 2004 from a single shell script. There is actually working code using a newer bitbake version, where this verbatim bbdebug() works. That code is proprietary; we decided not to publish it as is and instead merge features from it into a new code base, Isar. This verbatim base.class comes from that original code base. Not all features have been migrated yet; e.g., building from .dsc files is pending -- FWIW, due to changed bitbake API. And yes, there are users of Isar, as well as releases 0.1 and 0.2. I've applied the patch because bbdebug() was broken in Isar as it was. That said, I also don't like removing code without introducing a replacement. Providing debugging infrastructure to users, however small, is important for lowering the entry barrier. When we update bitbake, we should also take the logging functionality. > But keep it like the bugs in ext4! > > > > > > Can we please start dicsussing the real patches? Let's remain factual, respect others' work and use appropriate language / tone. With kind regards, Baurzhan.