public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes
Date: Tue, 22 Aug 2017 14:45:28 +0200	[thread overview]
Message-ID: <20170822144528.37e1cf5e@md1em3qc> (raw)
In-Reply-To: <20170822113129.GF4244@yssyq.radix50.net>

Am Tue, 22 Aug 2017 13:31:29 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Mon, Aug 21, 2017 at 08:29:40PM +0200, Henning Schild wrote:
> > > (2) is worse, as IMHO, bitbake should do that itself and it
> > > doesn't (https://github.com/ilbers/isar/issues/27). Concatenating
> > > configs is magic that Yocto users do not expect, and this has to
> > > be documented. Could you provide a patch for the manual?  
> > 
> > No. You do not apply a patch directly to master if that creates an
> > issue, you could have asked me for a v3 instead. Please revert or
> > provide the patch to the manual yourself.  
> 
> In general, this is our intended approach (although in this
> particular case I'd still not block the inclusion of a patch that has
> value for the project by a required bitbake change upstream -- but
> that is a different story). Our current focus is to work together to
> improve Isar and process the patch backlog -- which I thought you
> agreed with Alex on phone. If this doesn't help you and you prefer
> the other model -- let's do it that way, it will only save my time.

We agreed that he would change my patches to save me the time to rebase
and change them. I asked him to add his signed-off to all patches he
actually modifies. 
After that offer i did not hear back about remaining issues, so i
assumed they all got fixed on your side. And now "my commits" are the
cause for issues ... If you see the issue coming you should bring it up
in the review and not after applying the patch.

I further assumed that any such patch would naturally be published for
review again, which did not happen or at least the comments where
ignored.

Henning

> With kind regards,
> Baurzhan.
> 


  reply	other threads:[~2017-08-22 12:45 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 11:55 [PATCH 0-10 of 16 v2 0/8] splitting the previous q Henning Schild
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake Henning Schild
2017-08-07 16:27   ` Alexander Smirnov
2017-08-08  8:52     ` Henning Schild
2017-08-08  9:39       ` Alexander Smirnov
2017-08-09 13:15         ` Henning Schild
2017-08-08 11:40       ` Jan Kiszka
2017-08-07 19:18   ` Alexander Smirnov
2017-08-08  8:43     ` Henning Schild
2017-08-08 14:02       ` Alexander Smirnov
2017-08-08 14:15         ` Henning Schild
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function Henning Schild
2017-08-07 19:36   ` Alexander Smirnov
2017-08-08  8:05     ` Henning Schild
2017-08-08  9:33       ` Alexander Smirnov
2017-08-08 12:08         ` Henning Schild
2017-08-08 12:29           ` Alexander Smirnov
2017-08-08 13:12             ` Henning Schild
2017-08-08 13:24               ` Alexander Smirnov
2017-08-08 14:21                 ` Henning Schild
2017-08-21 23:05                   ` Baurzhan Ismagulov
2017-08-08 13:47               ` Alexander Smirnov
2017-08-08 14:17                 ` Henning Schild
2017-08-21 22:26   ` Baurzhan Ismagulov
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 3/8] remove redundant variable THISDIR Henning Schild
2017-08-07 19:30   ` Alexander Smirnov
2017-08-08  8:02     ` Henning Schild
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes Henning Schild
2017-08-07 19:37   ` Alexander Smirnov
2017-08-21 13:25   ` Baurzhan Ismagulov
2017-08-21 18:29     ` Henning Schild
2017-08-22 11:31       ` Baurzhan Ismagulov
2017-08-22 12:45         ` Henning Schild [this message]
2017-08-22 15:31           ` Baurzhan Ismagulov
2017-08-22 18:55             ` Henning Schild
2017-08-23 11:31               ` Baurzhan Ismagulov
2017-08-23 11:46                 ` Henning Schild
2017-08-27 23:46                   ` Baurzhan Ismagulov
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 5/8] meta: conf: clean up local bitbake config Henning Schild
2017-08-07 19:37   ` Alexander Smirnov
2017-08-21 19:55   ` Baurzhan Ismagulov
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base Henning Schild
2017-08-07 19:40   ` Alexander Smirnov
2017-08-08  8:00     ` Henning Schild
2017-08-08  9:30       ` Alexander Smirnov
2017-08-08 12:01         ` Henning Schild
2017-08-21 20:27           ` Baurzhan Ismagulov
2017-08-22  8:19             ` Henning Schild
2017-08-22 10:18               ` Baurzhan Ismagulov
2017-08-22 10:44                 ` Henning Schild
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 7/8] meta: dpdk use [dirs] directive instead of mkdir Henning Schild
2017-08-07 19:41   ` Alexander Smirnov
2017-08-21 20:33   ` Baurzhan Ismagulov
2017-08-03 11:55 ` [PATCH 0-10 of 16 v2 8/8] meta: dpkg: reorder and rename do_install to install in addtask Henning Schild
2017-08-07 19:41   ` Alexander Smirnov
2017-08-21 20:42   ` Baurzhan Ismagulov
2017-08-07 19:44 ` [PATCH 0-10 of 16 v2 0/8] splitting the previous q Alexander Smirnov
2017-08-08  8:45   ` Henning Schild
2017-08-08  9:43     ` Alexander Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170822144528.37e1cf5e@md1em3qc \
    --to=henning.schild@siemens.com \
    --cc=ibr@radix50.net \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox