[PATCH 0-10 of 16 v2 0/8] splitting the previous q

[PATCH 0-10 of 16 v2 0/8] splitting the previous q

[Henning Schild]

Since the first q was pretty long with 16 patches and some of the later ones
still need to be dicsussed in more detail, i decided to split the q and send
the less controversial stuff first.

Changes to V1:

- dropped 01/16 from v1
  - ext4 is not on the wic path, it can keep its obvious bugs
- 02/16 is 1v2, added copyright header
- 03/16 is 2v2, keep it seperate after all (logical vs. structural)
- 04/16 is 3v2, do not touch bitbake anymore
- 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license header
- 06/16 is 5v2, keep it seperate after all (logical vs. structural)
- 07/16 dropped
- 08/16 is 6v2, no image-class anymore, update comment
- 09/16 is 7v2, nothing changed
- 10/16 is 8v2, updated comment


Henning Schild (8):
  meta: classes: use base.bbclass from bitbake
  meta: isar-base: remove unused function
  remove redundant variable THISDIR
  meta: conf: use bitbake.conf from bitbake and apply local changes
  meta: conf: clean up local bitbake config
  classes: move fetch and unpack into isar-base
  meta: dpdk use [dirs] directive instead of mkdir
  meta: dpkg: reorder and rename do_install to install in addtask

 meta-isar/recipes-core/images/isar-image-base.bb |  8 +--
 meta/classes/base.bbclass                        | 81 +-----------------------
 meta/classes/dpkg.bbclass                        | 46 ++------------
 meta/classes/ext4-img.bbclass                    |  2 +
 meta/classes/isar-base.bbclass                   | 55 ++++++++++++++++
 meta/conf/bitbake.conf.sample                    | 68 --------------------
 meta/conf/isar-bitbake.conf                      | 31 +++++++++
 meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +--
 scripts/isar-setup-builddir                      | 33 ++++++++--
 9 files changed, 134 insertions(+), 200 deletions(-)
 mode change 100644 => 120000 meta/classes/base.bbclass
 create mode 100644 meta/classes/isar-base.bbclass
 delete mode 100644 meta/conf/bitbake.conf.sample
 create mode 100644 meta/conf/isar-bitbake.conf

-- 
2.13.0

[PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Henning Schild]

Do not use our own copy of that class and move local deviations into
isar-base. That also fixes the default tasks "showdata" and "listtasks",
which probably never worked.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/base.bbclass      | 81 +-----------------------------------------
 meta/classes/dpkg.bbclass      |  2 ++
 meta/classes/ext4-img.bbclass  |  2 ++
 meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
 4 files changed, 41 insertions(+), 80 deletions(-)
 mode change 100644 => 120000 meta/classes/base.bbclass
 create mode 100644 meta/classes/isar-base.bbclass

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
deleted file mode 100644
index 48b6bac..0000000
--- a/meta/classes/base.bbclass
+++ /dev/null
@@ -1,80 +0,0 @@
-# Copyright (C) 2003  Chris Larson
-#
-# Permission is hereby granted, free of charge, to any person obtaining a
-# copy of this software and associated documentation files (the "Software"),
-# to deal in the Software without restriction, including without limitation
-# the rights to use, copy, modify, merge, publish, distribute, sublicense,
-# and/or sell copies of the Software, and to permit persons to whom the
-# Software is furnished to do so, subject to the following conditions:
-#
-# The above copyright notice and this permission notice shall be included
-# in all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
-# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
-# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
-# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
-# OTHER DEALINGS IN THE SOFTWARE.
-
-THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
-
-die() {
-	bbfatal "$*"
-}
-
-bbnote() {
-	echo "NOTE:" "$*"
-}
-
-bbwarn() {
-	echo "WARNING:" "$*"
-}
-
-bbfatal() {
-	echo "FATAL:" "$*"
-	exit 1
-}
-
-bbdebug() {
-	test $# -ge 2 || {
-		echo "Usage: bbdebug level \"message\""
-		exit 1
-	}
-
-	test ${@bb.msg.debug_level['default']} -ge $1 && {
-		shift
-		echo "DEBUG:" $*
-	}
-}
-
-addtask showdata
-do_showdata[nostamp] = "1"
-python do_showdata() {
-	import sys
-	# emit variables and shell functions
-	bb.data.emit_env(sys.__stdout__, d, True)
-	# emit the metadata which isnt valid shell
-	for e in bb.data.keys(d):
-		if bb.data.getVarFlag(e, 'python', d):
-			sys.__stdout__.write("\npython %s () {\n%s}\n" % (e, bb.data.getVar(e, d, 1)))
-}
-
-addtask listtasks
-do_listtasks[nostamp] = "1"
-python do_listtasks() {
-	import sys
-	for e in bb.data.keys(d):
-		if bb.data.getVarFlag(e, 'task', d):
-			sys.__stdout__.write("%s\n" % e)
-}
-
-addtask build
-do_build[dirs] = "${TOPDIR}"
-python base_do_build () {
-	bb.note("The included, default BB base.bbclass does not define a useful default task.")
-	bb.note("Try running the 'listtasks' task against a .bb to see what tasks are defined.")
-}
-
-EXPORT_FUNCTIONS do_clean do_mrproper do_build
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
new file mode 120000
index 0000000..11fe0a4
--- /dev/null
+++ b/meta/classes/base.bbclass
@@ -0,0 +1 @@
+../../bitbake/classes/base.bbclass
\ No newline at end of file
diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index a0446d7..3d7aafb 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -1,6 +1,8 @@
 # This software is a part of ISAR.
 # Copyright (C) 2015-2016 ilbers GmbH
 
+inherit isar-base
+
 # Add dependency from buildchroot creation
 DEPENDS += "buildchroot"
 do_unpack[deptask] = "do_build"
diff --git a/meta/classes/ext4-img.bbclass b/meta/classes/ext4-img.bbclass
index 65d4c11..1486c3e 100644
--- a/meta/classes/ext4-img.bbclass
+++ b/meta/classes/ext4-img.bbclass
@@ -1,6 +1,8 @@
 # This software is a part of ISAR.
 # Copyright (C) 2015-2016 ilbers GmbH
 
+inherit isar-base
+
 # Extra space for rootfs in MB
 ROOTFS_EXTRA ?= "64"
 
diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.bbclass
new file mode 100644
index 0000000..67d38a1
--- /dev/null
+++ b/meta/classes/isar-base.bbclass
@@ -0,0 +1,36 @@
+# This software is a part of ISAR.
+# Copyright (C) 2017  Siemens AG
+#
+# Permission is hereby granted, free of charge, to any person obtaining a
+# copy of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom the
+# Software is furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+# OTHER DEALINGS IN THE SOFTWARE.
+
+THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
+
+bbdebug() {
+	test $# -ge 2 || {
+		echo "Usage: bbdebug level \"message\""
+		exit 1
+	}
+
+	test ${@bb.msg.debug_level['default']} -ge $1 && {
+		shift
+		echo "DEBUG:" $*
+	}
+}
+
+do_build[nostamp] = "0"
-- 
2.13.0

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 7576 bytes --]

Hi Henning,

thank you for the series! I'm trying to build Isar with your patches but
got an error:

ERROR: buildchroot-1.0-r0 do_build: Build of do_build failed
ERROR: buildchroot-1.0-r0 do_build: Traceback (most recent call last):
  File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py", line
388, in expandWithRefs
    s = __expand_python_regexp__.sub(varparse.python_sub, s)
  File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py", line
138, in python_sub
    value = utils.better_eval(codeobj, DataContext(self.d), {'d' : self.d})


  File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/utils.py", line 424,
in better_eval

    return eval(source, ctx, locals)


  File "FILESDIR", line 1, in <module>


AttributeError: 'module' object has no attribute 'which'



The above exception was the direct cause of the following exception:
...

>From the internet I got that this problem caused by old python which doesn
have 'which' method in 'module' object.
Which python version do you use? My version is python 3.4.2 - this is
standard one for Debian-8.

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Do not use our own copy of that class and move local deviations into
> isar-base. That also fixes the default tasks "showdata" and "listtasks",
> which probably never worked.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/base.bbclass      | 81 +-----------------------------
> ------------
>  meta/classes/dpkg.bbclass      |  2 ++
>  meta/classes/ext4-img.bbclass  |  2 ++
>  meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
>  4 files changed, 41 insertions(+), 80 deletions(-)
>  mode change 100644 => 120000 meta/classes/base.bbclass
>  create mode 100644 meta/classes/isar-base.bbclass
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> deleted file mode 100644
> index 48b6bac..0000000
> --- a/meta/classes/base.bbclass
> +++ /dev/null
> @@ -1,80 +0,0 @@
> -# Copyright (C) 2003  Chris Larson
> -#
> -# Permission is hereby granted, free of charge, to any person obtaining a
> -# copy of this software and associated documentation files (the
> "Software"),
> -# to deal in the Software without restriction, including without
> limitation
> -# the rights to use, copy, modify, merge, publish, distribute, sublicense,
> -# and/or sell copies of the Software, and to permit persons to whom the
> -# Software is furnished to do so, subject to the following conditions:
> -#
> -# The above copyright notice and this permission notice shall be included
> -# in all copies or substantial portions of the Software.
> -#
> -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR
> -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> -# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> -# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> -# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> -# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> -# OTHER DEALINGS IN THE SOFTWARE.
> -
> -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> -
> -die() {
> -       bbfatal "$*"
> -}
> -
> -bbnote() {
> -       echo "NOTE:" "$*"
> -}
> -
> -bbwarn() {
> -       echo "WARNING:" "$*"
> -}
> -
> -bbfatal() {
> -       echo "FATAL:" "$*"
> -       exit 1
> -}
> -
> -bbdebug() {
> -       test $# -ge 2 || {
> -               echo "Usage: bbdebug level \"message\""
> -               exit 1
> -       }
> -
> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> -               shift
> -               echo "DEBUG:" $*
> -       }
> -}
> -
> -addtask showdata
> -do_showdata[nostamp] = "1"
> -python do_showdata() {
> -       import sys
> -       # emit variables and shell functions
> -       bb.data.emit_env(sys.__stdout__, d, True)
> -       # emit the metadata which isnt valid shell
> -       for e in bb.data.keys(d):
> -               if bb.data.getVarFlag(e, 'python', d):
> -                       sys.__stdout__.write("\npython %s () {\n%s}\n" %
> (e, bb.data.getVar(e, d, 1)))
> -}
> -
> -addtask listtasks
> -do_listtasks[nostamp] = "1"
> -python do_listtasks() {
> -       import sys
> -       for e in bb.data.keys(d):
> -               if bb.data.getVarFlag(e, 'task', d):
> -                       sys.__stdout__.write("%s\n" % e)
> -}
> -
> -addtask build
> -do_build[dirs] = "${TOPDIR}"
> -python base_do_build () {
> -       bb.note("The included, default BB base.bbclass does not define a
> useful default task.")
> -       bb.note("Try running the 'listtasks' task against a .bb to see
> what tasks are defined.")
> -}
> -
> -EXPORT_FUNCTIONS do_clean do_mrproper do_build
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> new file mode 120000
> index 0000000..11fe0a4
> --- /dev/null
> +++ b/meta/classes/base.bbclass
> @@ -0,0 +1 @@
> +../../bitbake/classes/base.bbclass
> \ No newline at end of file
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index a0446d7..3d7aafb 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -1,6 +1,8 @@
>  # This software is a part of ISAR.
>  # Copyright (C) 2015-2016 ilbers GmbH
>
> +inherit isar-base
> +
>  # Add dependency from buildchroot creation
>  DEPENDS += "buildchroot"
>  do_unpack[deptask] = "do_build"
> diff --git a/meta/classes/ext4-img.bbclass b/meta/classes/ext4-img.bbclass
> index 65d4c11..1486c3e 100644
> --- a/meta/classes/ext4-img.bbclass
> +++ b/meta/classes/ext4-img.bbclass
> @@ -1,6 +1,8 @@
>  # This software is a part of ISAR.
>  # Copyright (C) 2015-2016 ilbers GmbH
>
> +inherit isar-base
> +
>  # Extra space for rootfs in MB
>  ROOTFS_EXTRA ?= "64"
>
> diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.
> bbclass
> new file mode 100644
> index 0000000..67d38a1
> --- /dev/null
> +++ b/meta/classes/isar-base.bbclass
> @@ -0,0 +1,36 @@
> +# This software is a part of ISAR.
> +# Copyright (C) 2017  Siemens AG
> +#
> +# Permission is hereby granted, free of charge, to any person obtaining a
> +# copy of this software and associated documentation files (the
> "Software"),
> +# to deal in the Software without restriction, including without
> limitation
> +# the rights to use, copy, modify, merge, publish, distribute, sublicense,
> +# and/or sell copies of the Software, and to permit persons to whom the
> +# Software is furnished to do so, subject to the following conditions:
> +#
> +# The above copyright notice and this permission notice shall be included
> +# in all copies or substantial portions of the Software.
> +#
> +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR
> +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> +# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> +# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> +# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> +# OTHER DEALINGS IN THE SOFTWARE.
> +
> +THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> +
> +bbdebug() {
> +       test $# -ge 2 || {
> +               echo "Usage: bbdebug level \"message\""
> +               exit 1
> +       }
> +
> +       test ${@bb.msg.debug_level['default']} -ge $1 && {
> +               shift
> +               echo "DEBUG:" $*
> +       }
> +}
> +
> +do_build[nostamp] = "0"
> --
> 2.13.0
>
>

[-- Attachment #2: Type: text/html, Size: 10632 bytes --]

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Henning Schild]

Am Mon, 7 Aug 2017 19:27:43 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> Hi Henning,
> 
> thank you for the series! I'm trying to build Isar with your patches
> but got an error:

Thanks for merging some of the stuff!

> ERROR: buildchroot-1.0-r0 do_build: Build of do_build failed
> ERROR: buildchroot-1.0-r0 do_build: Traceback (most recent call last):
>   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py",
> line 388, in expandWithRefs
>     s = __expand_python_regexp__.sub(varparse.python_sub, s)
>   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py",
> line 138, in python_sub
>     value = utils.better_eval(codeobj, DataContext(self.d), {'d' :
> self.d})
> 
> 
>   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/utils.py", line
> 424, in better_eval
> 
>     return eval(source, ctx, locals)
> 
> 
>   File "FILESDIR", line 1, in <module>
> 
> 
> AttributeError: 'module' object has no attribute 'which'
> 
> 
> 
> The above exception was the direct cause of the following exception:
> ...
> 
> From the internet I got that this problem caused by old python which
> doesn have 'which' method in 'module' object.
> Which python version do you use? My version is python 3.4.2 - this is
> standard one for Debian-8.

I am using 3.4.2 in a Debian-8 container, it just contains a few
Debian-9 packages to fix multistrap host-leakage.
Docker: jankiszka/kas-isar/base

Maybe we build it differently? Could you try the unmodified q on master
as well?

Henning

> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Do not use our own copy of that class and move local deviations into
> > isar-base. That also fixes the default tasks "showdata" and
> > "listtasks", which probably never worked.
> >
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  meta/classes/base.bbclass      | 81 +-----------------------------
> > ------------
> >  meta/classes/dpkg.bbclass      |  2 ++
> >  meta/classes/ext4-img.bbclass  |  2 ++
> >  meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
> >  4 files changed, 41 insertions(+), 80 deletions(-)
> >  mode change 100644 => 120000 meta/classes/base.bbclass
> >  create mode 100644 meta/classes/isar-base.bbclass
> >
> > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > deleted file mode 100644
> > index 48b6bac..0000000
> > --- a/meta/classes/base.bbclass
> > +++ /dev/null
> > @@ -1,80 +0,0 @@
> > -# Copyright (C) 2003  Chris Larson
> > -#
> > -# Permission is hereby granted, free of charge, to any person
> > obtaining a -# copy of this software and associated documentation
> > files (the "Software"),
> > -# to deal in the Software without restriction, including without
> > limitation
> > -# the rights to use, copy, modify, merge, publish, distribute,
> > sublicense, -# and/or sell copies of the Software, and to permit
> > persons to whom the -# Software is furnished to do so, subject to
> > the following conditions: -#
> > -# The above copyright notice and this permission notice shall be
> > included -# in all copies or substantial portions of the Software.
> > -#
> > -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > EXPRESS OR
> > -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > MERCHANTABILITY, -# FITNESS FOR A PARTICULAR PURPOSE AND
> > NONINFRINGEMENT. IN NO EVENT SHALL -# THE AUTHORS OR COPYRIGHT
> > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR -# OTHER LIABILITY,
> > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, -# ARISING
> > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR -#
> > OTHER DEALINGS IN THE SOFTWARE. -
> > -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > -
> > -die() {
> > -       bbfatal "$*"
> > -}
> > -
> > -bbnote() {
> > -       echo "NOTE:" "$*"
> > -}
> > -
> > -bbwarn() {
> > -       echo "WARNING:" "$*"
> > -}
> > -
> > -bbfatal() {
> > -       echo "FATAL:" "$*"
> > -       exit 1
> > -}
> > -
> > -bbdebug() {
> > -       test $# -ge 2 || {
> > -               echo "Usage: bbdebug level \"message\""
> > -               exit 1
> > -       }
> > -
> > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > -               shift
> > -               echo "DEBUG:" $*
> > -       }
> > -}
> > -
> > -addtask showdata
> > -do_showdata[nostamp] = "1"
> > -python do_showdata() {
> > -       import sys
> > -       # emit variables and shell functions
> > -       bb.data.emit_env(sys.__stdout__, d, True)
> > -       # emit the metadata which isnt valid shell
> > -       for e in bb.data.keys(d):
> > -               if bb.data.getVarFlag(e, 'python', d):
> > -                       sys.__stdout__.write("\npython %s ()
> > {\n%s}\n" % (e, bb.data.getVar(e, d, 1)))
> > -}
> > -
> > -addtask listtasks
> > -do_listtasks[nostamp] = "1"
> > -python do_listtasks() {
> > -       import sys
> > -       for e in bb.data.keys(d):
> > -               if bb.data.getVarFlag(e, 'task', d):
> > -                       sys.__stdout__.write("%s\n" % e)
> > -}
> > -
> > -addtask build
> > -do_build[dirs] = "${TOPDIR}"
> > -python base_do_build () {
> > -       bb.note("The included, default BB base.bbclass does not
> > define a useful default task.")
> > -       bb.note("Try running the 'listtasks' task against a .bb to
> > see what tasks are defined.")
> > -}
> > -
> > -EXPORT_FUNCTIONS do_clean do_mrproper do_build
> > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > new file mode 120000
> > index 0000000..11fe0a4
> > --- /dev/null
> > +++ b/meta/classes/base.bbclass
> > @@ -0,0 +1 @@
> > +../../bitbake/classes/base.bbclass
> > \ No newline at end of file
> > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > index a0446d7..3d7aafb 100644
> > --- a/meta/classes/dpkg.bbclass
> > +++ b/meta/classes/dpkg.bbclass
> > @@ -1,6 +1,8 @@
> >  # This software is a part of ISAR.
> >  # Copyright (C) 2015-2016 ilbers GmbH
> >
> > +inherit isar-base
> > +
> >  # Add dependency from buildchroot creation
> >  DEPENDS += "buildchroot"
> >  do_unpack[deptask] = "do_build"
> > diff --git a/meta/classes/ext4-img.bbclass
> > b/meta/classes/ext4-img.bbclass index 65d4c11..1486c3e 100644
> > --- a/meta/classes/ext4-img.bbclass
> > +++ b/meta/classes/ext4-img.bbclass
> > @@ -1,6 +1,8 @@
> >  # This software is a part of ISAR.
> >  # Copyright (C) 2015-2016 ilbers GmbH
> >
> > +inherit isar-base
> > +
> >  # Extra space for rootfs in MB
> >  ROOTFS_EXTRA ?= "64"
> >
> > diff --git a/meta/classes/isar-base.bbclass
> > b/meta/classes/isar-base. bbclass
> > new file mode 100644
> > index 0000000..67d38a1
> > --- /dev/null
> > +++ b/meta/classes/isar-base.bbclass
> > @@ -0,0 +1,36 @@
> > +# This software is a part of ISAR.
> > +# Copyright (C) 2017  Siemens AG
> > +#
> > +# Permission is hereby granted, free of charge, to any person
> > obtaining a +# copy of this software and associated documentation
> > files (the "Software"),
> > +# to deal in the Software without restriction, including without
> > limitation
> > +# the rights to use, copy, modify, merge, publish, distribute,
> > sublicense, +# and/or sell copies of the Software, and to permit
> > persons to whom the +# Software is furnished to do so, subject to
> > the following conditions: +#
> > +# The above copyright notice and this permission notice shall be
> > included +# in all copies or substantial portions of the Software.
> > +#
> > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > EXPRESS OR
> > +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND
> > NONINFRINGEMENT. IN NO EVENT SHALL +# THE AUTHORS OR COPYRIGHT
> > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR +# OTHER LIABILITY,
> > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, +# ARISING
> > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +#
> > OTHER DEALINGS IN THE SOFTWARE. +
> > +THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > +
> > +bbdebug() {
> > +       test $# -ge 2 || {
> > +               echo "Usage: bbdebug level \"message\""
> > +               exit 1
> > +       }
> > +
> > +       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > +               shift
> > +               echo "DEBUG:" $*
> > +       }
> > +}
> > +
> > +do_build[nostamp] = "0"
> > --
> > 2.13.0
> >
> >  

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 9355 bytes --]

2017-08-08 11:52 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Am Mon, 7 Aug 2017 19:27:43 +0300
> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>
> > Hi Henning,
> >
> > thank you for the series! I'm trying to build Isar with your patches
> > but got an error:
>
> Thanks for merging some of the stuff!
>
> > ERROR: buildchroot-1.0-r0 do_build: Build of do_build failed
> > ERROR: buildchroot-1.0-r0 do_build: Traceback (most recent call last):
> >   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py",
> > line 388, in expandWithRefs
> >     s = __expand_python_regexp__.sub(varparse.python_sub, s)
> >   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py",
> > line 138, in python_sub
> >     value = utils.better_eval(codeobj, DataContext(self.d), {'d' :
> > self.d})
> >
> >
> >   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/utils.py", line
> > 424, in better_eval
> >
> >     return eval(source, ctx, locals)
> >
> >
> >   File "FILESDIR", line 1, in <module>
> >
> >
> > AttributeError: 'module' object has no attribute 'which'
> >
> >
> >
> > The above exception was the direct cause of the following exception:
> > ...
> >
> > From the internet I got that this problem caused by old python which
> > doesn have 'which' method in 'module' object.
> > Which python version do you use? My version is python 3.4.2 - this is
> > standard one for Debian-8.
>
> I am using 3.4.2 in a Debian-8 container, it just contains a few
> Debian-9 packages to fix multistrap host-leakage.
> Docker: jankiszka/kas-isar/base
>
> Maybe we build it differently? Could you try the unmodified q on master
> as well?
>

What I've tried:

1. I have clean Debian-8 in chroot with python 3.4.2 installed.
2. The current master at github.com works good.
3. The paster with your series applied (without any changes from my side) -
fails with the error mentioned in this mail.
4. To build I use the following command: bitbake
multiconfig:qemuarm-wheezy:isar-image-base

Could you please send the list of python plugins installed?

Alex


> > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > <henning.schild@siemens.com>:
> >
> > > Do not use our own copy of that class and move local deviations into
> > > isar-base. That also fixes the default tasks "showdata" and
> > > "listtasks", which probably never worked.
> > >
> > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > ---
> > >  meta/classes/base.bbclass      | 81 +-----------------------------
> > > ------------
> > >  meta/classes/dpkg.bbclass      |  2 ++
> > >  meta/classes/ext4-img.bbclass  |  2 ++
> > >  meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
> > >  4 files changed, 41 insertions(+), 80 deletions(-)
> > >  mode change 100644 => 120000 meta/classes/base.bbclass
> > >  create mode 100644 meta/classes/isar-base.bbclass
> > >
> > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > > deleted file mode 100644
> > > index 48b6bac..0000000
> > > --- a/meta/classes/base.bbclass
> > > +++ /dev/null
> > > @@ -1,80 +0,0 @@
> > > -# Copyright (C) 2003  Chris Larson
> > > -#
> > > -# Permission is hereby granted, free of charge, to any person
> > > obtaining a -# copy of this software and associated documentation
> > > files (the "Software"),
> > > -# to deal in the Software without restriction, including without
> > > limitation
> > > -# the rights to use, copy, modify, merge, publish, distribute,
> > > sublicense, -# and/or sell copies of the Software, and to permit
> > > persons to whom the -# Software is furnished to do so, subject to
> > > the following conditions: -#
> > > -# The above copyright notice and this permission notice shall be
> > > included -# in all copies or substantial portions of the Software.
> > > -#
> > > -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > > EXPRESS OR
> > > -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > MERCHANTABILITY, -# FITNESS FOR A PARTICULAR PURPOSE AND
> > > NONINFRINGEMENT. IN NO EVENT SHALL -# THE AUTHORS OR COPYRIGHT
> > > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR -# OTHER LIABILITY,
> > > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, -# ARISING
> > > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR -#
> > > OTHER DEALINGS IN THE SOFTWARE. -
> > > -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > -
> > > -die() {
> > > -       bbfatal "$*"
> > > -}
> > > -
> > > -bbnote() {
> > > -       echo "NOTE:" "$*"
> > > -}
> > > -
> > > -bbwarn() {
> > > -       echo "WARNING:" "$*"
> > > -}
> > > -
> > > -bbfatal() {
> > > -       echo "FATAL:" "$*"
> > > -       exit 1
> > > -}
> > > -
> > > -bbdebug() {
> > > -       test $# -ge 2 || {
> > > -               echo "Usage: bbdebug level \"message\""
> > > -               exit 1
> > > -       }
> > > -
> > > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > -               shift
> > > -               echo "DEBUG:" $*
> > > -       }
> > > -}
> > > -
> > > -addtask showdata
> > > -do_showdata[nostamp] = "1"
> > > -python do_showdata() {
> > > -       import sys
> > > -       # emit variables and shell functions
> > > -       bb.data.emit_env(sys.__stdout__, d, True)
> > > -       # emit the metadata which isnt valid shell
> > > -       for e in bb.data.keys(d):
> > > -               if bb.data.getVarFlag(e, 'python', d):
> > > -                       sys.__stdout__.write("\npython %s ()
> > > {\n%s}\n" % (e, bb.data.getVar(e, d, 1)))
> > > -}
> > > -
> > > -addtask listtasks
> > > -do_listtasks[nostamp] = "1"
> > > -python do_listtasks() {
> > > -       import sys
> > > -       for e in bb.data.keys(d):
> > > -               if bb.data.getVarFlag(e, 'task', d):
> > > -                       sys.__stdout__.write("%s\n" % e)
> > > -}
> > > -
> > > -addtask build
> > > -do_build[dirs] = "${TOPDIR}"
> > > -python base_do_build () {
> > > -       bb.note("The included, default BB base.bbclass does not
> > > define a useful default task.")
> > > -       bb.note("Try running the 'listtasks' task against a .bb to
> > > see what tasks are defined.")
> > > -}
> > > -
> > > -EXPORT_FUNCTIONS do_clean do_mrproper do_build
> > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > > new file mode 120000
> > > index 0000000..11fe0a4
> > > --- /dev/null
> > > +++ b/meta/classes/base.bbclass
> > > @@ -0,0 +1 @@
> > > +../../bitbake/classes/base.bbclass
> > > \ No newline at end of file
> > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > > index a0446d7..3d7aafb 100644
> > > --- a/meta/classes/dpkg.bbclass
> > > +++ b/meta/classes/dpkg.bbclass
> > > @@ -1,6 +1,8 @@
> > >  # This software is a part of ISAR.
> > >  # Copyright (C) 2015-2016 ilbers GmbH
> > >
> > > +inherit isar-base
> > > +
> > >  # Add dependency from buildchroot creation
> > >  DEPENDS += "buildchroot"
> > >  do_unpack[deptask] = "do_build"
> > > diff --git a/meta/classes/ext4-img.bbclass
> > > b/meta/classes/ext4-img.bbclass index 65d4c11..1486c3e 100644
> > > --- a/meta/classes/ext4-img.bbclass
> > > +++ b/meta/classes/ext4-img.bbclass
> > > @@ -1,6 +1,8 @@
> > >  # This software is a part of ISAR.
> > >  # Copyright (C) 2015-2016 ilbers GmbH
> > >
> > > +inherit isar-base
> > > +
> > >  # Extra space for rootfs in MB
> > >  ROOTFS_EXTRA ?= "64"
> > >
> > > diff --git a/meta/classes/isar-base.bbclass
> > > b/meta/classes/isar-base. bbclass
> > > new file mode 100644
> > > index 0000000..67d38a1
> > > --- /dev/null
> > > +++ b/meta/classes/isar-base.bbclass
> > > @@ -0,0 +1,36 @@
> > > +# This software is a part of ISAR.
> > > +# Copyright (C) 2017  Siemens AG
> > > +#
> > > +# Permission is hereby granted, free of charge, to any person
> > > obtaining a +# copy of this software and associated documentation
> > > files (the "Software"),
> > > +# to deal in the Software without restriction, including without
> > > limitation
> > > +# the rights to use, copy, modify, merge, publish, distribute,
> > > sublicense, +# and/or sell copies of the Software, and to permit
> > > persons to whom the +# Software is furnished to do so, subject to
> > > the following conditions: +#
> > > +# The above copyright notice and this permission notice shall be
> > > included +# in all copies or substantial portions of the Software.
> > > +#
> > > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > > EXPRESS OR
> > > +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND
> > > NONINFRINGEMENT. IN NO EVENT SHALL +# THE AUTHORS OR COPYRIGHT
> > > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR +# OTHER LIABILITY,
> > > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, +# ARISING
> > > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +#
> > > OTHER DEALINGS IN THE SOFTWARE. +
> > > +THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > +
> > > +bbdebug() {
> > > +       test $# -ge 2 || {
> > > +               echo "Usage: bbdebug level \"message\""
> > > +               exit 1
> > > +       }
> > > +
> > > +       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > +               shift
> > > +               echo "DEBUG:" $*
> > > +       }
> > > +}
> > > +
> > > +do_build[nostamp] = "0"
> > > --
> > > 2.13.0
> > >
> > >
>
>

[-- Attachment #2: Type: text/html, Size: 13075 bytes --]

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Henning Schild]

Am Tue, 8 Aug 2017 12:39:47 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> 2017-08-08 11:52 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Am Mon, 7 Aug 2017 19:27:43 +0300
> > schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >  
> > > Hi Henning,
> > >
> > > thank you for the series! I'm trying to build Isar with your
> > > patches but got an error:  
> >
> > Thanks for merging some of the stuff!
> >  
> > > ERROR: buildchroot-1.0-r0 do_build: Build of do_build failed
> > > ERROR: buildchroot-1.0-r0 do_build: Traceback (most recent call
> > > last): File
> > > "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py",
> > > line 388, in expandWithRefs s =
> > > __expand_python_regexp__.sub(varparse.python_sub, s) File
> > > "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py",
> > > line 138, in python_sub value = utils.better_eval(codeobj,
> > > DataContext(self.d), {'d' : self.d})
> > >
> > >
> > >   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/utils.py",
> > > line 424, in better_eval
> > >
> > >     return eval(source, ctx, locals)
> > >
> > >
> > >   File "FILESDIR", line 1, in <module>
> > >
> > >
> > > AttributeError: 'module' object has no attribute 'which'
> > >
> > >
> > >
> > > The above exception was the direct cause of the following
> > > exception: ...
> > >
> > > From the internet I got that this problem caused by old python
> > > which doesn have 'which' method in 'module' object.
> > > Which python version do you use? My version is python 3.4.2 -
> > > this is standard one for Debian-8.  
> >
> > I am using 3.4.2 in a Debian-8 container, it just contains a few
> > Debian-9 packages to fix multistrap host-leakage.
> > Docker: jankiszka/kas-isar/base
> >
> > Maybe we build it differently? Could you try the unmodified q on
> > master as well?
> >  

Well it can not be connected to your python version. What should be
called is bb.utils.which and that is implemented in

bitabake/lib/bb/utils.py:914

And not anything from python core. I guess that python is fine and
something else is borked. Can you use any of the other bb.utils in a
simple task?

Henning

> What I've tried:
> 
> 1. I have clean Debian-8 in chroot with python 3.4.2 installed.
> 2. The current master at github.com works good.
> 3. The paster with your series applied (without any changes from my
> side) - fails with the error mentioned in this mail.
> 4. To build I use the following command: bitbake
> multiconfig:qemuarm-wheezy:isar-image-base
> 
> Could you please send the list of python plugins installed?
> 
> Alex
> 
> 
> > > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > > <henning.schild@siemens.com>:
> > >  
> > > > Do not use our own copy of that class and move local deviations
> > > > into isar-base. That also fixes the default tasks "showdata" and
> > > > "listtasks", which probably never worked.
> > > >
> > > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > > ---
> > > >  meta/classes/base.bbclass      | 81
> > > > +----------------------------- ------------
> > > >  meta/classes/dpkg.bbclass      |  2 ++
> > > >  meta/classes/ext4-img.bbclass  |  2 ++
> > > >  meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
> > > >  4 files changed, 41 insertions(+), 80 deletions(-)
> > > >  mode change 100644 => 120000 meta/classes/base.bbclass
> > > >  create mode 100644 meta/classes/isar-base.bbclass
> > > >
> > > > diff --git a/meta/classes/base.bbclass
> > > > b/meta/classes/base.bbclass deleted file mode 100644
> > > > index 48b6bac..0000000
> > > > --- a/meta/classes/base.bbclass
> > > > +++ /dev/null
> > > > @@ -1,80 +0,0 @@
> > > > -# Copyright (C) 2003  Chris Larson
> > > > -#
> > > > -# Permission is hereby granted, free of charge, to any person
> > > > obtaining a -# copy of this software and associated
> > > > documentation files (the "Software"),
> > > > -# to deal in the Software without restriction, including
> > > > without limitation
> > > > -# the rights to use, copy, modify, merge, publish, distribute,
> > > > sublicense, -# and/or sell copies of the Software, and to permit
> > > > persons to whom the -# Software is furnished to do so, subject
> > > > to the following conditions: -#
> > > > -# The above copyright notice and this permission notice shall
> > > > be included -# in all copies or substantial portions of the
> > > > Software. -#
> > > > -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
> > > > KIND, EXPRESS OR
> > > > -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > > MERCHANTABILITY, -# FITNESS FOR A PARTICULAR PURPOSE AND
> > > > NONINFRINGEMENT. IN NO EVENT SHALL -# THE AUTHORS OR COPYRIGHT
> > > > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR -# OTHER LIABILITY,
> > > > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, -# ARISING
> > > > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR -#
> > > > OTHER DEALINGS IN THE SOFTWARE. -
> > > > -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > > -
> > > > -die() {
> > > > -       bbfatal "$*"
> > > > -}
> > > > -
> > > > -bbnote() {
> > > > -       echo "NOTE:" "$*"
> > > > -}
> > > > -
> > > > -bbwarn() {
> > > > -       echo "WARNING:" "$*"
> > > > -}
> > > > -
> > > > -bbfatal() {
> > > > -       echo "FATAL:" "$*"
> > > > -       exit 1
> > > > -}
> > > > -
> > > > -bbdebug() {
> > > > -       test $# -ge 2 || {
> > > > -               echo "Usage: bbdebug level \"message\""
> > > > -               exit 1
> > > > -       }
> > > > -
> > > > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > > -               shift
> > > > -               echo "DEBUG:" $*
> > > > -       }
> > > > -}
> > > > -
> > > > -addtask showdata
> > > > -do_showdata[nostamp] = "1"
> > > > -python do_showdata() {
> > > > -       import sys
> > > > -       # emit variables and shell functions
> > > > -       bb.data.emit_env(sys.__stdout__, d, True)
> > > > -       # emit the metadata which isnt valid shell
> > > > -       for e in bb.data.keys(d):
> > > > -               if bb.data.getVarFlag(e, 'python', d):
> > > > -                       sys.__stdout__.write("\npython %s ()
> > > > {\n%s}\n" % (e, bb.data.getVar(e, d, 1)))
> > > > -}
> > > > -
> > > > -addtask listtasks
> > > > -do_listtasks[nostamp] = "1"
> > > > -python do_listtasks() {
> > > > -       import sys
> > > > -       for e in bb.data.keys(d):
> > > > -               if bb.data.getVarFlag(e, 'task', d):
> > > > -                       sys.__stdout__.write("%s\n" % e)
> > > > -}
> > > > -
> > > > -addtask build
> > > > -do_build[dirs] = "${TOPDIR}"
> > > > -python base_do_build () {
> > > > -       bb.note("The included, default BB base.bbclass does not
> > > > define a useful default task.")
> > > > -       bb.note("Try running the 'listtasks' task against a .bb
> > > > to see what tasks are defined.")
> > > > -}
> > > > -
> > > > -EXPORT_FUNCTIONS do_clean do_mrproper do_build
> > > > diff --git a/meta/classes/base.bbclass
> > > > b/meta/classes/base.bbclass new file mode 120000
> > > > index 0000000..11fe0a4
> > > > --- /dev/null
> > > > +++ b/meta/classes/base.bbclass
> > > > @@ -0,0 +1 @@
> > > > +../../bitbake/classes/base.bbclass
> > > > \ No newline at end of file
> > > > diff --git a/meta/classes/dpkg.bbclass
> > > > b/meta/classes/dpkg.bbclass index a0446d7..3d7aafb 100644
> > > > --- a/meta/classes/dpkg.bbclass
> > > > +++ b/meta/classes/dpkg.bbclass
> > > > @@ -1,6 +1,8 @@
> > > >  # This software is a part of ISAR.
> > > >  # Copyright (C) 2015-2016 ilbers GmbH
> > > >
> > > > +inherit isar-base
> > > > +
> > > >  # Add dependency from buildchroot creation
> > > >  DEPENDS += "buildchroot"
> > > >  do_unpack[deptask] = "do_build"
> > > > diff --git a/meta/classes/ext4-img.bbclass
> > > > b/meta/classes/ext4-img.bbclass index 65d4c11..1486c3e 100644
> > > > --- a/meta/classes/ext4-img.bbclass
> > > > +++ b/meta/classes/ext4-img.bbclass
> > > > @@ -1,6 +1,8 @@
> > > >  # This software is a part of ISAR.
> > > >  # Copyright (C) 2015-2016 ilbers GmbH
> > > >
> > > > +inherit isar-base
> > > > +
> > > >  # Extra space for rootfs in MB
> > > >  ROOTFS_EXTRA ?= "64"
> > > >
> > > > diff --git a/meta/classes/isar-base.bbclass
> > > > b/meta/classes/isar-base. bbclass
> > > > new file mode 100644
> > > > index 0000000..67d38a1
> > > > --- /dev/null
> > > > +++ b/meta/classes/isar-base.bbclass
> > > > @@ -0,0 +1,36 @@
> > > > +# This software is a part of ISAR.
> > > > +# Copyright (C) 2017  Siemens AG
> > > > +#
> > > > +# Permission is hereby granted, free of charge, to any person
> > > > obtaining a +# copy of this software and associated
> > > > documentation files (the "Software"),
> > > > +# to deal in the Software without restriction, including
> > > > without limitation
> > > > +# the rights to use, copy, modify, merge, publish, distribute,
> > > > sublicense, +# and/or sell copies of the Software, and to permit
> > > > persons to whom the +# Software is furnished to do so, subject
> > > > to the following conditions: +#
> > > > +# The above copyright notice and this permission notice shall
> > > > be included +# in all copies or substantial portions of the
> > > > Software. +#
> > > > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
> > > > KIND, EXPRESS OR
> > > > +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > > MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND
> > > > NONINFRINGEMENT. IN NO EVENT SHALL +# THE AUTHORS OR COPYRIGHT
> > > > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR +# OTHER LIABILITY,
> > > > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, +# ARISING
> > > > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +#
> > > > OTHER DEALINGS IN THE SOFTWARE. +
> > > > +THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > > +
> > > > +bbdebug() {
> > > > +       test $# -ge 2 || {
> > > > +               echo "Usage: bbdebug level \"message\""
> > > > +               exit 1
> > > > +       }
> > > > +
> > > > +       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > > +               shift
> > > > +               echo "DEBUG:" $*
> > > > +       }
> > > > +}
> > > > +
> > > > +do_build[nostamp] = "0"
> > > > --
> > > > 2.13.0
> > > >
> > > >  
> >
> >  

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Jan Kiszka]

On 2017-08-08 04:52, [ext] Henning Schild wrote:
> Am Mon, 7 Aug 2017 19:27:43 +0300
> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> 
>> Hi Henning,
>>
>> thank you for the series! I'm trying to build Isar with your patches
>> but got an error:
> 
> Thanks for merging some of the stuff!
> 
>> ERROR: buildchroot-1.0-r0 do_build: Build of do_build failed
>> ERROR: buildchroot-1.0-r0 do_build: Traceback (most recent call last):
>>   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py",
>> line 388, in expandWithRefs
>>     s = __expand_python_regexp__.sub(varparse.python_sub, s)
>>   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/data_smart.py",
>> line 138, in python_sub
>>     value = utils.better_eval(codeobj, DataContext(self.d), {'d' :
>> self.d})
>>
>>
>>   File "/home/asmirnov/Work/isar/isar/bitbake/lib/bb/utils.py", line
>> 424, in better_eval
>>
>>     return eval(source, ctx, locals)
>>
>>
>>   File "FILESDIR", line 1, in <module>
>>
>>
>> AttributeError: 'module' object has no attribute 'which'
>>
>>
>>
>> The above exception was the direct cause of the following exception:
>> ...
>>
>> From the internet I got that this problem caused by old python which
>> doesn have 'which' method in 'module' object.
>> Which python version do you use? My version is python 3.4.2 - this is
>> standard one for Debian-8.
> 
> I am using 3.4.2 in a Debian-8 container, it just contains a few
> Debian-9 packages to fix multistrap host-leakage.
> Docker: jankiszka/kas-isar/base

The reference shall be kasproject/kas-isar:0.11.0 now. My repo only
contained test versions.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 7060 bytes --]

Hi again,

it looks like this patch doesn't work for Isar. 'base.bbclass' is the one
which is included by default to any bitbake operation. In the default
'base.bbclass' there is one very bad line:

bitbake/classes/base.bbclass:
51: do_build[nostamp] = "1"

This line disables stamps for build tasks, it completely destroys the
pipeline. In your patch you move the line: do_build[nostamp] = "0" to
'isar-base.bbclass'. But to have this construction working you have to
explicitely include this class to *every* recipe in Isar, what looks for me
as huge overhead.

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Do not use our own copy of that class and move local deviations into
> isar-base. That also fixes the default tasks "showdata" and "listtasks",
> which probably never worked.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/base.bbclass      | 81 +-----------------------------
> ------------
>  meta/classes/dpkg.bbclass      |  2 ++
>  meta/classes/ext4-img.bbclass  |  2 ++
>  meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
>  4 files changed, 41 insertions(+), 80 deletions(-)
>  mode change 100644 => 120000 meta/classes/base.bbclass
>  create mode 100644 meta/classes/isar-base.bbclass
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> deleted file mode 100644
> index 48b6bac..0000000
> --- a/meta/classes/base.bbclass
> +++ /dev/null
> @@ -1,80 +0,0 @@
> -# Copyright (C) 2003  Chris Larson
> -#
> -# Permission is hereby granted, free of charge, to any person obtaining a
> -# copy of this software and associated documentation files (the
> "Software"),
> -# to deal in the Software without restriction, including without
> limitation
> -# the rights to use, copy, modify, merge, publish, distribute, sublicense,
> -# and/or sell copies of the Software, and to permit persons to whom the
> -# Software is furnished to do so, subject to the following conditions:
> -#
> -# The above copyright notice and this permission notice shall be included
> -# in all copies or substantial portions of the Software.
> -#
> -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR
> -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> -# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> -# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> -# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> -# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> -# OTHER DEALINGS IN THE SOFTWARE.
> -
> -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> -
> -die() {
> -       bbfatal "$*"
> -}
> -
> -bbnote() {
> -       echo "NOTE:" "$*"
> -}
> -
> -bbwarn() {
> -       echo "WARNING:" "$*"
> -}
> -
> -bbfatal() {
> -       echo "FATAL:" "$*"
> -       exit 1
> -}
> -
> -bbdebug() {
> -       test $# -ge 2 || {
> -               echo "Usage: bbdebug level \"message\""
> -               exit 1
> -       }
> -
> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> -               shift
> -               echo "DEBUG:" $*
> -       }
> -}
> -
> -addtask showdata
> -do_showdata[nostamp] = "1"
> -python do_showdata() {
> -       import sys
> -       # emit variables and shell functions
> -       bb.data.emit_env(sys.__stdout__, d, True)
> -       # emit the metadata which isnt valid shell
> -       for e in bb.data.keys(d):
> -               if bb.data.getVarFlag(e, 'python', d):
> -                       sys.__stdout__.write("\npython %s () {\n%s}\n" %
> (e, bb.data.getVar(e, d, 1)))
> -}
> -
> -addtask listtasks
> -do_listtasks[nostamp] = "1"
> -python do_listtasks() {
> -       import sys
> -       for e in bb.data.keys(d):
> -               if bb.data.getVarFlag(e, 'task', d):
> -                       sys.__stdout__.write("%s\n" % e)
> -}
> -
> -addtask build
> -do_build[dirs] = "${TOPDIR}"
> -python base_do_build () {
> -       bb.note("The included, default BB base.bbclass does not define a
> useful default task.")
> -       bb.note("Try running the 'listtasks' task against a .bb to see
> what tasks are defined.")
> -}
> -
> -EXPORT_FUNCTIONS do_clean do_mrproper do_build
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> new file mode 120000
> index 0000000..11fe0a4
> --- /dev/null
> +++ b/meta/classes/base.bbclass
> @@ -0,0 +1 @@
> +../../bitbake/classes/base.bbclass
> \ No newline at end of file
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index a0446d7..3d7aafb 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -1,6 +1,8 @@
>  # This software is a part of ISAR.
>  # Copyright (C) 2015-2016 ilbers GmbH
>
> +inherit isar-base
> +
>  # Add dependency from buildchroot creation
>  DEPENDS += "buildchroot"
>  do_unpack[deptask] = "do_build"
> diff --git a/meta/classes/ext4-img.bbclass b/meta/classes/ext4-img.bbclass
> index 65d4c11..1486c3e 100644
> --- a/meta/classes/ext4-img.bbclass
> +++ b/meta/classes/ext4-img.bbclass
> @@ -1,6 +1,8 @@
>  # This software is a part of ISAR.
>  # Copyright (C) 2015-2016 ilbers GmbH
>
> +inherit isar-base
> +
>  # Extra space for rootfs in MB
>  ROOTFS_EXTRA ?= "64"
>
> diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.bbcla
> ss
> new file mode 100644
> index 0000000..67d38a1
> --- /dev/null
> +++ b/meta/classes/isar-base.bbclass
> @@ -0,0 +1,36 @@
> +# This software is a part of ISAR.
> +# Copyright (C) 2017  Siemens AG
> +#
> +# Permission is hereby granted, free of charge, to any person obtaining a
> +# copy of this software and associated documentation files (the
> "Software"),
> +# to deal in the Software without restriction, including without
> limitation
> +# the rights to use, copy, modify, merge, publish, distribute, sublicense,
> +# and/or sell copies of the Software, and to permit persons to whom the
> +# Software is furnished to do so, subject to the following conditions:
> +#
> +# The above copyright notice and this permission notice shall be included
> +# in all copies or substantial portions of the Software.
> +#
> +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR
> +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> +# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> +# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> +# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> +# OTHER DEALINGS IN THE SOFTWARE.
> +
> +THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> +
> +bbdebug() {
> +       test $# -ge 2 || {
> +               echo "Usage: bbdebug level \"message\""
> +               exit 1
> +       }
> +
> +       test ${@bb.msg.debug_level['default']} -ge $1 && {
> +               shift
> +               echo "DEBUG:" $*
> +       }
> +}
> +
> +do_build[nostamp] = "0"
> --
> 2.13.0
>
>

[-- Attachment #2: Type: text/html, Size: 9085 bytes --]

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Henning Schild]

Am Mon, 7 Aug 2017 22:18:36 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> Hi again,
> 
> it looks like this patch doesn't work for Isar. 'base.bbclass' is the
> one which is included by default to any bitbake operation. In the
> default 'base.bbclass' there is one very bad line:
> 
> bitbake/classes/base.bbclass:
> 51: do_build[nostamp] = "1"
> 
> This line disables stamps for build tasks, it completely destroys the
> pipeline. In your patch you move the line: do_build[nostamp] = "0" to
> 'isar-base.bbclass'. But to have this construction working you have to
> explicitely include this class to *every* recipe in Isar, what looks
> for me as huge overhead.

Ok i did not know what that line does but since i moved it to isar-base
and every class and recipe includes that, the semantics is kept.

Making sure local changes are always included is less of a problem than
copying files from bitbake and ending up with an outdated copy again.

Every recipe in isar will probably include dpdk-bin or dpdk-src, which
both inherit isar-base. The images also include isar-base.

Henning

> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Do not use our own copy of that class and move local deviations into
> > isar-base. That also fixes the default tasks "showdata" and
> > "listtasks", which probably never worked.
> >
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  meta/classes/base.bbclass      | 81 +-----------------------------
> > ------------
> >  meta/classes/dpkg.bbclass      |  2 ++
> >  meta/classes/ext4-img.bbclass  |  2 ++
> >  meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
> >  4 files changed, 41 insertions(+), 80 deletions(-)
> >  mode change 100644 => 120000 meta/classes/base.bbclass
> >  create mode 100644 meta/classes/isar-base.bbclass
> >
> > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > deleted file mode 100644
> > index 48b6bac..0000000
> > --- a/meta/classes/base.bbclass
> > +++ /dev/null
> > @@ -1,80 +0,0 @@
> > -# Copyright (C) 2003  Chris Larson
> > -#
> > -# Permission is hereby granted, free of charge, to any person
> > obtaining a -# copy of this software and associated documentation
> > files (the "Software"),
> > -# to deal in the Software without restriction, including without
> > limitation
> > -# the rights to use, copy, modify, merge, publish, distribute,
> > sublicense, -# and/or sell copies of the Software, and to permit
> > persons to whom the -# Software is furnished to do so, subject to
> > the following conditions: -#
> > -# The above copyright notice and this permission notice shall be
> > included -# in all copies or substantial portions of the Software.
> > -#
> > -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > EXPRESS OR
> > -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > MERCHANTABILITY, -# FITNESS FOR A PARTICULAR PURPOSE AND
> > NONINFRINGEMENT. IN NO EVENT SHALL -# THE AUTHORS OR COPYRIGHT
> > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR -# OTHER LIABILITY,
> > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, -# ARISING
> > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR -#
> > OTHER DEALINGS IN THE SOFTWARE. -
> > -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > -
> > -die() {
> > -       bbfatal "$*"
> > -}
> > -
> > -bbnote() {
> > -       echo "NOTE:" "$*"
> > -}
> > -
> > -bbwarn() {
> > -       echo "WARNING:" "$*"
> > -}
> > -
> > -bbfatal() {
> > -       echo "FATAL:" "$*"
> > -       exit 1
> > -}
> > -
> > -bbdebug() {
> > -       test $# -ge 2 || {
> > -               echo "Usage: bbdebug level \"message\""
> > -               exit 1
> > -       }
> > -
> > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > -               shift
> > -               echo "DEBUG:" $*
> > -       }
> > -}
> > -
> > -addtask showdata
> > -do_showdata[nostamp] = "1"
> > -python do_showdata() {
> > -       import sys
> > -       # emit variables and shell functions
> > -       bb.data.emit_env(sys.__stdout__, d, True)
> > -       # emit the metadata which isnt valid shell
> > -       for e in bb.data.keys(d):
> > -               if bb.data.getVarFlag(e, 'python', d):
> > -                       sys.__stdout__.write("\npython %s ()
> > {\n%s}\n" % (e, bb.data.getVar(e, d, 1)))
> > -}
> > -
> > -addtask listtasks
> > -do_listtasks[nostamp] = "1"
> > -python do_listtasks() {
> > -       import sys
> > -       for e in bb.data.keys(d):
> > -               if bb.data.getVarFlag(e, 'task', d):
> > -                       sys.__stdout__.write("%s\n" % e)
> > -}
> > -
> > -addtask build
> > -do_build[dirs] = "${TOPDIR}"
> > -python base_do_build () {
> > -       bb.note("The included, default BB base.bbclass does not
> > define a useful default task.")
> > -       bb.note("Try running the 'listtasks' task against a .bb to
> > see what tasks are defined.")
> > -}
> > -
> > -EXPORT_FUNCTIONS do_clean do_mrproper do_build
> > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > new file mode 120000
> > index 0000000..11fe0a4
> > --- /dev/null
> > +++ b/meta/classes/base.bbclass
> > @@ -0,0 +1 @@
> > +../../bitbake/classes/base.bbclass
> > \ No newline at end of file
> > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > index a0446d7..3d7aafb 100644
> > --- a/meta/classes/dpkg.bbclass
> > +++ b/meta/classes/dpkg.bbclass
> > @@ -1,6 +1,8 @@
> >  # This software is a part of ISAR.
> >  # Copyright (C) 2015-2016 ilbers GmbH
> >
> > +inherit isar-base
> > +
> >  # Add dependency from buildchroot creation
> >  DEPENDS += "buildchroot"
> >  do_unpack[deptask] = "do_build"
> > diff --git a/meta/classes/ext4-img.bbclass
> > b/meta/classes/ext4-img.bbclass index 65d4c11..1486c3e 100644
> > --- a/meta/classes/ext4-img.bbclass
> > +++ b/meta/classes/ext4-img.bbclass
> > @@ -1,6 +1,8 @@
> >  # This software is a part of ISAR.
> >  # Copyright (C) 2015-2016 ilbers GmbH
> >
> > +inherit isar-base
> > +
> >  # Extra space for rootfs in MB
> >  ROOTFS_EXTRA ?= "64"
> >
> > diff --git a/meta/classes/isar-base.bbclass
> > b/meta/classes/isar-base.bbcla ss
> > new file mode 100644
> > index 0000000..67d38a1
> > --- /dev/null
> > +++ b/meta/classes/isar-base.bbclass
> > @@ -0,0 +1,36 @@
> > +# This software is a part of ISAR.
> > +# Copyright (C) 2017  Siemens AG
> > +#
> > +# Permission is hereby granted, free of charge, to any person
> > obtaining a +# copy of this software and associated documentation
> > files (the "Software"),
> > +# to deal in the Software without restriction, including without
> > limitation
> > +# the rights to use, copy, modify, merge, publish, distribute,
> > sublicense, +# and/or sell copies of the Software, and to permit
> > persons to whom the +# Software is furnished to do so, subject to
> > the following conditions: +#
> > +# The above copyright notice and this permission notice shall be
> > included +# in all copies or substantial portions of the Software.
> > +#
> > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > EXPRESS OR
> > +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND
> > NONINFRINGEMENT. IN NO EVENT SHALL +# THE AUTHORS OR COPYRIGHT
> > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR +# OTHER LIABILITY,
> > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, +# ARISING
> > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +#
> > OTHER DEALINGS IN THE SOFTWARE. +
> > +THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > +
> > +bbdebug() {
> > +       test $# -ge 2 || {
> > +               echo "Usage: bbdebug level \"message\""
> > +               exit 1
> > +       }
> > +
> > +       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > +               shift
> > +               echo "DEBUG:" $*
> > +       }
> > +}
> > +
> > +do_build[nostamp] = "0"
> > --
> > 2.13.0
> >
> >  

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 9427 bytes --]

2017-08-08 11:43 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Am Mon, 7 Aug 2017 22:18:36 +0300
> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>
> > Hi again,
> >
> > it looks like this patch doesn't work for Isar. 'base.bbclass' is the
> > one which is included by default to any bitbake operation. In the
> > default 'base.bbclass' there is one very bad line:
> >
> > bitbake/classes/base.bbclass:
> > 51: do_build[nostamp] = "1"
> >
> > This line disables stamps for build tasks, it completely destroys the
> > pipeline. In your patch you move the line: do_build[nostamp] = "0" to
> > 'isar-base.bbclass'. But to have this construction working you have to
> > explicitely include this class to *every* recipe in Isar, what looks
> > for me as huge overhead.
>
> Ok i did not know what that line does but since i moved it to isar-base
> and every class and recipe includes that, the semantics is kept.
>
> Making sure local changes are always included is less of a problem than
> copying files from bitbake and ending up with an outdated copy again.
>

We are speaking about sample base class in bitbake tree which by default
provides *nothing*. As I can understand, this is just an example which
doesn't affect the bitbake functionality. Nor OE, nor Yocto doesn't use it
and implement their own base classes. Also in bitbake manual:
https://www.yoctoproject.org/docs/1.6/bitbake-user-manual/bitbake-user-manual.html
chapter A4, document proposes you to create your base class.

I was OK with this idea because I assumed that the deafult base class
provides correct settings, but now I realized that it doesn't. So keeping
broken base class for some reasons and overwrite it in run-time looks too
compicated for such simple things.


> Every recipe in isar will probably include dpdk-bin or dpdk-src, which
> both inherit isar-base. The images also include isar-base.
>

It's not a question about workaround. It's about knowingly keeping of
broken base class and fix it from another class. Meanwhile nothing is used
from original base class. I don't really understand why we need base class
then...

Alex


>
> Henning
>
> > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > <henning.schild@siemens.com>:
> >
> > > Do not use our own copy of that class and move local deviations into
> > > isar-base. That also fixes the default tasks "showdata" and
> > > "listtasks", which probably never worked.
> > >
> > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > ---
> > >  meta/classes/base.bbclass      | 81 +-----------------------------
> > > ------------
> > >  meta/classes/dpkg.bbclass      |  2 ++
> > >  meta/classes/ext4-img.bbclass  |  2 ++
> > >  meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
> > >  4 files changed, 41 insertions(+), 80 deletions(-)
> > >  mode change 100644 => 120000 meta/classes/base.bbclass
> > >  create mode 100644 meta/classes/isar-base.bbclass
> > >
> > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > > deleted file mode 100644
> > > index 48b6bac..0000000
> > > --- a/meta/classes/base.bbclass
> > > +++ /dev/null
> > > @@ -1,80 +0,0 @@
> > > -# Copyright (C) 2003  Chris Larson
> > > -#
> > > -# Permission is hereby granted, free of charge, to any person
> > > obtaining a -# copy of this software and associated documentation
> > > files (the "Software"),
> > > -# to deal in the Software without restriction, including without
> > > limitation
> > > -# the rights to use, copy, modify, merge, publish, distribute,
> > > sublicense, -# and/or sell copies of the Software, and to permit
> > > persons to whom the -# Software is furnished to do so, subject to
> > > the following conditions: -#
> > > -# The above copyright notice and this permission notice shall be
> > > included -# in all copies or substantial portions of the Software.
> > > -#
> > > -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > > EXPRESS OR
> > > -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > MERCHANTABILITY, -# FITNESS FOR A PARTICULAR PURPOSE AND
> > > NONINFRINGEMENT. IN NO EVENT SHALL -# THE AUTHORS OR COPYRIGHT
> > > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR -# OTHER LIABILITY,
> > > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, -# ARISING
> > > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR -#
> > > OTHER DEALINGS IN THE SOFTWARE. -
> > > -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > -
> > > -die() {
> > > -       bbfatal "$*"
> > > -}
> > > -
> > > -bbnote() {
> > > -       echo "NOTE:" "$*"
> > > -}
> > > -
> > > -bbwarn() {
> > > -       echo "WARNING:" "$*"
> > > -}
> > > -
> > > -bbfatal() {
> > > -       echo "FATAL:" "$*"
> > > -       exit 1
> > > -}
> > > -
> > > -bbdebug() {
> > > -       test $# -ge 2 || {
> > > -               echo "Usage: bbdebug level \"message\""
> > > -               exit 1
> > > -       }
> > > -
> > > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > -               shift
> > > -               echo "DEBUG:" $*
> > > -       }
> > > -}
> > > -
> > > -addtask showdata
> > > -do_showdata[nostamp] = "1"
> > > -python do_showdata() {
> > > -       import sys
> > > -       # emit variables and shell functions
> > > -       bb.data.emit_env(sys.__stdout__, d, True)
> > > -       # emit the metadata which isnt valid shell
> > > -       for e in bb.data.keys(d):
> > > -               if bb.data.getVarFlag(e, 'python', d):
> > > -                       sys.__stdout__.write("\npython %s ()
> > > {\n%s}\n" % (e, bb.data.getVar(e, d, 1)))
> > > -}
> > > -
> > > -addtask listtasks
> > > -do_listtasks[nostamp] = "1"
> > > -python do_listtasks() {
> > > -       import sys
> > > -       for e in bb.data.keys(d):
> > > -               if bb.data.getVarFlag(e, 'task', d):
> > > -                       sys.__stdout__.write("%s\n" % e)
> > > -}
> > > -
> > > -addtask build
> > > -do_build[dirs] = "${TOPDIR}"
> > > -python base_do_build () {
> > > -       bb.note("The included, default BB base.bbclass does not
> > > define a useful default task.")
> > > -       bb.note("Try running the 'listtasks' task against a .bb to
> > > see what tasks are defined.")
> > > -}
> > > -
> > > -EXPORT_FUNCTIONS do_clean do_mrproper do_build
> > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > > new file mode 120000
> > > index 0000000..11fe0a4
> > > --- /dev/null
> > > +++ b/meta/classes/base.bbclass
> > > @@ -0,0 +1 @@
> > > +../../bitbake/classes/base.bbclass
> > > \ No newline at end of file
> > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > > index a0446d7..3d7aafb 100644
> > > --- a/meta/classes/dpkg.bbclass
> > > +++ b/meta/classes/dpkg.bbclass
> > > @@ -1,6 +1,8 @@
> > >  # This software is a part of ISAR.
> > >  # Copyright (C) 2015-2016 ilbers GmbH
> > >
> > > +inherit isar-base
> > > +
> > >  # Add dependency from buildchroot creation
> > >  DEPENDS += "buildchroot"
> > >  do_unpack[deptask] = "do_build"
> > > diff --git a/meta/classes/ext4-img.bbclass
> > > b/meta/classes/ext4-img.bbclass index 65d4c11..1486c3e 100644
> > > --- a/meta/classes/ext4-img.bbclass
> > > +++ b/meta/classes/ext4-img.bbclass
> > > @@ -1,6 +1,8 @@
> > >  # This software is a part of ISAR.
> > >  # Copyright (C) 2015-2016 ilbers GmbH
> > >
> > > +inherit isar-base
> > > +
> > >  # Extra space for rootfs in MB
> > >  ROOTFS_EXTRA ?= "64"
> > >
> > > diff --git a/meta/classes/isar-base.bbclass
> > > b/meta/classes/isar-base.bbcla ss
> > > new file mode 100644
> > > index 0000000..67d38a1
> > > --- /dev/null
> > > +++ b/meta/classes/isar-base.bbclass
> > > @@ -0,0 +1,36 @@
> > > +# This software is a part of ISAR.
> > > +# Copyright (C) 2017  Siemens AG
> > > +#
> > > +# Permission is hereby granted, free of charge, to any person
> > > obtaining a +# copy of this software and associated documentation
> > > files (the "Software"),
> > > +# to deal in the Software without restriction, including without
> > > limitation
> > > +# the rights to use, copy, modify, merge, publish, distribute,
> > > sublicense, +# and/or sell copies of the Software, and to permit
> > > persons to whom the +# Software is furnished to do so, subject to
> > > the following conditions: +#
> > > +# The above copyright notice and this permission notice shall be
> > > included +# in all copies or substantial portions of the Software.
> > > +#
> > > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > > EXPRESS OR
> > > +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND
> > > NONINFRINGEMENT. IN NO EVENT SHALL +# THE AUTHORS OR COPYRIGHT
> > > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR +# OTHER LIABILITY,
> > > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, +# ARISING
> > > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +#
> > > OTHER DEALINGS IN THE SOFTWARE. +
> > > +THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > +
> > > +bbdebug() {
> > > +       test $# -ge 2 || {
> > > +               echo "Usage: bbdebug level \"message\""
> > > +               exit 1
> > > +       }
> > > +
> > > +       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > +               shift
> > > +               echo "DEBUG:" $*
> > > +       }
> > > +}
> > > +
> > > +do_build[nostamp] = "0"
> > > --
> > > 2.13.0
> > >
> > >
>
>

[-- Attachment #2: Type: text/html, Size: 13170 bytes --]

Re: [PATCH 0-10 of 16 v2 1/8] meta: classes: use base.bbclass from bitbake

[Henning Schild]

Am Tue, 8 Aug 2017 17:02:19 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> 2017-08-08 11:43 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Am Mon, 7 Aug 2017 22:18:36 +0300
> > schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >  
> > > Hi again,
> > >
> > > it looks like this patch doesn't work for Isar. 'base.bbclass' is
> > > the one which is included by default to any bitbake operation. In
> > > the default 'base.bbclass' there is one very bad line:
> > >
> > > bitbake/classes/base.bbclass:
> > > 51: do_build[nostamp] = "1"
> > >
> > > This line disables stamps for build tasks, it completely destroys
> > > the pipeline. In your patch you move the line: do_build[nostamp]
> > > = "0" to 'isar-base.bbclass'. But to have this construction
> > > working you have to explicitely include this class to *every*
> > > recipe in Isar, what looks for me as huge overhead.  
> >
> > Ok i did not know what that line does but since i moved it to
> > isar-base and every class and recipe includes that, the semantics
> > is kept.
> >
> > Making sure local changes are always included is less of a problem
> > than copying files from bitbake and ending up with an outdated copy
> > again. 
> 
> We are speaking about sample base class in bitbake tree which by
> default provides *nothing*. As I can understand, this is just an
> example which doesn't affect the bitbake functionality. Nor OE, nor
> Yocto doesn't use it and implement their own base classes. Also in
> bitbake manual:
> https://www.yoctoproject.org/docs/1.6/bitbake-user-manual/bitbake-user-manual.html
> chapter A4, document proposes you to create your base class.
> 
> I was OK with this idea because I assumed that the deafult base class
> provides correct settings, but now I realized that it doesn't. So
> keeping broken base class for some reasons and overwrite it in
> run-time looks too compicated for such simple things.
> 
> 
> > Every recipe in isar will probably include dpdk-bin or dpdk-src,
> > which both inherit isar-base. The images also include isar-base.
> >  
> 
> It's not a question about workaround. It's about knowingly keeping of
> broken base class and fix it from another class. Meanwhile nothing is
> used from original base class. I don't really understand why we need
> base class then...

It provides 'listtasks' and 'showdata' they never used to work but are
handy now that they do. And the logging functions ...

Henning

> Alex
> 
> 
> >
> > Henning
> >  
> > > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > > <henning.schild@siemens.com>:
> > >  
> > > > Do not use our own copy of that class and move local deviations
> > > > into isar-base. That also fixes the default tasks "showdata" and
> > > > "listtasks", which probably never worked.
> > > >
> > > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > > ---
> > > >  meta/classes/base.bbclass      | 81
> > > > +----------------------------- ------------
> > > >  meta/classes/dpkg.bbclass      |  2 ++
> > > >  meta/classes/ext4-img.bbclass  |  2 ++
> > > >  meta/classes/isar-base.bbclass | 36 +++++++++++++++++++
> > > >  4 files changed, 41 insertions(+), 80 deletions(-)
> > > >  mode change 100644 => 120000 meta/classes/base.bbclass
> > > >  create mode 100644 meta/classes/isar-base.bbclass
> > > >
> > > > diff --git a/meta/classes/base.bbclass
> > > > b/meta/classes/base.bbclass deleted file mode 100644
> > > > index 48b6bac..0000000
> > > > --- a/meta/classes/base.bbclass
> > > > +++ /dev/null
> > > > @@ -1,80 +0,0 @@
> > > > -# Copyright (C) 2003  Chris Larson
> > > > -#
> > > > -# Permission is hereby granted, free of charge, to any person
> > > > obtaining a -# copy of this software and associated
> > > > documentation files (the "Software"),
> > > > -# to deal in the Software without restriction, including
> > > > without limitation
> > > > -# the rights to use, copy, modify, merge, publish, distribute,
> > > > sublicense, -# and/or sell copies of the Software, and to permit
> > > > persons to whom the -# Software is furnished to do so, subject
> > > > to the following conditions: -#
> > > > -# The above copyright notice and this permission notice shall
> > > > be included -# in all copies or substantial portions of the
> > > > Software. -#
> > > > -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
> > > > KIND, EXPRESS OR
> > > > -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > > MERCHANTABILITY, -# FITNESS FOR A PARTICULAR PURPOSE AND
> > > > NONINFRINGEMENT. IN NO EVENT SHALL -# THE AUTHORS OR COPYRIGHT
> > > > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR -# OTHER LIABILITY,
> > > > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, -# ARISING
> > > > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR -#
> > > > OTHER DEALINGS IN THE SOFTWARE. -
> > > > -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > > -
> > > > -die() {
> > > > -       bbfatal "$*"
> > > > -}
> > > > -
> > > > -bbnote() {
> > > > -       echo "NOTE:" "$*"
> > > > -}
> > > > -
> > > > -bbwarn() {
> > > > -       echo "WARNING:" "$*"
> > > > -}
> > > > -
> > > > -bbfatal() {
> > > > -       echo "FATAL:" "$*"
> > > > -       exit 1
> > > > -}
> > > > -
> > > > -bbdebug() {
> > > > -       test $# -ge 2 || {
> > > > -               echo "Usage: bbdebug level \"message\""
> > > > -               exit 1
> > > > -       }
> > > > -
> > > > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > > -               shift
> > > > -               echo "DEBUG:" $*
> > > > -       }
> > > > -}
> > > > -
> > > > -addtask showdata
> > > > -do_showdata[nostamp] = "1"
> > > > -python do_showdata() {
> > > > -       import sys
> > > > -       # emit variables and shell functions
> > > > -       bb.data.emit_env(sys.__stdout__, d, True)
> > > > -       # emit the metadata which isnt valid shell
> > > > -       for e in bb.data.keys(d):
> > > > -               if bb.data.getVarFlag(e, 'python', d):
> > > > -                       sys.__stdout__.write("\npython %s ()
> > > > {\n%s}\n" % (e, bb.data.getVar(e, d, 1)))
> > > > -}
> > > > -
> > > > -addtask listtasks
> > > > -do_listtasks[nostamp] = "1"
> > > > -python do_listtasks() {
> > > > -       import sys
> > > > -       for e in bb.data.keys(d):
> > > > -               if bb.data.getVarFlag(e, 'task', d):
> > > > -                       sys.__stdout__.write("%s\n" % e)
> > > > -}
> > > > -
> > > > -addtask build
> > > > -do_build[dirs] = "${TOPDIR}"
> > > > -python base_do_build () {
> > > > -       bb.note("The included, default BB base.bbclass does not
> > > > define a useful default task.")
> > > > -       bb.note("Try running the 'listtasks' task against a .bb
> > > > to see what tasks are defined.")
> > > > -}
> > > > -
> > > > -EXPORT_FUNCTIONS do_clean do_mrproper do_build
> > > > diff --git a/meta/classes/base.bbclass
> > > > b/meta/classes/base.bbclass new file mode 120000
> > > > index 0000000..11fe0a4
> > > > --- /dev/null
> > > > +++ b/meta/classes/base.bbclass
> > > > @@ -0,0 +1 @@
> > > > +../../bitbake/classes/base.bbclass
> > > > \ No newline at end of file
> > > > diff --git a/meta/classes/dpkg.bbclass
> > > > b/meta/classes/dpkg.bbclass index a0446d7..3d7aafb 100644
> > > > --- a/meta/classes/dpkg.bbclass
> > > > +++ b/meta/classes/dpkg.bbclass
> > > > @@ -1,6 +1,8 @@
> > > >  # This software is a part of ISAR.
> > > >  # Copyright (C) 2015-2016 ilbers GmbH
> > > >
> > > > +inherit isar-base
> > > > +
> > > >  # Add dependency from buildchroot creation
> > > >  DEPENDS += "buildchroot"
> > > >  do_unpack[deptask] = "do_build"
> > > > diff --git a/meta/classes/ext4-img.bbclass
> > > > b/meta/classes/ext4-img.bbclass index 65d4c11..1486c3e 100644
> > > > --- a/meta/classes/ext4-img.bbclass
> > > > +++ b/meta/classes/ext4-img.bbclass
> > > > @@ -1,6 +1,8 @@
> > > >  # This software is a part of ISAR.
> > > >  # Copyright (C) 2015-2016 ilbers GmbH
> > > >
> > > > +inherit isar-base
> > > > +
> > > >  # Extra space for rootfs in MB
> > > >  ROOTFS_EXTRA ?= "64"
> > > >
> > > > diff --git a/meta/classes/isar-base.bbclass
> > > > b/meta/classes/isar-base.bbcla ss
> > > > new file mode 100644
> > > > index 0000000..67d38a1
> > > > --- /dev/null
> > > > +++ b/meta/classes/isar-base.bbclass
> > > > @@ -0,0 +1,36 @@
> > > > +# This software is a part of ISAR.
> > > > +# Copyright (C) 2017  Siemens AG
> > > > +#
> > > > +# Permission is hereby granted, free of charge, to any person
> > > > obtaining a +# copy of this software and associated
> > > > documentation files (the "Software"),
> > > > +# to deal in the Software without restriction, including
> > > > without limitation
> > > > +# the rights to use, copy, modify, merge, publish, distribute,
> > > > sublicense, +# and/or sell copies of the Software, and to permit
> > > > persons to whom the +# Software is furnished to do so, subject
> > > > to the following conditions: +#
> > > > +# The above copyright notice and this permission notice shall
> > > > be included +# in all copies or substantial portions of the
> > > > Software. +#
> > > > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
> > > > KIND, EXPRESS OR
> > > > +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > > MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND
> > > > NONINFRINGEMENT. IN NO EVENT SHALL +# THE AUTHORS OR COPYRIGHT
> > > > HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR +# OTHER LIABILITY,
> > > > WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, +# ARISING
> > > > FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +#
> > > > OTHER DEALINGS IN THE SOFTWARE. +
> > > > +THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > > +
> > > > +bbdebug() {
> > > > +       test $# -ge 2 || {
> > > > +               echo "Usage: bbdebug level \"message\""
> > > > +               exit 1
> > > > +       }
> > > > +
> > > > +       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > > +               shift
> > > > +               echo "DEBUG:" $*
> > > > +       }
> > > > +}
> > > > +
> > > > +do_build[nostamp] = "0"
> > > > --
> > > > 2.13.0
> > > >
> > > >  
> >
> >  

[PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Henning Schild]

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/isar-base.bbclass | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.bbclass
index 67d38a1..efd4223 100644
--- a/meta/classes/isar-base.bbclass
+++ b/meta/classes/isar-base.bbclass
@@ -21,16 +21,4 @@
 
 THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
 
-bbdebug() {
-	test $# -ge 2 || {
-		echo "Usage: bbdebug level \"message\""
-		exit 1
-	}
-
-	test ${@bb.msg.debug_level['default']} -ge $1 && {
-		shift
-		echo "DEBUG:" $*
-	}
-}
-
 do_build[nostamp] = "0"
-- 
2.13.0

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

I'm not sure that this function is unused. It's usually used for debug
purposes to route traces to console.

http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
chapter: 2.3.8.2

I think it makes sense to keep it to debug complicated classes and recipes
in future.

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/isar-base.bbclass | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.
> bbclass
> index 67d38a1..efd4223 100644
> --- a/meta/classes/isar-base.bbclass
> +++ b/meta/classes/isar-base.bbclass
> @@ -21,16 +21,4 @@
>
>  THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
>
> -bbdebug() {
> -       test $# -ge 2 || {
> -               echo "Usage: bbdebug level \"message\""
> -               exit 1
> -       }
> -
> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> -               shift
> -               echo "DEBUG:" $*
> -       }
> -}
> -
>  do_build[nostamp] = "0"
> --
> 2.13.0
>
>

[-- Attachment #2: Type: text/html, Size: 1950 bytes --]

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Henning Schild]

Am Mon, 7 Aug 2017 22:36:18 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> I'm not sure that this function is unused. It's usually used for debug
> purposes to route traces to console.

It is unused in Isar and not part of the default base class of bitbake.

> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> chapter: 2.3.8.2

OE implements it in meta/classes/logging.bbclass

> I think it makes sense to keep it to debug complicated classes and
> recipes in future.

Ok.

Henning

> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  meta/classes/isar-base.bbclass | 12 ------------
> >  1 file changed, 12 deletions(-)
> >
> > diff --git a/meta/classes/isar-base.bbclass
> > b/meta/classes/isar-base. bbclass
> > index 67d38a1..efd4223 100644
> > --- a/meta/classes/isar-base.bbclass
> > +++ b/meta/classes/isar-base.bbclass
> > @@ -21,16 +21,4 @@
> >
> >  THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> >
> > -bbdebug() {
> > -       test $# -ge 2 || {
> > -               echo "Usage: bbdebug level \"message\""
> > -               exit 1
> > -       }
> > -
> > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > -               shift
> > -               echo "DEBUG:" $*
> > -       }
> > -}
> > -
> >  do_build[nostamp] = "0"
> > --
> > 2.13.0
> >
> >  

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]

2017-08-08 11:05 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Am Mon, 7 Aug 2017 22:36:18 +0300
> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>
> > I'm not sure that this function is unused. It's usually used for debug
> > purposes to route traces to console.
>
> It is unused in Isar and not part of the default base class of bitbake.
>
> > http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> > chapter: 2.3.8.2
>
> OE implements it in meta/classes/logging.bbclass
>
>
That's a good hint! So probably we can move this function to similar class
instead of removing it.


> > I think it makes sense to keep it to debug complicated classes and
> > recipes in future.
>
> Ok.
>
> Henning
>
> > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > <henning.schild@siemens.com>:
> >
> > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > ---
> > >  meta/classes/isar-base.bbclass | 12 ------------
> > >  1 file changed, 12 deletions(-)
> > >
> > > diff --git a/meta/classes/isar-base.bbclass
> > > b/meta/classes/isar-base. bbclass
> > > index 67d38a1..efd4223 100644
> > > --- a/meta/classes/isar-base.bbclass
> > > +++ b/meta/classes/isar-base.bbclass
> > > @@ -21,16 +21,4 @@
> > >
> > >  THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > >
> > > -bbdebug() {
> > > -       test $# -ge 2 || {
> > > -               echo "Usage: bbdebug level \"message\""
> > > -               exit 1
> > > -       }
> > > -
> > > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > -               shift
> > > -               echo "DEBUG:" $*
> > > -       }
> > > -}
> > > -
> > >  do_build[nostamp] = "0"
> > > --
> > > 2.13.0
> > >
> > >
>
>

[-- Attachment #2: Type: text/html, Size: 3172 bytes --]

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Henning Schild]

Am Tue, 8 Aug 2017 12:33:58 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> 2017-08-08 11:05 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Am Mon, 7 Aug 2017 22:36:18 +0300
> > schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >  
> > > I'm not sure that this function is unused. It's usually used for
> > > debug purposes to route traces to console.  
> >
> > It is unused in Isar and not part of the default base class of
> > bitbake. 
> > > http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> > > chapter: 2.3.8.2  
> >
> > OE implements it in meta/classes/logging.bbclass
> >
> >  
> That's a good hint! So probably we can move this function to similar
> class instead of removing it.

I would still remove it since it is not used. When people need it they
can introduce it again. For logging we have bbnote bbwarn and bbfatal
from base.bbclass already.

Our bitbake does not seem to know "debug_level" so it is outdated and
unused.

Henning

> 
> > > I think it makes sense to keep it to debug complicated classes and
> > > recipes in future.  
> >
> > Ok.
> >
> > Henning
> >  
> > > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > > <henning.schild@siemens.com>:
> > >  
> > > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > > ---
> > > >  meta/classes/isar-base.bbclass | 12 ------------
> > > >  1 file changed, 12 deletions(-)
> > > >
> > > > diff --git a/meta/classes/isar-base.bbclass
> > > > b/meta/classes/isar-base. bbclass
> > > > index 67d38a1..efd4223 100644
> > > > --- a/meta/classes/isar-base.bbclass
> > > > +++ b/meta/classes/isar-base.bbclass
> > > > @@ -21,16 +21,4 @@
> > > >
> > > >  THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > > >
> > > > -bbdebug() {
> > > > -       test $# -ge 2 || {
> > > > -               echo "Usage: bbdebug level \"message\""
> > > > -               exit 1
> > > > -       }
> > > > -
> > > > -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> > > > -               shift
> > > > -               echo "DEBUG:" $*
> > > > -       }
> > > > -}
> > > > -
> > > >  do_build[nostamp] = "0"
> > > > --
> > > > 2.13.0
> > > >
> > > >  
> >
> >  

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Alexander Smirnov]

Hi,

On 08/08/2017 03:08 PM, Henning Schild wrote:
> Am Tue, 8 Aug 2017 12:33:58 +0300
> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> 
>> 2017-08-08 11:05 GMT+03:00 Henning Schild
>> <henning.schild@siemens.com>:
>>
>>> Am Mon, 7 Aug 2017 22:36:18 +0300
>>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>>>   
>>>> I'm not sure that this function is unused. It's usually used for
>>>> debug purposes to route traces to console.
>>>
>>> It is unused in Isar and not part of the default base class of
>>> bitbake.
>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
>>>> chapter: 2.3.8.2
>>>
>>> OE implements it in meta/classes/logging.bbclass
>>>
>>>   
>> That's a good hint! So probably we can move this function to similar
>> class instead of removing it.
> 
> I would still remove it since it is not used. When people need it they
> can introduce it again. For logging we have bbnote bbwarn and bbfatal
> from base.bbclass already.
> 
> Our bitbake does not seem to know "debug_level" so it is outdated and
> unused.

I'll send patch which introduces logging class and move all the 'bbXXX' 
helpers to it (also fix bbdebug).

I really don't like the idea to drop debug capabilities only because 
they are not used at the moment. If this interface is going to be 
dropped, then we need to introduce new interface before.

Alex

> 
>>
>>>> I think it makes sense to keep it to debug complicated classes and
>>>> recipes in future.
>>>
>>> Ok.
>>>
>>> Henning
>>>   
>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild
>>>> <henning.schild@siemens.com>:
>>>>   
>>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>>>>> ---
>>>>>   meta/classes/isar-base.bbclass | 12 ------------
>>>>>   1 file changed, 12 deletions(-)
>>>>>
>>>>> diff --git a/meta/classes/isar-base.bbclass
>>>>> b/meta/classes/isar-base. bbclass
>>>>> index 67d38a1..efd4223 100644
>>>>> --- a/meta/classes/isar-base.bbclass
>>>>> +++ b/meta/classes/isar-base.bbclass
>>>>> @@ -21,16 +21,4 @@
>>>>>
>>>>>   THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
>>>>>
>>>>> -bbdebug() {
>>>>> -       test $# -ge 2 || {
>>>>> -               echo "Usage: bbdebug level \"message\""
>>>>> -               exit 1
>>>>> -       }
>>>>> -
>>>>> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
>>>>> -               shift
>>>>> -               echo "DEBUG:" $*
>>>>> -       }
>>>>> -}
>>>>> -
>>>>>   do_build[nostamp] = "0"
>>>>> --
>>>>> 2.13.0
>>>>>
>>>>>   
>>>
>>>   
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Henning Schild]

Am Tue, 8 Aug 2017 15:29:35 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> Hi,
> 
> On 08/08/2017 03:08 PM, Henning Schild wrote:
> > Am Tue, 8 Aug 2017 12:33:58 +0300
> > schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >   
> >> 2017-08-08 11:05 GMT+03:00 Henning Schild
> >> <henning.schild@siemens.com>:
> >>  
> >>> Am Mon, 7 Aug 2017 22:36:18 +0300
> >>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >>>     
> >>>> I'm not sure that this function is unused. It's usually used for
> >>>> debug purposes to route traces to console.  
> >>>
> >>> It is unused in Isar and not part of the default base class of
> >>> bitbake.  
> >>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> >>>> chapter: 2.3.8.2  
> >>>
> >>> OE implements it in meta/classes/logging.bbclass
> >>>
> >>>     
> >> That's a good hint! So probably we can move this function to
> >> similar class instead of removing it.  
> > 
> > I would still remove it since it is not used. When people need it
> > they can introduce it again. For logging we have bbnote bbwarn and
> > bbfatal from base.bbclass already.
> > 
> > Our bitbake does not seem to know "debug_level" so it is outdated
> > and unused.  
> 
> I'll send patch which introduces logging class and move all the
> 'bbXXX' helpers to it (also fix bbdebug).

Please do not touch base.bbclass! Or come up with one that is really
different from the bitbake default one for a good reason.

> I really don't like the idea to drop debug capabilities only because 
> they are not used at the moment. If this interface is going to be 
> dropped, then we need to introduce new interface before.

Like Isar was used by anyone or this was anything like a tiny
broken print function.... without users or a release who cares about
interfaces? But keep it like the bugs in ext4!

Can we please start dicsussing the real patches?

Henning

> Alex
> 
> >   
> >>  
> >>>> I think it makes sense to keep it to debug complicated classes
> >>>> and recipes in future.  
> >>>
> >>> Ok.
> >>>
> >>> Henning
> >>>     
> >>>> 2017-08-03 14:55 GMT+03:00 Henning Schild
> >>>> <henning.schild@siemens.com>:
> >>>>     
> >>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> >>>>> ---
> >>>>>   meta/classes/isar-base.bbclass | 12 ------------
> >>>>>   1 file changed, 12 deletions(-)
> >>>>>
> >>>>> diff --git a/meta/classes/isar-base.bbclass
> >>>>> b/meta/classes/isar-base. bbclass
> >>>>> index 67d38a1..efd4223 100644
> >>>>> --- a/meta/classes/isar-base.bbclass
> >>>>> +++ b/meta/classes/isar-base.bbclass
> >>>>> @@ -21,16 +21,4 @@
> >>>>>
> >>>>>   THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> >>>>>
> >>>>> -bbdebug() {
> >>>>> -       test $# -ge 2 || {
> >>>>> -               echo "Usage: bbdebug level \"message\""
> >>>>> -               exit 1
> >>>>> -       }
> >>>>> -
> >>>>> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> >>>>> -               shift
> >>>>> -               echo "DEBUG:" $*
> >>>>> -       }
> >>>>> -}
> >>>>> -
> >>>>>   do_build[nostamp] = "0"
> >>>>> --
> >>>>> 2.13.0
> >>>>>
> >>>>>     
> >>>
> >>>     
> >   
> 

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Alexander Smirnov]

On 08/08/2017 04:12 PM, Henning Schild wrote:
> Am Tue, 8 Aug 2017 15:29:35 +0300
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
>> Hi,
>>
>> On 08/08/2017 03:08 PM, Henning Schild wrote:
>>> Am Tue, 8 Aug 2017 12:33:58 +0300
>>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>>>    
>>>> 2017-08-08 11:05 GMT+03:00 Henning Schild
>>>> <henning.schild@siemens.com>:
>>>>   
>>>>> Am Mon, 7 Aug 2017 22:36:18 +0300
>>>>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>>>>>      
>>>>>> I'm not sure that this function is unused. It's usually used for
>>>>>> debug purposes to route traces to console.
>>>>>
>>>>> It is unused in Isar and not part of the default base class of
>>>>> bitbake.
>>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
>>>>>> chapter: 2.3.8.2
>>>>>
>>>>> OE implements it in meta/classes/logging.bbclass
>>>>>
>>>>>      
>>>> That's a good hint! So probably we can move this function to
>>>> similar class instead of removing it.
>>>
>>> I would still remove it since it is not used. When people need it
>>> they can introduce it again. For logging we have bbnote bbwarn and
>>> bbfatal from base.bbclass already.
>>>
>>> Our bitbake does not seem to know "debug_level" so it is outdated
>>> and unused.
>>
>> I'll send patch which introduces logging class and move all the
>> 'bbXXX' helpers to it (also fix bbdebug).
> 
> Please do not touch base.bbclass! Or come up with one that is really
> different from the bitbake default one for a good reason.
> 

Why base.bbclass should stay untouched? If default bitbake contains 
garbage, should we still keep it and workaround as much as possible?

>> I really don't like the idea to drop debug capabilities only because
>> they are not used at the moment. If this interface is going to be
>> dropped, then we need to introduce new interface before.
> 
> Like Isar was used by anyone or this was anything like a tiny
> broken print function.... without users or a release who cares about
> interfaces? But keep it like the bugs in ext4!

In my previous comment I mentioned, that bbdebug should be fixed.

> 
> Can we please start dicsussing the real patches?

This discussion relates to real patch.

>>>>>> I think it makes sense to keep it to debug complicated classes
>>>>>> and recipes in future.
>>>>>
>>>>> Ok.
>>>>>
>>>>> Henning
>>>>>      
>>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild
>>>>>> <henning.schild@siemens.com>:
>>>>>>      
>>>>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>>>>>>> ---
>>>>>>>    meta/classes/isar-base.bbclass | 12 ------------
>>>>>>>    1 file changed, 12 deletions(-)
>>>>>>>
>>>>>>> diff --git a/meta/classes/isar-base.bbclass
>>>>>>> b/meta/classes/isar-base. bbclass
>>>>>>> index 67d38a1..efd4223 100644
>>>>>>> --- a/meta/classes/isar-base.bbclass
>>>>>>> +++ b/meta/classes/isar-base.bbclass
>>>>>>> @@ -21,16 +21,4 @@
>>>>>>>
>>>>>>>    THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
>>>>>>>
>>>>>>> -bbdebug() {
>>>>>>> -       test $# -ge 2 || {
>>>>>>> -               echo "Usage: bbdebug level \"message\""
>>>>>>> -               exit 1
>>>>>>> -       }
>>>>>>> -
>>>>>>> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
>>>>>>> -               shift
>>>>>>> -               echo "DEBUG:" $*
>>>>>>> -       }
>>>>>>> -}
>>>>>>> -
>>>>>>>    do_build[nostamp] = "0"
>>>>>>> --
>>>>>>> 2.13.0
>>>>>>>
>>>>>>>      
>>>>>
>>>>>      
>>>    
>>
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Henning Schild]

Am Tue, 8 Aug 2017 16:24:44 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> On 08/08/2017 04:12 PM, Henning Schild wrote:
> > Am Tue, 8 Aug 2017 15:29:35 +0300
> > schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> >   
> >> Hi,
> >>
> >> On 08/08/2017 03:08 PM, Henning Schild wrote:  
> >>> Am Tue, 8 Aug 2017 12:33:58 +0300
> >>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >>>      
> >>>> 2017-08-08 11:05 GMT+03:00 Henning Schild
> >>>> <henning.schild@siemens.com>:
> >>>>     
> >>>>> Am Mon, 7 Aug 2017 22:36:18 +0300
> >>>>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >>>>>        
> >>>>>> I'm not sure that this function is unused. It's usually used
> >>>>>> for debug purposes to route traces to console.  
> >>>>>
> >>>>> It is unused in Isar and not part of the default base class of
> >>>>> bitbake.  
> >>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> >>>>>> chapter: 2.3.8.2  
> >>>>>
> >>>>> OE implements it in meta/classes/logging.bbclass
> >>>>>
> >>>>>        
> >>>> That's a good hint! So probably we can move this function to
> >>>> similar class instead of removing it.  
> >>>
> >>> I would still remove it since it is not used. When people need it
> >>> they can introduce it again. For logging we have bbnote bbwarn and
> >>> bbfatal from base.bbclass already.
> >>>
> >>> Our bitbake does not seem to know "debug_level" so it is outdated
> >>> and unused.  
> >>
> >> I'll send patch which introduces logging class and move all the
> >> 'bbXXX' helpers to it (also fix bbdebug).  
> > 
> > Please do not touch base.bbclass! Or come up with one that is really
> > different from the bitbake default one for a good reason.
> >   
> 
> Why base.bbclass should stay untouched? If default bitbake contains 
> garbage, should we still keep it and workaround as much as possible?

To be able to update bitbake without using copied parts of the old
bitbake. If we use code from the default base.bbclass this should be
done with inheritance and not copying.

Getting a copy is exactly how we got broken listtasks in the first
place.

Henning

> >> I really don't like the idea to drop debug capabilities only
> >> because they are not used at the moment. If this interface is
> >> going to be dropped, then we need to introduce new interface
> >> before.  
> > 
> > Like Isar was used by anyone or this was anything like a tiny
> > broken print function.... without users or a release who cares about
> > interfaces? But keep it like the bugs in ext4!  
> 
> In my previous comment I mentioned, that bbdebug should be fixed.
> 
> > 
> > Can we please start dicsussing the real patches?  
> 
> This discussion relates to real patch.
> 
> >>>>>> I think it makes sense to keep it to debug complicated classes
> >>>>>> and recipes in future.  
> >>>>>
> >>>>> Ok.
> >>>>>
> >>>>> Henning
> >>>>>        
> >>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild
> >>>>>> <henning.schild@siemens.com>:
> >>>>>>        
> >>>>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> >>>>>>> ---
> >>>>>>>    meta/classes/isar-base.bbclass | 12 ------------
> >>>>>>>    1 file changed, 12 deletions(-)
> >>>>>>>
> >>>>>>> diff --git a/meta/classes/isar-base.bbclass
> >>>>>>> b/meta/classes/isar-base. bbclass
> >>>>>>> index 67d38a1..efd4223 100644
> >>>>>>> --- a/meta/classes/isar-base.bbclass
> >>>>>>> +++ b/meta/classes/isar-base.bbclass
> >>>>>>> @@ -21,16 +21,4 @@
> >>>>>>>
> >>>>>>>    THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> >>>>>>>
> >>>>>>> -bbdebug() {
> >>>>>>> -       test $# -ge 2 || {
> >>>>>>> -               echo "Usage: bbdebug level \"message\""
> >>>>>>> -               exit 1
> >>>>>>> -       }
> >>>>>>> -
> >>>>>>> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> >>>>>>> -               shift
> >>>>>>> -               echo "DEBUG:" $*
> >>>>>>> -       }
> >>>>>>> -}
> >>>>>>> -
> >>>>>>>    do_build[nostamp] = "0"
> >>>>>>> --
> >>>>>>> 2.13.0
> >>>>>>>
> >>>>>>>        
> >>>>>
> >>>>>        
> >>>      
> >>  
> >   
> 

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Baurzhan Ismagulov]

On Tue, Aug 08, 2017 at 04:21:37PM +0200, Henning Schild wrote:
> To be able to update bitbake without using copied parts of the old
> bitbake. If we use code from the default base.bbclass this should be
> done with inheritance and not copying.

In general, I agree with the approach.

In practice, bitbake interfaces are not stable. This means that one generally
can't update bitbake version without thorough testing. We have to work with
upstream regarding this.


> > > Like Isar was used by anyone or this was anything like a tiny
> > > broken print function.... without users or a release who cares about
> > > interfaces?

We started 2004 from a single shell script. There is actually working code
using a newer bitbake version, where this verbatim bbdebug() works. That code
is proprietary; we decided not to publish it as is and instead merge features
from it into a new code base, Isar. This verbatim base.class comes from that
original code base. Not all features have been migrated yet; e.g., building
from .dsc files is pending -- FWIW, due to changed bitbake API. And yes, there
are users of Isar, as well as releases 0.1 and 0.2.

I've applied the patch because bbdebug() was broken in Isar as it was. That
said, I also don't like removing code without introducing a replacement.
Providing debugging infrastructure to users, however small, is important for
lowering the entry barrier. When we update bitbake, we should also take the
logging functionality.


> But keep it like the bugs in ext4!  
> > > 
> > > Can we please start dicsussing the real patches?  

Let's remain factual, respect others' work and use appropriate language / tone.


With kind regards,
Baurzhan.

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Alexander Smirnov]

On 08/08/2017 04:12 PM, Henning Schild wrote:
> Am Tue, 8 Aug 2017 15:29:35 +0300
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
>> Hi,
>>
>> On 08/08/2017 03:08 PM, Henning Schild wrote:
>>> Am Tue, 8 Aug 2017 12:33:58 +0300
>>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>>>    
>>>> 2017-08-08 11:05 GMT+03:00 Henning Schild
>>>> <henning.schild@siemens.com>:
>>>>   
>>>>> Am Mon, 7 Aug 2017 22:36:18 +0300
>>>>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>>>>>      
>>>>>> I'm not sure that this function is unused. It's usually used for
>>>>>> debug purposes to route traces to console.
>>>>>
>>>>> It is unused in Isar and not part of the default base class of
>>>>> bitbake.
>>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
>>>>>> chapter: 2.3.8.2
>>>>>
>>>>> OE implements it in meta/classes/logging.bbclass
>>>>>
>>>>>      
>>>> That's a good hint! So probably we can move this function to
>>>> similar class instead of removing it.
>>>
>>> I would still remove it since it is not used. When people need it
>>> they can introduce it again. For logging we have bbnote bbwarn and
>>> bbfatal from base.bbclass already.

Ahh, I suppose I got it now, I thought that bbdebug was a part of 
default base.class, that why I insisted on keeping it. But now I see 
that default class doesn't contain this blob. Ok, agreed.

Alex

>>>
>>> Our bitbake does not seem to know "debug_level" so it is outdated
>>> and unused.
>>
>> I'll send patch which introduces logging class and move all the
>> 'bbXXX' helpers to it (also fix bbdebug).
> 
> Please do not touch base.bbclass! Or come up with one that is really
> different from the bitbake default one for a good reason.
> 
>> I really don't like the idea to drop debug capabilities only because
>> they are not used at the moment. If this interface is going to be
>> dropped, then we need to introduce new interface before.
> 
> Like Isar was used by anyone or this was anything like a tiny
> broken print function.... without users or a release who cares about
> interfaces? But keep it like the bugs in ext4!
> 
> Can we please start dicsussing the real patches?
> 
> Henning
> 
>> Alex
>>
>>>    
>>>>   
>>>>>> I think it makes sense to keep it to debug complicated classes
>>>>>> and recipes in future.
>>>>>
>>>>> Ok.
>>>>>
>>>>> Henning
>>>>>      
>>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild
>>>>>> <henning.schild@siemens.com>:
>>>>>>      
>>>>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>>>>>>> ---
>>>>>>>    meta/classes/isar-base.bbclass | 12 ------------
>>>>>>>    1 file changed, 12 deletions(-)
>>>>>>>
>>>>>>> diff --git a/meta/classes/isar-base.bbclass
>>>>>>> b/meta/classes/isar-base. bbclass
>>>>>>> index 67d38a1..efd4223 100644
>>>>>>> --- a/meta/classes/isar-base.bbclass
>>>>>>> +++ b/meta/classes/isar-base.bbclass
>>>>>>> @@ -21,16 +21,4 @@
>>>>>>>
>>>>>>>    THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
>>>>>>>
>>>>>>> -bbdebug() {
>>>>>>> -       test $# -ge 2 || {
>>>>>>> -               echo "Usage: bbdebug level \"message\""
>>>>>>> -               exit 1
>>>>>>> -       }
>>>>>>> -
>>>>>>> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
>>>>>>> -               shift
>>>>>>> -               echo "DEBUG:" $*
>>>>>>> -       }
>>>>>>> -}
>>>>>>> -
>>>>>>>    do_build[nostamp] = "0"
>>>>>>> --
>>>>>>> 2.13.0
>>>>>>>
>>>>>>>      
>>>>>
>>>>>      
>>>    
>>
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Henning Schild]

Am Tue, 8 Aug 2017 16:47:26 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> On 08/08/2017 04:12 PM, Henning Schild wrote:
> > Am Tue, 8 Aug 2017 15:29:35 +0300
> > schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> >   
> >> Hi,
> >>
> >> On 08/08/2017 03:08 PM, Henning Schild wrote:  
> >>> Am Tue, 8 Aug 2017 12:33:58 +0300
> >>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >>>      
> >>>> 2017-08-08 11:05 GMT+03:00 Henning Schild
> >>>> <henning.schild@siemens.com>:
> >>>>     
> >>>>> Am Mon, 7 Aug 2017 22:36:18 +0300
> >>>>> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >>>>>        
> >>>>>> I'm not sure that this function is unused. It's usually used
> >>>>>> for debug purposes to route traces to console.  
> >>>>>
> >>>>> It is unused in Isar and not part of the default base class of
> >>>>> bitbake.  
> >>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> >>>>>> chapter: 2.3.8.2  
> >>>>>
> >>>>> OE implements it in meta/classes/logging.bbclass
> >>>>>
> >>>>>        
> >>>> That's a good hint! So probably we can move this function to
> >>>> similar class instead of removing it.  
> >>>
> >>> I would still remove it since it is not used. When people need it
> >>> they can introduce it again. For logging we have bbnote bbwarn and
> >>> bbfatal from base.bbclass already.  
> 
> Ahh, I suppose I got it now, I thought that bbdebug was a part of 
> default base.class, that why I insisted on keeping it. But now I see 
> that default class doesn't contain this blob. Ok, agreed.

Ok, nice!

Henning

> Alex
> 
> >>>
> >>> Our bitbake does not seem to know "debug_level" so it is outdated
> >>> and unused.  
> >>
> >> I'll send patch which introduces logging class and move all the
> >> 'bbXXX' helpers to it (also fix bbdebug).  
> > 
> > Please do not touch base.bbclass! Or come up with one that is really
> > different from the bitbake default one for a good reason.
> >   
> >> I really don't like the idea to drop debug capabilities only
> >> because they are not used at the moment. If this interface is
> >> going to be dropped, then we need to introduce new interface
> >> before.  
> > 
> > Like Isar was used by anyone or this was anything like a tiny
> > broken print function.... without users or a release who cares about
> > interfaces? But keep it like the bugs in ext4!
> > 
> > Can we please start dicsussing the real patches?
> > 
> > Henning
> >   
> >> Alex
> >>  
> >>>      
> >>>>     
> >>>>>> I think it makes sense to keep it to debug complicated classes
> >>>>>> and recipes in future.  
> >>>>>
> >>>>> Ok.
> >>>>>
> >>>>> Henning
> >>>>>        
> >>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild
> >>>>>> <henning.schild@siemens.com>:
> >>>>>>        
> >>>>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> >>>>>>> ---
> >>>>>>>    meta/classes/isar-base.bbclass | 12 ------------
> >>>>>>>    1 file changed, 12 deletions(-)
> >>>>>>>
> >>>>>>> diff --git a/meta/classes/isar-base.bbclass
> >>>>>>> b/meta/classes/isar-base. bbclass
> >>>>>>> index 67d38a1..efd4223 100644
> >>>>>>> --- a/meta/classes/isar-base.bbclass
> >>>>>>> +++ b/meta/classes/isar-base.bbclass
> >>>>>>> @@ -21,16 +21,4 @@
> >>>>>>>
> >>>>>>>    THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> >>>>>>>
> >>>>>>> -bbdebug() {
> >>>>>>> -       test $# -ge 2 || {
> >>>>>>> -               echo "Usage: bbdebug level \"message\""
> >>>>>>> -               exit 1
> >>>>>>> -       }
> >>>>>>> -
> >>>>>>> -       test ${@bb.msg.debug_level['default']} -ge $1 && {
> >>>>>>> -               shift
> >>>>>>> -               echo "DEBUG:" $*
> >>>>>>> -       }
> >>>>>>> -}
> >>>>>>> -
> >>>>>>>    do_build[nostamp] = "0"
> >>>>>>> --
> >>>>>>> 2.13.0
> >>>>>>>
> >>>>>>>        
> >>>>>
> >>>>>        
> >>>      
> >>  
> >   
> 

Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function

[Baurzhan Ismagulov]

On Thu, Aug 03, 2017 at 01:55:51PM +0200, Henning Schild wrote:
> Signed-off-by: Henning Schild <henning.schild@siemens.com>

Applied with comment amendments, thanks. Forgot to add Signed-off-by for that,
sorry.

With kind regards,
Baurzhan.

[PATCH 0-10 of 16 v2 3/8] remove redundant variable THISDIR

[Henning Schild]

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta-isar/recipes-core/images/isar-image-base.bb |  8 ++++----
 meta/classes/isar-base.bbclass                   |  2 --
 meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +++++-----
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
index 337c329..0810de0 100644
--- a/meta-isar/recipes-core/images/isar-image-base.bb
+++ b/meta-isar/recipes-core/images/isar-image-base.bb
@@ -27,10 +27,10 @@ do_rootfs() {
     install -d -m 755 ${WORKDIR}/hooks_multistrap
 
     # Copy config file
-    install -m 644 ${THISDIR}/files/multistrap.conf.in ${WORKDIR}/multistrap.conf
-    install -m 755 ${THISDIR}/files/${DISTRO_CONFIG_SCRIPT} ${WORKDIR}/configscript.sh
-    install -m 755 ${THISDIR}/files/setup.sh ${WORKDIR}
-    install -m 755 ${THISDIR}/files/download_dev-random ${WORKDIR}/hooks_multistrap/
+    install -m 644 ${FILESDIR}/multistrap.conf.in ${WORKDIR}/multistrap.conf
+    install -m 755 ${FILESDIR}/${DISTRO_CONFIG_SCRIPT} ${WORKDIR}/configscript.sh
+    install -m 755 ${FILESDIR}/setup.sh ${WORKDIR}
+    install -m 755 ${FILESDIR}/download_dev-random ${WORKDIR}/hooks_multistrap/
 
     # Adjust multistrap config
     sed -i 's|##IMAGE_PREINSTALL##|${IMAGE_PREINSTALL}|' ${WORKDIR}/multistrap.conf
diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.bbclass
index efd4223..d860937 100644
--- a/meta/classes/isar-base.bbclass
+++ b/meta/classes/isar-base.bbclass
@@ -19,6 +19,4 @@
 # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 # OTHER DEALINGS IN THE SOFTWARE.
 
-THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
-
 do_build[nostamp] = "0"
diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb
index ba1bc66..f471f5e 100644
--- a/meta/recipes-devtools/buildchroot/buildchroot.bb
+++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
@@ -29,10 +29,10 @@ do_build() {
     install -d -m 755 ${WORKDIR}/hooks_multistrap
 
     # Copy config files
-    install -m 644 ${THISDIR}/files/multistrap.conf.in ${WORKDIR}/multistrap.conf
-    install -m 755 ${THISDIR}/files/configscript.sh ${WORKDIR}
-    install -m 755 ${THISDIR}/files/setup.sh ${WORKDIR}
-    install -m 755 ${THISDIR}/files/download_dev-random ${WORKDIR}/hooks_multistrap/
+    install -m 644 ${FILESDIR}/multistrap.conf.in ${WORKDIR}/multistrap.conf
+    install -m 755 ${FILESDIR}/configscript.sh ${WORKDIR}
+    install -m 755 ${FILESDIR}/setup.sh ${WORKDIR}
+    install -m 755 ${FILESDIR}/download_dev-random ${WORKDIR}/hooks_multistrap/
 
     # Adjust multistrap config
     sed -i 's|##BUILDCHROOT_PREINSTALL##|${BUILDCHROOT_PREINSTALL}|' ${WORKDIR}/multistrap.conf
@@ -51,7 +51,7 @@ do_build() {
     sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f "${WORKDIR}/multistrap.conf" || true
 
     # Install package builder script
-    sudo install -m 755 ${THISDIR}/files/build.sh ${BUILDCHROOT_DIR}
+    sudo install -m 755 ${FILESDIR}/build.sh ${BUILDCHROOT_DIR}
 
     # Configure root filesystem
     sudo chroot ${BUILDCHROOT_DIR} /configscript.sh
-- 
2.13.0

Re: [PATCH 0-10 of 16 v2 3/8] remove redundant variable THISDIR

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 3577 bytes --]

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta-isar/recipes-core/images/isar-image-base.bb |  8 ++++----
>  meta/classes/isar-base.bbclass                   |  2 --
>  meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +++++-----
>  3 files changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
> b/meta-isar/recipes-core/images/isar-image-base.bb
> index 337c329..0810de0 100644
> --- a/meta-isar/recipes-core/images/isar-image-base.bb
> +++ b/meta-isar/recipes-core/images/isar-image-base.bb
> @@ -27,10 +27,10 @@ do_rootfs() {
>      install -d -m 755 ${WORKDIR}/hooks_multistrap
>
>      # Copy config file
> -    install -m 644 ${THISDIR}/files/multistrap.conf.in
> ${WORKDIR}/multistrap.conf
> -    install -m 755 ${THISDIR}/files/${DISTRO_CONFIG_SCRIPT}
> ${WORKDIR}/configscript.sh
> -    install -m 755 ${THISDIR}/files/setup.sh ${WORKDIR}
> -    install -m 755 ${THISDIR}/files/download_dev-random
> ${WORKDIR}/hooks_multistrap/
> +    install -m 644 ${FILESDIR}/multistrap.conf.in
> ${WORKDIR}/multistrap.conf
> +    install -m 755 ${FILESDIR}/${DISTRO_CONFIG_SCRIPT}
> ${WORKDIR}/configscript.sh
> +    install -m 755 ${FILESDIR}/setup.sh ${WORKDIR}
> +    install -m 755 ${FILESDIR}/download_dev-random
> ${WORKDIR}/hooks_multistrap/
>
>      # Adjust multistrap config
>      sed -i 's|##IMAGE_PREINSTALL##|${IMAGE_PREINSTALL}|'
> ${WORKDIR}/multistrap.conf
> diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.
> bbclass
> index efd4223..d860937 100644
> --- a/meta/classes/isar-base.bbclass
> +++ b/meta/classes/isar-base.bbclass
> @@ -19,6 +19,4 @@
>  # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>  # OTHER DEALINGS IN THE SOFTWARE.
>
> -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> -
>  do_build[nostamp] = "0"
> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb
> b/meta/recipes-devtools/buildchroot/buildchroot.bb
> index ba1bc66..f471f5e 100644
> --- a/meta/recipes-devtools/buildchroot/buildchroot.bb
> +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
> @@ -29,10 +29,10 @@ do_build() {
>      install -d -m 755 ${WORKDIR}/hooks_multistrap
>
>      # Copy config files
> -    install -m 644 ${THISDIR}/files/multistrap.conf.in
> ${WORKDIR}/multistrap.conf
> -    install -m 755 ${THISDIR}/files/configscript.sh ${WORKDIR}
> -    install -m 755 ${THISDIR}/files/setup.sh ${WORKDIR}
> -    install -m 755 ${THISDIR}/files/download_dev-random
> ${WORKDIR}/hooks_multistrap/
> +    install -m 644 ${FILESDIR}/multistrap.conf.in
> ${WORKDIR}/multistrap.conf
> +    install -m 755 ${FILESDIR}/configscript.sh ${WORKDIR}
> +    install -m 755 ${FILESDIR}/setup.sh ${WORKDIR}
> +    install -m 755 ${FILESDIR}/download_dev-random
> ${WORKDIR}/hooks_multistrap/
>
>      # Adjust multistrap config
>      sed -i 's|##BUILDCHROOT_PREINSTALL##|${BUILDCHROOT_PREINSTALL}|'
> ${WORKDIR}/multistrap.conf
> @@ -51,7 +51,7 @@ do_build() {
>      sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f
> "${WORKDIR}/multistrap.conf" || true
>
>      # Install package builder script
> -    sudo install -m 755 ${THISDIR}/files/build.sh ${BUILDCHROOT_DIR}
> +    sudo install -m 755 ${FILESDIR}/build.sh ${BUILDCHROOT_DIR}
>
>      # Configure root filesystem
>      sudo chroot ${BUILDCHROOT_DIR} /configscript.sh
> --
> 2.13.0
>
>
As I already mentioned, there is a build problem, need further
investigation about python version.

[-- Attachment #2: Type: text/html, Size: 5525 bytes --]

Re: [PATCH 0-10 of 16 v2 3/8] remove redundant variable THISDIR

[Henning Schild]

Am Mon, 7 Aug 2017 22:30:48 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  meta-isar/recipes-core/images/isar-image-base.bb |  8 ++++----
> >  meta/classes/isar-base.bbclass                   |  2 --
> >  meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +++++-----
> >  3 files changed, 9 insertions(+), 11 deletions(-)
> >
> > diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
> > b/meta-isar/recipes-core/images/isar-image-base.bb
> > index 337c329..0810de0 100644
> > --- a/meta-isar/recipes-core/images/isar-image-base.bb
> > +++ b/meta-isar/recipes-core/images/isar-image-base.bb
> > @@ -27,10 +27,10 @@ do_rootfs() {
> >      install -d -m 755 ${WORKDIR}/hooks_multistrap
> >
> >      # Copy config file
> > -    install -m 644 ${THISDIR}/files/multistrap.conf.in
> > ${WORKDIR}/multistrap.conf
> > -    install -m 755 ${THISDIR}/files/${DISTRO_CONFIG_SCRIPT}
> > ${WORKDIR}/configscript.sh
> > -    install -m 755 ${THISDIR}/files/setup.sh ${WORKDIR}
> > -    install -m 755 ${THISDIR}/files/download_dev-random
> > ${WORKDIR}/hooks_multistrap/
> > +    install -m 644 ${FILESDIR}/multistrap.conf.in
> > ${WORKDIR}/multistrap.conf
> > +    install -m 755 ${FILESDIR}/${DISTRO_CONFIG_SCRIPT}
> > ${WORKDIR}/configscript.sh
> > +    install -m 755 ${FILESDIR}/setup.sh ${WORKDIR}
> > +    install -m 755 ${FILESDIR}/download_dev-random
> > ${WORKDIR}/hooks_multistrap/
> >
> >      # Adjust multistrap config
> >      sed -i 's|##IMAGE_PREINSTALL##|${IMAGE_PREINSTALL}|'
> > ${WORKDIR}/multistrap.conf
> > diff --git a/meta/classes/isar-base.bbclass
> > b/meta/classes/isar-base. bbclass
> > index efd4223..d860937 100644
> > --- a/meta/classes/isar-base.bbclass
> > +++ b/meta/classes/isar-base.bbclass
> > @@ -19,6 +19,4 @@
> >  # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
> > USE OR # OTHER DEALINGS IN THE SOFTWARE.
> >
> > -THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
> > -
> >  do_build[nostamp] = "0"
> > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb
> > b/meta/recipes-devtools/buildchroot/buildchroot.bb
> > index ba1bc66..f471f5e 100644
> > --- a/meta/recipes-devtools/buildchroot/buildchroot.bb
> > +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
> > @@ -29,10 +29,10 @@ do_build() {
> >      install -d -m 755 ${WORKDIR}/hooks_multistrap
> >
> >      # Copy config files
> > -    install -m 644 ${THISDIR}/files/multistrap.conf.in
> > ${WORKDIR}/multistrap.conf
> > -    install -m 755 ${THISDIR}/files/configscript.sh ${WORKDIR}
> > -    install -m 755 ${THISDIR}/files/setup.sh ${WORKDIR}
> > -    install -m 755 ${THISDIR}/files/download_dev-random
> > ${WORKDIR}/hooks_multistrap/
> > +    install -m 644 ${FILESDIR}/multistrap.conf.in
> > ${WORKDIR}/multistrap.conf
> > +    install -m 755 ${FILESDIR}/configscript.sh ${WORKDIR}
> > +    install -m 755 ${FILESDIR}/setup.sh ${WORKDIR}
> > +    install -m 755 ${FILESDIR}/download_dev-random
> > ${WORKDIR}/hooks_multistrap/
> >
> >      # Adjust multistrap config
> >      sed -i
> > 's|##BUILDCHROOT_PREINSTALL##|${BUILDCHROOT_PREINSTALL}|'
> > ${WORKDIR}/multistrap.conf @@ -51,7 +51,7 @@ do_build() {
> >      sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f
> > "${WORKDIR}/multistrap.conf" || true
> >
> >      # Install package builder script
> > -    sudo install -m 755 ${THISDIR}/files/build.sh
> > ${BUILDCHROOT_DIR}
> > +    sudo install -m 755 ${FILESDIR}/build.sh ${BUILDCHROOT_DIR}
> >
> >      # Configure root filesystem
> >      sudo chroot ${BUILDCHROOT_DIR} /configscript.sh
> > --
> > 2.13.0
> >
> >  
> As I already mentioned, there is a build problem, need further
> investigation about python version.

I do not remember that remark and do not see how it influences the
validity of this patch. Does the patch introduce the build-problem?

Henning

[PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Henning Schild]

force isar to always use a bitbake.conf from its bitbake
the diff went into a file that needs to be looked at later

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 .../{bitbake.conf.sample => isar-bitbake.conf}     | 32 ++-------------------
 scripts/isar-setup-builddir                        | 33 +++++++++++++++++++---
 2 files changed, 31 insertions(+), 34 deletions(-)
 rename meta/conf/{bitbake.conf.sample => isar-bitbake.conf} (59%)

diff --git a/meta/conf/bitbake.conf.sample b/meta/conf/isar-bitbake.conf
similarity index 59%
rename from meta/conf/bitbake.conf.sample
rename to meta/conf/isar-bitbake.conf
index 9d7c1f4..7469ea7 100644
--- a/meta/conf/bitbake.conf.sample
+++ b/meta/conf/isar-bitbake.conf
@@ -1,4 +1,4 @@
-# Copyright (C) 2003  Chris Larson
+# Copyright (C) 2017  Siemens AG
 #
 # Permission is hereby granted, free of charge, to any person obtaining a
 # copy of this software and associated documentation files (the "Software"),
@@ -18,45 +18,17 @@
 # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 # OTHER DEALINGS IN THE SOFTWARE.
 
-B = "${S}"
-CVSDIR = "${DL_DIR}/cvs"
-DEPENDS = ""
-DEPLOY_DIR = "${TMPDIR}/deploy"
+
 DEPLOY_DIR_DEB = "${TMPDIR}/deploy/deb/${MACHINE}"
-DEPLOY_DIR_IMAGE = "${DEPLOY_DIR}/images"
-DL_DIR = "${TMPDIR}/downloads"
 SSTATE_DIR ?= "${TMPDIR}/sstate-cache"
-FILESDIR = "${@bb.which(bb.data.getVar('FILESPATH', d, 1), '.')}"
-FILESPATH = "${FILE_DIRNAME}/${PF}:${FILE_DIRNAME}/${P}:${FILE_DIRNAME}/${PN}:${FILE_DIRNAME}/files:${FILE_DIRNAME}"
-FILE_DIRNAME = "${@os.path.dirname(bb.data.getVar('FILE', d))}"
-GITDIR = "${DL_DIR}/git"
-IMAGE_CMD = "_NO_DEFINED_IMAGE_TYPES_"
-IMAGE_ROOTFS = "${TMPDIR}/rootfs"
 MKTEMPCMD = "mktemp -q ${TMPBASE}"
 MKTEMPDIRCMD = "mktemp -d -q ${TMPBASE}"
-OVERRIDES = "local:${MACHINE}:${TARGET_OS}:${TARGET_ARCH}"
-P = "${PN}-${PV}"
-PERSISTENT_DIR = "${TMPDIR}/cache"
-PF = "${PN}-${PV}-${PR}"
-PN = "${@bb.parse.BBHandler.vars_from_file(bb.data.getVar('FILE',d),d)[0] or 'defaultpkgname'}"
-PR = "${@bb.parse.BBHandler.vars_from_file(bb.data.getVar('FILE',d),d)[2] or 'r0'}"
-PROVIDES = ""
-PV = "${@bb.parse.BBHandler.vars_from_file(bb.data.getVar('FILE',d),d)[1] or '1.0'}"
 RESUMECOMMAND = ""
 RESUMECOMMAND_wget = "/usr/bin/env wget -c -t 5 --passive-ftp -P ${DL_DIR} ${URI}"
-S = "${WORKDIR}/${P}"
-SRC_URI = "file://${FILE}"
 STAMPS_DIR ?= "${TMPDIR}/stamps"
-STAMP = "${TMPDIR}/stamps/${PF}"
-SVNDIR = "${DL_DIR}/svn"
-T = "${WORKDIR}/temp"
-TARGET_ARCH = "${BUILD_ARCH}"
-TMPDIR = "${TOPDIR}/tmp"
 UPDATECOMMAND = ""
 UPDATECOMMAND_cvs = "/usr/bin/env cvs -d${CVSROOT} update ${CVSCOOPTS}"
 UPDATECOMMAND_svn = "/usr/bin/env svn update ${SVNCOOPTS}"
-WORKDIR = "${TMPDIR}/work/${PF}"
-PERSISTENT_DIR = "${TMPDIR}/cache"
 BUILDCHROOT_DIR = "${TOPDIR}/tmp/work/buildchroot/${DISTRO}/rootfs"
 CACHE = "${TMPDIR}/cache"
 
diff --git a/scripts/isar-setup-builddir b/scripts/isar-setup-builddir
index 070a316..d400694 100755
--- a/scripts/isar-setup-builddir
+++ b/scripts/isar-setup-builddir
@@ -106,10 +106,35 @@ EOM
     SHOWYPDOC=yes
 fi
 
-if [ ! -f "$BUILDDIR/conf/bitbake.conf" ]; then
-    cp "$ISARROOT/meta/conf/bitbake.conf.sample" \
-       "$BUILDDIR/conf/bitbake.conf"
-fi
+cat <<EOF > $BUILDDIR/conf/bitbake.conf
+# ********************************************
+# THIS FILE IS GENERATED! DO NOT MESS WITH IT!
+# ********************************************
+
+# ---------
+# begin original bitbake.conf
+# ---------
+
+EOF
+cat "$ISARROOT/bitbake/conf/bitbake.conf" >> \
+  "$BUILDDIR/conf/bitbake.conf"
+cat <<EOF >> $BUILDDIR/conf/bitbake.conf
+# ---------
+# end original bitbake.conf
+# ---------
+
+# ---------
+# begin isar-bitbake.conf
+# ---------
+
+EOF
+cat "$ISARROOT/meta/conf/isar-bitbake.conf" >> \
+  "$BUILDDIR/conf/bitbake.conf"
+cat <<EOF >> $BUILDDIR/conf/bitbake.conf
+# ---------
+# end isar-bitbake.conf
+# ---------
+EOF
 
 # Ending the first-time run message. Show the no documentation banner.
 if [ ! -z "$SHOWYPDOC" ]; then
-- 
2.13.0

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 4353 bytes --]

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> force isar to always use a bitbake.conf from its bitbake
> the diff went into a file that needs to be looked at later
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  .../{bitbake.conf.sample => isar-bitbake.conf}     | 32
> ++-------------------
>  scripts/isar-setup-builddir                        | 33
> +++++++++++++++++++---
>  2 files changed, 31 insertions(+), 34 deletions(-)
>  rename meta/conf/{bitbake.conf.sample => isar-bitbake.conf} (59%)
>
> diff --git a/meta/conf/bitbake.conf.sample b/meta/conf/isar-bitbake.conf
> similarity index 59%
> rename from meta/conf/bitbake.conf.sample
> rename to meta/conf/isar-bitbake.conf
> index 9d7c1f4..7469ea7 100644
> --- a/meta/conf/bitbake.conf.sample
> +++ b/meta/conf/isar-bitbake.conf
> @@ -1,4 +1,4 @@
> -# Copyright (C) 2003  Chris Larson
> +# Copyright (C) 2017  Siemens AG
>  #
>  # Permission is hereby granted, free of charge, to any person obtaining a
>  # copy of this software and associated documentation files (the
> "Software"),
> @@ -18,45 +18,17 @@
>  # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>  # OTHER DEALINGS IN THE SOFTWARE.
>
> -B = "${S}"
> -CVSDIR = "${DL_DIR}/cvs"
> -DEPENDS = ""
> -DEPLOY_DIR = "${TMPDIR}/deploy"
> +
>  DEPLOY_DIR_DEB = "${TMPDIR}/deploy/deb/${MACHINE}"
> -DEPLOY_DIR_IMAGE = "${DEPLOY_DIR}/images"
> -DL_DIR = "${TMPDIR}/downloads"
>  SSTATE_DIR ?= "${TMPDIR}/sstate-cache"
> -FILESDIR = "${@bb.which(bb.data.getVar('FILESPATH', d, 1), '.')}"
> -FILESPATH = "${FILE_DIRNAME}/${PF}:${FILE_DIRNAME}/${P}:${FILE_DIRNAME}/
> ${PN}:${FILE_DIRNAME}/files:${FILE_DIRNAME}"
> -FILE_DIRNAME = "${@os.path.dirname(bb.data.getVar('FILE', d))}"
> -GITDIR = "${DL_DIR}/git"
> -IMAGE_CMD = "_NO_DEFINED_IMAGE_TYPES_"
> -IMAGE_ROOTFS = "${TMPDIR}/rootfs"
>  MKTEMPCMD = "mktemp -q ${TMPBASE}"
>  MKTEMPDIRCMD = "mktemp -d -q ${TMPBASE}"
> -OVERRIDES = "local:${MACHINE}:${TARGET_OS}:${TARGET_ARCH}"
> -P = "${PN}-${PV}"
> -PERSISTENT_DIR = "${TMPDIR}/cache"
> -PF = "${PN}-${PV}-${PR}"
> -PN = "${@bb.parse.BBHandler.vars_from_file(bb.data.getVar('FILE',d),d)[0]
> or 'defaultpkgname'}"
> -PR = "${@bb.parse.BBHandler.vars_from_file(bb.data.getVar('FILE',d),d)[2]
> or 'r0'}"
> -PROVIDES = ""
> -PV = "${@bb.parse.BBHandler.vars_from_file(bb.data.getVar('FILE',d),d)[1]
> or '1.0'}"
>  RESUMECOMMAND = ""
>  RESUMECOMMAND_wget = "/usr/bin/env wget -c -t 5 --passive-ftp -P
> ${DL_DIR} ${URI}"
> -S = "${WORKDIR}/${P}"
> -SRC_URI = "file://${FILE}"
>  STAMPS_DIR ?= "${TMPDIR}/stamps"
> -STAMP = "${TMPDIR}/stamps/${PF}"
> -SVNDIR = "${DL_DIR}/svn"
> -T = "${WORKDIR}/temp"
> -TARGET_ARCH = "${BUILD_ARCH}"
> -TMPDIR = "${TOPDIR}/tmp"
>  UPDATECOMMAND = ""
>  UPDATECOMMAND_cvs = "/usr/bin/env cvs -d${CVSROOT} update ${CVSCOOPTS}"
>  UPDATECOMMAND_svn = "/usr/bin/env svn update ${SVNCOOPTS}"
> -WORKDIR = "${TMPDIR}/work/${PF}"
> -PERSISTENT_DIR = "${TMPDIR}/cache"
>  BUILDCHROOT_DIR = "${TOPDIR}/tmp/work/buildchroot/${DISTRO}/rootfs"
>  CACHE = "${TMPDIR}/cache"
>
> diff --git a/scripts/isar-setup-builddir b/scripts/isar-setup-builddir
> index 070a316..d400694 100755
> --- a/scripts/isar-setup-builddir
> +++ b/scripts/isar-setup-builddir
> @@ -106,10 +106,35 @@ EOM
>      SHOWYPDOC=yes
>  fi
>
> -if [ ! -f "$BUILDDIR/conf/bitbake.conf" ]; then
> -    cp "$ISARROOT/meta/conf/bitbake.conf.sample" \
> -       "$BUILDDIR/conf/bitbake.conf"
> -fi
> +cat <<EOF > $BUILDDIR/conf/bitbake.conf
> +# ********************************************
> +# THIS FILE IS GENERATED! DO NOT MESS WITH IT!
> +# ********************************************
> +
> +# ---------
> +# begin original bitbake.conf
> +# ---------
> +
> +EOF
> +cat "$ISARROOT/bitbake/conf/bitbake.conf" >> \
> +  "$BUILDDIR/conf/bitbake.conf"
> +cat <<EOF >> $BUILDDIR/conf/bitbake.conf
> +# ---------
> +# end original bitbake.conf
> +# ---------
> +
> +# ---------
> +# begin isar-bitbake.conf
> +# ---------
> +
> +EOF
> +cat "$ISARROOT/meta/conf/isar-bitbake.conf" >> \
> +  "$BUILDDIR/conf/bitbake.conf"
> +cat <<EOF >> $BUILDDIR/conf/bitbake.conf
> +# ---------
> +# end isar-bitbake.conf
> +# ---------
> +EOF
>
>  # Ending the first-time run message. Show the no documentation banner.
>  if [ ! -z "$SHOWYPDOC" ]; then
> --
> 2.13.0
>
>
Merged to asmirnov/next

[-- Attachment #2: Type: text/html, Size: 5921 bytes --]

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Baurzhan Ismagulov]

On Thu, Aug 03, 2017 at 01:55:53PM +0200, Henning Schild wrote:
> force isar to always use a bitbake.conf from its bitbake
> the diff went into a file that needs to be looked at later

Applied with comment amendments, thanks.

Alex has updated the commit comment to reflect also the motivation for the
change. In the commit comment, please use complete sentences (first cap, period
at the end).

We had considered the split configuration in the beginning and have seen that
1. Yocto forks it, and 2. bitbake doesn't seem to support reading both by
itself. These were the reasons why we also forked the file.

(1) might be caused by the fact that there are no major bitbake users except
Yocto, so both are possibly not clearly separated. The separation has value for
Isar, since it clearly shows what is different, that is why I've applied the
patch.

(2) is worse, as IMHO, bitbake should do that itself and it doesn't
(https://github.com/ilbers/isar/issues/27). Concatenating configs is magic that
Yocto users do not expect, and this has to be documented. Could you provide a
patch for the manual?

With kind regards,
Baurzhan.

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Henning Schild]

Am Mon, 21 Aug 2017 15:25:39 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Thu, Aug 03, 2017 at 01:55:53PM +0200, Henning Schild wrote:
> > force isar to always use a bitbake.conf from its bitbake
> > the diff went into a file that needs to be looked at later  
> 
> Applied with comment amendments, thanks.

Ok.

> Alex has updated the commit comment to reflect also the motivation
> for the change. In the commit comment, please use complete sentences
> (first cap, period at the end).

Yes i have seen that.

> We had considered the split configuration in the beginning and have
> seen that 1. Yocto forks it, and 2. bitbake doesn't seem to support
> reading both by itself. These were the reasons why we also forked the
> file.
> 
> (1) might be caused by the fact that there are no major bitbake users
> except Yocto, so both are possibly not clearly separated. The
> separation has value for Isar, since it clearly shows what is
> different, that is why I've applied the patch.
> 
> (2) is worse, as IMHO, bitbake should do that itself and it doesn't
> (https://github.com/ilbers/isar/issues/27). Concatenating configs is
> magic that Yocto users do not expect, and this has to be documented.
> Could you provide a patch for the manual?

No. You do not apply a patch directly to master if that creates an
issue, you could have asked me for a v3 instead. Please revert or
provide the patch to the manual yourself.

Henning

> With kind regards,
> Baurzhan.
> 

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Baurzhan Ismagulov]

On Mon, Aug 21, 2017 at 08:29:40PM +0200, Henning Schild wrote:
> > (2) is worse, as IMHO, bitbake should do that itself and it doesn't
> > (https://github.com/ilbers/isar/issues/27). Concatenating configs is
> > magic that Yocto users do not expect, and this has to be documented.
> > Could you provide a patch for the manual?
> 
> No. You do not apply a patch directly to master if that creates an
> issue, you could have asked me for a v3 instead. Please revert or
> provide the patch to the manual yourself.

In general, this is our intended approach (although in this particular case I'd
still not block the inclusion of a patch that has value for the project by a
required bitbake change upstream -- but that is a different story). Our current
focus is to work together to improve Isar and process the patch backlog --
which I thought you agreed with Alex on phone. If this doesn't help you and you
prefer the other model -- let's do it that way, it will only save my time.

With kind regards,
Baurzhan.

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Henning Schild]

Am Tue, 22 Aug 2017 13:31:29 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Mon, Aug 21, 2017 at 08:29:40PM +0200, Henning Schild wrote:
> > > (2) is worse, as IMHO, bitbake should do that itself and it
> > > doesn't (https://github.com/ilbers/isar/issues/27). Concatenating
> > > configs is magic that Yocto users do not expect, and this has to
> > > be documented. Could you provide a patch for the manual?  
> > 
> > No. You do not apply a patch directly to master if that creates an
> > issue, you could have asked me for a v3 instead. Please revert or
> > provide the patch to the manual yourself.  
> 
> In general, this is our intended approach (although in this
> particular case I'd still not block the inclusion of a patch that has
> value for the project by a required bitbake change upstream -- but
> that is a different story). Our current focus is to work together to
> improve Isar and process the patch backlog -- which I thought you
> agreed with Alex on phone. If this doesn't help you and you prefer
> the other model -- let's do it that way, it will only save my time.

We agreed that he would change my patches to save me the time to rebase
and change them. I asked him to add his signed-off to all patches he
actually modifies. 
After that offer i did not hear back about remaining issues, so i
assumed they all got fixed on your side. And now "my commits" are the
cause for issues ... If you see the issue coming you should bring it up
in the review and not after applying the patch.

I further assumed that any such patch would naturally be published for
review again, which did not happen or at least the comments where
ignored.

Henning

> With kind regards,
> Baurzhan.
> 

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Baurzhan Ismagulov]

On Tue, Aug 22, 2017 at 02:45:28PM +0200, Henning Schild wrote:
> We agreed that he would change my patches to save me the time to rebase
> and change them. I asked him to add his signed-off to all patches he
> actually modifies. 
> After that offer i did not hear back about remaining issues, so i
> assumed they all got fixed on your side. And now "my commits" are the
> cause for issues ... If you see the issue coming you should bring it up
> in the review and not after applying the patch.
> 
> I further assumed that any such patch would naturally be published for
> review again, which did not happen or at least the comments where
> ignored.

Oh, please let me know whether I understand you correctly:

You didn't like the way how I recently handled your patches, because you want
to provide complete, high-quality code, and:

1. Issues related to a commit may lead to doubt regarding the commit quality.

2. You don't necessarily agree with my or Alex's changes.


If this is the case, I agree that switching back to the classic workflow
would be the best way to go. Still, let me comment on the points above.

1. I use issues as reminders to do something later without blocking code that
   has value, especially right now, when we process the patch backlog. E.g., I
   don't want to block isar-bitbake.conf till we enhance upstream bitbake.
   Similarly, the documentation should not be forgotten -- this is the only
   reason for that, apply and move forward.

2. Changing patches (sometimes substantially) before applying is common
   practice in e.g. Linux kernel. Again, we did that with the intention to
   speed up the process. I see that our attempt produced the opposite results.


Now that we haven't processed all your patches, I'd suggest the following:

* You rebase your changes on master and send them to the list.

* We provide feedback and don't change your patches, even if it costs one or
  another round-trip.

* If we all agree on a particular patch, it goes in, completely and verbatim.

Could we proceed in this way, or do you have an alternative suggestion?


With kind regards,
Baurzhan.

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Henning Schild]

Am Tue, 22 Aug 2017 17:31:02 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Tue, Aug 22, 2017 at 02:45:28PM +0200, Henning Schild wrote:
> > We agreed that he would change my patches to save me the time to
> > rebase and change them. I asked him to add his signed-off to all
> > patches he actually modifies. 
> > After that offer i did not hear back about remaining issues, so i
> > assumed they all got fixed on your side. And now "my commits" are
> > the cause for issues ... If you see the issue coming you should
> > bring it up in the review and not after applying the patch.
> > 
> > I further assumed that any such patch would naturally be published
> > for review again, which did not happen or at least the comments
> > where ignored.  
> 
> Oh, please let me know whether I understand you correctly:
> 
> You didn't like the way how I recently handled your patches, because
> you want to provide complete, high-quality code, and:
> 
> 1. Issues related to a commit may lead to doubt regarding the commit
> quality.
> 
> 2. You don't necessarily agree with my or Alex's changes.
> 
> 
> If this is the case, I agree that switching back to the classic
> workflow would be the best way to go. Still, let me comment on the
> points above.
> 
> 1. I use issues as reminders to do something later without blocking
> code that has value, especially right now, when we process the patch
> backlog. E.g., I don't want to block isar-bitbake.conf till we
> enhance upstream bitbake. Similarly, the documentation should not be
> forgotten -- this is the only reason for that, apply and move forward.

Ok, understood. I think using issues as reminder list might shine the
wrong light on the project, but that is a personal feeling.

> 2. Changing patches (sometimes substantially) before applying is
> common practice in e.g. Linux kernel. Again, we did that with the
> intention to speed up the process. I see that our attempt produced
> the opposite results.
> 
> 
> Now that we haven't processed all your patches, I'd suggest the
> following:
> 
> * You rebase your changes on master and send them to the list.
> 
> * We provide feedback and don't change your patches, even if it costs
> one or another round-trip.
> 
> * If we all agree on a particular patch, it goes in, completely and
> verbatim.
> 
> Could we proceed in this way, or do you have an alternative
> suggestion?

We can proceed in this way or stick to the original plan. Or use one
where both sides modify the patches, depending on the change that needs
to be made.
But if anyone substancially changes a patch it has to be reviewed
again. Or at least end up in "the official" next branch where it will
sit for a few days for everyone to look at.

Henning
 
> With kind regards,
> Baurzhan.
> 

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Baurzhan Ismagulov]

On Tue, Aug 22, 2017 at 08:55:54PM +0200, Henning Schild wrote:
> Ok, understood. I think using issues as reminder list might shine the
> wrong light on the project, but that is a personal feeling.

This is a good point. At least small stuff like two lines of docs would really
be better to do immediately and not to postpone.

Bigger stuff like upstream bitbake changes would still exist. One approach
could be to distinguish between user bugs and project own TODOs (not offered by
GitHub). We've discussed this with Alex; ATM, we'd prefer to stick to the
existing infrastructure, at least till the development is streamlined.
Internally, we have an even longer list of issues and plan to move them to
GitHub for now as well.


> We can proceed in this way or stick to the original plan. Or use one
> where both sides modify the patches, depending on the change that needs
> to be made.
> But if anyone substancially changes a patch it has to be reviewed
> again.

The original plan was supposed to be faster due to quick fixes without later
review. Since we want a final review of changes, let's switch back to the
classic process.


> Or at least end up in "the official" next branch where it will
> sit for a few days for everyone to look at.

Ok, we've discussed this with Alex and would like to introduce next.

Currently, we are checking whether we still need asmirnov/next, and what
implications that would have on the maintainer process.


We also have some wishes:

* When submitting patches, considering the stuff from CONTRIBUTING would help
  us to review them, especially w.r.t. communicating the background /
  motivation / intention to work at something early in the process.

* We'll comment on the desired formatting. CodingStyle is on my TODO.

* If there is a problem, please articulate expectations; that would allow us to
  address them (unlike e.g. just a request to revert).

* We've looked at the apt implementations and currently tend towards the
  existing one, as it supports binary package caching and is shared with the
  Deby project. Regarding reprepro, we'd like to keep it because dropping it
  would mean re-implementing that in Isar and keeping up with possible Debian
  archive structure changes in the future.


With kind regards,
Baurzhan.

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Henning Schild]

Am Wed, 23 Aug 2017 13:31:42 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Tue, Aug 22, 2017 at 08:55:54PM +0200, Henning Schild wrote:
> > Ok, understood. I think using issues as reminder list might shine
> > the wrong light on the project, but that is a personal feeling.  
> 
> This is a good point. At least small stuff like two lines of docs
> would really be better to do immediately and not to postpone.
> 
> Bigger stuff like upstream bitbake changes would still exist. One
> approach could be to distinguish between user bugs and project own
> TODOs (not offered by GitHub). We've discussed this with Alex; ATM,
> we'd prefer to stick to the existing infrastructure, at least till
> the development is streamlined. Internally, we have an even longer
> list of issues and plan to move them to GitHub for now as well.
> 
> 
> > We can proceed in this way or stick to the original plan. Or use one
> > where both sides modify the patches, depending on the change that
> > needs to be made.
> > But if anyone substancially changes a patch it has to be reviewed
> > again.  
> 
> The original plan was supposed to be faster due to quick fixes
> without later review. Since we want a final review of changes, let's
> switch back to the classic process.
> 
> 
> > Or at least end up in "the official" next branch where it will
> > sit for a few days for everyone to look at.  
> 
> Ok, we've discussed this with Alex and would like to introduce next.
> 
> Currently, we are checking whether we still need asmirnov/next, and
> what implications that would have on the maintainer process.
> 
> 
> We also have some wishes:
> 
> * When submitting patches, considering the stuff from CONTRIBUTING
> would help us to review them, especially w.r.t. communicating the
> background / motivation / intention to work at something early in the
> process.

Sure, now that this document is there. The patches still on the plate
appeared before it.

> * We'll comment on the desired formatting. CodingStyle is on my TODO.
> 
> * If there is a problem, please articulate expectations; that would
> allow us to address them (unlike e.g. just a request to revert).

In this very example i did request the revert earlier, with reasoning.
And i got tired of repeating myself and mails not beeing read
carefully or at all, also not for the first time.

> * We've looked at the apt implementations and currently tend towards
> the existing one, as it supports binary package caching and is shared
> with the Deby project. Regarding reprepro, we'd like to keep it
> because dropping it would mean re-implementing that in Isar and
> keeping up with possible Debian archive structure changes in the
> future.

I have no clue what that section is about. If it has anything to do
with workflow we can keep discussing it here. If it has impact on the
proposed features please discuss it with the patches.

Henning
 
> With kind regards,
> Baurzhan.
> 

Re: [PATCH 0-10 of 16 v2 4/8] meta: conf: use bitbake.conf from bitbake and apply local changes

[Baurzhan Ismagulov]

On Wed, Aug 23, 2017 at 01:46:30PM +0200, Henning Schild wrote:
> > * If there is a problem, please articulate expectations; that would
> > allow us to address them (unlike e.g. just a request to revert).
> 
> In this very example i did request the revert earlier, with reasoning.

For this example, I had got the reasoning. I still hope we can bring
communication harmony to the next level ;) .


> And i got tired of repeating myself and mails not beeing read
> carefully or at all, also not for the first time.

This can be frustrating. I hope the following could help understanding why.

* Patch processing takes time.

* The order depends on the effort and may not be sequential.

* If you see no response, it can have various reasons.

  * Accusing people is harmful.

  * What would help is taking one specific issue and bringing it to a certain
    result.

  * Many parallel threads are ineffective.

  * Asking about all outstanding issues altogether is ineffective.

  * Negative result is also a result. One reason for dead threads is the loop
    where the participants don't change their opinions but continue looping
    over the same arguments.


With kind regards,
Baurzhan.

[PATCH 0-10 of 16 v2 5/8] meta: conf: clean up local bitbake config

[Henning Schild]

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/conf/isar-bitbake.conf | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/meta/conf/isar-bitbake.conf b/meta/conf/isar-bitbake.conf
index 7469ea7..ce35a22 100644
--- a/meta/conf/isar-bitbake.conf
+++ b/meta/conf/isar-bitbake.conf
@@ -21,16 +21,7 @@
 
 DEPLOY_DIR_DEB = "${TMPDIR}/deploy/deb/${MACHINE}"
 SSTATE_DIR ?= "${TMPDIR}/sstate-cache"
-MKTEMPCMD = "mktemp -q ${TMPBASE}"
-MKTEMPDIRCMD = "mktemp -d -q ${TMPBASE}"
-RESUMECOMMAND = ""
-RESUMECOMMAND_wget = "/usr/bin/env wget -c -t 5 --passive-ftp -P ${DL_DIR} ${URI}"
-STAMPS_DIR ?= "${TMPDIR}/stamps"
-UPDATECOMMAND = ""
-UPDATECOMMAND_cvs = "/usr/bin/env cvs -d${CVSROOT} update ${CVSCOOPTS}"
-UPDATECOMMAND_svn = "/usr/bin/env svn update ${SVNCOOPTS}"
 BUILDCHROOT_DIR = "${TOPDIR}/tmp/work/buildchroot/${DISTRO}/rootfs"
-CACHE = "${TMPDIR}/cache"
 
 # Setup our default hash policy
 BB_SIGNATURE_HANDLER ?= "noop"
-- 
2.13.0

Re: [PATCH 0-10 of 16 v2 5/8] meta: conf: clean up local bitbake config

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/conf/isar-bitbake.conf | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/meta/conf/isar-bitbake.conf b/meta/conf/isar-bitbake.conf
> index 7469ea7..ce35a22 100644
> --- a/meta/conf/isar-bitbake.conf
> +++ b/meta/conf/isar-bitbake.conf
> @@ -21,16 +21,7 @@
>
>  DEPLOY_DIR_DEB = "${TMPDIR}/deploy/deb/${MACHINE}"
>  SSTATE_DIR ?= "${TMPDIR}/sstate-cache"
> -MKTEMPCMD = "mktemp -q ${TMPBASE}"
> -MKTEMPDIRCMD = "mktemp -d -q ${TMPBASE}"
> -RESUMECOMMAND = ""
> -RESUMECOMMAND_wget = "/usr/bin/env wget -c -t 5 --passive-ftp -P
> ${DL_DIR} ${URI}"
> -STAMPS_DIR ?= "${TMPDIR}/stamps"
> -UPDATECOMMAND = ""
> -UPDATECOMMAND_cvs = "/usr/bin/env cvs -d${CVSROOT} update ${CVSCOOPTS}"
> -UPDATECOMMAND_svn = "/usr/bin/env svn update ${SVNCOOPTS}"
>  BUILDCHROOT_DIR = "${TOPDIR}/tmp/work/buildchroot/${DISTRO}/rootfs"
> -CACHE = "${TMPDIR}/cache"
>
>  # Setup our default hash policy
>  BB_SIGNATURE_HANDLER ?= "noop"
> --
> 2.13.0
>
>
Merged to asmirnov/next

[-- Attachment #2: Type: text/html, Size: 1794 bytes --]

Re: [PATCH 0-10 of 16 v2 5/8] meta: conf: clean up local bitbake config

[Baurzhan Ismagulov]

On Thu, Aug 03, 2017 at 01:55:54PM +0200, Henning Schild wrote:
> Signed-off-by: Henning Schild <henning.schild@siemens.com>

Applied with comment amendments, thanks.

Your title was also correct; still, Alex has dropped "local" to avoid potential
confusion with local.conf.

With kind regards,
Baurzhan.

[PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Henning Schild]

That way we can use the fetchers in images and future classes/recipes
without having to "inherit dpdk".

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/dpkg.bbclass      | 38 ++------------------------------------
 meta/classes/isar-base.bbclass | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 36 deletions(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 3d7aafb..e334dda 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -11,44 +11,10 @@ do_unpack[deptask] = "do_build"
 # recipe name as identifier
 PP = "/home/builder/${PN}"
 BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
-
-do_fetch[dirs] = "${DL_DIR}"
-
-# Fetch package from the source link
-python do_fetch() {
-    src_uri = (d.getVar('SRC_URI', True) or "").split()
-    if len(src_uri) == 0:
-        return
-
-    try:
-        fetcher = bb.fetch2.Fetch(src_uri, d)
-        fetcher.download()
-    except bb.fetch2.BBFetchException as e:
-        raise bb.build.FuncFailed(e)
-}
-
-addtask fetch before do_build
-
-do_unpack[dirs] = "${BUILDROOT}"
-do_unpack[stamp-extra-info] = "${DISTRO}"
 S ?= "${BUILDROOT}"
 
-# Unpack package and put it into working directory in buildchroot
-python do_unpack() {
-    src_uri = (d.getVar('SRC_URI', True) or "").split()
-    if len(src_uri) == 0:
-        return
-
-    rootdir = d.getVar('BUILDROOT', True)
-
-    try:
-        fetcher = bb.fetch2.Fetch(src_uri, d)
-        fetcher.unpack(rootdir)
-    except bb.fetch2.BBFetchException as e:
-        raise bb.build.FuncFailed(e)
-}
-
-addtask unpack after do_fetch before do_build
+# make the unpacker extract to BUILDROOT
+WORKDIR_task-unpack = "${BUILDROOT}"
 
 do_build[stamp-extra-info] = "${DISTRO}"
 
diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.bbclass
index d860937..ec4272f 100644
--- a/meta/classes/isar-base.bbclass
+++ b/meta/classes/isar-base.bbclass
@@ -20,3 +20,36 @@
 # OTHER DEALINGS IN THE SOFTWARE.
 
 do_build[nostamp] = "0"
+
+# Fetch package from the source link
+python do_fetch() {
+    src_uri = (d.getVar('SRC_URI', True) or "").split()
+    if len(src_uri) == 0:
+        return
+
+    try:
+        fetcher = bb.fetch2.Fetch(src_uri, d)
+        fetcher.download()
+    except bb.fetch2.BBFetchException as e:
+        raise bb.build.FuncFailed(e)
+}
+
+addtask fetch before do_build
+do_fetch[dirs] = "${DL_DIR}"
+
+# Unpack package and put it into working directory in buildchroot
+python do_unpack() {
+    src_uri = (d.getVar('SRC_URI', True) or "").split()
+    if len(src_uri) == 0:
+        return
+
+    try:
+        fetcher = bb.fetch2.Fetch(src_uri, d)
+        fetcher.unpack(d.getVar('WORKDIR', True))
+    except bb.fetch2.BBFetchException as e:
+        raise bb.build.FuncFailed(e)
+}
+
+addtask unpack after do_fetch before do_build
+do_unpack[dirs] = "${WORKDIR}"
+do_unpack[stamp-extra-info] = "${DISTRO}"
-- 
2.13.0

Re: [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 4051 bytes --]

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> That way we can use the fetchers in images and future classes/recipes
> without having to "inherit dpdk".
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/dpkg.bbclass      | 38 ++----------------------------
> --------
>  meta/classes/isar-base.bbclass | 33 +++++++++++++++++++++++++++++++++
>  2 files changed, 35 insertions(+), 36 deletions(-)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index 3d7aafb..e334dda 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -11,44 +11,10 @@ do_unpack[deptask] = "do_build"
>  # recipe name as identifier
>  PP = "/home/builder/${PN}"
>  BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
> -
> -do_fetch[dirs] = "${DL_DIR}"
> -
> -# Fetch package from the source link
> -python do_fetch() {
> -    src_uri = (d.getVar('SRC_URI', True) or "").split()
> -    if len(src_uri) == 0:
> -        return
> -
> -    try:
> -        fetcher = bb.fetch2.Fetch(src_uri, d)
> -        fetcher.download()
> -    except bb.fetch2.BBFetchException as e:
> -        raise bb.build.FuncFailed(e)
> -}
> -
> -addtask fetch before do_build
> -
> -do_unpack[dirs] = "${BUILDROOT}"
> -do_unpack[stamp-extra-info] = "${DISTRO}"
>  S ?= "${BUILDROOT}"
>
> -# Unpack package and put it into working directory in buildchroot
> -python do_unpack() {
> -    src_uri = (d.getVar('SRC_URI', True) or "").split()
> -    if len(src_uri) == 0:
> -        return
> -
> -    rootdir = d.getVar('BUILDROOT', True)
> -
> -    try:
> -        fetcher = bb.fetch2.Fetch(src_uri, d)
> -        fetcher.unpack(rootdir)
> -    except bb.fetch2.BBFetchException as e:
> -        raise bb.build.FuncFailed(e)
> -}
> -
> -addtask unpack after do_fetch before do_build
> +# make the unpacker extract to BUILDROOT
> +WORKDIR_task-unpack = "${BUILDROOT}"
>
>  do_build[stamp-extra-info] = "${DISTRO}"
>
> diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.
> bbclass
> index d860937..ec4272f 100644
> --- a/meta/classes/isar-base.bbclass
> +++ b/meta/classes/isar-base.bbclass
> @@ -20,3 +20,36 @@
>  # OTHER DEALINGS IN THE SOFTWARE.
>
>  do_build[nostamp] = "0"
> +
> +# Fetch package from the source link
> +python do_fetch() {
> +    src_uri = (d.getVar('SRC_URI', True) or "").split()
> +    if len(src_uri) == 0:
> +        return
> +
> +    try:
> +        fetcher = bb.fetch2.Fetch(src_uri, d)
> +        fetcher.download()
> +    except bb.fetch2.BBFetchException as e:
> +        raise bb.build.FuncFailed(e)
> +}
> +
> +addtask fetch before do_build
> +do_fetch[dirs] = "${DL_DIR}"
> +
> +# Unpack package and put it into working directory in buildchroot
> +python do_unpack() {
> +    src_uri = (d.getVar('SRC_URI', True) or "").split()
> +    if len(src_uri) == 0:
> +        return
> +
> +    try:
> +        fetcher = bb.fetch2.Fetch(src_uri, d)
> +        fetcher.unpack(d.getVar('WORKDIR', True))
> +    except bb.fetch2.BBFetchException as e:
> +        raise bb.build.FuncFailed(e)
> +}
> +
> +addtask unpack after do_fetch before do_build
> +do_unpack[dirs] = "${WORKDIR}"
> +do_unpack[stamp-extra-info] = "${DISTRO}"
> --
> 2.13.0
>
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To post to this group, send email to isar-users@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/isar-users/7c03d914f33ef0563cb7af2951f56e8cd5fd20bc.1501760818.git.
> henning.schild%40siemens.com.
> For more options, visit https://groups.google.com/d/optout.
>


This patch doesn't really do the things mentioned in commit message,
because you change the variables, for example: do_unpack[dirs] =
"${WORKDIR}", so it's not only about moving, but also some reworking which
is unclear for me.

I've partially apply it (only fetch) to asmirnov/next

[-- Attachment #2: Type: text/html, Size: 5739 bytes --]

Re: [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Henning Schild]

Am Mon, 7 Aug 2017 22:40:55 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > That way we can use the fetchers in images and future
> > classes/recipes without having to "inherit dpdk".
> >
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  meta/classes/dpkg.bbclass      | 38 ++----------------------------
> > --------
> >  meta/classes/isar-base.bbclass | 33
> > +++++++++++++++++++++++++++++++++ 2 files changed, 35
> > insertions(+), 36 deletions(-)
> >
> > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > index 3d7aafb..e334dda 100644
> > --- a/meta/classes/dpkg.bbclass
> > +++ b/meta/classes/dpkg.bbclass
> > @@ -11,44 +11,10 @@ do_unpack[deptask] = "do_build"
> >  # recipe name as identifier
> >  PP = "/home/builder/${PN}"
> >  BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
> > -
> > -do_fetch[dirs] = "${DL_DIR}"
> > -
> > -# Fetch package from the source link
> > -python do_fetch() {
> > -    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > -    if len(src_uri) == 0:
> > -        return
> > -
> > -    try:
> > -        fetcher = bb.fetch2.Fetch(src_uri, d)
> > -        fetcher.download()
> > -    except bb.fetch2.BBFetchException as e:
> > -        raise bb.build.FuncFailed(e)
> > -}
> > -
> > -addtask fetch before do_build
> > -
> > -do_unpack[dirs] = "${BUILDROOT}"
> > -do_unpack[stamp-extra-info] = "${DISTRO}"
> >  S ?= "${BUILDROOT}"
> >
> > -# Unpack package and put it into working directory in buildchroot
> > -python do_unpack() {
> > -    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > -    if len(src_uri) == 0:
> > -        return
> > -
> > -    rootdir = d.getVar('BUILDROOT', True)
> > -
> > -    try:
> > -        fetcher = bb.fetch2.Fetch(src_uri, d)
> > -        fetcher.unpack(rootdir)
> > -    except bb.fetch2.BBFetchException as e:
> > -        raise bb.build.FuncFailed(e)
> > -}
> > -
> > -addtask unpack after do_fetch before do_build
> > +# make the unpacker extract to BUILDROOT
> > +WORKDIR_task-unpack = "${BUILDROOT}"

This is where we force the unpacker to use BUILDROOT instead of
WORKDIR. We did not finish the discussion on why we need to break out
of WORKDIR in the first place.

Henning

> >  do_build[stamp-extra-info] = "${DISTRO}"
> >
> > diff --git a/meta/classes/isar-base.bbclass
> > b/meta/classes/isar-base. bbclass
> > index d860937..ec4272f 100644
> > --- a/meta/classes/isar-base.bbclass
> > +++ b/meta/classes/isar-base.bbclass
> > @@ -20,3 +20,36 @@
> >  # OTHER DEALINGS IN THE SOFTWARE.
> >
> >  do_build[nostamp] = "0"
> > +
> > +# Fetch package from the source link
> > +python do_fetch() {
> > +    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > +    if len(src_uri) == 0:
> > +        return
> > +
> > +    try:
> > +        fetcher = bb.fetch2.Fetch(src_uri, d)
> > +        fetcher.download()
> > +    except bb.fetch2.BBFetchException as e:
> > +        raise bb.build.FuncFailed(e)
> > +}
> > +
> > +addtask fetch before do_build
> > +do_fetch[dirs] = "${DL_DIR}"
> > +
> > +# Unpack package and put it into working directory in buildchroot
> > +python do_unpack() {
> > +    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > +    if len(src_uri) == 0:
> > +        return
> > +
> > +    try:
> > +        fetcher = bb.fetch2.Fetch(src_uri, d)
> > +        fetcher.unpack(d.getVar('WORKDIR', True))
> > +    except bb.fetch2.BBFetchException as e:
> > +        raise bb.build.FuncFailed(e)
> > +}
> > +
> > +addtask unpack after do_fetch before do_build
> > +do_unpack[dirs] = "${WORKDIR}"
> > +do_unpack[stamp-extra-info] = "${DISTRO}"
> > --
> > 2.13.0
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "isar-users" group.
> > To unsubscribe from this group and stop receiving emails from it,
> > send an email to isar-users+unsubscribe@googlegroups.com.
> > To post to this group, send email to isar-users@googlegroups.com.
> > To view this discussion on the web visit
> > https://groups.google.com/d/
> > msgid/isar-users/7c03d914f33ef0563cb7af2951f56e8cd5fd20bc.1501760818.git.
> > henning.schild%40siemens.com. For more options, visit
> > https://groups.google.com/d/optout. 
> 
> 
> This patch doesn't really do the things mentioned in commit message,
> because you change the variables, for example: do_unpack[dirs] =
> "${WORKDIR}", so it's not only about moving, but also some reworking
> which is unclear for me.
> 
> I've partially apply it (only fetch) to asmirnov/next

Re: [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 5064 bytes --]

2017-08-08 11:00 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Am Mon, 7 Aug 2017 22:40:55 +0300
> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>
> > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > <henning.schild@siemens.com>:
> >
> > > That way we can use the fetchers in images and future
> > > classes/recipes without having to "inherit dpdk".
> > >
> > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > ---
> > >  meta/classes/dpkg.bbclass      | 38 ++----------------------------
> > > --------
> > >  meta/classes/isar-base.bbclass | 33
> > > +++++++++++++++++++++++++++++++++ 2 files changed, 35
> > > insertions(+), 36 deletions(-)
> > >
> > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > > index 3d7aafb..e334dda 100644
> > > --- a/meta/classes/dpkg.bbclass
> > > +++ b/meta/classes/dpkg.bbclass
> > > @@ -11,44 +11,10 @@ do_unpack[deptask] = "do_build"
> > >  # recipe name as identifier
> > >  PP = "/home/builder/${PN}"
> > >  BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
> > > -
> > > -do_fetch[dirs] = "${DL_DIR}"
> > > -
> > > -# Fetch package from the source link
> > > -python do_fetch() {
> > > -    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > > -    if len(src_uri) == 0:
> > > -        return
> > > -
> > > -    try:
> > > -        fetcher = bb.fetch2.Fetch(src_uri, d)
> > > -        fetcher.download()
> > > -    except bb.fetch2.BBFetchException as e:
> > > -        raise bb.build.FuncFailed(e)
> > > -}
> > > -
> > > -addtask fetch before do_build
> > > -
> > > -do_unpack[dirs] = "${BUILDROOT}"
> > > -do_unpack[stamp-extra-info] = "${DISTRO}"
> > >  S ?= "${BUILDROOT}"
> > >
> > > -# Unpack package and put it into working directory in buildchroot
> > > -python do_unpack() {
> > > -    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > > -    if len(src_uri) == 0:
> > > -        return
> > > -
> > > -    rootdir = d.getVar('BUILDROOT', True)
> > > -
> > > -    try:
> > > -        fetcher = bb.fetch2.Fetch(src_uri, d)
> > > -        fetcher.unpack(rootdir)
> > > -    except bb.fetch2.BBFetchException as e:
> > > -        raise bb.build.FuncFailed(e)
> > > -}
> > > -
> > > -addtask unpack after do_fetch before do_build
> > > +# make the unpacker extract to BUILDROOT
> > > +WORKDIR_task-unpack = "${BUILDROOT}"
>
> This is where we force the unpacker to use BUILDROOT instead of
> WORKDIR. We did not finish the discussion on why we need to break out
> of WORKDIR in the first place.


I only mean, that in patch you mention "move", by move I understand
"copy-paste". This this should be done in two steps: 1. modify, 2. move.

Alex

>
> > >  do_build[stamp-extra-info] = "${DISTRO}"
> > >
> > > diff --git a/meta/classes/isar-base.bbclass
> > > b/meta/classes/isar-base. bbclass
> > > index d860937..ec4272f 100644
> > > --- a/meta/classes/isar-base.bbclass
> > > +++ b/meta/classes/isar-base.bbclass
> > > @@ -20,3 +20,36 @@
> > >  # OTHER DEALINGS IN THE SOFTWARE.
> > >
> > >  do_build[nostamp] = "0"
> > > +
> > > +# Fetch package from the source link
> > > +python do_fetch() {
> > > +    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > > +    if len(src_uri) == 0:
> > > +        return
> > > +
> > > +    try:
> > > +        fetcher = bb.fetch2.Fetch(src_uri, d)
> > > +        fetcher.download()
> > > +    except bb.fetch2.BBFetchException as e:
> > > +        raise bb.build.FuncFailed(e)
> > > +}
> > > +
> > > +addtask fetch before do_build
> > > +do_fetch[dirs] = "${DL_DIR}"
> > > +
> > > +# Unpack package and put it into working directory in buildchroot
> > > +python do_unpack() {
> > > +    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > > +    if len(src_uri) == 0:
> > > +        return
> > > +
> > > +    try:
> > > +        fetcher = bb.fetch2.Fetch(src_uri, d)
> > > +        fetcher.unpack(d.getVar('WORKDIR', True))
> > > +    except bb.fetch2.BBFetchException as e:
> > > +        raise bb.build.FuncFailed(e)
> > > +}
> > > +
> > > +addtask unpack after do_fetch before do_build
> > > +do_unpack[dirs] = "${WORKDIR}"
> > > +do_unpack[stamp-extra-info] = "${DISTRO}"
> > > --
> > > 2.13.0
> > >
> > > --
> > > You received this message because you are subscribed to the Google
> > > Groups "isar-users" group.
> > > To unsubscribe from this group and stop receiving emails from it,
> > > send an email to isar-users+unsubscribe@googlegroups.com.
> > > To post to this group, send email to isar-users@googlegroups.com.
> > > To view this discussion on the web visit
> > > https://groups.google.com/d/
> > > msgid/isar-users/7c03d914f33ef0563cb7af2951f56e
> 8cd5fd20bc.1501760818.git.
> > > henning.schild%40siemens.com. For more options, visit
> > > https://groups.google.com/d/optout.
> >
> >
> > This patch doesn't really do the things mentioned in commit message,
> > because you change the variables, for example: do_unpack[dirs] =
> > "${WORKDIR}", so it's not only about moving, but also some reworking
> > which is unclear for me.
> >
> > I've partially apply it (only fetch) to asmirnov/next
>
>

[-- Attachment #2: Type: text/html, Size: 7734 bytes --]

Re: [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Henning Schild]

Am Tue, 8 Aug 2017 12:30:46 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> 2017-08-08 11:00 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Am Mon, 7 Aug 2017 22:40:55 +0300
> > schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
> >  
> > > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > > <henning.schild@siemens.com>:
> > >  
> > > > That way we can use the fetchers in images and future
> > > > classes/recipes without having to "inherit dpdk".
> > > >
> > > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > > ---
> > > >  meta/classes/dpkg.bbclass      | 38
> > > > ++---------------------------- --------
> > > >  meta/classes/isar-base.bbclass | 33
> > > > +++++++++++++++++++++++++++++++++ 2 files changed, 35
> > > > insertions(+), 36 deletions(-)
> > > >
> > > > diff --git a/meta/classes/dpkg.bbclass
> > > > b/meta/classes/dpkg.bbclass index 3d7aafb..e334dda 100644
> > > > --- a/meta/classes/dpkg.bbclass
> > > > +++ b/meta/classes/dpkg.bbclass
> > > > @@ -11,44 +11,10 @@ do_unpack[deptask] = "do_build"
> > > >  # recipe name as identifier
> > > >  PP = "/home/builder/${PN}"
> > > >  BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
> > > > -
> > > > -do_fetch[dirs] = "${DL_DIR}"
> > > > -
> > > > -# Fetch package from the source link
> > > > -python do_fetch() {
> > > > -    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > > > -    if len(src_uri) == 0:
> > > > -        return
> > > > -
> > > > -    try:
> > > > -        fetcher = bb.fetch2.Fetch(src_uri, d)
> > > > -        fetcher.download()
> > > > -    except bb.fetch2.BBFetchException as e:
> > > > -        raise bb.build.FuncFailed(e)
> > > > -}
> > > > -
> > > > -addtask fetch before do_build
> > > > -
> > > > -do_unpack[dirs] = "${BUILDROOT}"
> > > > -do_unpack[stamp-extra-info] = "${DISTRO}"
> > > >  S ?= "${BUILDROOT}"
> > > >
> > > > -# Unpack package and put it into working directory in
> > > > buildchroot -python do_unpack() {
> > > > -    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > > > -    if len(src_uri) == 0:
> > > > -        return
> > > > -
> > > > -    rootdir = d.getVar('BUILDROOT', True)
> > > > -
> > > > -    try:
> > > > -        fetcher = bb.fetch2.Fetch(src_uri, d)
> > > > -        fetcher.unpack(rootdir)
> > > > -    except bb.fetch2.BBFetchException as e:
> > > > -        raise bb.build.FuncFailed(e)
> > > > -}
> > > > -
> > > > -addtask unpack after do_fetch before do_build
> > > > +# make the unpacker extract to BUILDROOT
> > > > +WORKDIR_task-unpack = "${BUILDROOT}"  
> >
> > This is where we force the unpacker to use BUILDROOT instead of
> > WORKDIR. We did not finish the discussion on why we need to break
> > out of WORKDIR in the first place.  
> 
> 
> I only mean, that in patch you mention "move", by move I understand
> "copy-paste". This this should be done in two steps: 1. modify, 2.
> move.

Ok. If you want me to turn it into two commits i will do so. But please
tell me what to do.
Especially since i would not know which branch to rebase on now that
you even split my patches.

Henning

> Alex
> 
> >  
> > > >  do_build[stamp-extra-info] = "${DISTRO}"
> > > >
> > > > diff --git a/meta/classes/isar-base.bbclass
> > > > b/meta/classes/isar-base. bbclass
> > > > index d860937..ec4272f 100644
> > > > --- a/meta/classes/isar-base.bbclass
> > > > +++ b/meta/classes/isar-base.bbclass
> > > > @@ -20,3 +20,36 @@
> > > >  # OTHER DEALINGS IN THE SOFTWARE.
> > > >
> > > >  do_build[nostamp] = "0"
> > > > +
> > > > +# Fetch package from the source link
> > > > +python do_fetch() {
> > > > +    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > > > +    if len(src_uri) == 0:
> > > > +        return
> > > > +
> > > > +    try:
> > > > +        fetcher = bb.fetch2.Fetch(src_uri, d)
> > > > +        fetcher.download()
> > > > +    except bb.fetch2.BBFetchException as e:
> > > > +        raise bb.build.FuncFailed(e)
> > > > +}
> > > > +
> > > > +addtask fetch before do_build
> > > > +do_fetch[dirs] = "${DL_DIR}"
> > > > +
> > > > +# Unpack package and put it into working directory in
> > > > buildchroot +python do_unpack() {
> > > > +    src_uri = (d.getVar('SRC_URI', True) or "").split()
> > > > +    if len(src_uri) == 0:
> > > > +        return
> > > > +
> > > > +    try:
> > > > +        fetcher = bb.fetch2.Fetch(src_uri, d)
> > > > +        fetcher.unpack(d.getVar('WORKDIR', True))
> > > > +    except bb.fetch2.BBFetchException as e:
> > > > +        raise bb.build.FuncFailed(e)
> > > > +}
> > > > +
> > > > +addtask unpack after do_fetch before do_build
> > > > +do_unpack[dirs] = "${WORKDIR}"
> > > > +do_unpack[stamp-extra-info] = "${DISTRO}"
> > > > --
> > > > 2.13.0
> > > >
> > > > --
> > > > You received this message because you are subscribed to the
> > > > Google Groups "isar-users" group.
> > > > To unsubscribe from this group and stop receiving emails from
> > > > it, send an email to isar-users+unsubscribe@googlegroups.com.
> > > > To post to this group, send email to
> > > > isar-users@googlegroups.com. To view this discussion on the web
> > > > visit https://groups.google.com/d/
> > > > msgid/isar-users/7c03d914f33ef0563cb7af2951f56e  
> > 8cd5fd20bc.1501760818.git.  
> > > > henning.schild%40siemens.com. For more options, visit
> > > > https://groups.google.com/d/optout.  
> > >
> > >
> > > This patch doesn't really do the things mentioned in commit
> > > message, because you change the variables, for example:
> > > do_unpack[dirs] = "${WORKDIR}", so it's not only about moving,
> > > but also some reworking which is unclear for me.
> > >
> > > I've partially apply it (only fetch) to asmirnov/next  
> >
> >  

Re: [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Baurzhan Ismagulov]

On Tue, Aug 08, 2017 at 02:01:50PM +0200, Henning Schild wrote:
> Ok. If you want me to turn it into two commits i will do so. But please
> tell me what to do.

Applied partially, thanks.

The baseline for rebase is master. It will eventually include asmirnov/next, so
right now, you could start rebasing on that.


> Especially since i would not know which branch to rebase on now that
> you even split my patches.

This allows us to take low-hanging fruits and avoid reviewing the stuff again,
especially since this series consists of unrelated bits -- please avoid in the
future. A binary all-or-nothing approach would block all patches. If you prefer
that way, I'd suggest to talk offline so that we can understand the reasons for
that.


With kind regards,
Baurzhan.

Re: [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Henning Schild]

Am Mon, 21 Aug 2017 22:27:38 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Tue, Aug 08, 2017 at 02:01:50PM +0200, Henning Schild wrote:
> > Ok. If you want me to turn it into two commits i will do so. But
> > please tell me what to do.  
> 
> Applied partially, thanks.

Please revert or remove me as author, thanks.

Henning

> The baseline for rebase is master. It will eventually include
> asmirnov/next, so right now, you could start rebasing on that.
> 
> 
> > Especially since i would not know which branch to rebase on now that
> > you even split my patches.  
> 
> This allows us to take low-hanging fruits and avoid reviewing the
> stuff again, especially since this series consists of unrelated bits
> -- please avoid in the future. A binary all-or-nothing approach would
> block all patches. If you prefer that way, I'd suggest to talk
> offline so that we can understand the reasons for that.
> 
> 
> With kind regards,
> Baurzhan.
> 

Re: [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Baurzhan Ismagulov]

On Tue, Aug 22, 2017 at 10:19:09AM +0200, Henning Schild wrote:
> > On Tue, Aug 08, 2017 at 02:01:50PM +0200, Henning Schild wrote:
> > > Ok. If you want me to turn it into two commits i will do so. But
> > > please tell me what to do.  
> > 
> > Applied partially, thanks.
> 
> Please revert or remove me as author, thanks.

Hmm, you had agreed to splitting it into two parts... Reverted.

With kind regards,
Baurzhan.

Re: [PATCH 0-10 of 16 v2 6/8] classes: move fetch and unpack into isar-base

[Henning Schild]

Am Tue, 22 Aug 2017 12:18:44 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Tue, Aug 22, 2017 at 10:19:09AM +0200, Henning Schild wrote:
> > > On Tue, Aug 08, 2017 at 02:01:50PM +0200, Henning Schild wrote:  
> > > > Ok. If you want me to turn it into two commits i will do so. But
> > > > please tell me what to do.    
> > > 
> > > Applied partially, thanks.  
> > 
> > Please revert or remove me as author, thanks.  
> 
> Hmm, you had agreed to splitting it into two parts... Reverted.

The split i agreed to was a totally different one.

Henning

> With kind regards,
> Baurzhan.
> 

[PATCH 0-10 of 16 v2 7/8] meta: dpdk use [dirs] directive instead of mkdir

[Henning Schild]

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/dpkg.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index e334dda..36e047a 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -27,8 +27,8 @@ do_install[stamp-extra-info] = "${MACHINE}"
 
 # Install package to dedicated deploy directory
 do_install() {
-    install -d ${DEPLOY_DIR_DEB}
     install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/
 }
 
 addtask do_install after do_build
+do_install[dirs] = "${DEPLOY_DIR_DEB}"
-- 
2.13.0

Re: [PATCH 0-10 of 16 v2 7/8] meta: dpdk use [dirs] directive instead of mkdir

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/dpkg.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index e334dda..36e047a 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -27,8 +27,8 @@ do_install[stamp-extra-info] = "${MACHINE}"
>
>  # Install package to dedicated deploy directory
>  do_install() {
> -    install -d ${DEPLOY_DIR_DEB}
>      install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/
>  }
>
>  addtask do_install after do_build
> +do_install[dirs] = "${DEPLOY_DIR_DEB}"
> --
> 2.13.0
>
>
Applied to asmirnov/next

[-- Attachment #2: Type: text/html, Size: 1303 bytes --]

Re: [PATCH 0-10 of 16 v2 7/8] meta: dpdk use [dirs] directive instead of mkdir

[Baurzhan Ismagulov]

On Thu, Aug 03, 2017 at 01:55:56PM +0200, Henning Schild wrote:
> Signed-off-by: Henning Schild <henning.schild@siemens.com>

Applied with comment amendments, thanks.

With kind regards,
Baurzhan.

[PATCH 0-10 of 16 v2 8/8] meta: dpkg: reorder and rename do_install to install in addtask

[Henning Schild]

the reordering should improve readability
when adding a task you skip the do_ prefix

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/dpkg.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 36e047a..ca0c5ab 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -23,12 +23,12 @@ do_build() {
     sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR}
 }
 
-do_install[stamp-extra-info] = "${MACHINE}"
 
 # Install package to dedicated deploy directory
 do_install() {
     install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/
 }
 
-addtask do_install after do_build
+addtask install after do_build
 do_install[dirs] = "${DEPLOY_DIR_DEB}"
+do_install[stamp-extra-info] = "${MACHINE}"
-- 
2.13.0

Re: [PATCH 0-10 of 16 v2 8/8] meta: dpkg: reorder and rename do_install to install in addtask

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> the reordering should improve readability
> when adding a task you skip the do_ prefix
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/dpkg.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index 36e047a..ca0c5ab 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -23,12 +23,12 @@ do_build() {
>      sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR}
>  }
>
> -do_install[stamp-extra-info] = "${MACHINE}"
>
>  # Install package to dedicated deploy directory
>  do_install() {
>      install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/
>  }
>
> -addtask do_install after do_build
> +addtask install after do_build
>  do_install[dirs] = "${DEPLOY_DIR_DEB}"
> +do_install[stamp-extra-info] = "${MACHINE}"
> --
> 2.13.0
>
>
Applied to asmirnov/next

[-- Attachment #2: Type: text/html, Size: 1571 bytes --]

Re: [PATCH 0-10 of 16 v2 8/8] meta: dpkg: reorder and rename do_install to install in addtask

[Baurzhan Ismagulov]

On Thu, Aug 03, 2017 at 01:55:57PM +0200, Henning Schild wrote:
> the reordering should improve readability
> when adding a task you skip the do_ prefix

Applied with comment amendments, thanks.

With kind regards,
Baurzhan.

Re: [PATCH 0-10 of 16 v2 0/8] splitting the previous q

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 2438 bytes --]

Hi,

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Since the first q was pretty long with 16 patches and some of the later
> ones
> still need to be dicsussed in more detail, i decided to split the q and
> send
> the less controversial stuff first.
>
> Changes to V1:
>
> - dropped 01/16 from v1
>   - ext4 is not on the wic path, it can keep its obvious bugs
> - 02/16 is 1v2, added copyright header
> - 03/16 is 2v2, keep it seperate after all (logical vs. structural)
> - 04/16 is 3v2, do not touch bitbake anymore
> - 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license header
> - 06/16 is 5v2, keep it seperate after all (logical vs. structural)
> - 07/16 dropped
> - 08/16 is 6v2, no image-class anymore, update comment
> - 09/16 is 7v2, nothing changed
> - 10/16 is 8v2, updated comment
>
>
I have new comments regarding v2 series. But to somehow move the work
forward, I've partially applied your patches to asmirnov/next branch. Huge
series are very hard to review and apply at once, so I'd propose to send
them in small parts.


>
> Henning Schild (8):
>   meta: classes: use base.bbclass from bitbake
>   meta: isar-base: remove unused function
>   remove redundant variable THISDIR
>   meta: conf: use bitbake.conf from bitbake and apply local changes
>   meta: conf: clean up local bitbake config
>   classes: move fetch and unpack into isar-base
>   meta: dpdk use [dirs] directive instead of mkdir
>   meta: dpkg: reorder and rename do_install to install in addtask
>
>  meta-isar/recipes-core/images/isar-image-base.bb |  8 +--
>  meta/classes/base.bbclass                        | 81
> +-----------------------
>  meta/classes/dpkg.bbclass                        | 46 ++------------
>  meta/classes/ext4-img.bbclass                    |  2 +
>  meta/classes/isar-base.bbclass                   | 55 ++++++++++++++++
>  meta/conf/bitbake.conf.sample                    | 68 --------------------
>  meta/conf/isar-bitbake.conf                      | 31 +++++++++
>  meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +--
>  scripts/isar-setup-builddir                      | 33 ++++++++--
>  9 files changed, 134 insertions(+), 200 deletions(-)
>  mode change 100644 => 120000 meta/classes/base.bbclass
>  create mode 100644 meta/classes/isar-base.bbclass
>  delete mode 100644 meta/conf/bitbake.conf.sample
>  create mode 100644 meta/conf/isar-bitbake.conf
>
> --
> 2.13.0
>
>

[-- Attachment #2: Type: text/html, Size: 3349 bytes --]

Re: [PATCH 0-10 of 16 v2 0/8] splitting the previous q

[Henning Schild]

Am Mon, 7 Aug 2017 22:44:15 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> Hi,
> 
> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@siemens.com>:
> 
> > Since the first q was pretty long with 16 patches and some of the
> > later ones
> > still need to be dicsussed in more detail, i decided to split the q
> > and send
> > the less controversial stuff first.
> >
> > Changes to V1:
> >
> > - dropped 01/16 from v1
> >   - ext4 is not on the wic path, it can keep its obvious bugs
> > - 02/16 is 1v2, added copyright header
> > - 03/16 is 2v2, keep it seperate after all (logical vs. structural)
> > - 04/16 is 3v2, do not touch bitbake anymore
> > - 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license
> > header
> > - 06/16 is 5v2, keep it seperate after all (logical vs. structural)
> > - 07/16 dropped
> > - 08/16 is 6v2, no image-class anymore, update comment
> > - 09/16 is 7v2, nothing changed
> > - 10/16 is 8v2, updated comment
> >
> >  
> I have new comments regarding v2 series. But to somehow move the work
> forward, I've partially applied your patches to asmirnov/next branch.
> Huge series are very hard to review and apply at once, so I'd propose
> to send them in small parts.

I know, that is why i split it. Thanks for taking some of the commits
in. Will you send your patches for review as well?

Henning

> 
> >
> > Henning Schild (8):
> >   meta: classes: use base.bbclass from bitbake
> >   meta: isar-base: remove unused function
> >   remove redundant variable THISDIR
> >   meta: conf: use bitbake.conf from bitbake and apply local changes
> >   meta: conf: clean up local bitbake config
> >   classes: move fetch and unpack into isar-base
> >   meta: dpdk use [dirs] directive instead of mkdir
> >   meta: dpkg: reorder and rename do_install to install in addtask
> >
> >  meta-isar/recipes-core/images/isar-image-base.bb |  8 +--
> >  meta/classes/base.bbclass                        | 81
> > +-----------------------
> >  meta/classes/dpkg.bbclass                        | 46
> > ++------------ meta/classes/ext4-img.bbclass                    |
> > 2 + meta/classes/isar-base.bbclass                   | 55
> > ++++++++++++++++ meta/conf/bitbake.conf.sample                    |
> > 68 --------------------
> > meta/conf/isar-bitbake.conf                      | 31 +++++++++
> > meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +--
> > scripts/isar-setup-builddir                      | 33 ++++++++-- 9
> > files changed, 134 insertions(+), 200 deletions(-) mode change
> > 100644 => 120000 meta/classes/base.bbclass create mode 100644
> > meta/classes/isar-base.bbclass delete mode 100644
> > meta/conf/bitbake.conf.sample create mode 100644
> > meta/conf/isar-bitbake.conf
> >
> > --
> > 2.13.0
> >
> >  

Re: [PATCH 0-10 of 16 v2 0/8] splitting the previous q

[Alexander Smirnov]

[-- Attachment #1: Type: text/plain, Size: 3677 bytes --]

2017-08-08 11:45 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Am Mon, 7 Aug 2017 22:44:15 +0300
> schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:
>
> > Hi,
> >
> > 2017-08-03 14:55 GMT+03:00 Henning Schild
> > <henning.schild@siemens.com>:
> >
> > > Since the first q was pretty long with 16 patches and some of the
> > > later ones
> > > still need to be dicsussed in more detail, i decided to split the q
> > > and send
> > > the less controversial stuff first.
> > >
> > > Changes to V1:
> > >
> > > - dropped 01/16 from v1
> > >   - ext4 is not on the wic path, it can keep its obvious bugs
> > > - 02/16 is 1v2, added copyright header
> > > - 03/16 is 2v2, keep it seperate after all (logical vs. structural)
> > > - 04/16 is 3v2, do not touch bitbake anymore
> > > - 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license
> > > header
> > > - 06/16 is 5v2, keep it seperate after all (logical vs. structural)
> > > - 07/16 dropped
> > > - 08/16 is 6v2, no image-class anymore, update comment
> > > - 09/16 is 7v2, nothing changed
> > > - 10/16 is 8v2, updated comment
> > >
> > >
> > I have new comments regarding v2 series. But to somehow move the work
> > forward, I've partially applied your patches to asmirnov/next branch.
> > Huge series are very hard to review and apply at once, so I'd propose
> > to send them in small parts.
>
> I know, that is why i split it. Thanks for taking some of the commits
> in. Will you send your patches for review as well?
>

You are welcome!

Regarding my patches - sure, I'll send it for review. The main technical
payload of my patches - to have possibility to start parallel builds in one
command:

$ bitbake multiconfig:qemuarm-wheezy:isar-image-base
multiconfig:qemuarm-jessie:isar-image-base
multiconfig:qemuarm-stretch:isar-image-base
multiconfig:qemui386-jessie:isar-image-base
multiconfig:qemui386-stretch:isar-image-base
multiconfig:qemuamd64-jessie:isar-image-base
multiconfig:qemuamd64-stretch:isar-image-base
multiconfig:rpi-jessie:isar-image-base

So this command builds all the possible Isar configurations. I use it in
our jenkins to ensure that upcomming patches do not break the build.

Alex


> >
> > >
> > > Henning Schild (8):
> > >   meta: classes: use base.bbclass from bitbake
> > >   meta: isar-base: remove unused function
> > >   remove redundant variable THISDIR
> > >   meta: conf: use bitbake.conf from bitbake and apply local changes
> > >   meta: conf: clean up local bitbake config
> > >   classes: move fetch and unpack into isar-base
> > >   meta: dpdk use [dirs] directive instead of mkdir
> > >   meta: dpkg: reorder and rename do_install to install in addtask
> > >
> > >  meta-isar/recipes-core/images/isar-image-base.bb |  8 +--
> > >  meta/classes/base.bbclass                        | 81
> > > +-----------------------
> > >  meta/classes/dpkg.bbclass                        | 46
> > > ++------------ meta/classes/ext4-img.bbclass                    |
> > > 2 + meta/classes/isar-base.bbclass                   | 55
> > > ++++++++++++++++ meta/conf/bitbake.conf.sample                    |
> > > 68 --------------------
> > > meta/conf/isar-bitbake.conf                      | 31 +++++++++
> > > meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +--
> > > scripts/isar-setup-builddir                      | 33 ++++++++-- 9
> > > files changed, 134 insertions(+), 200 deletions(-) mode change
> > > 100644 => 120000 meta/classes/base.bbclass create mode 100644
> > > meta/classes/isar-base.bbclass delete mode 100644
> > > meta/conf/bitbake.conf.sample create mode 100644
> > > meta/conf/isar-bitbake.conf
> > >
> > > --
> > > 2.13.0
> > >
> > >
>
>

[-- Attachment #2: Type: text/html, Size: 5317 bytes --]