From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6458964006491127808 X-Received: by 10.28.63.151 with SMTP id m145mr67922wma.19.1503932231418; Mon, 28 Aug 2017 07:57:11 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.20.29 with SMTP id u29ls53836ljd.19.gmail; Mon, 28 Aug 2017 07:57:10 -0700 (PDT) X-Google-Smtp-Source: ADKCNb4l44DmHxNx9VzSLfHm+IlFm45Jj/MM+Jxe1iLWAUqnXgT9w54xZ3Ot+a44qmoeL9rOd9NH X-Received: by 10.46.13.1 with SMTP id 1mr83271ljn.1.1503932230971; Mon, 28 Aug 2017 07:57:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503932230; cv=none; d=google.com; s=arc-20160816; b=cQ8F9/0R2cdSgEf1YDqxj1ZHQNdPxfk9ot39r3iLgkKWYg/PLnbUKJL80inx+dM2vf lmRjg+N7qpuL49mxypzV/8cytXqbfNdP1P1DcURWecFH9JMsh2hANG+CybDQW3cpSj9A rTz9XdrMWGeUKGaxBTBHWaM/KAukKw6wxJ3ckTM30suS/Hl0XyGg4AHfq8DgiXNb2SFT pC7PF3T32eKzv8HeraUpJzC0S96O+DWmLowDm9RSwckRC5neuSKSG2jTQpYAqdQOxCmz FmIvL1a1DpAwkuR75YdMFVwBBRmcjPBps02+UiIAou4Ff3L5gxrzQn+I92JvjdONz63e USTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=9HWF8klzr6JHS0owCVpfJgUU+sWWmNHp5Ny4+adiEuE=; b=PJ2wl81MTjfI56e8ZH8PhVOJVUuexLfMBEi8lUZW+ck0BaztfwS2cpj7aSnk9xTTZE 5xrgieTzf35O0C1UgPSVEnDlK4E7Yr6L6vVpAX5Zd6qmFEEPEvcsDfoq4I3L+2QXxpgV aXmVO+eZRGnS5vt6P3cCAUEEeaf8shjZKwQ/++t6bxwDDpGCcPaDf/Sc9EhmGE4BRXaB hcodEkBeAQds02iFIjYWlABxllHyguGnR0zGo6N6AxSd/jZhwZECj/5ErD1rn+2RfLvO 6EFEo2igpXg432HERe3CNKm7PbQcI+cHMEIUVpmnFRJTzrMLRibKK/xRwdIgrlHsAiJt OsNg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id h196si51880wmg.0.2017.08.28.07.57.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Aug 2017 07:57:10 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v7SEvAqX012115 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Aug 2017 16:57:10 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v7SEvAS0005279; Mon, 28 Aug 2017 16:57:10 +0200 Date: Mon, 28 Aug 2017 16:57:13 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 1/5] classes/base: Fix fetch task dependency Message-ID: <20170828165713.207c248c@md1em3qc> In-Reply-To: <20170827143840.12436-2-asmirnov@ilbers.de> References: <20170827143840.12436-1-asmirnov@ilbers.de> <20170827143840.12436-2-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: vpln33FumiYP Am Sun, 27 Aug 2017 17:38:36 +0300 schrieb Alexander Smirnov : > Fetch task should be run before unpack, not before build. > > Signed-off-by: Alexander Smirnov > --- > meta/classes/dpkg.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 23d5e6c..360a95c 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -25,7 +25,7 @@ python do_fetch() { > raise bb.build.FuncFailed(e) > } > > -addtask fetch before do_build > +addtask fetch before do_unpack > > do_unpack[dirs] = "${BUILDROOT}" > do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" A few lines below that you find: > addtask unpack after do_fetch before do_build With this patch you would have the order expressed twice, which is not a good idea. This patches does not change anything, it just introduces redundant information. Henning