public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Alexander Smirnov <asmirnov@ilbers.de>
Cc: <isar-users@googlegroups.com>, Baurzhan Ismagulov <ibr@ilbers.de>
Subject: Re: [PATCH 2/6] classes/image: Provide /dev/null for Stretch apt
Date: Mon, 28 Aug 2017 17:26:49 +0200	[thread overview]
Message-ID: <20170828172649.059ab655@md1em3qc> (raw)
In-Reply-To: <20170828172006.44dfa73b@md1em3qc>

Am Mon, 28 Aug 2017 17:20:06 +0200
schrieb "[ext] Henning Schild" <henning.schild@siemens.com>:

> Am Sun, 27 Aug 2017 18:13:35 +0300
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
> > From: Baurzhan Ismagulov <ibr@ilbers.de>
> > 
> > Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> > Signed-off-by: Baurzhan Ismagulov <ibr@ilbers.de>
> > ---
> >  meta/classes/image.bbclass                              | 3 +++
> >  meta/recipes-devtools/buildchroot/files/configscript.sh | 1 +
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > index f42aa48..c2ff453 100644
> > --- a/meta/classes/image.bbclass
> > +++ b/meta/classes/image.bbclass
> > @@ -20,11 +20,14 @@ do_populate() {
> >              sudo mkdir -p "${S}/${DEBCACHEMNT}"
> >              sudo mount -o bind "${DIR_CACHE}" "${S}/${DEBCACHEMNT}"
> >  
> > +            # apt-get http method, gpg require /dev/null
> > +            # Otherwise, apt http method hangs on Stretch
> >              sudo chroot "${S}" apt-get update -y
> >              for package in ${IMAGE_INSTALL}; do
> >                  sudo chroot "${S}" apt-get install -t
> > "${DEBDISTRONAME}" -y \ --allow-unauthenticated "${package}"
> >              done
> > +            sudo umount "${S}/dev"  
> 
> I see a new umount and a comment, where is the new mount?
> 
> Henning
> 
> >              sudo umount "${S}/${DEBCACHEMNT}"
> >          else
> > diff --git a/meta/recipes-devtools/buildchroot/files/configscript.sh
> > b/meta/recipes-devtools/buildchroot/files/configscript.sh index
> > 5080ae1..08c818b 100644 ---
> > a/meta/recipes-devtools/buildchroot/files/configscript.sh +++
> > b/meta/recipes-devtools/buildchroot/files/configscript.sh @@ -40,6
> > +40,7 @@ export LC_ALL=C LANGUAGE=C
> > LANG=C /var/lib/dpkg/info/dash.preinst install 
> >  # apt-get http method, gpg require /dev/null
> > +# Otherwise, apt http method hangs on Stretch
> >  mount -t devtmpfs -o mode=0755,nosuid devtmpfs /dev

Found it ... and it is not new.

Can we not get the "mount; { stuff } umount;" into one file?

But we should first discuss whether we will drop do_populate
alltogether. See
"[PATCH 3/3] classes: image: remove populate and replace it with a
custom repo"

Henning
 
> >  #configuring packages  
> 


  reply	other threads:[~2017-08-28 15:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-27 15:13 [PATCH 0/6] Isar apt cache implementation Alexander Smirnov
2017-08-27 15:13 ` [PATCH 1/6] meta-isar-bin: Enable caching of deb packages Alexander Smirnov
2017-08-28 15:18   ` Henning Schild
2017-08-29  6:40     ` Alexander Smirnov
2017-08-29  7:51       ` Henning Schild
2017-08-29  8:20         ` Alexander Smirnov
2017-08-31 10:55     ` Claudius Heine
2017-08-31 11:20       ` Henning Schild
2017-08-31 12:08         ` Claudius Heine
2017-09-06 14:21   ` Henning Schild
2017-09-07 11:13     ` Claudius Heine
2017-08-27 15:13 ` [PATCH 2/6] classes/image: Provide /dev/null for Stretch apt Alexander Smirnov
2017-08-28 15:20   ` Henning Schild
2017-08-28 15:26     ` Henning Schild [this message]
2017-08-27 15:13 ` [PATCH 3/6] classes/dpkg: Split install for cache Alexander Smirnov
2017-08-28  8:00   ` Claudius Heine
2017-08-29  7:18     ` Alexander Smirnov
2017-08-30  8:54       ` Claudius Heine
2017-08-28 15:30   ` Henning Schild
2017-08-27 15:13 ` [PATCH 4/6] meta-isar-bin: Enable apt repo generation for amd64 Alexander Smirnov
2017-08-27 15:13 ` [PATCH 5/6] classes/dpkg: Properly update packages in the cache Alexander Smirnov
2017-08-28 15:32   ` Henning Schild
2017-08-29  7:20     ` Alexander Smirnov
2017-08-29  7:57       ` Henning Schild
2017-08-29 11:26         ` Jan Kiszka
2017-08-27 15:13 ` [PATCH 6/6] doc/technical_overview: Describe binary cache Alexander Smirnov
2017-08-28 15:36   ` Henning Schild
2017-08-29  7:29     ` Alexander Smirnov
2017-08-29  8:06       ` Henning Schild
2017-08-29 11:29     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828172649.059ab655@md1em3qc \
    --to=henning.schild@siemens.com \
    --cc=asmirnov@ilbers.de \
    --cc=ibr@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox