From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6458964006491127808 X-Received: by 10.28.229.136 with SMTP id c130mr245062wmh.32.1503992620201; Tue, 29 Aug 2017 00:43:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.229.6 with SMTP id c6ls160681wmh.3.gmail; Tue, 29 Aug 2017 00:43:39 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5e1AMF+Dk5MCSVpYwLMC2CIxa0t3UF2ZKDjjhIh1blp0q2PH4wnmnGxphvu35duBWRfX/1 X-Received: by 10.28.16.74 with SMTP id 71mr227237wmq.7.1503992619919; Tue, 29 Aug 2017 00:43:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503992619; cv=none; d=google.com; s=arc-20160816; b=csNY/WfV4TmKqiUFz5FmQQP56/xaKJ9QEohkd+ESvbvuKQMG5K4rk0yi29KkvRMnTX vd3W71BMhTKguY5tzk2gu0hVM5MNX+4dXSVkH0tmcQ6dVLU1/V/3OixMkJQ+zcLQr5Sl 5jJjreJTVCCFesRckP7RhyemkmEE1nMmVupIjiUIcBDyaKUqoTWDYhzwaG5IgWhL47jK DFEr3h8CRGZyPb+M0k3AEJbTxNQFa4FHcJ7R95AHaFE6MVUG8voaxPuD6iJ/wFmOuvds Vi9cfqUX5njTeHRX3hAou+DZDS/mXK/L2GMTDovVf/h5s0y6YwvgYBj6l4NjL4lN/jOj zx2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=B27TU/kcgUwohnetK7E3SeIZk25ioLcn88j+rmSlXUQ=; b=sAeOCJr773GWyekBeF+ggAp14u/NyejVbvCz8Tx3kugOUdwQPYTMZIWzLj42iKVpl5 WMpR+ooHMr8jU6+L2e1ncYt8BHT7LwHRnp1D65vTE1xfyy2djbvnPFXeeh4N4BinRYl5 +xyARaRnEsLRpZPJZ/zZKzTIJzilL1H7I57PYsfx6iU5MMyPLV3wgNN98QrYBsC/UBxR aozU4Fq0RS8CaQ1nOkom1lBzymjW3uAjhsA5YbW7bD0Ts9iAVuMXebwAoPRJ4NRtq+7q Rcsikbozj0Z0yNZFWtuLI0unf7ToexC/haR8gZTASxbo+K8BoYCKr8pbfWtXtS6pkPzN 7WPg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id p200si57694wmg.1.2017.08.29.00.43.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 00:43:39 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v7T7hdPQ005804 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Aug 2017 09:43:39 +0200 Received: from md1em3qc ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v7T7hdQ4012485; Tue, 29 Aug 2017 09:43:39 +0200 Date: Tue, 29 Aug 2017 09:43:43 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 1/5] classes/base: Fix fetch task dependency Message-ID: <20170829094343.15198220@md1em3qc> In-Reply-To: References: <20170827143840.12436-1-asmirnov@ilbers.de> <20170827143840.12436-2-asmirnov@ilbers.de> <20170828165713.207c248c@md1em3qc> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 4z8noNVhx3wE Am Tue, 29 Aug 2017 09:27:59 +0300 schrieb Alexander Smirnov : > On 08/28/2017 05:57 PM, Henning Schild wrote: > > Am Sun, 27 Aug 2017 17:38:36 +0300 > > schrieb Alexander Smirnov : > > > >> Fetch task should be run before unpack, not before build. > >> > >> Signed-off-by: Alexander Smirnov > >> --- > >> meta/classes/dpkg.bbclass | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > >> index 23d5e6c..360a95c 100644 > >> --- a/meta/classes/dpkg.bbclass > >> +++ b/meta/classes/dpkg.bbclass > >> @@ -25,7 +25,7 @@ python do_fetch() { > >> raise bb.build.FuncFailed(e) > >> } > >> > >> -addtask fetch before do_build > >> +addtask fetch before do_unpack > >> > >> do_unpack[dirs] = "${BUILDROOT}" > >> do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > > > A few lines below that you find: > > > >> addtask unpack after do_fetch before do_build > > > > With this patch you would have the order expressed twice, which is > > not a good idea. This patches does not change anything, it just > > introduces redundant information. > > This patch is not about technical issues, it just improves code > readability and explicitly defines the order of tasks. If task fetch > should go before unpack, it would be more evident do define it in > this way. The order is already explicit. Writing it down twice is redundant. And redundancy means that future changes would have to keep both expressions in sync. In my point of view it harms readability because one has to still read both expressions and make sure to what result they will add up. Henning