From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145511672315904 X-Received: by 10.46.68.27 with SMTP id r27mr154052lja.15.1504859449390; Fri, 08 Sep 2017 01:30:49 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.81.11 with SMTP id f11ls103510lfb.26.gmail; Fri, 08 Sep 2017 01:30:49 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBwOtnlOCJ9qBpbe6wBiAffv2XWhtzgRMfDSWhE5k2ih28OxJq7yBN5gJl2GyGVCJOnjFOt X-Received: by 10.25.219.206 with SMTP id t75mr156113lfi.7.1504859449019; Fri, 08 Sep 2017 01:30:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504859448; cv=none; d=google.com; s=arc-20160816; b=yTNLUD7FiWDp3wGTi/MbJcKtO2x3GgeV2sBXHiQpSUq/RR6Ux1Evoyxj1pm7nWQiXc 759dpJIZcZ8pq0cY1TkC5LVh2wKMY0X/Jwnq2juHQMdWTY/XcxaflVGbbrFHUqT/lrHy mIfoYIAaxiMzPJpDSbDzVjTM532bB/ahaJFBEpHQF5AaJ8BWk3yC8kcaA0CgCUQQRnaG mpdoQmimEEGAHl33MFG2fjut3m69hkthG+zPFSPFf6YvLhV/D/lp6UY0cbehFZPy1JLq 7na5t0F9y/Eji2XbqmvZENyeIDZNWu6q3q2U2W8pfPMwFysRQs74es39RNCDb1T3tjY0 Wi0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=kGyuRC7nfsjQSSwjqo1o3SkeG4JW1yoJbx6YA5HQtd0=; b=ISpS8wolSrC9RU18UxKGGmKHecJ28887qv67iy/K3k/9fUQ5212oDf79FO/JxLli+r qZJz9ZeePun4kxKEysx6mRBLeLaYiSto4rvc9m1nKz44Dzs2ThOapj3Hj7M3IclLnfCW FMZhoDUYCQZycwvQtT7oGGorAoo6cDrcTUebIq9LyNt6cwKTabM4Ds6s7/p6HK6e2lMC oqKBPeAwOlt/sFJr6NqLliMqdCnDMAhcshGTq4Jeq8Yyx3XNDPky1RGQZa8sYg+2+AJw yS/k2GIoxUICLWDnGUsg9MnsdwzEUAHECLIzL/Ri6AxZGE74JmXUd3m5hdIxLST8ZMpl 5BGg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id b196si72324wmd.2.2017.09.08.01.30.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Sep 2017 01:30:48 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v888UmEp007120 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Sep 2017 10:30:48 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v888Ul55019663; Fri, 8 Sep 2017 10:30:48 +0200 Date: Fri, 8 Sep 2017 10:30:57 +0200 From: Henning Schild To: Alexander Smirnov Cc: Claudius Heine , Subject: Re: [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out Message-ID: <20170908103057.34462bf1@md1em3qc> In-Reply-To: References: <6f7b53c5-3238-1d8d-88a7-7afc3859a9ec@ilbers.de> <62849b3a-fd2f-3184-ace0-0941fd3f9325@siemens.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: D0xuG+WRsViW Am Tue, 5 Sep 2017 10:37:48 +0300 schrieb Alexander Smirnov : > Hi, > > >> On 09/04/2017 05:11 PM, Alexander Smirnov wrote: > >>> On 08/30/2017 10:03 PM, Henning Schild wrote: > >>>> Issue: > >>>> The unpacker in dpkg is not generic since it does not unpack to > >>>> WORKDIR, so it can not be pulled into a more generic class to > >>>> make it available for other users. > >>>> > >>> > >>> As I already wrote to mail-list, WORKDIR and BUILDROOT are > >>> different folders, and there was the reason to do so. > >> > >> Yes we (Henning and I) get that. That is the reason why the patch > >> includes the line: > >> > >> +WORKDIR_task-unpack = "${BUILDROOT}" > >> > >> That means that only for the unpack task in the dpkg.bbclass the > >> variable WORKDIR is set to the BUILDROOT variable. This makes the > >> unpack step more generic so that it can be moved to the base > >> class. Essentially removing the dependency of the unpack task to > >> the dpkg class. > > > > Does this mean that "log.do_unpack" and "run.do_unpack" will be > > stored in buildchroot? Let me check this. > > > > Yes it does: > > ls > isar/build/tmp/work/buildchroot/debian-wheezy-armhf/rootfs/home/builder/hello/temp/ > > log.do_unpack > log.do_unpack.19557 > log.task_order > run.do_unpack > run.do_unpack.19557 > > While it's assumed that they should be stored in: > isar/build/tmp/work/hello-0.1+g7f35942-1-r0/temp/ I think i am starting to understand the whole problem with the WORKDIR and the BUILDROOT better. Instead of the unpacking to BUILDROOT or messing with WORKDIR i think we should have a new task after do_unpack So instead of do_unpack -> BUILDROOT do_unpack archive -> WORKDIR do_copy_to_buildroot WORKDIR -> BUILDROOT That should keep all the logs in an unmodified WORKDIR and the unpacker would always extract to there. Classes that need the files to live in BUILDROOT would have to include the task do_copy_to_buildroot. Henning